)]}'
{"octavia_tempest_plugin/tests/api/v2/test_member.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b9090f3b296e13f7fdffa4953d02bc638d2edc9c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                exceptions.Forbidden,"},{"line_number":149,"context_line":"                self.os_primary.member_client.create_member,"},{"line_number":150,"context_line":"                **member_kwargs)"},{"line_number":151,"context_line":"        no_monitor \u003d False"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":154,"context_line":"        except Exception:"},{"line_number":155,"context_line":"            # In case provider driver doesnt support monitors"},{"line_number":156,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":157,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":158,"context_line":"            no_monitor \u003d True"},{"line_number":159,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":160,"context_line":"        self.addClassResourceCleanup("},{"line_number":161,"context_line":"            self.mem_member_client.cleanup_member,"},{"line_number":162,"context_line":"            member[const.ID], pool_id\u003dself.pool_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_08e32ca6","line":159,"range":{"start_line":151,"start_character":0,"end_line":159,"end_character":74},"updated":"2018-08-31 08:58:09.000000000","message":"Perhaps we need to turn this piece of code in a helper method to avoid duplicating it around the whole file ? May I suggest something like:\n\n   def get_member(self, member_params):\n       monitor_supported \u003d False\n       try:\n           member \u003d \n       except Exception:\n           ...\n           member_params.pop(..., None)\n           member \u003d ...\n\n      return (member, monitor_supported)","commit_id":"14f9f72cde9a3f53078091dd94b467110d2747c8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"64f096e58094d6d7422df9d523dbe9f1cf1a4bd2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                exceptions.Forbidden,"},{"line_number":149,"context_line":"                self.os_primary.member_client.create_member,"},{"line_number":150,"context_line":"                **member_kwargs)"},{"line_number":151,"context_line":"        no_monitor \u003d False"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":154,"context_line":"        except Exception:"},{"line_number":155,"context_line":"            # In case provider driver doesnt support monitors"},{"line_number":156,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":157,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":158,"context_line":"            no_monitor \u003d True"},{"line_number":159,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":160,"context_line":"        self.addClassResourceCleanup("},{"line_number":161,"context_line":"            self.mem_member_client.cleanup_member,"},{"line_number":162,"context_line":"            member[const.ID], pool_id\u003dself.pool_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_063698b5","line":159,"range":{"start_line":151,"start_character":0,"end_line":159,"end_character":74},"in_reply_to":"3f79a3b5_08e32ca6","updated":"2018-09-06 05:18:27.000000000","message":"Done","commit_id":"14f9f72cde9a3f53078091dd94b467110d2747c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b9090f3b296e13f7fdffa4953d02bc638d2edc9c","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            # In case provider driver doesnt support monitors"},{"line_number":446,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":447,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":448,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        self.addClassResourceCleanup("},{"line_number":451,"context_line":"            self.mem_member_client.cleanup_member,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_28f7085c","line":448,"updated":"2018-08-31 08:58:09.000000000","message":"member, no_monitor \u003d self.get_member(...)","commit_id":"14f9f72cde9a3f53078091dd94b467110d2747c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b9090f3b296e13f7fdffa4953d02bc638d2edc9c","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            no_monitor \u003d True"},{"line_number":547,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":548,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":549,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        self.addClassResourceCleanup("},{"line_number":552,"context_line":"            self.mem_member_client.cleanup_member,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e896f0ef","line":549,"updated":"2018-08-31 08:58:09.000000000","message":"member, no_monitor \u003d self.get_member(...)","commit_id":"14f9f72cde9a3f53078091dd94b467110d2747c8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b9090f3b296e13f7fdffa4953d02bc638d2edc9c","unresolved":false,"context_lines":[{"line_number":736,"context_line":"            no_monitor \u003d True"},{"line_number":737,"context_line":"            del member1_kwargs[const.MONITOR_ADDRESS]"},{"line_number":738,"context_line":"            del member1_kwargs[const.MONITOR_PORT]"},{"line_number":739,"context_line":"            member1 \u003d self.mem_member_client.create_member(**member1_kwargs)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        self.addClassResourceCleanup("},{"line_number":742,"context_line":"            self.mem_member_client.cleanup_member,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a8a0f843","line":739,"updated":"2018-08-31 08:58:09.000000000","message":"member1, no_monitor \u003d self.get_member(...)","commit_id":"14f9f72cde9a3f53078091dd94b467110d2747c8"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9e45e389a92d30c8b669c561bfda1b7f972f059c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":105,"context_line":"            monitor_supported \u003d True"},{"line_number":106,"context_line":"        except Exception:"},{"line_number":107,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":108,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":109,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_6df8f9c3","line":106,"updated":"2019-01-08 01:43:52.000000000","message":"I don\u0027t like this because it could lead to false positives.\nThis is why we are explicit with the feature disable flags in the configuration file.\nHow do we know that it\u0027s not really a failure when using the monitor_address and/or monitor_port or some other reason?\nI think any \"disabled\" features should be explicitly based on settings disabled in the configuration file.","commit_id":"444dde719c3ad1950c035d4b48f14007adf066ed"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a917f9224b4e27bdee03b740ea672bb2470870f8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                CONF.load_balancer.build_interval,"},{"line_number":100,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def create_member_and_get_monitor_status(self, **member_kwargs):"},{"line_number":103,"context_line":"        monitor \u003d CONF.loadbalancer_feature_enabled.health_monitor_enabled"},{"line_number":104,"context_line":"        if monitor:"},{"line_number":105,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_85729610","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":44},"updated":"2019-01-10 16:41:54.000000000","message":"Make this an underscore method","commit_id":"0aa411e85264947833f3e68044b006fa997e61d0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a917f9224b4e27bdee03b740ea672bb2470870f8","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def create_member_and_get_monitor_status(self, **member_kwargs):"},{"line_number":103,"context_line":"        monitor \u003d CONF.loadbalancer_feature_enabled.health_monitor_enabled"},{"line_number":104,"context_line":"        if monitor:"},{"line_number":105,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":108,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":109,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":110,"context_line":"        return member, monitor"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # Note: This test also covers basic member show API"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_5438e73b","line":109,"range":{"start_line":104,"start_character":9,"end_line":109,"end_character":74},"updated":"2019-01-10 16:41:54.000000000","message":"This could be more simply written as:\n\n    if not monitor:\n        del member_kwargs[const.MONITOR_ADDRESS]\n        del member_kwargs[const.MONITOR_PORT]\n    member \u003d self.mem_member_client.create_member(**member_kwargs)","commit_id":"0aa411e85264947833f3e68044b006fa997e61d0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2ebb6a5ea1db6b22ce8243f7c16bf524c9fb05b6","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def create_member_and_get_monitor_status(self, **member_kwargs):"},{"line_number":103,"context_line":"        monitor \u003d CONF.loadbalancer_feature_enabled.health_monitor_enabled"},{"line_number":104,"context_line":"        if monitor:"},{"line_number":105,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":108,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":109,"context_line":"            member \u003d self.mem_member_client.create_member(**member_kwargs)"},{"line_number":110,"context_line":"        return member, monitor"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # Note: This test also covers basic member show API"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfdaf3ff_1a709a72","line":109,"range":{"start_line":104,"start_character":9,"end_line":109,"end_character":74},"in_reply_to":"dfd5e7cf_5438e73b","updated":"2019-01-21 13:14:10.000000000","message":"Yeah, thats possible :)\nThanks","commit_id":"0aa411e85264947833f3e68044b006fa997e61d0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a917f9224b4e27bdee03b740ea672bb2470870f8","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            })"},{"line_number":677,"context_line":"        if monitor:"},{"line_number":678,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":679,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d 8081"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        member \u003d self.mem_member_client.update_member("},{"line_number":682,"context_line":"            member[const.ID], **member_update_kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_e5ea8273","line":679,"range":{"start_line":679,"start_character":55,"end_line":679,"end_character":59},"updated":"2019-01-10 16:41:54.000000000","message":"should be member[const.MONITOR_PORT] + 1","commit_id":"0aa411e85264947833f3e68044b006fa997e61d0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2ebb6a5ea1db6b22ce8243f7c16bf524c9fb05b6","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            })"},{"line_number":677,"context_line":"        if monitor:"},{"line_number":678,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":679,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d 8081"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        member \u003d self.mem_member_client.update_member("},{"line_number":682,"context_line":"            member[const.ID], **member_update_kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfdaf3ff_9a09eade","line":679,"range":{"start_line":679,"start_character":55,"end_line":679,"end_character":59},"in_reply_to":"dfd5e7cf_e5ea8273","updated":"2019-01-21 13:14:10.000000000","message":"Seesm trivial, but Ok :)","commit_id":"0aa411e85264947833f3e68044b006fa997e61d0"}]}