)]}'
{"octavia_tempest_plugin/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cd0fdc4e8982fb441c635de83687aeb756170ed1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"},{"line_number":95,"context_line":"                    \u0027default RBAC tests. \"owner_or_admin\" runs the legacy \u0027"},{"line_number":96,"context_line":"                    \u0027owner or admin tests. \"none\" disables the RBAC tests.\u0027),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027monitor_enabled\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d\"Whether monitor is available with provider driver or \""},{"line_number":100,"context_line":"                     \"not.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_96dda16e","line":97,"updated":"2018-09-19 17:33:01.000000000","message":"We should call this health_monitor_enabled just to reduce confusion.","commit_id":"f5ad27fdddae40239859b748d8dc6970232a535a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"01614156081d6e4343051e452f605229b647aa69","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"},{"line_number":95,"context_line":"                    \u0027default RBAC tests. \"owner_or_admin\" runs the legacy \u0027"},{"line_number":96,"context_line":"                    \u0027owner or admin tests. \"none\" disables the RBAC tests.\u0027),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027monitor_enabled\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d\"Whether monitor is available with provider driver or \""},{"line_number":100,"context_line":"                     \"not.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3325b0bf","line":97,"in_reply_to":"3f79a3b5_165991fb","updated":"2018-09-24 06:31:54.000000000","message":"Done","commit_id":"f5ad27fdddae40239859b748d8dc6970232a535a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4a614f39f23646034830d7ddcb7ac9bd6ad1ebd8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"},{"line_number":95,"context_line":"                    \u0027default RBAC tests. \"owner_or_admin\" runs the legacy \u0027"},{"line_number":96,"context_line":"                    \u0027owner or admin tests. \"none\" disables the RBAC tests.\u0027),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027monitor_enabled\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d\"Whether monitor is available with provider driver or \""},{"line_number":100,"context_line":"                     \"not.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_165991fb","line":97,"in_reply_to":"3f79a3b5_96dda16e","updated":"2018-09-19 17:37:12.000000000","message":"Also, at the PTG we decided to create an \"[load-balancer-feature-enabled]\" section in the config file to capture all of these.\nCan you add that section and move this there? I assume it is the first of many we will need to implement.\nhttps://etherpad.openstack.org/p/octavia-stein-ptg Line 333","commit_id":"f5ad27fdddae40239859b748d8dc6970232a535a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"01614156081d6e4343051e452f605229b647aa69","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"},{"line_number":95,"context_line":"                    \u0027default RBAC tests. \"owner_or_admin\" runs the legacy \u0027"},{"line_number":96,"context_line":"                    \u0027owner or admin tests. \"none\" disables the RBAC tests.\u0027),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027monitor_enabled\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d\"Whether monitor is available with provider driver or \""},{"line_number":100,"context_line":"                     \"not.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d319dc87","line":97,"in_reply_to":"3f79a3b5_96dda16e","updated":"2018-09-24 06:31:54.000000000","message":"Done","commit_id":"f5ad27fdddae40239859b748d8dc6970232a535a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e67912305dedee32106ac96d78cf69a3a7da4a8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"               help\u003d\u0027Availability zone to use for creating servers.\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"lb_feature_enabled_group \u003d cfg.OptGroup(name\u003d\u0027lb_feature_enabled\u0027,"},{"line_number":149,"context_line":"                                        title\u003d\u0027Enabled/Disabled LB features\u0027)"},{"line_number":150,"context_line":"LBFeatureEnabledGroup \u003d ["},{"line_number":151,"context_line":"    cfg.BoolOpt(\u0027health_monitor_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d431bf59","line":148,"range":{"start_line":148,"start_character":46,"end_line":148,"end_character":64},"updated":"2018-10-15 22:17:12.000000000","message":"Can we make this consistent with the other services?\nloadbalancer-feature-enabled","commit_id":"6f92138e7d2a8dce70c728c1a1e49c4fe9d1341c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61fa8da85f731bffaa75b8bfa4daa79c51402164","unresolved":false,"context_lines":[{"line_number":145,"context_line":"               help\u003d\u0027Availability zone to use for creating servers.\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"lb_feature_enabled_group \u003d cfg.OptGroup(name\u003d\u0027lb_feature_enabled\u0027,"},{"line_number":149,"context_line":"                                        title\u003d\u0027Enabled/Disabled LB features\u0027)"},{"line_number":150,"context_line":"LBFeatureEnabledGroup \u003d ["},{"line_number":151,"context_line":"    cfg.BoolOpt(\u0027health_monitor_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_79e0dfcb","line":148,"range":{"start_line":148,"start_character":46,"end_line":148,"end_character":64},"in_reply_to":"3f79a3b5_d431bf59","updated":"2018-10-16 07:30:47.000000000","message":"I think it would be loadbalancer_feature_enabled ( _ and not - ) as per the above examples in Line#20,24, but I will do it","commit_id":"6f92138e7d2a8dce70c728c1a1e49c4fe9d1341c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4a6ab74dd1d86a32a274f617b8cefd3c7fb4ba2e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"               help\u003d\u0027Availability zone to use for creating servers.\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"lb_feature_enabled_group \u003d cfg.OptGroup(name\u003d\u0027loadbalancer_feature_enabled\u0027,"},{"line_number":149,"context_line":"                                        title\u003d\u0027Enabled/Disabled LB features\u0027)"},{"line_number":150,"context_line":"LBFeatureEnabledGroup \u003d ["},{"line_number":151,"context_line":"    cfg.BoolOpt(\u0027health_monitor_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_42a400b8","line":148,"updated":"2018-10-16 15:28:51.000000000","message":"Hmm, I still think this should be -\u0027s like the other services:\ncompute-feature-enabled\nnetwork-feature-enabled\nvolume-feature-enabled\nobject-storage-feature-enabled\n\nhttp://logs.openstack.org/17/604417/3/check/octavia-v2-dsvm-scenario/22a2dba/controller/logs/tempest_conf.txt","commit_id":"5cbb13f082365a93eb41826a2e811c75dd483c30"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5ee7edb8d3e2ba4c198c18df3962d3da74fcb3ca","unresolved":false,"context_lines":[{"line_number":145,"context_line":"               help\u003d\u0027Availability zone to use for creating servers.\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"lb_feature_enabled_group \u003d cfg.OptGroup(name\u003d\u0027loadbalancer_feature_enabled\u0027,"},{"line_number":149,"context_line":"                                        title\u003d\u0027Enabled/Disabled LB features\u0027)"},{"line_number":150,"context_line":"LBFeatureEnabledGroup \u003d ["},{"line_number":151,"context_line":"    cfg.BoolOpt(\u0027health_monitor_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_a22b94e7","line":148,"in_reply_to":"3f79a3b5_42a400b8","updated":"2018-10-16 15:35:46.000000000","message":"Done ! :)","commit_id":"5cbb13f082365a93eb41826a2e811c75dd483c30"}],"octavia_tempest_plugin/plugin.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"01614156081d6e4343051e452f605229b647aa69","unresolved":false,"context_lines":[{"line_number":45,"context_line":"             project_config.ServiceAvailableGroup),"},{"line_number":46,"context_line":"            (project_config.octavia_group.name,"},{"line_number":47,"context_line":"             project_config.OctaviaGroup),"},{"line_number":48,"context_line":"            (project_config.lb_feature_enabled_group,"},{"line_number":49,"context_line":"             project_config.LBFeatureEnabledGroup)"},{"line_number":50,"context_line":"        ]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_60b237e8","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":52},"updated":"2018-09-24 06:31:54.000000000","message":"forgot .name here ! :(","commit_id":"db0824256427bd17b45a489b5a83a14ac8df446d"}],"octavia_tempest_plugin/tests/api/v2/test_healthmonitor.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"216e00156b00e1b05e51219c36392e51af7f2e4e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class HealthMonitorAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":35,"context_line":"    \"\"\"Test the healthmonitor object API.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_528be366","line":34,"updated":"2018-09-03 13:31:14.000000000","message":"You could set the @testtools.skip here so that the entire class would be skipped.","commit_id":"f0636543c43601e943b2518f58abecc95844d4d4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5e8a32297c75703bcb337a06d455b052d18be07b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class HealthMonitorAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":35,"context_line":"    \"\"\"Test the healthmonitor object API.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f040a7a4","line":34,"in_reply_to":"3f79a3b5_528be366","updated":"2018-09-06 06:42:22.000000000","message":"Done","commit_id":"f0636543c43601e943b2518f58abecc95844d4d4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e3e9347778f37d96c3eadea1a58906aa18db5095","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@testtools.skipUnless(CONF.lb_feature_enabled.health_monitor_enabled,"},{"line_number":35,"context_line":"                      \u0027Health Monitors not supported\u0027)"},{"line_number":36,"context_line":"class HealthMonitorAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":37,"context_line":"    \"\"\"Test the healthmonitor object API.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4a166aa3","line":34,"updated":"2018-10-16 00:46:52.000000000","message":"Actually, this should probably be done using the skip_checks phase:\nhttps://docs.openstack.org/tempest/latest/write_tests.html#setupclass","commit_id":"6f92138e7d2a8dce70c728c1a1e49c4fe9d1341c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61fa8da85f731bffaa75b8bfa4daa79c51402164","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@testtools.skipUnless(CONF.lb_feature_enabled.health_monitor_enabled,"},{"line_number":35,"context_line":"                      \u0027Health Monitors not supported\u0027)"},{"line_number":36,"context_line":"class HealthMonitorAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":37,"context_line":"    \"\"\"Test the healthmonitor object API.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_59f2c39c","line":34,"in_reply_to":"3f79a3b5_4a166aa3","updated":"2018-10-16 07:30:47.000000000","message":"Thanks for the info :)","commit_id":"6f92138e7d2a8dce70c728c1a1e49c4fe9d1341c"}],"octavia_tempest_plugin/tests/scenario/v2/test_healthmonitor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e3e9347778f37d96c3eadea1a58906aa18db5095","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@testtools.skipUnless(CONF.lb_feature_enabled.health_monitor_enabled,"},{"line_number":31,"context_line":"                      \u0027Health Monitors not supported\u0027)"},{"line_number":32,"context_line":"class HealthMonitorScenarioTest(test_base.LoadBalancerBaseTest):"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ea76560c","line":30,"updated":"2018-10-16 00:46:52.000000000","message":"Actually, this should probably be done using the skip_checks phase:\nhttps://docs.openstack.org/tempest/latest/write_tests.html#setupclass","commit_id":"6f92138e7d2a8dce70c728c1a1e49c4fe9d1341c"}]}