)]}'
{"octavia_tempest_plugin/common/constants.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1783fbad76aa79c80a852d5a4ef05d0409794a4a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"AMPHORA_NON_TRANSIENT_STATUSES \u003d ("},{"line_number":198,"context_line":"    STATUS_ALLOCATED, STATUS_READY, STATUS_DELETED, STATUS_ERROR"},{"line_number":199,"context_line":")"},{"line_number":200,"context_line":"AMPHORA_TRANSIENT_STATUSES \u003d ("},{"line_number":201,"context_line":"    STATUS_BOOTING, STATUS_PENDING_CREATE, STATUS_PENDING_DELETE"},{"line_number":202,"context_line":")"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ecee54b3","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":26},"updated":"2019-11-25 11:13:49.000000000","message":"Constant defined but not used?","commit_id":"696d665d7af3e2a54a441b887d417fd731e4fb36"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1783fbad76aa79c80a852d5a4ef05d0409794a4a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    STATUS_ALLOCATED, STATUS_READY, STATUS_DELETED, STATUS_ERROR"},{"line_number":199,"context_line":")"},{"line_number":200,"context_line":"AMPHORA_TRANSIENT_STATUSES \u003d ("},{"line_number":201,"context_line":"    STATUS_BOOTING, STATUS_PENDING_CREATE, STATUS_PENDING_DELETE"},{"line_number":202,"context_line":")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"# Flavor capabilities"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ecd5f4e6","line":201,"updated":"2019-11-25 11:13:49.000000000","message":"Amphora can also be in PENDING_UPDATE.\n\nhttps://github.com/openstack/octavia/blob/05f5257075dda076b0960a319d49c970b0015022/octavia/controller/worker/v1/tasks/database_tasks.py#L818-L819","commit_id":"696d665d7af3e2a54a441b887d417fd731e4fb36"}],"octavia_tempest_plugin/tests/scenario/v2/test_amphora.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"31d5cf372ac7de87df71052d193e83ffc0cd0a71","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            # Test that all of the fields from the amp list match those"},{"line_number":164,"context_line":"            # from a show, but only for those with non-transient statuses"},{"line_number":165,"context_line":"            if amp[const.STATUS] not in (const.STATUS_PENDING_CREATE,"},{"line_number":166,"context_line":"                                         const.STATUS_BOOTING):"},{"line_number":167,"context_line":"                for field in show_amphora_response_fields:"},{"line_number":168,"context_line":"                    self.assertEqual(amp[field], amp_obj[field])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_2abe4165","line":165,"updated":"2019-01-08 21:08:45.000000000","message":"It seems like this would be better with know good states rather than not-transient states.\nWhat happens when we add PENDING_UPDATE or something similar?","commit_id":"c3abfc16d80a052218b0b1e5ba7e60229b4ee94a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6dab00aec8600cfdd89a9ef601669dd563df8363","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(AmphoraScenarioTest, cls).skip_checks()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if CONF.load_balancer.provider not in [\u0027amphora\u0027, \u0027octavia\u0027]:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Amphora tests require provider \u0027amphora\u0027 \""},{"line_number":39,"context_line":"                                    \"or \u0027octavia\u0027 (alias to \u0027amphora\u0027, \""},{"line_number":40,"context_line":"                                    \" deprecated) set\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_99bb56c2","line":37,"updated":"2019-11-04 22:55:44.000000000","message":"This should be a constant that has the list of constants.\nhttps://review.opendev.org/689128","commit_id":"696d665d7af3e2a54a441b887d417fd731e4fb36"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1783fbad76aa79c80a852d5a4ef05d0409794a4a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(AmphoraScenarioTest, cls).skip_checks()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if CONF.load_balancer.provider not in [\u0027amphora\u0027, \u0027octavia\u0027]:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Amphora tests require provider \u0027amphora\u0027 \""},{"line_number":39,"context_line":"                                    \"or \u0027octavia\u0027 (alias to \u0027amphora\u0027, \""},{"line_number":40,"context_line":"                                    \" deprecated) set\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cc083892","line":37,"in_reply_to":"3fa7e38b_99bb56c2","updated":"2019-11-25 11:13:49.000000000","message":"Yes, we could use this opportunity to improve here than a follow-up and nitty patch.","commit_id":"696d665d7af3e2a54a441b887d417fd731e4fb36"}]}