)]}'
{"octavia_tempest_plugin/config.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cf5a069365f52b1f629c41404e67a02b7ca01f6f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                default\u003dTrue,"},{"line_number":153,"context_line":"                help\u003d\"Whether Health Monitor is available with provider\""},{"line_number":154,"context_line":"                     \" driver or not.\"),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027l7_tests_enabled\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\"Whether L7 Protocols can be used for testing or not.\"),"},{"line_number":158,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_9e26aeb7","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":33},"updated":"2019-01-07 18:10:27.000000000","message":"Similar option names should be consistent. In this case, there\u0027s \"health_monitor_enabled\", so this new option should be \"l7_enabled\". Equally valid for the help message.","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                default\u003dTrue,"},{"line_number":153,"context_line":"                help\u003d\"Whether Health Monitor is available with provider\""},{"line_number":154,"context_line":"                     \" driver or not.\"),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027l7_tests_enabled\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\"Whether L7 Protocols can be used for testing or not.\"),"},{"line_number":158,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_0dc12d55","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":33},"in_reply_to":"dfd5e7cf_9e26aeb7","updated":"2019-01-08 01:58:34.000000000","message":"Agreed","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                default\u003dTrue,"},{"line_number":153,"context_line":"                help\u003d\"Whether Health Monitor is available with provider\""},{"line_number":154,"context_line":"                     \" driver or not.\"),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027l7_tests_enabled\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\"Whether L7 Protocols can be used for testing or not.\"),"},{"line_number":158,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_d65e56e5","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":33},"in_reply_to":"dfd5e7cf_9e26aeb7","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                default\u003dTrue,"},{"line_number":181,"context_line":"                help\u003d\"Whether L7 Protocols are available with the provider\""},{"line_number":182,"context_line":"                     \" driver or not.\"),"},{"line_number":183,"context_line":"    cfg.StrOpt(\u0027l4_protocol_enabled\u0027,"},{"line_number":184,"context_line":"               default\u003d\"TCP\","},{"line_number":185,"context_line":"               help\u003d\"The type of L4 Protocol which is supported with the\""},{"line_number":186,"context_line":"                    \" provider driver.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_46a146a9","line":183,"range":{"start_line":183,"start_character":16,"end_line":183,"end_character":35},"updated":"2019-01-22 17:01:23.000000000","message":"This option name hints at a boolean type option, just like the others above it with similar name.","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"}],"octavia_tempest_plugin/tests/api/v2/test_l7policy.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":38,"context_line":"            cls.skip(\u0027L7 API Tests are not supported\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_4d9bb571","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":20},"updated":"2019-01-08 01:58:34.000000000","message":"Does cls.skip work? I think you need to use cls.skipException\nI think cls.skip is a bug in the tempest documentation.","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":38,"context_line":"            cls.skip(\u0027L7 API Tests are not supported\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_2d9e7163","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":53},"updated":"2019-01-08 01:58:34.000000000","message":"It\u0027s nice to give users information as to why. Here is an example from the TLS patch I am working on:\n\u0027[loadbalancer-feature-enabled] \"terminated_tls_enabled\" is False in the tempest configuration. TLS tests will be skipped.\u0027","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":38,"context_line":"            cls.skip(\u0027L7 API Tests are not supported\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_b65952ff","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":20},"in_reply_to":"dfd5e7cf_4d9bb571","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":38,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":39,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":40,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":41,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_86916e9c","line":39,"range":{"start_line":39,"start_character":31,"end_line":39,"end_character":32},"updated":"2019-01-22 17:01:23.000000000","message":"nit: when line wrapping, the standard used is to add whitespace at the end of the upper line instead.","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":38,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":39,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":40,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":41,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_c669b6be","line":40,"range":{"start_line":40,"start_character":72,"end_line":40,"end_character":77},"updated":"2019-01-22 17:01:23.000000000","message":"nit: \"L7 scenario tests will be skipped.\" or \"Skipping L7 scenario tests.\"","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":38,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":39,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":40,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":41,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_06a57e04","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":56},"updated":"2019-01-22 17:01:23.000000000","message":"nit: missing white space. should be \"configuration. L7\"","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"}],"octavia_tempest_plugin/tests/api/v2/test_l7rule.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(L7RuleAPITest, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":37,"context_line":"            cls.skip(\u0027L7 API Tests are not supported\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_8d7afd21","line":36,"updated":"2019-01-08 01:58:34.000000000","message":"Same comments as the l7policy skip","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(L7RuleAPITest, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":37,"context_line":"            cls.skip(\u0027L7 API Tests are not supported\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_1665beb5","line":36,"in_reply_to":"dfd5e7cf_8d7afd21","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(L7RuleAPITest, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":37,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":38,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":39,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":40,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_86e64e44","line":40,"range":{"start_line":37,"start_character":30,"end_line":40,"end_character":44},"updated":"2019-01-22 17:01:23.000000000","message":"ditto","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":45,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":46,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":47,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_4dedf5ed","line":46,"updated":"2019-01-08 01:58:34.000000000","message":"If your driver can\u0027t support HTTP pools, that should be another feature disabled in the config in my opinion.","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":45,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":46,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":47,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_565106d8","line":46,"in_reply_to":"dfd5e7cf_4dedf5ed","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}],"octavia_tempest_plugin/tests/api/v2/test_member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                     const.NAME: lb_name}"},{"line_number":43,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":44,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":45,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":46,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_4d741536","line":45,"updated":"2019-01-08 01:58:34.000000000","message":"If your driver doesn\u0027t support HTTP listeners, this should be it\u0027s own configuration file setting to disable.","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                     const.NAME: lb_name}"},{"line_number":43,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":44,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":45,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":46,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_764a0a28","line":45,"in_reply_to":"dfd5e7cf_4d741536","updated":"2019-01-08 07:03:23.000000000","message":"Done, added another option, but not for HTTP, for L4 Protocols","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}],"octavia_tempest_plugin/tests/api/v2/test_pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     const.NAME: lb_name}"},{"line_number":42,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":43,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":44,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":45,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_ed8e2926","line":44,"updated":"2019-01-08 01:58:34.000000000","message":"Same, listener HTTP disable.","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     const.NAME: lb_name}"},{"line_number":42,"context_line":"        cls._setup_lb_network_kwargs(lb_kwargs)"},{"line_number":43,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":44,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":45,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_d645f618","line":44,"in_reply_to":"dfd5e7cf_ed8e2926","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}],"octavia_tempest_plugin/tests/scenario/v2/test_l7policy.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cf5a069365f52b1f629c41404e67a02b7ca01f6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7PolicyScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":35,"context_line":"            cls.skip(\u0027L7 Test Scenarios not supported\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_48716be0","line":35,"range":{"start_line":35,"start_character":40,"end_line":35,"end_character":53},"updated":"2019-01-07 18:10:27.000000000","message":"L7 tests were disabled by config, doesn\u0027t mean they are not supported by a given provider driver. Rename to \"disabled\"?","commit_id":"6744bb5bf219572f4c3c1fd0ea98f73cae5c9134"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7PolicyScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":35,"context_line":"            cls.skip(\u0027L7 Test Scenarios not supported\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_0d94cd36","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":55},"updated":"2019-01-08 01:58:34.000000000","message":"Same comments as l7policy API tests","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7PolicyScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":35,"context_line":"            cls.skip(\u0027L7 Test Scenarios not supported\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_b6407209","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":55},"in_reply_to":"dfd5e7cf_0d94cd36","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7PolicyScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":35,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":36,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":37,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":38,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_866dee99","line":38,"range":{"start_line":35,"start_character":31,"end_line":38,"end_character":43},"updated":"2019-01-22 17:01:23.000000000","message":"ditto","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"}],"octavia_tempest_plugin/tests/scenario/v2/test_l7rule.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7RuleScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":35,"context_line":"            cls.skip(\u0027L7 Test Scenarios not supported\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_ad98216a","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":55},"updated":"2019-01-08 01:58:34.000000000","message":"Same comments as l7policy API tests","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7RuleScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":35,"context_line":"            cls.skip(\u0027L7 Test Scenarios not supported\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_163cde91","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":55},"in_reply_to":"dfd5e7cf_ad98216a","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"527c4a7ec6e9a922c3b56a98e76f6d753a4eb254","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(L7RuleScenarioTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":35,"context_line":"            cls.skipException(\u0027[loadbalancer-feature-enabled]\u0027"},{"line_number":36,"context_line":"                              \u0027 \"l7_protocol_enabled\" is set to False in the\u0027"},{"line_number":37,"context_line":"                              \u0027 Tempest configuration.L7 Scenario tests would\u0027"},{"line_number":38,"context_line":"                              \u0027 be skipped.\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_8602ceb3","line":38,"range":{"start_line":35,"start_character":31,"end_line":38,"end_character":43},"updated":"2019-01-22 17:01:23.000000000","message":"ditto","commit_id":"5f6ca1be552027ee6cc721c1a29f9619dd548e0c"}],"octavia_tempest_plugin/tests/scenario/v2/test_listener.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04b7c59c3b564bf8f049a5d30b636354f58bf788","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":53,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":54,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":55,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":56,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pool1_name \u003d data_utils.rand_name(\"lb_member_pool1_listener\")"},{"line_number":59,"context_line":"        pool1_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5c075170","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":36},"updated":"2018-12-06 18:32:02.000000000","message":"Doesn\u0027t seem like the right usage for that config option","commit_id":"24adc41b396c2f53807c5db05d14c808f78593bc"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cf5a069365f52b1f629c41404e67a02b7ca01f6f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":53,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":54,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":55,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":56,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pool1_name \u003d data_utils.rand_name(\"lb_member_pool1_listener\")"},{"line_number":59,"context_line":"        pool1_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_7ea42a09","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":36},"in_reply_to":"3f79a3b5_088d1027","updated":"2019-01-07 18:10:27.000000000","message":"I\u0027d also like to know what Lucas has in mind.","commit_id":"24adc41b396c2f53807c5db05d14c808f78593bc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"682e36ee25746a61b54663c46046ccc13a6e8a31","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":53,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":54,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":55,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":56,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pool1_name \u003d data_utils.rand_name(\"lb_member_pool1_listener\")"},{"line_number":59,"context_line":"        pool1_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_088d1027","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":36},"in_reply_to":"3f79a3b5_5c075170","updated":"2018-12-07 05:59:59.000000000","message":"so what do you suggest?","commit_id":"24adc41b396c2f53807c5db05d14c808f78593bc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":53,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":54,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":55,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":56,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pool1_name \u003d data_utils.rand_name(\"lb_member_pool1_listener\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_6da2399d","line":55,"updated":"2019-01-08 01:58:34.000000000","message":"Same, pool HTTP disable","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":53,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":54,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":55,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":56,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pool1_name \u003d data_utils.rand_name(\"lb_member_pool1_listener\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_f636fab4","line":55,"in_reply_to":"dfd5e7cf_6da2399d","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}],"octavia_tempest_plugin/tests/scenario/v2/test_member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":53,"context_line":"        protocol \u003d const.HTTP"},{"line_number":54,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":55,"context_line":"            protocol \u003d const.TCP"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_member\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_2dac318b","line":54,"updated":"2019-01-08 01:58:34.000000000","message":"Same, listener HTTP disable","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":53,"context_line":"        protocol \u003d const.HTTP"},{"line_number":54,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":55,"context_line":"            protocol \u003d const.TCP"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_member\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_56bca604","line":54,"in_reply_to":"dfd5e7cf_2dac318b","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}],"octavia_tempest_plugin/tests/scenario/v2/test_pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23bb2a9f36fa59fe81b6b1a2c197e27065cb3d39","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":53,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":54,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":55,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_pool\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_edb709d8","line":54,"updated":"2019-01-08 01:58:34.000000000","message":"Same, listener HTTP disable","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"97a56604a52b775170e7796ef307dd7accebbbbc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":52,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":53,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":54,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_tests_enabled:"},{"line_number":55,"context_line":"            cls.protocol \u003d const.TCP"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_pool\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd5e7cf_36bfa2fc","line":54,"in_reply_to":"dfd5e7cf_edb709d8","updated":"2019-01-08 07:03:23.000000000","message":"Done","commit_id":"f3cd6091b241f1dd59de425b11259d521089b195"}]}