)]}'
{"octavia_tempest_plugin/services/load_balancer/v2/amphora_client.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3886001e3ebe8458cfcb10df43c2e61d185c169c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        uri \u003d \u0027{0}/{1}/config\u0027.format(self.uri, amphora_id)"},{"line_number":193,"context_line":"        response, body \u003d self.put(uri, \u0027\u0027)"},{"line_number":194,"context_line":"        self.expected_success(202, response.status)"},{"line_number":195,"context_line":"        return"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def amphora_failover(self, amphora_id):"},{"line_number":198,"context_line":"        \"\"\"Failover an amphora."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_6623d906","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":14},"updated":"2019-04-17 18:35:44.000000000","message":"nit: useless return","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a74a12bb2cc53d712c4f8da07db5145cd667905","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        uri \u003d \u0027{0}/{1}/config\u0027.format(self.uri, amphora_id)"},{"line_number":193,"context_line":"        response, body \u003d self.put(uri, \u0027\u0027)"},{"line_number":194,"context_line":"        self.expected_success(202, response.status)"},{"line_number":195,"context_line":"        return"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def amphora_failover(self, amphora_id):"},{"line_number":198,"context_line":"        \"\"\"Failover an amphora."}],"source_content_type":"text/x-python","patch_set":6,"id":"ffb9cba7_29f3cda0","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":14},"in_reply_to":"3fce034c_6623d906","updated":"2019-04-22 23:09:38.000000000","message":"Must have got that in a code copy...\nFixed","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3886001e3ebe8458cfcb10df43c2e61d185c169c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        uri \u003d \u0027{0}/{1}/failover\u0027.format(self.uri, amphora_id)"},{"line_number":229,"context_line":"        response, body \u003d self.put(uri, \u0027\u0027)"},{"line_number":230,"context_line":"        self.expected_success(202, response.status)"},{"line_number":231,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_06221501","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":14},"updated":"2019-04-17 18:35:44.000000000","message":"ditto","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a74a12bb2cc53d712c4f8da07db5145cd667905","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        uri \u003d \u0027{0}/{1}/failover\u0027.format(self.uri, amphora_id)"},{"line_number":229,"context_line":"        response, body \u003d self.put(uri, \u0027\u0027)"},{"line_number":230,"context_line":"        self.expected_success(202, response.status)"},{"line_number":231,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffb9cba7_e92a95e5","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":14},"in_reply_to":"3fce034c_06221501","updated":"2019-04-22 23:09:38.000000000","message":"Done","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"}],"octavia_tempest_plugin/tests/api/v2/test_amphora.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3886001e3ebe8458cfcb10df43c2e61d185c169c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AmphoraAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":28,"context_line":"    \"\"\"Test the amphora object API.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_6668b920","line":27,"updated":"2019-04-17 18:35:44.000000000","message":"Tests should be skipped if provider driver is not amphora (nor the octavia alias)","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a74a12bb2cc53d712c4f8da07db5145cd667905","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AmphoraAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":28,"context_line":"    \"\"\"Test the amphora object API.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffb9cba7_c91231b2","line":27,"in_reply_to":"3fce034c_6668b920","updated":"2019-04-22 23:09:38.000000000","message":"Done","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3886001e3ebe8458cfcb10df43c2e61d185c169c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        amp \u003d self.lb_admin_amphora_client.show_amphora(amphora_1[const.ID])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.assertEqual(const.STATUS_ALLOCATED, amp[const.STATUS])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_e64fc98f","line":89,"updated":"2019-04-17 18:35:44.000000000","message":"Should the provisioning be asserted to be on update and back to active after? Not sure if the provisioning status even changes, though, sorry.","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a74a12bb2cc53d712c4f8da07db5145cd667905","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        amp \u003d self.lb_admin_amphora_client.show_amphora(amphora_1[const.ID])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.assertEqual(const.STATUS_ALLOCATED, amp[const.STATUS])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffb9cba7_29b8ad28","line":89,"in_reply_to":"3fce034c_e64fc98f","updated":"2019-04-22 23:09:38.000000000","message":"Yeah, there is not status change for this action. It\u0027s transparent to the users and operators as it\u0027s a \"configuration mutation\".","commit_id":"4f8dbc453d97e008864e70412a3938c04d959e52"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"d81bc2db7185904441a388e75cf1f1d6d9176bf4","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Test that a user without the load balancer admin role cannot"},{"line_number":84,"context_line":"        # create a flavor"},{"line_number":85,"context_line":"        if CONF.load_balancer.RBAC_test_type \u003d\u003d const.ADVANCED:"},{"line_number":86,"context_line":"            self.assertRaises("},{"line_number":87,"context_line":"                exceptions.Forbidden,"},{"line_number":88,"context_line":"                self.os_primary.amphora_client.update_amphora_config,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffb9cba7_4869ed1e","line":85,"range":{"start_line":85,"start_character":54,"end_line":85,"end_character":62},"updated":"2019-04-28 20:03:36.000000000","message":"same question about legacy RBAC, can\u0027t we test for \u0027admin\u0027 in that case as well?","commit_id":"153c0aed24a415e267ae1925c525bb8886bb2896"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2883fc105611fb509da7d91857318387ca94e7c5","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Test that a user without the load balancer admin role cannot"},{"line_number":84,"context_line":"        # create a flavor"},{"line_number":85,"context_line":"        if CONF.load_balancer.RBAC_test_type \u003d\u003d const.ADVANCED:"},{"line_number":86,"context_line":"            self.assertRaises("},{"line_number":87,"context_line":"                exceptions.Forbidden,"},{"line_number":88,"context_line":"                self.os_primary.amphora_client.update_amphora_config,"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfbec78f_dd29d036","line":85,"range":{"start_line":85,"start_character":54,"end_line":85,"end_character":62},"in_reply_to":"ffb9cba7_4869ed1e","updated":"2019-05-16 15:06:10.000000000","message":"I don\u0027t understand your question. If this test is false, it runs with the legacy admin role.","commit_id":"153c0aed24a415e267ae1925c525bb8886bb2896"}]}