)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_member.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        protocol \u003d const.HTTP"},{"line_number":57,"context_line":"        lb_feature_enabled \u003d CONF.loadbalancer_feature_enabled"},{"line_number":58,"context_line":"        if not lb_feature_enabled.l7_protocol_enabled:"},{"line_number":59,"context_line":"            protocol \u003d lb_feature_enabled.l4_protocol"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_member\")"},{"line_number":62,"context_line":"        listener_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_2e91b952","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":20},"updated":"2019-02-17 22:05:13.000000000","message":"Not saying this is wrong, but would like to better understand why you removed cls here.","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        protocol \u003d const.HTTP"},{"line_number":57,"context_line":"        lb_feature_enabled \u003d CONF.loadbalancer_feature_enabled"},{"line_number":58,"context_line":"        if not lb_feature_enabled.l7_protocol_enabled:"},{"line_number":59,"context_line":"            protocol \u003d lb_feature_enabled.l4_protocol"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1_member\")"},{"line_number":62,"context_line":"        listener_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_df5bf51e","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":20},"in_reply_to":"9fdfeff1_2e91b952","updated":"2019-02-18 06:06:39.000000000","message":"Protocol is not being used outside the resource_setup() , so didnt need the cls parameter here.","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if self.lb_member_vip_subnet:"},{"line_number":129,"context_line":"            member_kwargs[const.SUBNET_ID] \u003d self.lb_member_vip_subnet["},{"line_number":130,"context_line":"                const.ID]"},{"line_number":131,"context_line":"        monitor \u003d self._get_monitor_status()"},{"line_number":132,"context_line":"        if not monitor:"},{"line_number":133,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":134,"context_line":"            del member_kwargs[const.MONITOR_PORT]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_4ea8bd8a","line":131,"range":{"start_line":131,"start_character":7,"end_line":131,"end_character":44},"updated":"2019-02-17 22:05:13.000000000","message":"I think what you added[1] on lines 57-59 is more readable. Additionally, the function name _get_monitor_status is a bit misleading since it does not actually check the monitoring status of a pool member.\n\n[1] https://review.openstack.org/#/c/621493/7/octavia_tempest_plugin/tests/api/v2/test_member.py@45","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if self.lb_member_vip_subnet:"},{"line_number":129,"context_line":"            member_kwargs[const.SUBNET_ID] \u003d self.lb_member_vip_subnet["},{"line_number":130,"context_line":"                const.ID]"},{"line_number":131,"context_line":"        monitor \u003d self._get_monitor_status()"},{"line_number":132,"context_line":"        if not monitor:"},{"line_number":133,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":134,"context_line":"            del member_kwargs[const.MONITOR_PORT]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3fa241fd","line":131,"range":{"start_line":131,"start_character":7,"end_line":131,"end_character":44},"in_reply_to":"9fdfeff1_4ea8bd8a","updated":"2019-02-18 06:06:39.000000000","message":"Done","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            member_kwargs[const.SUBNET_ID] \u003d self.lb_member_vip_subnet["},{"line_number":130,"context_line":"                const.ID]"},{"line_number":131,"context_line":"        monitor \u003d self._get_monitor_status()"},{"line_number":132,"context_line":"        if not monitor:"},{"line_number":133,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":134,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":135,"context_line":"        member \u003d self.mem_member_client.create_member(**member_kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_6e84a10b","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":22},"updated":"2019-02-17 22:05:13.000000000","message":"please use something more descriptive here, such as health_monitor_enabled","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            member_kwargs[const.SUBNET_ID] \u003d self.lb_member_vip_subnet["},{"line_number":130,"context_line":"                const.ID]"},{"line_number":131,"context_line":"        monitor \u003d self._get_monitor_status()"},{"line_number":132,"context_line":"        if not monitor:"},{"line_number":133,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":134,"context_line":"            del member_kwargs[const.MONITOR_PORT]"},{"line_number":135,"context_line":"        member \u003d self.mem_member_client.create_member(**member_kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_5fa5c501","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":22},"in_reply_to":"9fdfeff1_6e84a10b","updated":"2019-02-18 06:06:39.000000000","message":"Done","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        equal_items \u003d [const.NAME, const.ADMIN_STATE_UP, const.ADDRESS,"},{"line_number":170,"context_line":"                       const.PROTOCOL_PORT, const.WEIGHT]"},{"line_number":171,"context_line":"        if monitor:"},{"line_number":172,"context_line":"            equal_items +\u003d [const.MONITOR_ADDRESS, const.MONITOR_PORT]"},{"line_number":173,"context_line":"        if self.mem_member_client.is_version_supported("},{"line_number":174,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_0e7f1515","line":171,"range":{"start_line":171,"start_character":11,"end_line":171,"end_character":18},"updated":"2019-02-17 22:05:13.000000000","message":"ditto","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        equal_items \u003d [const.NAME, const.ADMIN_STATE_UP, const.ADDRESS,"},{"line_number":170,"context_line":"                       const.PROTOCOL_PORT, const.WEIGHT]"},{"line_number":171,"context_line":"        if monitor:"},{"line_number":172,"context_line":"            equal_items +\u003d [const.MONITOR_ADDRESS, const.MONITOR_PORT]"},{"line_number":173,"context_line":"        if self.mem_member_client.is_version_supported("},{"line_number":174,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_ffafd9df","line":171,"range":{"start_line":171,"start_character":11,"end_line":171,"end_character":18},"in_reply_to":"9fdfeff1_0e7f1515","updated":"2019-02-18 06:06:39.000000000","message":"Done","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                const.BACKUP: not member[const.BACKUP],"},{"line_number":197,"context_line":"            })"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if monitor:"},{"line_number":200,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":201,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d member["},{"line_number":202,"context_line":"                const.MONITOR_PORT] + 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_2e7a1923","line":199,"range":{"start_line":199,"start_character":11,"end_line":199,"end_character":18},"updated":"2019-02-17 22:05:13.000000000","message":"ditto","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                const.BACKUP: not member[const.BACKUP],"},{"line_number":197,"context_line":"            })"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if monitor:"},{"line_number":200,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":201,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d member["},{"line_number":202,"context_line":"                const.MONITOR_PORT] + 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1fabbdd5","line":199,"range":{"start_line":199,"start_character":11,"end_line":199,"end_character":18},"in_reply_to":"9fdfeff1_2e7a1923","updated":"2019-02-18 06:06:39.000000000","message":"Done","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"def27b3fe1f6a1c7a8a4b0485f6b647c0ad75d54","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # Test changed items"},{"line_number":220,"context_line":"        equal_items \u003d [const.NAME, const.ADMIN_STATE_UP, const.WEIGHT]"},{"line_number":221,"context_line":"        if monitor:"},{"line_number":222,"context_line":"            equal_items +\u003d [const.MONITOR_ADDRESS, const.MONITOR_PORT]"},{"line_number":223,"context_line":"        if self.mem_member_client.is_version_supported("},{"line_number":224,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_ce74ad38","line":221,"range":{"start_line":221,"start_character":11,"end_line":221,"end_character":18},"updated":"2019-02-17 22:05:13.000000000","message":"ditto","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1be48710ba951390e9f652e58e91afe86b979f21","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # Test changed items"},{"line_number":220,"context_line":"        equal_items \u003d [const.NAME, const.ADMIN_STATE_UP, const.WEIGHT]"},{"line_number":221,"context_line":"        if monitor:"},{"line_number":222,"context_line":"            equal_items +\u003d [const.MONITOR_ADDRESS, const.MONITOR_PORT]"},{"line_number":223,"context_line":"        if self.mem_member_client.is_version_supported("},{"line_number":224,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_bfb5d133","line":221,"range":{"start_line":221,"start_character":11,"end_line":221,"end_character":18},"in_reply_to":"9fdfeff1_ce74ad38","updated":"2019-02-18 06:06:39.000000000","message":"Done","commit_id":"62a0f1c22bf0c02a525e535a14e9b525675caf9d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7576133923803cadf78dca0eeda4cd9b23b07b34","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if self.lb_member_vip_subnet:"},{"line_number":129,"context_line":"            member_kwargs[const.SUBNET_ID] \u003d self.lb_member_vip_subnet["},{"line_number":130,"context_line":"                const.ID]"},{"line_number":131,"context_line":"        is_hm_enabled \u003d _check_monitor_enabled()"},{"line_number":132,"context_line":"        if not is_hm_enabled:"},{"line_number":133,"context_line":"            del member_kwargs[const.MONITOR_ADDRESS]"},{"line_number":134,"context_line":"            del member_kwargs[const.MONITOR_PORT]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_aee1249d","line":131,"range":{"start_line":131,"start_character":24,"end_line":131,"end_character":46},"updated":"2019-02-18 09:32:40.000000000","message":"not need for a function here.\nthe function has a single line it will be more clear (and also look the same as line#57) if you just:\n\nis_hm_enabled \u003d CONF.loadbalancer_feature_enabled.health_monitor_enabled","commit_id":"e0d8118ce8e1f7713706f1049eef58373a9d7e96"}]}