)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"598e38b1b9f233504b731a2d423e59bb6f4035c9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.assertEmpty(pool[const.LISTENERS])"},{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":151,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_9c472c1e","line":150,"updated":"2019-04-05 23:51:59.000000000","message":"This should be it\u0027s own feature as technically we support session persistence for TCP and UDP as well. Example: source_ip","commit_id":"ba1bc595e2cd9a49884889116e94452f44453d04"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f6b537a8164e55a001e69c12ad2378c9060205a3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.assertEmpty(pool[const.LISTENERS])"},{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":151,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_f829e19a","line":150,"in_reply_to":"3fce034c_486c1236","updated":"2019-04-24 07:41:31.000000000","message":"Ok, will do the same","commit_id":"ba1bc595e2cd9a49884889116e94452f44453d04"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eb8407ec9a5edd4f175c0c9c221deb3e6f6f259","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.assertEmpty(pool[const.LISTENERS])"},{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":151,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_486c1236","line":150,"in_reply_to":"5fc1f717_35688bf3","updated":"2019-04-11 23:19:22.000000000","message":"My point here is that we still do session persistence for L4 protocols such as TCP and UDP.\nMy recommendation was to create a new \"lb_feature_enabled\" for session persistence if the OVN provider doesn\u0027t support it at all.","commit_id":"ba1bc595e2cd9a49884889116e94452f44453d04"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ffb6ae0a072da9524ef728ee4cb09194c15fffd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.assertEmpty(pool[const.LISTENERS])"},{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":151,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_35688bf3","line":150,"in_reply_to":"5fc1f717_9c472c1e","updated":"2019-04-06 07:34:53.000000000","message":"Ok, so what I understand from https://developer.openstack.org/api-ref/load-balancer/v2/?expanded\u003dlist-pools-detail,create-pool-detail#session-persistence is that there are 3 types of Session Persistence, APP_COOKIE, SOURCE_IP and HTTP_COOKIE.\n\nAnd if I understand your comment correctly, we can probably see if L4 is enabled and verify the SOURCE_IP session persistence. If L7 is enabled, we can continue with the current asserts.","commit_id":"ba1bc595e2cd9a49884889116e94452f44453d04"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1eb8407ec9a5edd4f175c0c9c221deb3e6f6f259","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":151,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"},{"line_number":154,"context_line":"        self.assertEqual(pool_sp_cookie_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_a8601634","line":151,"updated":"2019-04-11 23:19:22.000000000","message":"I don\u0027t see how whether the provider supports L7 protocols directly relates to session persistence tests. I.e. L4 protocols such as TCP and UDP still support some forms of session persistence (source IP). I would probably create a lb_feature_enabled for each of these SP options.","commit_id":"59a03d98bbe58fd3d829942ee1e96a873cfc4039"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f6b537a8164e55a001e69c12ad2378c9060205a3","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":151,"context_line":"        if self.lb_feature_enabled.l7_protocol_enabled:"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"},{"line_number":154,"context_line":"        self.assertEqual(pool_sp_cookie_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_d82e5da4","line":151,"in_reply_to":"3fce034c_a8601634","updated":"2019-04-24 07:41:31.000000000","message":"Got it :)","commit_id":"59a03d98bbe58fd3d829942ee1e96a873cfc4039"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8ca2d62871a1fef7bcb80382d146838f20034ab3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            const.ADMIN_STATE_UP: False,"},{"line_number":102,"context_line":"            const.PROTOCOL: self.protocol,"},{"line_number":103,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":104,"context_line":"            const.SESSION_PERSISTENCE: {"},{"line_number":105,"context_line":"                const.TYPE: const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":106,"context_line":"                const.COOKIE_NAME: pool_sp_cookie_name,"},{"line_number":107,"context_line":"            },"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":"        if has_listener:"},{"line_number":110,"context_line":"            pool_kwargs[const.LISTENER_ID] \u003d self.listener_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_30b99c2d","line":107,"range":{"start_line":104,"start_character":12,"end_line":107,"end_character":14},"updated":"2019-05-10 06:03:54.000000000","message":"This needs to be skipped or a different session persistence option needs to be set according to support by the provider.","commit_id":"337f80941fffdba5faa9f4361cc8a0036a792d65"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bcdf99ab0dc59a9c1b3757a0c799730220984b09","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            const.ADMIN_STATE_UP: False,"},{"line_number":102,"context_line":"            const.PROTOCOL: self.protocol,"},{"line_number":103,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":104,"context_line":"            const.SESSION_PERSISTENCE: {"},{"line_number":105,"context_line":"                const.TYPE: const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":106,"context_line":"                const.COOKIE_NAME: pool_sp_cookie_name,"},{"line_number":107,"context_line":"            },"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":"        if has_listener:"},{"line_number":110,"context_line":"            pool_kwargs[const.LISTENER_ID] \u003d self.listener_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_f8cdcab6","line":107,"range":{"start_line":104,"start_character":12,"end_line":107,"end_character":14},"in_reply_to":"dfbec78f_30b99c2d","updated":"2019-05-16 12:48:56.000000000","message":"Wont using the session-persistence-enabled option work on it as well?","commit_id":"337f80941fffdba5faa9f4361cc8a0036a792d65"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8ca2d62871a1fef7bcb80382d146838f20034ab3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.assertEmpty(pool[const.LISTENERS])"},{"line_number":148,"context_line":"        self.assertEqual(const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":149,"context_line":"                         pool[const.LB_ALGORITHM])"},{"line_number":150,"context_line":"        self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":151,"context_line":"        if self.lb_feature_enabled.session_persistence_enabled:"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_9093a8a3","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":65},"updated":"2019-05-10 06:03:54.000000000","message":"This should be asserted as not none if session persistence is enabled.","commit_id":"337f80941fffdba5faa9f4361cc8a0036a792d65"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8ca2d62871a1fef7bcb80382d146838f20034ab3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if self.lb_feature_enabled.session_persistence_enabled:"},{"line_number":152,"context_line":"            self.assertEqual(const.SESSION_PERSISTENCE_APP_COOKIE,"},{"line_number":153,"context_line":"                             pool[const.SESSION_PERSISTENCE][const.TYPE])"},{"line_number":154,"context_line":"        self.assertEqual(pool_sp_cookie_name,"},{"line_number":155,"context_line":"                         pool[const.SESSION_PERSISTENCE][const.COOKIE_NAME])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Pool update"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_3092fc9f","line":154,"updated":"2019-05-10 06:03:54.000000000","message":"ditto","commit_id":"337f80941fffdba5faa9f4361cc8a0036a792d65"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8ca2d62871a1fef7bcb80382d146838f20034ab3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                const.LB_ALGORITHM_LEAST_CONNECTIONS"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if self.protocol \u003d\u003d const.HTTP:"},{"line_number":172,"context_line":"            pool_update_kwargs[const.SESSION_PERSISTENCE] \u003d {"},{"line_number":173,"context_line":"                const.TYPE: const.SESSION_PERSISTENCE_HTTP_COOKIE}"},{"line_number":174,"context_line":"        pool \u003d self.mem_pool_client.update_pool("},{"line_number":175,"context_line":"            pool[const.ID], **pool_update_kwargs)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_b07eec68","line":173,"range":{"start_line":172,"start_character":12,"end_line":173,"end_character":66},"updated":"2019-05-10 06:03:54.000000000","message":"ditto","commit_id":"337f80941fffdba5faa9f4361cc8a0036a792d65"}]}