)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"77077595a12b4945821bf91b11fe3d54ea6d148f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"afebd8c4_51c7e0ab","updated":"2022-03-28 15:47:12.000000000","message":"recheck","commit_id":"96a217e0f35e88d184f77559bb8fa8d309eafede"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e7d2276a480ceced482968481e3fedafa0aa8122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"13d6c556_8994a90c","updated":"2022-03-31 08:06:00.000000000","message":"recheck","commit_id":"53bd01ea11e3950717154c3c5576d28544035b2c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"53f7119141742b15713992ffd5b38dc21cde6a37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"36b9a630_de182d1c","updated":"2022-08-26 07:19:55.000000000","message":"recheck depends-on was updated","commit_id":"8e4e7593a2637fc1482dc2d92f5219e43e5352c6"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6ec3ffb182c3270424114364c3cd754fc06ced17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"c776ed46_2b365e4a","updated":"2023-09-20 09:20:27.000000000","message":"just some comments thinking on ovn provider implementation","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e926d2506237008d45ceb0c737479a37564a00cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"1c8c44ee_095fd269","updated":"2023-11-16 16:45:49.000000000","message":"recheck This Session\\\u0027s transaction has been rolled back due to a previous exception during flush. To begin a new transaction with this Session, first issue Session.rollback()","commit_id":"85a0b075e97580da8bd2791dd3b162f2e63aa217"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4e566c927db9bab47619d59035e57204af8c5545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"83dff4c4_2f0699e5","updated":"2026-01-28 07:08:00.000000000","message":"recheck need new logs","commit_id":"e562721d03fe7389f238b4e21590872ae4139e2e"}],"octavia_tempest_plugin/tests/scenario/v2/test_additional_vips_traffic_ops.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"10a0f39d2ab7f4df4b4c21df0b9d792fd32666c7","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            vip_obj \u003d ipaddress.ip_address(vip)"},{"line_number":231,"context_line":"            if (CONF.validation.connect_method \u003d\u003d \u0027floating\u0027 and"},{"line_number":232,"context_line":"                    vip_obj.version \u003d\u003d 4):"},{"line_number":233,"context_line":"                port_id \u003d lb[const.VIP_PORT_ID]"},{"line_number":234,"context_line":"                result \u003d cls.lb_mem_float_ip_client.create_floatingip("},{"line_number":235,"context_line":"                    floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":236,"context_line":"                    port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":38,"id":"441a90ff_8e45b071","line":233,"updated":"2025-04-03 15:14:40.000000000","message":"IIUC this  port_id \u003d lb[const.VIP_PORT_ID] is wrong, it is iterating on lb_vips that is the sum of vip+addi_vips but then iterating over lb_vips on L229 if it finds any IPv4 IP, it will add floating ip always to same port (VIP_PORT_ID). \n\ne.g. if the main LB VIP is a IPv6 and additional vip is a IPv4, it will try to add a Floating IP to the LB VIP IPv6 Port ID.","commit_id":"b18ba59731675da25dc987cc9bb5ca9939d6a500"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"55af44edbf40b0588e14de6de723440fb38db87b","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            vip_obj \u003d ipaddress.ip_address(vip)"},{"line_number":231,"context_line":"            if (CONF.validation.connect_method \u003d\u003d \u0027floating\u0027 and"},{"line_number":232,"context_line":"                    vip_obj.version \u003d\u003d 4):"},{"line_number":233,"context_line":"                port_id \u003d lb[const.VIP_PORT_ID]"},{"line_number":234,"context_line":"                result \u003d cls.lb_mem_float_ip_client.create_floatingip("},{"line_number":235,"context_line":"                    floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":236,"context_line":"                    port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":38,"id":"eac90e70_5dce6da6","line":233,"in_reply_to":"441a90ff_8e45b071","updated":"2025-04-09 14:46:36.000000000","message":"but there\u0027s only one vip_port per LB (so this port_id assignment could have been moved outside the for loop)\nIPv4 or IPv6 VIPs are set on this port","commit_id":"b18ba59731675da25dc987cc9bb5ca9939d6a500"}],"octavia_tempest_plugin/tests/scenario/v2/test_traffic_additional_vips.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6ec3ffb182c3270424114364c3cd754fc06ced17","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":63,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        protocol \u003d const.HTTP"},{"line_number":66,"context_line":"        lb_feature_enabled \u003d CONF.loadbalancer_feature_enabled"},{"line_number":67,"context_line":"        if not lb_feature_enabled.l7_protocol_enabled:"},{"line_number":68,"context_line":"            protocol \u003d lb_feature_enabled.l4_protocol"}],"source_content_type":"text/x-python","patch_set":28,"id":"13d3127c_8250bdc0","line":65,"updated":"2023-09-20 09:20:27.000000000","message":"Perhaps it could be passed as argument to eval other protocols","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a8a7c321423c908bbf21a1924e36c2af20da3f2a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                CONF.load_balancer.lb_build_interval,"},{"line_number":63,"context_line":"                                CONF.load_balancer.lb_build_timeout)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        protocol \u003d const.HTTP"},{"line_number":66,"context_line":"        lb_feature_enabled \u003d CONF.loadbalancer_feature_enabled"},{"line_number":67,"context_line":"        if not lb_feature_enabled.l7_protocol_enabled:"},{"line_number":68,"context_line":"            protocol \u003d lb_feature_enabled.l4_protocol"}],"source_content_type":"text/x-python","patch_set":28,"id":"d0c7c474_ce590989","line":65,"in_reply_to":"13d3127c_8250bdc0","updated":"2023-09-29 07:08:09.000000000","message":"Done","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6ec3ffb182c3270424114364c3cd754fc06ced17","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        pool_kwargs \u003d {"},{"line_number":92,"context_line":"            const.NAME: pool_name,"},{"line_number":93,"context_line":"            const.PROTOCOL: protocol,"},{"line_number":94,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":95,"context_line":"            const.LISTENER_ID: self.listener_id,"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"        pool \u003d self.mem_pool_client.create_pool(**pool_kwargs)"}],"source_content_type":"text/x-python","patch_set":28,"id":"cbe200aa_7695a425","line":94,"updated":"2023-09-20 09:20:27.000000000","message":"idem for the Load balancer algorithm","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a8a7c321423c908bbf21a1924e36c2af20da3f2a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        pool_kwargs \u003d {"},{"line_number":92,"context_line":"            const.NAME: pool_name,"},{"line_number":93,"context_line":"            const.PROTOCOL: protocol,"},{"line_number":94,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":95,"context_line":"            const.LISTENER_ID: self.listener_id,"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"        pool \u003d self.mem_pool_client.create_pool(**pool_kwargs)"}],"source_content_type":"text/x-python","patch_set":28,"id":"b75a8feb_67dfc254","line":94,"in_reply_to":"cbe200aa_7695a425","updated":"2023-09-29 07:08:09.000000000","message":"Done","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6ec3ffb182c3270424114364c3cd754fc06ced17","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            const.POOL_ID: self.pool_id,"},{"line_number":138,"context_line":"            const.NAME: member2_name,"},{"line_number":139,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":140,"context_line":"            const.ADDRESS: self.webserver2_ipv6,"},{"line_number":141,"context_line":"            const.PROTOCOL_PORT: 80,"},{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":"        if self.lb_member_2_ipv6_subnet:"}],"source_content_type":"text/x-python","patch_set":28,"id":"423f4fc1_29414e79","line":140,"updated":"2023-09-20 09:20:27.000000000","message":"Not clear why is here mixing member with IPv4 and IPv6, basically the test of the multivips should cover the testing of the additional VIPs (indeed IPv4 + IPv6) but over the VIP LB context, no?","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a8a7c321423c908bbf21a1924e36c2af20da3f2a","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            const.POOL_ID: self.pool_id,"},{"line_number":138,"context_line":"            const.NAME: member2_name,"},{"line_number":139,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":140,"context_line":"            const.ADDRESS: self.webserver2_ipv6,"},{"line_number":141,"context_line":"            const.PROTOCOL_PORT: 80,"},{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":"        if self.lb_member_2_ipv6_subnet:"}],"source_content_type":"text/x-python","patch_set":28,"id":"f2dcdd10_798bdd87","line":140,"in_reply_to":"423f4fc1_29414e79","updated":"2023-09-29 07:08:09.000000000","message":"we can ensure that the traffic to one of the VIP is forwarded to both members (ipv4 and ipv7).\nIIRC it\u0027s not possible with the other providers (it\u0027s also not possible with UDP listeners/pools in the amphora provider)","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6ec3ffb182c3270424114364c3cd754fc06ced17","unresolved":true,"context_lines":[{"line_number":175,"context_line":"                port_id \u003d lb[const.VIP_PORT_ID]"},{"line_number":176,"context_line":"                result \u003d cls.lb_mem_float_ip_client.create_floatingip("},{"line_number":177,"context_line":"                    floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":178,"context_line":"                    port_id\u003dport_id,"},{"line_number":179,"context_line":"                    fixed_ip_address\u003dvip)"},{"line_number":180,"context_line":"                floating_ip \u003d result[\u0027floatingip\u0027]"},{"line_number":181,"context_line":"                floating_address \u003d floating_ip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"04a03e0d_c10b8a61","line":178,"updated":"2023-09-20 09:20:27.000000000","message":"I just checked the implementation for the amphora provider and comparing to the ovn one, in amphora all additional vip are assigned to additional address of the only one VIP port, so this test make sense as this way, but for the ovn provider each additional vip has it own port, so the test will iterate over the same port id for each vip attaching #N FIPs to the same port.","commit_id":"e24463bfa47ec53a480527f217f4fe083ce96bdc"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d0f1c2bfb672ad7d14945dc9c5ccf22d2e4d9e6f","unresolved":true,"context_lines":[{"line_number":995,"context_line":"    override-checkout: stable/ussuri"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"- job:"},{"line_number":998,"context_line":"    name: octavia-v2-multivip-dsvm-scenario"},{"line_number":999,"context_line":"    parent: octavia-v2-dsvm-scenario"},{"line_number":1000,"context_line":"    vars:"},{"line_number":1001,"context_line":"      tempest_test_regex: ^octavia_tempest_plugin.tests.multivip_scenario.v2"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ebdb21c2_b453650f","line":998,"range":{"start_line":998,"start_character":21,"end_line":998,"end_character":29},"updated":"2022-03-31 08:05:47.000000000","message":"not sure we need a specific job for this feature","commit_id":"53bd01ea11e3950717154c3c5576d28544035b2c"}]}