)]}'
{"octavia_tempest_plugin/tests/act_stdby_scenario/v2/test_active_standby_iptables.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ef7657e0f0e2c890777b41609288886e12b85b98","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            fp \u003d open(key_file, \u0027r\u0027)"},{"line_number":55,"context_line":"            fp.close()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            raise cls.skipException(\"Could not open amphora SSH key file {0}.\""},{"line_number":58,"context_line":"                                    .format(key_file))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d98eeacf","line":58,"range":{"start_line":57,"start_character":12,"end_line":58,"end_character":54},"updated":"2019-08-02 09:30:01.000000000","message":"A missing or misconfigured ssh key should make the test fail instead of skipping it.\nIf a future change updates ssh key location or breaks some stuff related to ssh keys (permission, etc...), we won\u0027t be able to detect the issue.","commit_id":"23156003d9d49b98f10487627f3d7474e8ffaf35"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"20da13b47752bb7922224fd13f472882209c706c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            fp \u003d open(key_file, \u0027r\u0027)"},{"line_number":55,"context_line":"            fp.close()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            raise cls.skipException(\"Could not open amphora SSH key file {0}.\""},{"line_number":58,"context_line":"                                    .format(key_file))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_d6f7b7d2","line":58,"range":{"start_line":57,"start_character":12,"end_line":58,"end_character":54},"in_reply_to":"7faddb67_d98eeacf","updated":"2019-09-13 12:02:00.000000000","message":"Done","commit_id":"23156003d9d49b98f10487627f3d7474e8ffaf35"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f2a25bc54a3515c31fd40fc2dca80c2557f069e5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            raise cls.skipException(\"Configured load balancer topology is not \""},{"line_number":50,"context_line":"                                    \"%s.\" % const.ACTIVE_STANDBY)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        key_file \u003d CONF.load_balancer.amphora_ssh_key"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            fp \u003d open(key_file, \u0027r\u0027)"},{"line_number":55,"context_line":"            fp.close()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            raise Exception(\"Could not open amphora SSH key file {0}.\""},{"line_number":58,"context_line":"                            .format(key_file))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_f696733e","line":58,"range":{"start_line":52,"start_character":7,"end_line":58,"end_character":46},"updated":"2019-09-13 12:15:11.000000000","message":"Can you call _get_amphora_ssk_key here? This could avoid duplicated code.","commit_id":"08eb643c1234f8eacac2337db887f656385955ea"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e967afb0a47badf2e19d7548a5957ca95ca62c9e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            raise cls.skipException(\"Configured load balancer topology is not \""},{"line_number":50,"context_line":"                                    \"%s.\" % const.ACTIVE_STANDBY)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        key_file \u003d CONF.load_balancer.amphora_ssh_key"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            fp \u003d open(key_file, \u0027r\u0027)"},{"line_number":55,"context_line":"            fp.close()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            raise Exception(\"Could not open amphora SSH key file {0}.\""},{"line_number":58,"context_line":"                            .format(key_file))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_569c270e","line":58,"range":{"start_line":52,"start_character":7,"end_line":58,"end_character":46},"in_reply_to":"5faad753_f696733e","updated":"2019-09-13 12:39:21.000000000","message":"I considered that. The reason why I chose not to call was that it reads the whole file while we don\u0027t need that in skip_checks. I\u0027m gonna take your suggestion, thanks!","commit_id":"08eb643c1234f8eacac2337db887f656385955ea"}]}