)]}'
{"octavia_tempest_plugin/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"62bc1aad31dd2ae528dc29abb3a96817b5885f31","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                     \"provider driver.\"),"},{"line_number":232,"context_line":"    cfg.BoolOpt(\u0027log_offload_enabled\u0027, default\u003dFalse,"},{"line_number":233,"context_line":"                help\u003d\"Whether the log offload tests will run. These require \""},{"line_number":234,"context_line":"                     \"the tempest instance have access to the logs files \""},{"line_number":235,"context_line":"                     \"specified in the tempest configuration.\"),"},{"line_number":236,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_ffb5711a","line":234,"range":{"start_line":234,"start_character":62,"end_line":234,"end_character":66},"updated":"2020-01-13 22:33:12.000000000","message":"s/log","commit_id":"d7526be7a1eb3204769ca36c73c6c2c75ef1d03e"}],"octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"155eb27a84a130b16b424b1e81143f0e2833768d","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        self.assertEqual(project_id, fields[0])  # project_id"},{"line_number":924,"context_line":"        self.assertEqual(self.lb_id, fields[1])  # loadbalancer_id"},{"line_number":925,"context_line":"        self.assertEqual(listener_id, fields[2])  # listener_id"},{"line_number":926,"context_line":"        ipaddress.ip_address(six.u(fields[3]))  # client_ip"},{"line_number":927,"context_line":"        self.assertGreaterEqual(int(fields[4]), 0)  # client_port"},{"line_number":928,"context_line":"        self.assertLessEqual(int(fields[4]), 65535)  # client_port"},{"line_number":929,"context_line":"        datetime.datetime.strptime(fields[5],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf51134e_0ad7ce4c","line":926,"updated":"2020-06-29 21:05:48.000000000","message":"From what I can sell, six.u() on py3 is a noop and just returns the string without any conversion.\n                                         \n    def u(s):                                                                   \n        return s\n\nI thought we had removed six usage, but guess I missed this repo, will send something out.","commit_id":"77535cce31ebfebf983612feb13dcad40c8b1a31"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"53e87ce42921bf36fb9916b8f26ca6f2a66cf5b1","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        self.assertEqual(project_id, fields[0])  # project_id"},{"line_number":924,"context_line":"        self.assertEqual(self.lb_id, fields[1])  # loadbalancer_id"},{"line_number":925,"context_line":"        self.assertEqual(listener_id, fields[2])  # listener_id"},{"line_number":926,"context_line":"        ipaddress.ip_address(six.u(fields[3]))  # client_ip"},{"line_number":927,"context_line":"        self.assertGreaterEqual(int(fields[4]), 0)  # client_port"},{"line_number":928,"context_line":"        self.assertLessEqual(int(fields[4]), 65535)  # client_port"},{"line_number":929,"context_line":"        datetime.datetime.strptime(fields[5],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf51134e_aa4ce241","line":926,"in_reply_to":"bf51134e_0ad7ce4c","updated":"2020-06-29 21:09:17.000000000","message":"This patch is almost a year old now, so yeah, probably needs a sweep to remove the six references.","commit_id":"77535cce31ebfebf983612feb13dcad40c8b1a31"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7846346c5ba5c949a9f8df44d3b7321d76fece56","unresolved":false,"context_lines":[{"line_number":811,"context_line":"    @testtools.skipUnless("},{"line_number":812,"context_line":"        CONF.loadbalancer_feature_enabled.log_offload_enabled,"},{"line_number":813,"context_line":"        \u0027Skipping log offload tests because tempest configuration \u0027"},{"line_number":814,"context_line":"        \u0027[load_balancer] log_offload_enabled is False.\u0027)"},{"line_number":815,"context_line":"    @testtools.skipUnless("},{"line_number":816,"context_line":"        CONF.loadbalancer_feature_enabled.l7_protocol_enabled,"},{"line_number":817,"context_line":"        \u0027Log offload tests require l7_protocol_enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf51134e_b6e64faf","line":814,"range":{"start_line":814,"start_character":10,"end_line":814,"end_character":23},"updated":"2020-07-13 14:13:10.000000000","message":"nit: should be [loadbalancer-feature-enabled]","commit_id":"209d835988f49a9741b0cd87f38e22645725cc98"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0aa343fd8390d1a1c4d9955471dd67090e722d12","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        # Split the line into the log format fields"},{"line_number":919,"context_line":"        fields \u003d shlex.split(log_line)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # Validate the fields"},{"line_number":922,"context_line":"        self.assertEqual(project_id, fields[0])  # project_id"},{"line_number":923,"context_line":"        self.assertEqual(self.lb_id, fields[1])  # loadbalancer_id"},{"line_number":924,"context_line":"        self.assertEqual(listener_id, fields[2])  # listener_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf51134e_93778409","line":921,"updated":"2020-07-01 01:03:54.000000000","message":"nit: maybe using a namedtuple for below would make it easier to understand?\n\nin_log \u003d collections.namedtuple(\u0027log\u0027, \u0027project_id, lb_id... \u0027)\nmylog \u003d in_log(*fields)\nself.assertEqual(project_id, mylog.project_id)\n...","commit_id":"209d835988f49a9741b0cd87f38e22645725cc98"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"faed607663c7ad68eed791b785d35a2c4759c3a0","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        # Split the line into the log format fields"},{"line_number":919,"context_line":"        fields \u003d shlex.split(log_line)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # Validate the fields"},{"line_number":922,"context_line":"        self.assertEqual(project_id, fields[0])  # project_id"},{"line_number":923,"context_line":"        self.assertEqual(self.lb_id, fields[1])  # loadbalancer_id"},{"line_number":924,"context_line":"        self.assertEqual(listener_id, fields[2])  # listener_id"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_9d8671db","line":921,"updated":"2020-08-12 15:43:32.000000000","message":"This validation works only when user_log_format is the default value. Adding another tempest config option is unnecessary at this point I guess.","commit_id":"b1ba3b373ca44da31e8ec79a5eaba71e2ef2b81f"}]}
