)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"de67964dd98d7f508340c2637180188046d3f769","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(LoadBalancerScenarioTest, cls).resource_setup()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if cls.lb_admin_flavor_profile_client.is_version_supported("},{"line_number":40,"context_line":"                cls.api_version, \u00272.6\u0027) and CONF.load_balancer.test_flavors:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            # Create a shared flavor profile"},{"line_number":43,"context_line":"            flavor_profile_name \u003d data_utils.rand_name(\"lb_scenario-setup\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ca42bc68","line":40,"updated":"2019-10-09 22:45:27.000000000","message":"Can\u0027t we just capture the error from the \"create_flavor_profile\" call that will state it\u0027s not implemented by the provider?\nThis would make the skip more automatic and not require one more setting in the tempest.conf.","commit_id":"b7a808c9db1c3cc28e39b74ba4e133ef2005aa5d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"81e9443c726a459eb9bbce026724c92ba5262754","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(LoadBalancerScenarioTest, cls).resource_setup()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if cls.lb_admin_flavor_profile_client.is_version_supported("},{"line_number":40,"context_line":"                cls.api_version, \u00272.6\u0027) and CONF.load_balancer.test_flavors:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            # Create a shared flavor profile"},{"line_number":43,"context_line":"            flavor_profile_name \u003d data_utils.rand_name(\"lb_scenario-setup\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a2b3b297","line":40,"in_reply_to":"3fa7e38b_ca42bc68","updated":"2019-10-14 09:55:13.000000000","message":"++ good point","commit_id":"b7a808c9db1c3cc28e39b74ba4e133ef2005aa5d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0ef65a9c22db8d71ea28d7696808d9b0d2c10163","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    cls.flavor[const.ID])"},{"line_number":77,"context_line":"                cls.flavor_id \u003d cls.flavor[const.ID]"},{"line_number":78,"context_line":"            except exceptions.NotImplemented:"},{"line_number":79,"context_line":"                # Provider driver doesn\u0027t support flavors."},{"line_number":80,"context_line":"                cls.flavor_profile \u003d None"},{"line_number":81,"context_line":"                cls.flavor_id \u003d None"},{"line_number":82,"context_line":"                cls.flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_99e036ce","line":79,"updated":"2019-11-04 23:00:32.000000000","message":"nit: Might be nice to log this skip.","commit_id":"3e940a955b8ce587bc839f715243eef75a3894df"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"65f0c42891600956ef40fe16341931955a0e39af","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    cls.flavor[const.ID])"},{"line_number":79,"context_line":"                cls.flavor_id \u003d cls.flavor[const.ID]"},{"line_number":80,"context_line":"            except exceptions.NotImplemented:"},{"line_number":81,"context_line":"                LOG.debug(\"Provider driver %s doesn\u0027t support flavors.\","},{"line_number":82,"context_line":"                          CONF.load_balancer.provider)"},{"line_number":83,"context_line":"                cls.flavor_profile \u003d None"},{"line_number":84,"context_line":"                cls.flavor_id \u003d None"},{"line_number":85,"context_line":"                cls.flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_d7d02e56","line":82,"range":{"start_line":81,"start_character":11,"end_line":82,"end_character":54},"updated":"2019-11-15 15:16:23.000000000","message":"I think it will be better to introduce tempest config option like it is done for l7policies and other option that could be unavailable on other providers https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/config.py#L207","commit_id":"1c8e476f3b8cb0669a1295ad5ea9ae3b5b2975ac"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d0b92e7bfaa7705261f3a966dd3461c5ae8e5260","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    cls.flavor[const.ID])"},{"line_number":79,"context_line":"                cls.flavor_id \u003d cls.flavor[const.ID]"},{"line_number":80,"context_line":"            except exceptions.NotImplemented:"},{"line_number":81,"context_line":"                LOG.debug(\"Provider driver %s doesn\u0027t support flavors.\","},{"line_number":82,"context_line":"                          CONF.load_balancer.provider)"},{"line_number":83,"context_line":"                cls.flavor_profile \u003d None"},{"line_number":84,"context_line":"                cls.flavor_id \u003d None"},{"line_number":85,"context_line":"                cls.flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_4cc265eb","line":82,"range":{"start_line":81,"start_character":11,"end_line":82,"end_character":54},"in_reply_to":"3fa7e38b_054be586","updated":"2019-11-18 13:29:13.000000000","message":"oh, if cores say that :)\nFor me this seems as inconsistency - some options as skipped via config options and some are caught as NotImplemented.","commit_id":"1c8e476f3b8cb0669a1295ad5ea9ae3b5b2975ac"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"d55166dcb17268da0c14e5381905a1a26d08b392","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    cls.flavor[const.ID])"},{"line_number":79,"context_line":"                cls.flavor_id \u003d cls.flavor[const.ID]"},{"line_number":80,"context_line":"            except exceptions.NotImplemented:"},{"line_number":81,"context_line":"                LOG.debug(\"Provider driver %s doesn\u0027t support flavors.\","},{"line_number":82,"context_line":"                          CONF.load_balancer.provider)"},{"line_number":83,"context_line":"                cls.flavor_profile \u003d None"},{"line_number":84,"context_line":"                cls.flavor_id \u003d None"},{"line_number":85,"context_line":"                cls.flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_6fa63357","line":82,"range":{"start_line":81,"start_character":11,"end_line":82,"end_character":54},"in_reply_to":"3fa7e38b_4cc265eb","updated":"2019-11-18 14:27:41.000000000","message":"Yea, the goal now is to not do any of those configurations, if not needed.","commit_id":"1c8e476f3b8cb0669a1295ad5ea9ae3b5b2975ac"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e1de9d9038eaad1c697a03af13074ffa39d8dbda","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    cls.flavor[const.ID])"},{"line_number":79,"context_line":"                cls.flavor_id \u003d cls.flavor[const.ID]"},{"line_number":80,"context_line":"            except exceptions.NotImplemented:"},{"line_number":81,"context_line":"                LOG.debug(\"Provider driver %s doesn\u0027t support flavors.\","},{"line_number":82,"context_line":"                          CONF.load_balancer.provider)"},{"line_number":83,"context_line":"                cls.flavor_profile \u003d None"},{"line_number":84,"context_line":"                cls.flavor_id \u003d None"},{"line_number":85,"context_line":"                cls.flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_054be586","line":82,"range":{"start_line":81,"start_character":11,"end_line":82,"end_character":54},"in_reply_to":"3fa7e38b_d7d02e56","updated":"2019-11-18 08:58:36.000000000","message":"The tempest config option was introduced on PS1, but then after Cores review I changed it to catch exception.\n\nFor me that is better way of handling this instead adding new option.","commit_id":"1c8e476f3b8cb0669a1295ad5ea9ae3b5b2975ac"}]}