)]}'
{"octavia_tempest_plugin/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"954b0b99b9fff7256d6ef91fe665a3199e83f76f","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    cfg.BoolOpt(\u0027test_reuse_connection\u0027, default\u003dTrue,"},{"line_number":192,"context_line":"                help\u003d\u0027Reuse TCP connections while testing LB with \u0027"},{"line_number":193,"context_line":"                     \u0027HTTP members (keep-alive).\u0027),"},{"line_number":194,"context_line":"    cfg.StrOpt(\u0027test_ipv6_vip_subnet\u0027,"},{"line_number":195,"context_line":"               default\u003d\u0027ipv6-private-subnet\u0027,"},{"line_number":196,"context_line":"               help\u003d\u0027Existing IPv6 subnet to be used as VIP subnet for IPv6 \u0027"},{"line_number":197,"context_line":"                    \u0027tests.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7652aa6a","line":194,"updated":"2019-12-04 16:48:46.000000000","message":"This already exists as: test_ipv6_subnet_override above on line 153. Does that not meet the need?","commit_id":"21ee126797f9593beb476a284c818ce9da7debf1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"92ccf8c8c510b3a6525320713a45a2bf146f7d23","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    cfg.BoolOpt(\u0027test_reuse_connection\u0027, default\u003dTrue,"},{"line_number":192,"context_line":"                help\u003d\u0027Reuse TCP connections while testing LB with \u0027"},{"line_number":193,"context_line":"                     \u0027HTTP members (keep-alive).\u0027),"},{"line_number":194,"context_line":"    cfg.StrOpt(\u0027test_ipv6_vip_subnet\u0027,"},{"line_number":195,"context_line":"               default\u003d\u0027ipv6-private-subnet\u0027,"},{"line_number":196,"context_line":"               help\u003d\u0027Existing IPv6 subnet to be used as VIP subnet for IPv6 \u0027"},{"line_number":197,"context_line":"                    \u0027tests.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_712154b5","line":194,"in_reply_to":"3fa7e38b_7652aa6a","updated":"2019-12-04 17:54:28.000000000","message":"1. The issue with test_ipv6_subnet_override is that it works only when test_network_override and test_subnet_override are enabled, so it uses of the same network and subnets for all the resources used in the tests (members, vip, etc...), I\u0027d prefer to not use that.\n\n2. I\u0027m not really confident with the whole block that starts at https://review.opendev.org/gitweb?p\u003dopenstack/octavia-tempest-plugin.git;a\u003dblob;f\u003doctavia_tempest_plugin/tests/test_base.py;h\u003d5033ade6516ae6d192e18173bda957bc6943f111;hb\u003dHEAD#l164\n. The objects returned by show_net and show_subnet are incorrectly used: accessing to the objects triggers exceptions, and this block uses some invalid configuration directives (i.e. conf_lb.test_IPv6_subnet_override is badly spelled), so I guess it cannot work without a few fixes (can be part of another change and story).\n\nThe purpose of my change is to use the shortcut that was created for devstack (using ipv6-private-subnet directly) which could benefit other deployment tools.","commit_id":"21ee126797f9593beb476a284c818ce9da7debf1"}]}