)]}'
{"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9a94d88a0f3d3916b1a69dc10cc5d823534edf76","unresolved":false,"context_lines":[{"line_number":982,"context_line":"        # connectivity is functional between the load balancer and the membesr)"},{"line_number":983,"context_line":"        while time.time() - start \u003c CONF.load_balancer.build_timeout:"},{"line_number":984,"context_line":"            try:"},{"line_number":985,"context_line":"                if protocol !\u003d const.UDP:"},{"line_number":986,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":987,"context_line":"                        protocol.lower(),"},{"line_number":988,"context_line":"                        vip_address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6d22c954","side":"PARENT","line":985,"updated":"2020-03-19 14:14:07.000000000","message":"Rather than make a whole new block, you could do something simpler below this line, like:\n\nrequest_protocol \u003d const.HTTP.lower() if protocol \u003d\u003d const.TCP else protocol.lower()","commit_id":"fc308b3b2a7c489914a0e8e33f75324bff55e5ec"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b3f356d5545bb52cc8664eb5ccaf061ba34a69","unresolved":false,"context_lines":[{"line_number":982,"context_line":"        # connectivity is functional between the load balancer and the membesr)"},{"line_number":983,"context_line":"        while time.time() - start \u003c CONF.load_balancer.build_timeout:"},{"line_number":984,"context_line":"            try:"},{"line_number":985,"context_line":"                if protocol !\u003d const.UDP:"},{"line_number":986,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":987,"context_line":"                        protocol.lower(),"},{"line_number":988,"context_line":"                        vip_address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_f58eb8ce","side":"PARENT","line":985,"in_reply_to":"1fa4df85_6d22c954","updated":"2020-04-20 21:28:18.000000000","message":"Done","commit_id":"fc308b3b2a7c489914a0e8e33f75324bff55e5ec"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9a94d88a0f3d3916b1a69dc10cc5d823534edf76","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            try:"},{"line_number":985,"context_line":"                if protocol !\u003d const.UDP:"},{"line_number":986,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":987,"context_line":"                        protocol.lower(),"},{"line_number":988,"context_line":"                        vip_address,"},{"line_number":989,"context_line":"                        \u0027:\u0027 if protocol_port else \u0027\u0027,"},{"line_number":990,"context_line":"                        protocol_port or \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_cd109d03","side":"PARENT","line":987,"updated":"2020-03-19 14:14:07.000000000","message":"Then here just use `request_protocol`","commit_id":"fc308b3b2a7c489914a0e8e33f75324bff55e5ec"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b3f356d5545bb52cc8664eb5ccaf061ba34a69","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            try:"},{"line_number":985,"context_line":"                if protocol !\u003d const.UDP:"},{"line_number":986,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":987,"context_line":"                        protocol.lower(),"},{"line_number":988,"context_line":"                        vip_address,"},{"line_number":989,"context_line":"                        \u0027:\u0027 if protocol_port else \u0027\u0027,"},{"line_number":990,"context_line":"                        protocol_port or \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_55bdec66","side":"PARENT","line":987,"in_reply_to":"1fa4df85_cd109d03","updated":"2020-04-20 21:28:18.000000000","message":"Done","commit_id":"fc308b3b2a7c489914a0e8e33f75324bff55e5ec"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5249b10de8fb968cf612ac7015776bd7eab7734c","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"                        \u0027:\u0027 if protocol_port else \u0027\u0027,"},{"line_number":1004,"context_line":"                        protocol_port or \u0027\u0027)"},{"line_number":1005,"context_line":"                    r \u003d requests.get(url, timeout\u003d2, verify\u003dverify)"},{"line_number":1006,"context_line":"                    data \u003d r.content"},{"line_number":1007,"context_line":"                if data in response_counts:"},{"line_number":1008,"context_line":"                    response_counts[data] +\u003d 1"},{"line_number":1009,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_937f2cde","line":1006,"updated":"2020-03-19 10:45:51.000000000","message":"Not related to the change per-se, but this code and the L1033 to L1054 could be refactored to its own method","commit_id":"8adbf1ddbbf0032be73f8a78132bdd8e6e5e8b9a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b3f356d5545bb52cc8664eb5ccaf061ba34a69","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"                        \u0027:\u0027 if protocol_port else \u0027\u0027,"},{"line_number":1004,"context_line":"                        protocol_port or \u0027\u0027)"},{"line_number":1005,"context_line":"                    r \u003d requests.get(url, timeout\u003d2, verify\u003dverify)"},{"line_number":1006,"context_line":"                    data \u003d r.content"},{"line_number":1007,"context_line":"                if data in response_counts:"},{"line_number":1008,"context_line":"                    response_counts[data] +\u003d 1"},{"line_number":1009,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_75bc6869","line":1006,"in_reply_to":"1fa4df85_937f2cde","updated":"2020-04-20 21:28:18.000000000","message":"Ack, can look at consolidating things in a follow-on, thanks Lucas.","commit_id":"8adbf1ddbbf0032be73f8a78132bdd8e6e5e8b9a"}]}