)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7bc126cc591cede6dc2c051203f029bcbc89a127","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     oschwart \u003coschwart@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-18 10:10:04 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tags support tests were added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib14852d57535508fecee2705e704954cfd078474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_de7d381d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2020-06-18 17:57:41.000000000","message":"I\u0027d suggest to elaborate a bit more on tagging feature.\nIt could be one short sentence describing it.","commit_id":"cbc78e699b3d16fb50a2a01bd95551b66bdca47b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     oschwart \u003coschwart@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-18 10:10:04 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tags support tests were added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib14852d57535508fecee2705e704954cfd078474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_1c6b151e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"in_reply_to":"bf51134e_de7d381d","updated":"2020-06-23 07:09:50.000000000","message":"Ok, I will change/extend the commit message","commit_id":"cbc78e699b3d16fb50a2a01bd95551b66bdca47b"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d112a3887d9f80264e32e16d4d1ade7eb75631a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     oschwart \u003coschwart@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-07 14:28:02 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tags are strings attached to an entity with the purpose of classification into groups. Tags support API tests were added."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib14852d57535508fecee2705e704954cfd078474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bf51134e_a5b15092","line":7,"updated":"2020-07-07 11:34:34.000000000","message":"Please consider adopting these best practices: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"408412832d47b21b39e970c8a69aa4e120204fa1"}],"octavia_tempest_plugin/services/load_balancer/v2/healthmonitor_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class HealthMonitorClient(base_client.BaseLBaaSClient):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    root_tag \u003d \u0027healthmonitor\u0027"},{"line_number":26,"context_line":"    list_root_tag \u003d \u0027healthmonitors\u0027"},{"line_number":27,"context_line":"    resource_name \u003d \u0027healthmonitor\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_b784c25f","side":"PARENT","line":24,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"}],"octavia_tempest_plugin/services/load_balancer/v2/l7policy_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class L7PolicyClient(base_client.BaseLBaaSClient):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    root_tag \u003d \u0027l7policy\u0027"},{"line_number":26,"context_line":"    list_root_tag \u003d \u0027l7policies\u0027"},{"line_number":27,"context_line":"    resource_name \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_f77aba74","side":"PARENT","line":24,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"}],"octavia_tempest_plugin/services/load_balancer/v2/l7rule_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L7RuleClient(base_client.BaseLBaaSClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    root_tag \u003d \u0027rule\u0027"},{"line_number":27,"context_line":"    list_root_tag \u003d \u0027rules\u0027"},{"line_number":28,"context_line":"    resource_name \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_d77fb663","side":"PARENT","line":25,"updated":"2020-07-08 21:27:26.000000000","message":"ditto","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"}],"octavia_tempest_plugin/services/load_balancer/v2/loadbalancer_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param vip_port_id: The ID of the Virtual IP (VIP) port."},{"line_number":57,"context_line":"        :param vip_qos_policy_id: The ID of the QoS Policy which will apply to"},{"line_number":58,"context_line":"                                  the Virtual IP (VIP)."},{"line_number":59,"context_line":"        :param vip_subnet_id: The ID of the subnet for the Virtual IP (VIP)."},{"line_number":60,"context_line":"        :param return_object_only: If True, the response returns the object"},{"line_number":61,"context_line":"                                   inside the root tag. False returns the full"},{"line_number":62,"context_line":"                                   response from the API."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3e4aaa26","line":59,"updated":"2020-06-16 18:36:45.000000000","message":"We should add a \"tags\" docstring here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param vip_port_id: The ID of the Virtual IP (VIP) port."},{"line_number":57,"context_line":"        :param vip_qos_policy_id: The ID of the QoS Policy which will apply to"},{"line_number":58,"context_line":"                                  the Virtual IP (VIP)."},{"line_number":59,"context_line":"        :param vip_subnet_id: The ID of the subnet for the Virtual IP (VIP)."},{"line_number":60,"context_line":"        :param return_object_only: If True, the response returns the object"},{"line_number":61,"context_line":"                                   inside the root tag. False returns the full"},{"line_number":62,"context_line":"                                   response from the API."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4db88875","line":59,"in_reply_to":"bf51134e_3e4aaa26","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        :param lb_id: The loadbalancer ID to update."},{"line_number":180,"context_line":"        :param name: Human-readable name of the resource."},{"line_number":181,"context_line":"        :param description: A human-readable description for the resource."},{"line_number":182,"context_line":"        :param description: A human-readable tags for the resource."},{"line_number":183,"context_line":"        :param admin_state_up: The administrative state of the resource, which"},{"line_number":184,"context_line":"                               is up (true) or down (false)."},{"line_number":185,"context_line":"        :param vip_qos_policy_id: The ID of the QoS Policy which will apply to"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1e47e61f","line":182,"range":{"start_line":182,"start_character":15,"end_line":182,"end_character":26},"updated":"2020-06-16 18:36:45.000000000","message":"description -\u003e tags","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        :param lb_id: The loadbalancer ID to update."},{"line_number":180,"context_line":"        :param name: Human-readable name of the resource."},{"line_number":181,"context_line":"        :param description: A human-readable description for the resource."},{"line_number":182,"context_line":"        :param description: A human-readable tags for the resource."},{"line_number":183,"context_line":"        :param admin_state_up: The administrative state of the resource, which"},{"line_number":184,"context_line":"                               is up (true) or down (false)."},{"line_number":185,"context_line":"        :param vip_qos_policy_id: The ID of the QoS Policy which will apply to"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2dbd5465","line":182,"range":{"start_line":182,"start_character":15,"end_line":182,"end_character":26},"in_reply_to":"bf51134e_1e47e61f","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"}],"octavia_tempest_plugin/services/load_balancer/v2/member_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                       requests or connections it services compared to the"},{"line_number":57,"context_line":"                       other members of the pool."},{"line_number":58,"context_line":"        :param backup: Is the member a backup?"},{"line_number":59,"context_line":"        :param subnet_id: The subnet ID which the member service"},{"line_number":60,"context_line":"                                 is accessible from"},{"line_number":61,"context_line":"        :param monitor_address: An alternate IP address used for health"},{"line_number":62,"context_line":"                                monitoring a backend member."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7e5422cb","line":59,"updated":"2020-06-16 18:36:45.000000000","message":"Thanks!\nGenerally we do not allow un-related changes, but this is just a docstring so safe to do.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                       requests or connections it services compared to the"},{"line_number":57,"context_line":"                       other members of the pool."},{"line_number":58,"context_line":"        :param backup: Is the member a backup?"},{"line_number":59,"context_line":"        :param subnet_id: The subnet ID which the member service"},{"line_number":60,"context_line":"                                 is accessible from"},{"line_number":61,"context_line":"        :param monitor_address: An alternate IP address used for health"},{"line_number":62,"context_line":"                                monitoring a backend member."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fa0af387","line":59,"in_reply_to":"bf51134e_7e5422cb","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class MemberClient(base_client.BaseLBaaSClient):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    root_tag \u003d \u0027member\u0027"},{"line_number":30,"context_line":"    list_root_tag \u003d \u0027members\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_1795ae87","side":"PARENT","line":28,"updated":"2020-07-08 21:27:26.000000000","message":"ditto","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"}],"octavia_tempest_plugin/services/load_balancer/v2/pool_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param listener_id: The ID of the listener for the pool."},{"line_number":40,"context_line":"        :param name: Human-readable name of the resource."},{"line_number":41,"context_line":"        :param description: A human-readable description for the resource."},{"line_number":42,"context_line":"        :param tags: A human-readable tags for the resource."},{"line_number":43,"context_line":"        :param admin_state_up: The administrative state of the resource, which"},{"line_number":44,"context_line":"                               is up (true) or down (false)."},{"line_number":45,"context_line":"        :param session_persistence: A JSON object specifying the session"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_97eede1f","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":59},"updated":"2020-07-08 21:27:26.000000000","message":"s/Human-readable tags of the resource\n\nSame below.  Didn\u0027t check if other occurrences were all the same.","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"octavia_tempest_plugin/tests/api/v2/releasenotes/notes/add-tags-api-tests-1130aab82bb0f7f2.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf51134e_8e7004df","updated":"2020-06-30 17:50:11.000000000","message":"This file is in the wrong place. It must be off the root directory.\nAlso, you probably don\u0027t want to indent this line like this, it will look out of place with the other release notes.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf51134e_9917a552","in_reply_to":"bf51134e_8e7004df","updated":"2020-07-07 11:17:32.000000000","message":"Oops, I didn\u0027t notice the path.\nI indented it to be like the other release notes.\nJust to be sure - I should have put it in octavia-tempest-plugin/releasenotes/notes/add-tags-api-tests-1130aab82bb0f7f2.yaml along with the other notes, right?","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6ca13f4c504a844b4e040e3b5242944cd13defe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf51134e_a6c0332c","in_reply_to":"bf51134e_9917a552","updated":"2020-07-07 15:34:04.000000000","message":"Yep, you got it. You can check, by clicking on the \"release notes\" test job, it will render the new release notes and should include your new note.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"}],"octavia_tempest_plugin/tests/api/v2/test_availability_zone.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Testing that availability_zones do not support tags"},{"line_number":122,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":123,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":124,"context_line":"            availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_de5e0ee5","line":123,"updated":"2020-06-16 18:36:45.000000000","message":"Technically a negative test like this does not need to check the API version as no version should have tags support for AZs.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Testing that availability_zones do not support tags"},{"line_number":122,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":123,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":124,"context_line":"            availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5a5cbf7d","line":123,"in_reply_to":"bf51134e_de5e0ee5","updated":"2020-06-23 07:09:50.000000000","message":"Ok then, I removed it","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":123,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":124,"context_line":"            availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7e0262b6","line":125,"range":{"start_line":125,"start_character":12,"end_line":125,"end_character":43},"updated":"2020-06-16 18:36:45.000000000","message":"Why is this failed_availability_zone_kwargs instead of just availability_zone_kwargs or tags_availability_zone_kwargs?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":123,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":124,"context_line":"            availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5ad15fcd","line":125,"range":{"start_line":125,"start_character":12,"end_line":125,"end_character":43},"in_reply_to":"bf51134e_7e0262b6","updated":"2020-06-23 07:09:50.000000000","message":"I thought to name it with the \"failed\" name because if I am adding to it the tags attribute - it will fail,\nbut I agree with you anyway, on this line I am just copying the other kwargs, so no need to mention the \"failed\" part.\nI changed it to tags_availability_zone_kwargs.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e0936df","line":128,"updated":"2020-06-16 18:36:45.000000000","message":"Does this comment apply?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            failed_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_dafd6f3b","line":128,"in_reply_to":"bf51134e_9e0936df","updated":"2020-06-23 07:09:50.000000000","message":"I tried again and I could indent it, so please ignore that comment","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_be2d1a48","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":21},"updated":"2020-06-16 18:36:45.000000000","message":"This is just the client right? maybe az_client would be more clear for future readers?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            failed_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1a9527e5","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":21},"in_reply_to":"bf51134e_be2d1a48","updated":"2020-06-23 07:09:50.000000000","message":"I totally agree :)\nAnyway I could indent it as I wrote in the upper comment, so I deleted it, thanks","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u0027bba84c0c-2832-4c4c-90ff-d28acfe4ae36\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3ecf4a80","line":130,"range":{"start_line":130,"start_character":30,"end_line":130,"end_character":39},"updated":"2020-06-16 18:36:45.000000000","message":"This seems like the wrong exception.\n[come back to this once the test stack is up]","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u0027bba84c0c-2832-4c4c-90ff-d28acfe4ae36\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3aa46b57","line":130,"range":{"start_line":130,"start_character":30,"end_line":130,"end_character":39},"in_reply_to":"bf51134e_3ecf4a80","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"adcef004318f429a2665eef7a4579c9abfa47878","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u0027bba84c0c-2832-4c4c-90ff-d28acfe4ae36\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b12a6be4","line":130,"range":{"start_line":130,"start_character":30,"end_line":130,"end_character":39},"in_reply_to":"bf51134e_3ecf4a80","updated":"2020-06-16 18:48:57.000000000","message":"Ok, ignore these comments. In testing I see it is a TypeError:\nTypeError: create_availability_zone() got an unexpected keyword argument \u0027tags\u0027\nI just wanted to make sure we didn\u0027t have a bug in returning a not clear error for the user. This looks ok.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                availability_zone_tags"},{"line_number":128,"context_line":"            # The name is too long:"},{"line_number":129,"context_line":"            create_az \u003d self.lb_admin_availability_zone_client"},{"line_number":130,"context_line":"            self.assertRaises(TypeError, create_az.create_availability_zone,"},{"line_number":131,"context_line":"                              **failed_availability_zone_kwargs)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @decorators.idempotent_id(\u0027bba84c0c-2832-4c4c-90ff-d28acfe4ae36\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9a8817c7","line":130,"range":{"start_line":130,"start_character":30,"end_line":130,"end_character":39},"in_reply_to":"bf51134e_b12a6be4","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Testing that availability_zones do not support tags"},{"line_number":122,"context_line":"        availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":123,"context_line":"        tags_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":124,"context_line":"        tags_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":125,"context_line":"            availability_zone_tags"},{"line_number":126,"context_line":"        self.assertRaises("},{"line_number":127,"context_line":"            TypeError,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_4992664d","line":124,"range":{"start_line":124,"start_character":52,"end_line":124,"end_character":54},"updated":"2020-06-30 17:50:11.000000000","message":"The Octavia team does not use \\ line wrapping, please use () instead.\nNote: I have proposed a patch that fixes the hacking rules to check for this.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Testing that availability_zones do not support tags"},{"line_number":122,"context_line":"        availability_zone_tags \u003d [\"Hello\", \"World\"]"},{"line_number":123,"context_line":"        tags_availability_zone_kwargs \u003d availability_zone_kwargs.copy()"},{"line_number":124,"context_line":"        tags_availability_zone_kwargs[const.TAGS] \u003d  \\"},{"line_number":125,"context_line":"            availability_zone_tags"},{"line_number":126,"context_line":"        self.assertRaises("},{"line_number":127,"context_line":"            TypeError,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_243110ee","line":124,"range":{"start_line":124,"start_character":52,"end_line":124,"end_character":54},"in_reply_to":"bf51134e_4992664d","updated":"2020-07-07 11:17:32.000000000","message":"I see that I shouldn\u0027t even have to use the \u0027\\n\u0027 in that case, I could just delete it.\nProbably the auto indentation of VS Code... Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"}],"octavia_tempest_plugin/tests/api/v2/test_availability_zone_profile.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":45,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":46,"context_line":"        if not ("},{"line_number":47,"context_line":"            self.lb_admin_availability_zone_profile_client.is_version_supported("},{"line_number":48,"context_line":"                self.api_version, \u00272.14\u0027)):"},{"line_number":49,"context_line":"            raise self.skipException("},{"line_number":50,"context_line":"                \u0027Availability zone profiles are only available on \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06d83851","line":47,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":45,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":46,"context_line":"        if not ("},{"line_number":47,"context_line":"            self.lb_admin_availability_zone_profile_client.is_version_supported("},{"line_number":48,"context_line":"                self.api_version, \u00272.14\u0027)):"},{"line_number":49,"context_line":"            raise self.skipException("},{"line_number":50,"context_line":"                \u0027Availability zone profiles are only available on \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_54b5bd30","line":47,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Testing that availability_zone_profiles do not support tags"},{"line_number":98,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":99,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":100,"context_line":"            availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":101,"context_line":"            failed_availability_zone_profile_kwargs \u003d \\"},{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7e77023c","line":99,"updated":"2020-06-16 18:36:45.000000000","message":"Same comment here. AZ profiles should not support tags no matter what API version is available.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Testing that availability_zone_profiles do not support tags"},{"line_number":98,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":99,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":100,"context_line":"            availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":101,"context_line":"            failed_availability_zone_profile_kwargs \u003d \\"},{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ba56bb28","line":99,"in_reply_to":"bf51134e_7e77023c","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":99,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":100,"context_line":"            availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":101,"context_line":"            failed_availability_zone_profile_kwargs \u003d \\"},{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"},{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e93f64f","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":51},"updated":"2020-06-16 18:36:45.000000000","message":"Same question about the \"failed\" part here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":99,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":100,"context_line":"            availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":101,"context_line":"            failed_availability_zone_profile_kwargs \u003d \\"},{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"},{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1a31a70c","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":51},"in_reply_to":"bf51134e_9e93f64f","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"},{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3ea2aa9b","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":21},"updated":"2020-06-16 18:36:45.000000000","message":"az_profile_client maybe? There is also an availability_zone_client so this might be confusing.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                availability_zone_profile_kwargs.copy()"},{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fa1e736e","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":21},"in_reply_to":"bf51134e_3ea2aa9b","updated":"2020-06-23 07:09:50.000000000","message":"I agree, I changed it","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7eac228c","line":106,"range":{"start_line":106,"start_character":30,"end_line":106,"end_character":39},"updated":"2020-06-16 18:36:45.000000000","message":"Same question about this exception","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3a190b85","line":106,"range":{"start_line":106,"start_character":30,"end_line":106,"end_character":39},"in_reply_to":"bf51134e_313e5b29","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5a14bf4e","line":106,"range":{"start_line":106,"start_character":30,"end_line":106,"end_character":39},"in_reply_to":"bf51134e_7eac228c","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"adcef004318f429a2665eef7a4579c9abfa47878","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            failed_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":104,"context_line":"                availability_zone_profile_tags"},{"line_number":105,"context_line":"            az_client \u003d self.lb_admin_availability_zone_profile_client"},{"line_number":106,"context_line":"            self.assertRaises(TypeError,"},{"line_number":107,"context_line":"                              az_client.create_availability_zone_profile,"},{"line_number":108,"context_line":"                              **failed_availability_zone_profile_kwargs)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_313e5b29","line":106,"range":{"start_line":106,"start_character":30,"end_line":106,"end_character":39},"in_reply_to":"bf51134e_7eac228c","updated":"2020-06-16 18:48:57.000000000","message":"Ignore this comment","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Testing that availability_zone_profiles do not support tags"},{"line_number":98,"context_line":"        availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":99,"context_line":"        tags_availability_zone_profile_kwargs \u003d \\"},{"line_number":100,"context_line":"            availability_zone_profile_kwargs.copy()"},{"line_number":101,"context_line":"        tags_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":102,"context_line":"            availability_zone_profile_tags"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e9f7fa8b","line":99,"updated":"2020-06-30 17:50:11.000000000","message":"Please use () instead of \\ for line wrapping.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Testing that availability_zone_profiles do not support tags"},{"line_number":98,"context_line":"        availability_zone_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":99,"context_line":"        tags_availability_zone_profile_kwargs \u003d \\"},{"line_number":100,"context_line":"            availability_zone_profile_kwargs.copy()"},{"line_number":101,"context_line":"        tags_availability_zone_profile_kwargs[const.TAGS] \u003d \\"},{"line_number":102,"context_line":"            availability_zone_profile_tags"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a0b6a5db","line":99,"in_reply_to":"bf51134e_e9f7fa8b","updated":"2020-07-07 11:17:32.000000000","message":"It was probably the auto indentation of VS Code... Done.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":46,"context_line":"        if not ("},{"line_number":47,"context_line":"           self.lb_admin_availability_zone_profile_client.is_version_supported("},{"line_number":48,"context_line":"                self.api_version, \u00272.14\u0027)):"},{"line_number":49,"context_line":"            raise self.skipException("},{"line_number":50,"context_line":"                \u0027Availability zone profiles are only available on \u0027"},{"line_number":51,"context_line":"                \u0027Octavia API version 2.14 or newer.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_37c6f29b","line":48,"updated":"2020-07-08 21:27:26.000000000","message":"If nothing changed here I would just leave unrelated code as-is.","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            self.lb_admin_availability_zone_profile_client"},{"line_number":231,"context_line":"                .list_availability_zone_profiles("},{"line_number":232,"context_line":"                    query_params\u003d\u0027{sort}\u003d{name}:{order}\u0027.format("},{"line_number":233,"context_line":"                        sort\u003dconst.SORT, name\u003dconst.NAME, order\u003dconst.DESC)))"},{"line_number":234,"context_line":"        # Remove availability zone profiles not used in this test"},{"line_number":235,"context_line":"        profiles \u003d ["},{"line_number":236,"context_line":"            prof for prof in profiles"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_17c3ee8a","line":233,"updated":"2020-07-08 21:27:26.000000000","message":"Same comment as above (and below)","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"octavia_tempest_plugin/tests/api/v2/test_flavor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Test that flavors do not support tags"},{"line_number":109,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":110,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9ebc96bc","line":110,"updated":"2020-06-16 18:36:45.000000000","message":"Same here, flavors should not have tags no matter the API version.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Test that flavors do not support tags"},{"line_number":109,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":110,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_350e3c34","line":110,"in_reply_to":"bf51134e_9ebc96bc","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":110,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_deebaead","line":112,"range":{"start_line":112,"start_character":12,"end_line":112,"end_character":19},"updated":"2020-06-16 18:36:45.000000000","message":"Same question about the \"failed\" prefix.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":110,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9512a857","line":112,"range":{"start_line":112,"start_character":12,"end_line":112,"end_character":19},"in_reply_to":"bf51134e_deebaead","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"},{"line_number":116,"context_line":"                              **failed_flavor_kwargs)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3ed0eaf7","line":114,"range":{"start_line":114,"start_character":30,"end_line":114,"end_character":39},"updated":"2020-06-16 18:36:45.000000000","message":"Is this the right exception?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"},{"line_number":116,"context_line":"                              **failed_flavor_kwargs)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_750f142e","line":114,"range":{"start_line":114,"start_character":30,"end_line":114,"end_character":39},"in_reply_to":"bf51134e_3ed0eaf7","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"adcef004318f429a2665eef7a4579c9abfa47878","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"},{"line_number":116,"context_line":"                              **failed_flavor_kwargs)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7148d3cb","line":114,"range":{"start_line":114,"start_character":30,"end_line":114,"end_character":39},"in_reply_to":"bf51134e_3ed0eaf7","updated":"2020-06-16 18:48:57.000000000","message":"Ignore this comment.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            flavor_tags \u003d [\"Hello\", \"World\"]"},{"line_number":112,"context_line":"            failed_flavor_kwargs \u003d flavor_kwargs.copy()"},{"line_number":113,"context_line":"            failed_flavor_kwargs[const.TAGS] \u003d flavor_tags"},{"line_number":114,"context_line":"            self.assertRaises(TypeError,"},{"line_number":115,"context_line":"                              self.lb_admin_flavor_client.create_flavor,"},{"line_number":116,"context_line":"                              **failed_flavor_kwargs)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d51c206c","line":114,"range":{"start_line":114,"start_character":30,"end_line":114,"end_character":39},"in_reply_to":"bf51134e_7148d3cb","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"}],"octavia_tempest_plugin/tests/api/v2/test_flavor_profile.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":39,"context_line":"          create flavor profiles."},{"line_number":40,"context_line":"        * Create a fully populated flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1ecd265d","side":"PARENT","line":37,"updated":"2020-06-16 18:36:45.000000000","message":"This blank line should return. This can cause docs job failures.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2c48553a2cd7065e646455ab6174658107583caa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":39,"context_line":"          create flavor profiles."},{"line_number":40,"context_line":"        * Create a fully populated flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bf9d7b67","side":"PARENT","line":37,"in_reply_to":"bf51134e_1505f8c2","updated":"2020-06-24 22:44:27.000000000","message":"Yes, that was my comment. You fixed it as pep8 also complained.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":39,"context_line":"          create flavor profiles."},{"line_number":40,"context_line":"        * Create a fully populated flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1505f8c2","side":"PARENT","line":37,"in_reply_to":"bf51134e_1ecd265d","updated":"2020-06-23 07:09:50.000000000","message":"I didn\u0027t understand, can you explain it again please?\nI just saw that I should leave an empty line (without spaces) between the first line of the docstring and the rest of it, is that it?","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @decorators.idempotent_id(\u0027c4e17fdf-849a-4132-93ae-dfca21ce4444\u0027)"},{"line_number":84,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":85,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        * Create three flavor profiles."},{"line_number":88,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":89,"context_line":"        * List the flavor profiles using the default sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7eda6217","side":"PARENT","line":86,"updated":"2020-06-16 18:36:45.000000000","message":"Same, this should go back.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    @decorators.idempotent_id(\u0027a2c2ff9a-fce1-42fd-8cfd-56dea31610f6\u0027)"},{"line_number":255,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":256,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        * Create a fully populated flavor profile."},{"line_number":259,"context_line":"        * Show flavor profile details."},{"line_number":260,"context_line":"        * Validate the show reflects the requested values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5ed79eee","side":"PARENT","line":257,"updated":"2020-06-16 18:36:45.000000000","message":"Same, this should go back.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    @decorators.idempotent_id(\u002732a2e285-8dfc-485f-a450-a4d450d3c3ec\u0027)"},{"line_number":306,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":307,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        * Create a fully populated flavor profile."},{"line_number":310,"context_line":"        * Show flavor profile details."},{"line_number":311,"context_line":"        * Validate the show reflects the initial values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_be051a7d","side":"PARENT","line":308,"updated":"2020-06-16 18:36:45.000000000","message":"Same, this should go back.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    @decorators.idempotent_id(\u00274c2eaacf-c2c8-422a-b7dc-a30ceba6bcd4\u0027)"},{"line_number":387,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":388,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        * Creates a flavor profile."},{"line_number":391,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":392,"context_line":"        * Deletes the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e0ad687","side":"PARENT","line":389,"updated":"2020-06-16 18:36:45.000000000","message":"Same, this should go back.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a6e6ac15","line":36,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f47df16e","line":36,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_86e3a805","line":37,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @decorators.idempotent_id(\u0027d0e3a08e-d58a-4460-83ed-34307ca04cde\u0027)"},{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d4826d4f","line":37,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_34976993","line":38,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def test_flavor_profile_create(self):"},{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e6f0a4cc","line":38,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1494e58a","line":39,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"\"\"Tests flavor profile create and basic show APIs."},{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c6eda0f0","line":39,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":43,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_26bc5cdb","line":40,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        * Tests that users without the loadbalancer admin role cannot"},{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":43,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7491e199","line":40,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":43,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":44,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06c15855","line":41,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          create flavor profiles."},{"line_number":39,"context_line":"        * Create a fully populated flavor profile."},{"line_number":40,"context_line":"        * Validate the response reflects the requested values."},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":43,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":44,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_548e5d78","line":41,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Testing that flavor_profiles do not support tags"},{"line_number":83,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":84,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":85,"context_line":"            flavor_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_feff9264","line":84,"updated":"2020-06-16 18:36:45.000000000","message":"Same, version does not matter here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Testing that flavor_profiles do not support tags"},{"line_number":83,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":84,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":85,"context_line":"            flavor_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_35147cf5","line":84,"in_reply_to":"bf51134e_feff9264","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":84,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":85,"context_line":"            flavor_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_de044e7e","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":18},"updated":"2020-06-16 18:36:45.000000000","message":"Same question about the \"failed\" prefix.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":84,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":85,"context_line":"            flavor_profile_tags \u003d [\"Hello\", \"World\"]"},{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_95f8e8c4","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":18},"in_reply_to":"bf51134e_de044e7e","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"},{"line_number":90,"context_line":"                self.lb_admin_flavor_profile_client.create_flavor_profile,"},{"line_number":91,"context_line":"                **failed_flavor_profile_kwargs)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3ef90a80","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"updated":"2020-06-16 18:36:45.000000000","message":"Is this the right exception?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"},{"line_number":90,"context_line":"                self.lb_admin_flavor_profile_client.create_flavor_profile,"},{"line_number":91,"context_line":"                **failed_flavor_profile_kwargs)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_75f554cb","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"in_reply_to":"bf51134e_3ef90a80","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"adcef004318f429a2665eef7a4579c9abfa47878","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"},{"line_number":90,"context_line":"                self.lb_admin_flavor_profile_client.create_flavor_profile,"},{"line_number":91,"context_line":"                **failed_flavor_profile_kwargs)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b1138bb8","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"in_reply_to":"bf51134e_3ef90a80","updated":"2020-06-16 18:48:57.000000000","message":"Ignore this comment.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            failed_flavor_profile_kwargs \u003d flavor_profile_kwargs.copy()"},{"line_number":87,"context_line":"            failed_flavor_profile_kwargs[const.TAGS] \u003d flavor_profile_tags"},{"line_number":88,"context_line":"            self.assertRaises("},{"line_number":89,"context_line":"                TypeError,"},{"line_number":90,"context_line":"                self.lb_admin_flavor_profile_client.create_flavor_profile,"},{"line_number":91,"context_line":"                **failed_flavor_profile_kwargs)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d50260b4","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"in_reply_to":"bf51134e_b1138bb8","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027c4e17fdf-849a-4132-93ae-dfca21ce4444\u0027)"},{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_66b654fd","line":95,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027c4e17fdf-849a-4132-93ae-dfca21ce4444\u0027)"},{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b4e89916","line":95,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027c4e17fdf-849a-4132-93ae-dfca21ce4444\u0027)"},{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_46bb50e1","line":96,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    @decorators.idempotent_id(\u0027c4e17fdf-849a-4132-93ae-dfca21ce4444\u0027)"},{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_94ed9527","line":96,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a6cfcc7d","line":97,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_flavor_profile_list(self):"},{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f4f21106","line":97,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_86cc488a","line":98,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\"Tests flavor profile list API and field filtering."},{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d4f70df5","line":98,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_34dc8973","line":99,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        * Create three flavor profiles."},{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e6c9c478","line":99,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_14d98582","line":100,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        * Validates that non-admin accounts cannot list the flavor profiles."},{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c6c64068","line":100,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_26a1fcaa","line":101,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        * List the flavor profiles using the default sort order."},{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_74e60147","line":101,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06a678c2","line":102,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        * List the flavor profiles using descending sort order."},{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_54e3fd33","line":102,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_66abf488","line":103,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        * List the flavor profiles using ascending sort order."},{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b4d1b95a","line":103,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":107,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_46b070f5","line":104,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        * List the flavor profiles returning one field at a time."},{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":107,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_94d6354f","line":104,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":107,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":108,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a694ec45","line":105,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        * List the flavor profiles returning two fields."},{"line_number":103,"context_line":"        * List the flavor profiles filtering to one of the three."},{"line_number":104,"context_line":"        * List the flavor profiles filtered, one field, and sorted."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":107,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":108,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f4cb31a2","line":105,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027a2c2ff9a-fce1-42fd-8cfd-56dea31610f6\u0027)"},{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8691e855","line":265,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027a2c2ff9a-fce1-42fd-8cfd-56dea31610f6\u0027)"},{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d4d0ad53","line":265,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027a2c2ff9a-fce1-42fd-8cfd-56dea31610f6\u0027)"},{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_34c5a98f","line":266,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027a2c2ff9a-fce1-42fd-8cfd-56dea31610f6\u0027)"},{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e69ee461","line":266,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_14c22586","line":267,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def test_flavor_profile_show(self):"},{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c69be06f","line":267,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_268a9c1a","line":268,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        \"\"\"Tests flavor profile show API."},{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_74bf21fb","line":268,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":272,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_068f982a","line":269,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        * Create a fully populated flavor profile."},{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":272,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_54bc9d04","line":269,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":272,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":273,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6684940d","line":270,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        * Show flavor profile details."},{"line_number":268,"context_line":"        * Validate the show reflects the requested values."},{"line_number":269,"context_line":"        * Validates that non-lb-admin accounts cannot see the flavor profile."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":272,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":273,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b436d9b3","line":270,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    @decorators.idempotent_id(\u002732a2e285-8dfc-485f-a450-a4d450d3c3ec\u0027)"},{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_46899021","line":315,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    @decorators.idempotent_id(\u002732a2e285-8dfc-485f-a450-a4d450d3c3ec\u0027)"},{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_943bd59a","line":315,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    @decorators.idempotent_id(\u002732a2e285-8dfc-485f-a450-a4d450d3c3ec\u0027)"},{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a67d0c1e","line":316,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    @decorators.idempotent_id(\u002732a2e285-8dfc-485f-a450-a4d450d3c3ec\u0027)"},{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f440510a","line":316,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_867a8821","line":317,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    def test_flavor_profile_update(self):"},{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d4454d19","line":317,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_344ac926","line":318,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        \"\"\"Tests flavor profile update API."},{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e677043a","line":318,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1447c51f","line":319,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        * Create a fully populated flavor profile."},{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c6748038","line":319,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_268f3c24","line":320,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        * Show flavor profile details."},{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_745441cb","line":320,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0694b836","line":321,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        * Validate the show reflects the initial values."},{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_54513dd8","line":321,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6699346d","line":322,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        * Validates that non-admin accounts cannot update the flavor profile."},{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b45ff9e3","line":322,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":326,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_469eb056","line":323,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        * Update the flavor profile details."},{"line_number":321,"context_line":"        * Show flavor profile details."},{"line_number":322,"context_line":"        * Validate the show reflects the updated values."},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":326,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_946475bb","line":323,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @decorators.idempotent_id(\u00274c2eaacf-c2c8-422a-b7dc-a30ceba6bcd4\u0027)"},{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a6a22c99","line":395,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @decorators.idempotent_id(\u00274c2eaacf-c2c8-422a-b7dc-a30ceba6bcd4\u0027)"},{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f45971fe","line":395,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    @decorators.idempotent_id(\u00274c2eaacf-c2c8-422a-b7dc-a30ceba6bcd4\u0027)"},{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_869f284f","line":396,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    @decorators.idempotent_id(\u00274c2eaacf-c2c8-422a-b7dc-a30ceba6bcd4\u0027)"},{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d45eede4","line":396,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3473e982","line":397,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    def test_flavor_profile_delete(self):"},{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e6ac248e","line":397,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_14706572","line":398,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        \"\"\"Tests flavor profile create and delete APIs."},{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c6a9207c","line":398,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":402,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_26b8dcc6","line":399,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        * Creates a flavor profile."},{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":402,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_746d6197","line":399,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":402,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":403,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06bdd8b6","line":400,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        * Validates that other accounts cannot delete the flavor profile."},{"line_number":398,"context_line":"        * Deletes the flavor profile."},{"line_number":399,"context_line":"        * Validates the flavor profile is in the DELETED state."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        # We have to do this here as the api_version and clients are not"},{"line_number":402,"context_line":"        # setup in time to use a decorator or the skip_checks mixin"},{"line_number":403,"context_line":"        if not self.lb_admin_flavor_profile_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_546add7f","line":400,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"}],"octavia_tempest_plugin/tests/api/v2/test_healthmonitor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # Test tags"},{"line_number":161,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":162,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":163,"context_line":"            self.assertEqual(hm_kwargs[const.TAGS], hw_tags)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Helper functions for test healthmonitor list"},{"line_number":166,"context_line":"    def _filter_hms_by_pool_id(self, hms, pool_ids):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fe9e7205","line":163,"updated":"2020-06-16 18:36:45.000000000","message":"Two things here:\nOne, when using assertEqual, the reference (expected) value should always come first in the list. So it should read \"self.assertEqual(hw_tags, ...)\"\nThis makes the error message more readable to understand the expected value vs. the returned value.\n\nSecond, this is testing that the tags are in the hm_kwargs list, which is what you set and passed into the create method. You want to test the values in the \"hm\" object returned by the status GET call to validate they are present in the response.\nSo, corrected it would read:\nself.assertEqual(hw_tags, hm[const.TAGS])","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # Test tags"},{"line_number":161,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":162,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":163,"context_line":"            self.assertEqual(hm_kwargs[const.TAGS], hw_tags)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Helper functions for test healthmonitor list"},{"line_number":166,"context_line":"    def _filter_hms_by_pool_id(self, hms, pool_ids):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d59ee061","line":163,"in_reply_to":"bf51134e_fe9e7205","updated":"2020-06-23 07:09:50.000000000","message":"Ok, thanks for the information!\nDone","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return [hm for i, hm in enumerate(hms) if i not in indexes]"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027c9a9f20c-3680-4ae8-b657-33c687258fea\u0027)"},{"line_number":174,"context_line":"    def test_healthmonitor_list(self):"},{"line_number":175,"context_line":"        \"\"\"Tests healthmonitor list API and field filtering."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        * Create three clean pools to use for the healthmonitors."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e7db6e9","line":174,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return [hm for i, hm in enumerate(hms) if i not in indexes]"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u0027c9a9f20c-3680-4ae8-b657-33c687258fea\u0027)"},{"line_number":174,"context_line":"    def test_healthmonitor_list(self):"},{"line_number":175,"context_line":"        \"\"\"Tests healthmonitor list API and field filtering."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        * Create three clean pools to use for the healthmonitors."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_60dd9441","line":174,"in_reply_to":"bf51134e_9e7db6e9","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        # Test tags"},{"line_number":669,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":670,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":671,"context_line":"            self.assertEqual(hm_kwargs[const.TAGS], hw_tags)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        # Test that a user, without the loadbalancer member role, cannot"},{"line_number":674,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bebd1a6a","line":671,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and hm_kwargs-\u003ehm issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        # Test tags"},{"line_number":669,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":670,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":671,"context_line":"            self.assertEqual(hm_kwargs[const.TAGS], hw_tags)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        # Test that a user, without the loadbalancer member role, cannot"},{"line_number":674,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b5c24c32","line":671,"in_reply_to":"bf51134e_bebd1a6a","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        # Test tags"},{"line_number":760,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":761,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":762,"context_line":"            self.assertEqual(hm_update_kwargs[const.TAGS], hw_new_tags)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @decorators.idempotent_id(\u0027a7bab4ac-340c-4776-ab9d-9fcb66869432\u0027)"},{"line_number":765,"context_line":"    def test_healthmonitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9ec2d6e8","line":762,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and hm_kwargs-\u003ehm issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        # Test tags"},{"line_number":760,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":761,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":762,"context_line":"            self.assertEqual(hm_update_kwargs[const.TAGS], hw_new_tags)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @decorators.idempotent_id(\u0027a7bab4ac-340c-4776-ab9d-9fcb66869432\u0027)"},{"line_number":765,"context_line":"    def test_healthmonitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d5c5403e","line":762,"in_reply_to":"bf51134e_9ec2d6e8","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # Test tags"},{"line_number":161,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":162,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":163,"context_line":"            self.assertEqual(hw_tags, hm_kwargs[const.TAGS])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Helper functions for test healthmonitor list"},{"line_number":166,"context_line":"    def _filter_hms_by_pool_id(self, hms, pool_ids):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c9395640","line":163,"range":{"start_line":163,"start_character":38,"end_line":163,"end_character":47},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, hm here instead of hm_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # Test tags"},{"line_number":161,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":162,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":163,"context_line":"            self.assertEqual(hw_tags, hm_kwargs[const.TAGS])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Helper functions for test healthmonitor list"},{"line_number":166,"context_line":"    def _filter_hms_by_pool_id(self, hms, pool_ids):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_00c79147","line":163,"range":{"start_line":163,"start_character":38,"end_line":163,"end_character":47},"in_reply_to":"bf51134e_c9395640","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        # Test tags"},{"line_number":707,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":708,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":709,"context_line":"            self.assertEqual(hw_tags, hm_kwargs[const.TAGS])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        # Test that a user, without the loadbalancer member role, cannot"},{"line_number":712,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_6912cab6","line":709,"range":{"start_line":709,"start_character":38,"end_line":709,"end_character":47},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, hm here instead of hm_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        # Test tags"},{"line_number":707,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":708,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":709,"context_line":"            self.assertEqual(hw_tags, hm_kwargs[const.TAGS])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        # Test that a user, without the loadbalancer member role, cannot"},{"line_number":712,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_60c48d41","line":709,"range":{"start_line":709,"start_character":38,"end_line":709,"end_character":47},"in_reply_to":"bf51134e_6912cab6","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        # Test tags"},{"line_number":798,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":799,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":800,"context_line":"            self.assertEqual(hw_new_tags, hm_update_kwargs[const.TAGS])"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    @decorators.idempotent_id(\u0027a7bab4ac-340c-4776-ab9d-9fcb66869432\u0027)"},{"line_number":803,"context_line":"    def test_healthmonitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a90ce294","line":800,"range":{"start_line":800,"start_character":42,"end_line":800,"end_character":58},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, hm here instead of hm_update_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        # Test tags"},{"line_number":798,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":799,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":800,"context_line":"            self.assertEqual(hw_new_tags, hm_update_kwargs[const.TAGS])"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    @decorators.idempotent_id(\u0027a7bab4ac-340c-4776-ab9d-9fcb66869432\u0027)"},{"line_number":803,"context_line":"    def test_healthmonitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_40c1892e","line":800,"range":{"start_line":800,"start_character":42,"end_line":800,"end_character":58},"in_reply_to":"bf51134e_a90ce294","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        * Validate the show reflects the requested values."},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        pool_name \u003d data_utils.rand_name(\"lb_member_pool1_hm-create\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        pool_kwargs \u003d {"},{"line_number":79,"context_line":"            const.NAME: pool_name,"},{"line_number":80,"context_line":"            const.PROTOCOL: const.HTTP,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_973c1e94","line":77,"updated":"2020-07-08 21:27:26.000000000","message":"Random whitespace change","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        hms \u003d self.mem_healthmonitor_client.list_healthmonitors("},{"line_number":403,"context_line":"            query_params\u003d\u0027{sort}\u003d{url_path}:{desc}\u0027"},{"line_number":404,"context_line":"            .format(sort\u003dconst.SORT,"},{"line_number":405,"context_line":"                    url_path\u003dconst.URL_PATH, desc\u003dconst.DESC))"},{"line_number":406,"context_line":"        hms \u003d self._filter_hms_by_pool_id(hms, (pool1_id, pool2_id, pool3_id))"},{"line_number":407,"context_line":"        self.assertEqual(hm1[const.URL_PATH],"},{"line_number":408,"context_line":"                         hms[1][const.URL_PATH])"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_374b922b","line":405,"updated":"2020-07-08 21:27:26.000000000","message":"Doesn\u0027t look like the code changed, would just leave alone","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8ee2b1b09a3bbec47d368cedc1f4d17e730a6c0b","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                test_list, [hm1[const.NAME], hm3[const.NAME]])"},{"line_number":501,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":502,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":503,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":504,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_b1cdb931","line":503,"range":{"start_line":503,"start_character":37,"end_line":503,"end_character":59},"updated":"2020-07-13 15:07:43.000000000","message":"I don\u0027t get this, is \".*\" supposed to be a regexp?","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c261150c1c3d0ab257e49524831b73e379d5c6e9","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                test_list, [hm1[const.NAME], hm3[const.NAME]])"},{"line_number":501,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":502,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":503,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":504,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_0d627eae","line":503,"range":{"start_line":503,"start_character":37,"end_line":503,"end_character":59},"in_reply_to":"bf51134e_b1cdb931","updated":"2020-07-14 11:01:28.000000000","message":"Exactly. And it should return an empty list of entities with tags (instead of all of them). The test makes sure tags do not support regex.","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8ee2b1b09a3bbec47d368cedc1f4d17e730a6c0b","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":492,"context_line":"            list_of_hms \u003d [hm1, hm2, hm3]"},{"line_number":493,"context_line":"            test_list \u003d []"},{"line_number":494,"context_line":"            for hm in list_of_hms:"},{"line_number":495,"context_line":"                if \"English\" in hm[const.TAGS] and \"Creativity\" in ("},{"line_number":496,"context_line":"                    hm[const.TAGS]) and \"Spanish\" not in ("},{"line_number":497,"context_line":"                        hm[const.TAGS]):"},{"line_number":498,"context_line":"                    test_list.append(hm[const.NAME])"},{"line_number":499,"context_line":"            self.assertEqual("},{"line_number":500,"context_line":"                test_list, [hm1[const.NAME], hm3[const.NAME]])"},{"line_number":501,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":502,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":503,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":504,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"},{"line_number":507,"context_line":"    def test_healthmonitor_show(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_f1273111","line":504,"range":{"start_line":494,"start_character":12,"end_line":504,"end_character":61},"updated":"2020-07-13 15:07:43.000000000","message":"Could you add comments here about what you are doing here? (i.e what are you building in test_list, why should [\"\" in hm.... for hm in list_of_hms] be empty...)\nIt would be also helpful to duplicate the comments in the other files that are using this block.","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c261150c1c3d0ab257e49524831b73e379d5c6e9","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":492,"context_line":"            list_of_hms \u003d [hm1, hm2, hm3]"},{"line_number":493,"context_line":"            test_list \u003d []"},{"line_number":494,"context_line":"            for hm in list_of_hms:"},{"line_number":495,"context_line":"                if \"English\" in hm[const.TAGS] and \"Creativity\" in ("},{"line_number":496,"context_line":"                    hm[const.TAGS]) and \"Spanish\" not in ("},{"line_number":497,"context_line":"                        hm[const.TAGS]):"},{"line_number":498,"context_line":"                    test_list.append(hm[const.NAME])"},{"line_number":499,"context_line":"            self.assertEqual("},{"line_number":500,"context_line":"                test_list, [hm1[const.NAME], hm3[const.NAME]])"},{"line_number":501,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":502,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":503,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":504,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"},{"line_number":507,"context_line":"    def test_healthmonitor_show(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_6d705a73","line":504,"range":{"start_line":494,"start_character":12,"end_line":504,"end_character":61},"in_reply_to":"bf51134e_f1273111","updated":"2020-07-14 11:01:28.000000000","message":"Yes, I will, thanks!","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3385bd8ca193041385cf812c6ea4a6a5675442d8","unresolved":false,"context_lines":[{"line_number":509,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":510,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"            # Tests that filtering with regex is not supported"},{"line_number":513,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":514,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"},{"line_number":517,"context_line":"    def test_healthmonitor_show(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_5d141244","line":514,"range":{"start_line":512,"start_character":12,"end_line":514,"end_character":61},"updated":"2020-07-15 07:52:24.000000000","message":"so I think that part is not really helpful, it doesn\u0027t test Octavia API, it only verifies that the \u0027in\u0027 operator doesn\u0027t support mixing regexes with python strings.","commit_id":"e47f80818517576d33aeb3179070b04d6c30d51d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bab91b1d027558fdc44fb812d5ffa0beddcd0629","unresolved":false,"context_lines":[{"line_number":509,"context_line":"            self.assertTrue(not any([\"\" in hm[const.TAGS]"},{"line_number":510,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"            # Tests that filtering with regex is not supported"},{"line_number":513,"context_line":"            self.assertTrue(not any([\".*\" in hm[const.TAGS]"},{"line_number":514,"context_line":"                                     for hm in list_of_hms]))"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    @decorators.idempotent_id(\u0027284e8d3b-7b2d-4697-9e41-580b3423c0b4\u0027)"},{"line_number":517,"context_line":"    def test_healthmonitor_show(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_87073bca","line":514,"range":{"start_line":512,"start_character":12,"end_line":514,"end_character":61},"in_reply_to":"bf51134e_5d141244","updated":"2020-07-19 09:34:10.000000000","message":"I looked at it again and I agree, I will remove those parts from the tests.","commit_id":"e47f80818517576d33aeb3179070b04d6c30d51d"}],"octavia_tempest_plugin/tests/api/v2/test_l7policy.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # Test tags"},{"line_number":216,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":217,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":218,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1eaec62d","line":218,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and l7policy_kwargs-\u003el7policy issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # Test tags"},{"line_number":216,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":217,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":218,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_00c13855","line":218,"in_reply_to":"bf51134e_1eaec62d","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"},{"line_number":222,"context_line":"        \"\"\"Tests l7policy list API and field filtering."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        * Create a clean listener."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e35b6fa","line":221,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"},{"line_number":222,"context_line":"        \"\"\"Tests l7policy list API and field filtering."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        * Create a clean listener."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_40bb30e1","line":221,"in_reply_to":"bf51134e_9e35b6fa","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":693,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":694,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        # Test that a user, without the load balancer member role, cannot"},{"line_number":697,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9e677626","line":694,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and l7policy_kwargs-\u003el7policy issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":693,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":694,"context_line":"            self.assertEqual(l7policy_kwargs[const.TAGS], l7_policy_tags)"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        # Test that a user, without the load balancer member role, cannot"},{"line_number":697,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c0746038","line":694,"in_reply_to":"bf51134e_9e677626","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        # Test tags"},{"line_number":786,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":787,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":788,"context_line":"            self.assertEqual(l7policy_update_kwargs[const.TAGS],"},{"line_number":789,"context_line":"                             l7_policy_new_tags)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    @decorators.idempotent_id(\u00277925eb4b-94b6-4c28-98c2-fd0b4f0976cc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_de71eee2","line":788,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and l7policy_update_kwargs-\u003el7policy issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        # Test tags"},{"line_number":786,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":787,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":788,"context_line":"            self.assertEqual(l7policy_update_kwargs[const.TAGS],"},{"line_number":789,"context_line":"                             l7_policy_new_tags)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    @decorators.idempotent_id(\u00277925eb4b-94b6-4c28-98c2-fd0b4f0976cc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_00bdb8b6","line":788,"in_reply_to":"bf51134e_de71eee2","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # Test tags"},{"line_number":216,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":217,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":218,"context_line":"            self.assertEqual(l7_policy_tags, l7policy_kwargs[const.TAGS])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e9253a0c","line":218,"range":{"start_line":218,"start_character":45,"end_line":218,"end_character":60},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, l7policy here instead of l7policy_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # Test tags"},{"line_number":216,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":217,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":218,"context_line":"            self.assertEqual(l7_policy_tags, l7policy_kwargs[const.TAGS])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u002742fa14ba-caf1-465e-ab36-27e7501f95ef\u0027)"},{"line_number":221,"context_line":"    def test_l7policy_list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_80e0c1ce","line":218,"range":{"start_line":218,"start_character":45,"end_line":218,"end_character":60},"in_reply_to":"bf51134e_e9253a0c","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":731,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":732,"context_line":"            self.assertEqual(l7_policy_tags, l7policy_kwargs[const.TAGS])"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        # Test that a user, without the load balancer member role, cannot"},{"line_number":735,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c922f601","line":732,"range":{"start_line":732,"start_character":45,"end_line":732,"end_character":61},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, l7policy here instead of l7policy_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":731,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":732,"context_line":"            self.assertEqual(l7_policy_tags, l7policy_kwargs[const.TAGS])"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        # Test that a user, without the load balancer member role, cannot"},{"line_number":735,"context_line":"        # use this command"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c0eab9aa","line":732,"range":{"start_line":732,"start_character":45,"end_line":732,"end_character":61},"in_reply_to":"bf51134e_c922f601","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":825,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":826,"context_line":"            self.assertEqual(l7_policy_new_tags,"},{"line_number":827,"context_line":"                             l7policy_update_kwargs[const.TAGS])"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    @decorators.idempotent_id(\u00277925eb4b-94b6-4c28-98c2-fd0b4f0976cc\u0027)"},{"line_number":830,"context_line":"    def test_l7policy_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_2920d2f7","line":827,"range":{"start_line":827,"start_character":29,"end_line":827,"end_character":51},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, l7policy here instead of l7policy_update_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":825,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":826,"context_line":"            self.assertEqual(l7_policy_new_tags,"},{"line_number":827,"context_line":"                             l7policy_update_kwargs[const.TAGS])"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    @decorators.idempotent_id(\u00277925eb4b-94b6-4c28-98c2-fd0b4f0976cc\u0027)"},{"line_number":830,"context_line":"    def test_l7policy_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_20cf3558","line":827,"range":{"start_line":827,"start_character":29,"end_line":827,"end_character":51},"in_reply_to":"bf51134e_2920d2f7","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        l7policy_name \u003d data_utils.rand_name(\"lb_member_l7policy1-create\")"},{"line_number":129,"context_line":"        l7policy_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        l7policy_kwargs \u003d {"},{"line_number":132,"context_line":"            const.LISTENER_ID: self.listener_id,"},{"line_number":133,"context_line":"            const.NAME: l7policy_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_77518ad9","line":130,"updated":"2020-07-08 21:27:26.000000000","message":"Random whitespace change","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        l7policies \u003d self.mem_l7policy_client.list_l7policies("},{"line_number":400,"context_line":"            query_params\u003d\u0027listener_id\u003d{listener_id}\u0026{sort}\u003d{descr}:{desc}\u0027"},{"line_number":401,"context_line":"            .format(listener_id\u003dlistener_id, sort\u003dconst.SORT,"},{"line_number":402,"context_line":"                    descr\u003dconst.DESCRIPTION, desc\u003dconst.DESC))"},{"line_number":403,"context_line":"        self.assertEqual(l7policy1[const.DESCRIPTION],"},{"line_number":404,"context_line":"                         l7policies[1][const.DESCRIPTION])"},{"line_number":405,"context_line":"        self.assertEqual(l7policy2[const.DESCRIPTION],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_b76042a7","line":402,"updated":"2020-07-08 21:27:26.000000000","message":"Same comment about unrelated code","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            self.assertTrue(not any([\".*\" in l7policy[const.TAGS]"},{"line_number":527,"context_line":"                                     for l7policy in list_of_l7policies]))"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    @ decorators.idempotent_id(\u0027baaa8104-a037-4976-b908-82a0b3e08129\u0027)"},{"line_number":530,"context_line":"    def test_l7policy_show(self):"},{"line_number":531,"context_line":"        \"\"\"Tests l7policy show API."},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_b705e2c4","line":529,"updated":"2020-07-08 21:27:26.000000000","message":"Surprised that space didn\u0027t cause a failure","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                self.os_primary.l7policy_client.show_l7policy,"},{"line_number":637,"context_line":"                l7policy[const.ID])"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    @ decorators.idempotent_id(\u002708f73b22-550b-4e5a-b3d6-2ec03251ca13\u0027)"},{"line_number":640,"context_line":"    def test_l7policy_update(self):"},{"line_number":641,"context_line":"        \"\"\"Tests l7policy update and show APIs."},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_37743268","line":639,"updated":"2020-07-08 21:27:26.000000000","message":"ditto","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":657,"context_line":"            const.PROTOCOL_PORT: \u002781\u0027,"},{"line_number":658,"context_line":"            const.LOADBALANCER_ID: self.lb_id,"},{"line_number":659,"context_line":"        }"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        listener \u003d self.mem_listener_client.create_listener(**listener_kwargs)"},{"line_number":662,"context_line":"        listener_id \u003d listener[const.ID]"},{"line_number":663,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_17712e77","line":660,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":826,"context_line":"            self.assertEqual(l7_policy_new_tags,"},{"line_number":827,"context_line":"                             l7policy[const.TAGS])"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    @ decorators.idempotent_id(\u00277925eb4b-94b6-4c28-98c2-fd0b4f0976cc\u0027)"},{"line_number":830,"context_line":"    def test_l7policy_delete(self):"},{"line_number":831,"context_line":"        \"\"\"Tests l7policy create and delete APIs."},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_776a2a81","line":829,"updated":"2020-07-08 21:27:26.000000000","message":"ditto","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"octavia_tempest_plugin/tests/api/v2/test_l7rule.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # Test tags"},{"line_number":207,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":208,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":209,"context_line":"            self.assertEqual(l7rule_kwargs[const.TAGS], l7_rule_tags)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_be199a89","line":209,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and l7rule_kwargs-\u003el7rule issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # Test tags"},{"line_number":207,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":208,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":209,"context_line":"            self.assertEqual(l7rule_kwargs[const.TAGS], l7_rule_tags)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed035c0c","line":209,"in_reply_to":"bf51134e_be199a89","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            self.assertEqual(l7rule_kwargs[const.TAGS], l7_rule_tags)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"},{"line_number":213,"context_line":"        \"\"\"Tests l7rule list API and field filtering."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        * Create a clean l7policy."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3e246ac6","line":212,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            self.assertEqual(l7rule_kwargs[const.TAGS], l7_rule_tags)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"},{"line_number":213,"context_line":"        \"\"\"Tests l7rule list API and field filtering."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        * Create a clean l7policy."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0dffb001","line":212,"in_reply_to":"bf51134e_3e246ac6","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # Test tags"},{"line_number":207,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":208,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":209,"context_line":"            self.assertEqual(l7_rule_tags, l7rule_kwargs[const.TAGS])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a98182c6","line":209,"range":{"start_line":209,"start_character":43,"end_line":209,"end_character":57},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, l7rule here instead of l7rule_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # Test tags"},{"line_number":207,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":208,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":209,"context_line":"            self.assertEqual(l7_rule_tags, l7rule_kwargs[const.TAGS])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @decorators.idempotent_id(\u002769095254-f106-4fb6-9f54-7a78cc14fb51\u0027)"},{"line_number":212,"context_line":"    def test_l7rule_list(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_60f2cd9c","line":209,"range":{"start_line":209,"start_character":43,"end_line":209,"end_character":57},"in_reply_to":"bf51134e_a98182c6","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            list_of_l7rules \u003d [l7rule1, l7rule2, l7rule3]"},{"line_number":457,"context_line":"            test_list \u003d []"},{"line_number":458,"context_line":"            for l7rule in list_of_l7rules:"},{"line_number":459,"context_line":"                if \"English\" in l7rule[const.TAGS] and \"Creativity\" \\"},{"line_number":460,"context_line":"                    in l7rule[const.TAGS] and \"Spanish\" not in \\"},{"line_number":461,"context_line":"                        l7rule[const.TAGS]:"},{"line_number":462,"context_line":"                    test_list.append(l7rule[const.VALUE])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e9c9ba5a","line":459,"updated":"2020-06-30 17:50:11.000000000","message":"Same here, please use () instead of \\","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            list_of_l7rules \u003d [l7rule1, l7rule2, l7rule3]"},{"line_number":457,"context_line":"            test_list \u003d []"},{"line_number":458,"context_line":"            for l7rule in list_of_l7rules:"},{"line_number":459,"context_line":"                if \"English\" in l7rule[const.TAGS] and \"Creativity\" \\"},{"line_number":460,"context_line":"                    in l7rule[const.TAGS] and \"Spanish\" not in \\"},{"line_number":461,"context_line":"                        l7rule[const.TAGS]:"},{"line_number":462,"context_line":"                    test_list.append(l7rule[const.VALUE])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_801721a4","line":459,"in_reply_to":"bf51134e_e9c9ba5a","updated":"2020-07-07 11:17:32.000000000","message":"Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            const.TYPE: const.HEADER,"},{"line_number":293,"context_line":"            const.VALUE: \u00273\u0027,"},{"line_number":294,"context_line":"            const.COMPARE_TYPE: const.EQUAL_TO,"},{"line_number":295,"context_line":"            const.KEY: \u0027mykey3-list\u0027,"},{"line_number":296,"context_line":"        }"},{"line_number":297,"context_line":"        l7rule3 \u003d self.mem_l7rule_client.create_l7rule("},{"line_number":298,"context_line":"            **l7rule3_kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_b72e8240","side":"PARENT","line":295,"range":{"start_line":295,"start_character":36,"end_line":295,"end_character":37},"updated":"2020-07-08 21:27:26.000000000","message":"unrelated change","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class L7RuleAPITest(test_base.LoadBalancerBaseTest):"},{"line_number":32,"context_line":"    \"\"\"Test the l7rule object API.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7RuleAPITest, cls).skip_checks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_17f64ed8","line":33,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change, and below","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self.assertEqual(const.OFFLINE, listener[const.OPERATING_STATUS])"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            self.assertEqual(const.ONLINE, listener[const.OPERATING_STATUS])"},{"line_number":162,"context_line":"        insert_headers \u003d listener[const.INSERT_HEADERS]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":165,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_66ddb441","line":162,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: F841 local variable \u0027insert_headers\u0027 is assigned to but never used","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self.assertEqual(const.OFFLINE, listener[const.OPERATING_STATUS])"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            self.assertEqual(const.ONLINE, listener[const.OPERATING_STATUS])"},{"line_number":162,"context_line":"        insert_headers \u003d listener[const.INSERT_HEADERS]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":165,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b4837956","line":162,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: F841 local variable \u0027insert_headers\u0027 is assigned to but never used","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":165,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":166,"context_line":"            equal_items \u003d ["},{"line_number":167,"context_line":"                const.TIMEOUT_CLIENT_DATA, const.TIMEOUT_MEMBER_CONNECT,"},{"line_number":168,"context_line":"                const.TIMEOUT_MEMBER_DATA,"},{"line_number":169,"context_line":"                const.TIMEOUT_TCP_INSPECT]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_91eda727","line":166,"updated":"2020-06-16 18:36:45.000000000","message":"This could be moved up to line 150, then we would only need to iterate over the fields once.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":165,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":166,"context_line":"            equal_items \u003d ["},{"line_number":167,"context_line":"                const.TIMEOUT_CLIENT_DATA, const.TIMEOUT_MEMBER_CONNECT,"},{"line_number":168,"context_line":"                const.TIMEOUT_MEMBER_DATA,"},{"line_number":169,"context_line":"                const.TIMEOUT_TCP_INSPECT]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_15c7b814","line":166,"in_reply_to":"bf51134e_91eda727","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # Test tags"},{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_kwargs[const.TAGS].sort(),"},{"line_number":178,"context_line":"             listener_tags.sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_11d99782","line":177,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and listener_kwargs-\u003elistener issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # Test tags"},{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_kwargs[const.TAGS].sort(),"},{"line_number":178,"context_line":"             listener_tags.sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_559f7002","line":177,"in_reply_to":"bf51134e_11d99782","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_kwargs[const.TAGS].sort(),"},{"line_number":178,"context_line":"             listener_tags.sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"},{"line_number":181,"context_line":"    def test_listener_create_on_same_port(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_46e23005","line":178,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_kwargs[const.TAGS].sort(),"},{"line_number":178,"context_line":"             listener_tags.sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"},{"line_number":181,"context_line":"    def test_listener_create_on_same_port(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9488f571","line":178,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                **listener4_kwargs)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @decorators.idempotent_id(\u002778ba6eb0-178c-477e-9156-b6775ca7b271\u0027)"},{"line_number":315,"context_line":"    def test_listener_list(self):"},{"line_number":316,"context_line":"        \"\"\"Tests listener list API and field filtering."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        * Create a clean loadbalancer."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b15f0be4","line":315,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                **listener4_kwargs)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @decorators.idempotent_id(\u002778ba6eb0-178c-477e-9156-b6775ca7b271\u0027)"},{"line_number":315,"context_line":"    def test_listener_list(self):"},{"line_number":316,"context_line":"        \"\"\"Tests listener list API and field filtering."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        * Create a clean loadbalancer."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_402df041","line":315,"in_reply_to":"bf51134e_b15f0be4","updated":"2020-06-23 07:09:50.000000000","message":"I added the tags\u0027 lists tests only in this test because I wasn\u0027t sure if I should add them or not, but I will add them also to the other API\u0027s tests as well","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        listener_kwargs \u003d {"},{"line_number":610,"context_line":"            const.NAME: listener_name,"},{"line_number":611,"context_line":"            const.DESCRIPTION: listener_description,"},{"line_number":612,"context_line":"            const.TAGS: listener_tags,"},{"line_number":613,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":614,"context_line":"            const.PROTOCOL: self.protocol,"},{"line_number":615,"context_line":"            const.PROTOCOL_PORT: 81,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_51bcaf04","line":612,"updated":"2020-06-16 18:36:45.000000000","message":"This will only be present in version 2.5 or newer of the API.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        listener_kwargs \u003d {"},{"line_number":610,"context_line":"            const.NAME: listener_name,"},{"line_number":611,"context_line":"            const.DESCRIPTION: listener_description,"},{"line_number":612,"context_line":"            const.TAGS: listener_tags,"},{"line_number":613,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":614,"context_line":"            const.PROTOCOL: self.protocol,"},{"line_number":615,"context_line":"            const.PROTOCOL_PORT: 81,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6022b4a6","line":612,"in_reply_to":"bf51134e_51bcaf04","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                const.ONLINE,"},{"line_number":659,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":660,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":661,"context_line":"        equal_items \u003d [const.NAME, const.DESCRIPTION, const.TAGS,"},{"line_number":662,"context_line":"                       const.ADMIN_STATE_UP,"},{"line_number":663,"context_line":"                       const.PROTOCOL, const.PROTOCOL_PORT,"},{"line_number":664,"context_line":"                       const.CONNECTION_LIMIT,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d1455f19","line":661,"updated":"2020-06-16 18:36:45.000000000","message":"TAGS will only be present in version 2.5 or newer of the API.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                const.ONLINE,"},{"line_number":659,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":660,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":661,"context_line":"        equal_items \u003d [const.NAME, const.DESCRIPTION, const.TAGS,"},{"line_number":662,"context_line":"                       const.ADMIN_STATE_UP,"},{"line_number":663,"context_line":"                       const.PROTOCOL, const.PROTOCOL_PORT,"},{"line_number":664,"context_line":"                       const.CONNECTION_LIMIT,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2028bc84","line":661,"in_reply_to":"bf51134e_d1455f19","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":680,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":681,"context_line":"            equal_items \u003d ["},{"line_number":682,"context_line":"                const.TIMEOUT_CLIENT_DATA, const.TIMEOUT_MEMBER_CONNECT,"},{"line_number":683,"context_line":"                const.TIMEOUT_MEMBER_DATA,"},{"line_number":684,"context_line":"                const.TIMEOUT_TCP_INSPECT]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1147d71f","line":681,"updated":"2020-06-16 18:36:45.000000000","message":"Same, this could be moved up to line 666 to only iterate the fields once.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":680,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":681,"context_line":"            equal_items \u003d ["},{"line_number":682,"context_line":"                const.TIMEOUT_CLIENT_DATA, const.TIMEOUT_MEMBER_CONNECT,"},{"line_number":683,"context_line":"                const.TIMEOUT_MEMBER_DATA,"},{"line_number":684,"context_line":"                const.TIMEOUT_TCP_INSPECT]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c019007a","line":681,"in_reply_to":"bf51134e_1147d71f","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":172,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":173,"context_line":"            self.assertEqual(listener_tags.sort(),"},{"line_number":174,"context_line":"                             listener_kwargs[const.TAGS].sort())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"},{"line_number":177,"context_line":"    def test_listener_create_on_same_port(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_69600a37","line":174,"range":{"start_line":174,"start_character":29,"end_line":174,"end_character":44},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, listener here instead of listener_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":172,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":173,"context_line":"            self.assertEqual(listener_tags.sort(),"},{"line_number":174,"context_line":"                             listener_kwargs[const.TAGS].sort())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"},{"line_number":177,"context_line":"    def test_listener_create_on_same_port(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_807c41ec","line":174,"range":{"start_line":174,"start_character":29,"end_line":174,"end_character":44},"in_reply_to":"bf51134e_69600a37","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":578,"context_line":"            list_of_listeners \u003d [listener1, listener2, listener3]"},{"line_number":579,"context_line":"            test_list \u003d []"},{"line_number":580,"context_line":"            for listener in list_of_listeners:"},{"line_number":581,"context_line":"                if \"English\" in listener[const.TAGS] and \"Creativity\" \\"},{"line_number":582,"context_line":"                    in listener[const.TAGS] and \"Spanish\" not in \\"},{"line_number":583,"context_line":"                        listener[const.TAGS]:"},{"line_number":584,"context_line":"                    test_list.append(listener[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_49e0a6cd","line":581,"updated":"2020-06-30 17:50:11.000000000","message":"Same, () please","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":578,"context_line":"            list_of_listeners \u003d [listener1, listener2, listener3]"},{"line_number":579,"context_line":"            test_list \u003d []"},{"line_number":580,"context_line":"            for listener in list_of_listeners:"},{"line_number":581,"context_line":"                if \"English\" in listener[const.TAGS] and \"Creativity\" \\"},{"line_number":582,"context_line":"                    in listener[const.TAGS] and \"Spanish\" not in \\"},{"line_number":583,"context_line":"                        listener[const.TAGS]:"},{"line_number":584,"context_line":"                    test_list.append(listener[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_206bb51f","line":581,"in_reply_to":"bf51134e_49e0a6cd","updated":"2020-07-07 11:17:32.000000000","message":"Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        listener_name \u003d data_utils.rand_name(\"lb_member_listener1-create\")"},{"line_number":73,"context_line":"        listener_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        listener_kwargs \u003d {"},{"line_number":76,"context_line":"            const.NAME: listener_name,"},{"line_number":77,"context_line":"            const.DESCRIPTION: listener_description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_d7297637","side":"PARENT","line":74,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertTrue("},{"line_number":154,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_FOR]))"},{"line_number":155,"context_line":"        self.assertTrue("},{"line_number":156,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_PORT]))"},{"line_number":157,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":158,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":159,"context_line":"            self.assertEqual(1000, listener[const.TIMEOUT_CLIENT_DATA])"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_57ea86d7","side":"PARENT","line":156,"updated":"2020-07-08 21:27:26.000000000","message":"These two asserts were lost","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c261150c1c3d0ab257e49524831b73e379d5c6e9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertTrue("},{"line_number":154,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_FOR]))"},{"line_number":155,"context_line":"        self.assertTrue("},{"line_number":156,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_PORT]))"},{"line_number":157,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":158,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":159,"context_line":"            self.assertEqual(1000, listener[const.TIMEOUT_CLIENT_DATA])"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_39151de6","side":"PARENT","line":156,"in_reply_to":"bf51134e_57ea86d7","updated":"2020-07-14 11:01:28.000000000","message":"I thought that appending const.INSERT_HEADERS to the equal_items list would do, my bad.\nThanks!","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self.assertTrue("},{"line_number":625,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_FOR]))"},{"line_number":626,"context_line":"        self.assertTrue("},{"line_number":627,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_PORT]))"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":630,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_97c1be57","side":"PARENT","line":627,"updated":"2020-07-08 21:27:26.000000000","message":"These asserts were lost","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c261150c1c3d0ab257e49524831b73e379d5c6e9","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self.assertTrue("},{"line_number":625,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_FOR]))"},{"line_number":626,"context_line":"        self.assertTrue("},{"line_number":627,"context_line":"            strutils.bool_from_string(insert_headers[const.X_FORWARDED_PORT]))"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":630,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_39fcfdb3","side":"PARENT","line":627,"in_reply_to":"bf51134e_97c1be57","updated":"2020-07-14 11:01:28.000000000","message":"I thought that appending const.INSERT_HEADERS to the equal_items list would do, my bad.\nThanks!","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        listeners \u003d self.mem_listener_client.list_listeners("},{"line_number":490,"context_line":"            query_params\u003d\u0027loadbalancer_id\u003d{lb_id}\u0026{sort}\u003d{descr}:{desc}\u0027"},{"line_number":491,"context_line":"            .format(lb_id\u003dlb_id, sort\u003dconst.SORT,"},{"line_number":492,"context_line":"                    descr\u003dconst.DESCRIPTION, desc\u003dconst.DESC))"},{"line_number":493,"context_line":"        self.assertEqual(listener1[const.DESCRIPTION],"},{"line_number":494,"context_line":"                         listeners[1][const.DESCRIPTION])"},{"line_number":495,"context_line":"        self.assertEqual(listener2[const.DESCRIPTION],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_b7bcc2dc","line":492,"updated":"2020-07-08 21:27:26.000000000","message":"Same comment about unrelated code","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8ee2b1b09a3bbec47d368cedc1f4d17e730a6c0b","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_tags.sort(),"},{"line_number":178,"context_line":"                             listener[const.TAGS].sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_d1730de6","line":177,"range":{"start_line":177,"start_character":29,"end_line":177,"end_character":50},"updated":"2020-07-13 15:07:43.000000000","message":"listener_tags.sort() sorts the list in place and doesn\u0027t return the list, basically the assert here is evaluated as assertEqual(None, None).\nYou could use \"sorted(listener_tags)\" instead, it returns a sorted list.","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c261150c1c3d0ab257e49524831b73e379d5c6e9","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":176,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":177,"context_line":"            self.assertEqual(listener_tags.sort(),"},{"line_number":178,"context_line":"                             listener[const.TAGS].sort())"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027cceac303-4db5-4d5a-9f6e-ff33780a5f29\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_6df5faca","line":177,"range":{"start_line":177,"start_character":29,"end_line":177,"end_character":50},"in_reply_to":"bf51134e_d1730de6","updated":"2020-07-14 11:01:28.000000000","message":"I didn\u0027t know that, thanks! I will change it as you suggested.","commit_id":"e4f9f0844bdc1098031be16875a3d8ef8aeed0e1"}],"octavia_tempest_plugin/tests/api/v2/test_load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from dateutil import parser"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_716d7397","side":"PARENT","line":20,"updated":"2020-06-16 18:36:45.000000000","message":"This is incorrect, dateutil is a third party library, so technically should go in the group below.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from dateutil import parser"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fee219a0","side":"PARENT","line":20,"in_reply_to":"bf51134e_3f984b68","updated":"2020-07-07 11:17:32.000000000","message":"Ok, thanks for the information! Done.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from dateutil import parser"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed519c10","side":"PARENT","line":20,"in_reply_to":"bf51134e_716d7397","updated":"2020-06-23 07:09:50.000000000","message":"Ok, so I am a little confused, what should I do in this case?","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2c48553a2cd7065e646455ab6174658107583caa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from dateutil import parser"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3f984b68","side":"PARENT","line":20,"in_reply_to":"bf51134e_ed519c10","updated":"2020-06-24 22:44:27.000000000","message":"In OpenStack we have a standard of three blocks of import statements:\n\n1. python built in modules\n2. modules that are external to this application, but are not included with python.\n3. modules that are part of this application.\n\ndateutil is not part of the python built in modules (https://pypi.org/project/python-dateutil/1.4/), so it should be grouped with the modules in the second section.","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ab454b27c0af66db032e9a2caba8c8420bd74548","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":"from dateutil import parser"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_66b2d4e8","line":20,"updated":"2020-06-17 00:42:58.000000000","message":"pep8: H306: imports not in alphabetical order (uuid.uuid, dateutil.parser)","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"895d69cea6365b00bd0d961a7d0f4ceef958424f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":"from dateutil import parser"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_74b8c129","line":20,"updated":"2020-06-16 19:19:32.000000000","message":"pep8: H306: imports not in alphabetical order (uuid.uuid, dateutil.parser)","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        return [lb for i, lb in enumerate(lbs) if i not in indexes]"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @decorators.idempotent_id(\u00276546ef3c-c0e2-46af-b892-f795f4d01119\u0027)"},{"line_number":258,"context_line":"    def test_load_balancer_list(self):"},{"line_number":259,"context_line":"        \"\"\"Tests load balancer list API and field filtering."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        * Create three load balancers."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b1042bc8","line":258,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        return [lb for i, lb in enumerate(lbs) if i not in indexes]"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @decorators.idempotent_id(\u00276546ef3c-c0e2-46af-b892-f795f4d01119\u0027)"},{"line_number":258,"context_line":"    def test_load_balancer_list(self):"},{"line_number":259,"context_line":"        \"\"\"Tests load balancer list API and field filtering."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        * Create three load balancers."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6d3d8cba","line":258,"in_reply_to":"bf51134e_b1042bc8","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                     # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":475,"context_line":"                     const.PROVIDER: CONF.load_balancer.provider,"},{"line_number":476,"context_line":"                     const.NAME: lb_name"},{"line_number":477,"context_line":"                     }"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self._setup_lb_network_kwargs(lb_kwargs, 4, use_fixed_ip\u003dTrue)"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_910927df","line":477,"updated":"2020-06-16 18:36:45.000000000","message":"This really does not need to change.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                     # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":475,"context_line":"                     const.PROVIDER: CONF.load_balancer.provider,"},{"line_number":476,"context_line":"                     const.NAME: lb_name"},{"line_number":477,"context_line":"                     }"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self._setup_lb_network_kwargs(lb_kwargs, 4, use_fixed_ip\u003dTrue)"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed9fdcb1","line":477,"in_reply_to":"bf51134e_910927df","updated":"2020-06-23 07:09:50.000000000","message":"I reverted it","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        # Test tags"},{"line_number":619,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":620,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":621,"context_line":"            self.assertEqual(lb_kwargs[const.TAGS], lb_tags)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_lb1-update\")"},{"line_number":624,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_710293b6","line":621,"updated":"2020-06-16 18:36:45.000000000","message":"Same order and lb_kwargs-\u003elb issue here.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        # Test tags"},{"line_number":619,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":620,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":621,"context_line":"            self.assertEqual(lb_kwargs[const.TAGS], lb_tags)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_lb1-update\")"},{"line_number":624,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8dae20e5","line":621,"in_reply_to":"bf51134e_710293b6","updated":"2020-06-23 07:09:50.000000000","message":"Done","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            # TODO(johnsom) Add QoS"},{"line_number":662,"context_line":"            # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":663,"context_line":"            name\u003dnew_name,"},{"line_number":664,"context_line":"            tags\u003dnew_tags)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        lb \u003d waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"},{"line_number":667,"context_line":"                                     lb[const.ID], const.PROVISIONING_STATUS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_711bb31a","line":664,"updated":"2020-06-16 18:36:45.000000000","message":"I don\u0027t think this will work on API versions less than 2.5.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            # TODO(johnsom) Add QoS"},{"line_number":662,"context_line":"            # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":663,"context_line":"            name\u003dnew_name,"},{"line_number":664,"context_line":"            tags\u003dnew_tags)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        lb \u003d waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"},{"line_number":667,"context_line":"                                     lb[const.ID], const.PROVISIONING_STATUS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0d8a101a","line":664,"in_reply_to":"bf51134e_711bb31a","updated":"2020-06-23 07:09:50.000000000","message":"Ok, I changed it to be updated with kwargs, like the other ones.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7b41a08eee55350a252e4f376f3e086332c34a9a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":"from dateutil import parser"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_38d57744","line":20,"updated":"2020-06-18 09:58:28.000000000","message":"pep8: H306: imports not in alphabetical order (uuid.uuid, dateutil.parser)","commit_id":"cbc78e699b3d16fb50a2a01bd95551b66bdca47b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            list_of_lbs \u003d [lb1, lb2, lb3]"},{"line_number":498,"context_line":"            test_list \u003d []"},{"line_number":499,"context_line":"            for lb in list_of_lbs:"},{"line_number":500,"context_line":"                if \"English\" in lb[const.TAGS] and \"Creativity\" \\"},{"line_number":501,"context_line":"                    in lb[const.TAGS] and \"Spanish\" not in \\"},{"line_number":502,"context_line":"                        lb[const.TAGS]:"},{"line_number":503,"context_line":"                    test_list.append(lb[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_29d9f221","line":500,"updated":"2020-06-30 17:50:11.000000000","message":"Same, () please","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            list_of_lbs \u003d [lb1, lb2, lb3]"},{"line_number":498,"context_line":"            test_list \u003d []"},{"line_number":499,"context_line":"            for lb in list_of_lbs:"},{"line_number":500,"context_line":"                if \"English\" in lb[const.TAGS] and \"Creativity\" \\"},{"line_number":501,"context_line":"                    in lb[const.TAGS] and \"Spanish\" not in \\"},{"line_number":502,"context_line":"                        lb[const.TAGS]:"},{"line_number":503,"context_line":"                    test_list.append(lb[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_20545554","line":500,"in_reply_to":"bf51134e_29d9f221","updated":"2020-07-07 11:17:32.000000000","message":"Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        # Test tags"},{"line_number":672,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":673,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":674,"context_line":"            self.assertEqual(lb_tags, lb_kwargs[const.TAGS])"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_lb1-update\")"},{"line_number":677,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e9537a6b","line":674,"range":{"start_line":674,"start_character":38,"end_line":674,"end_character":47},"updated":"2020-06-30 17:50:11.000000000","message":"This is still testing your input settings against the reference. I think you want to be testing the returned result, lb here instead of lb_kwargs.","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        # Test tags"},{"line_number":672,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":673,"context_line":"                self.api_version, \u00272.5\u0027):"},{"line_number":674,"context_line":"            self.assertEqual(lb_tags, lb_kwargs[const.TAGS])"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_lb1-update\")"},{"line_number":677,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_00515163","line":674,"range":{"start_line":674,"start_character":38,"end_line":674,"end_character":47},"in_reply_to":"bf51134e_e9537a6b","updated":"2020-07-07 11:17:32.000000000","message":"That\u0027s exactly what I wanted, done!","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from uuid import UUID"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from dateutil import parser"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest import config"},{"line_number":24,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":25,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_d7b7b6f4","side":"PARENT","line":22,"updated":"2020-07-08 21:27:26.000000000","message":"random whitespace change, and below","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                     # flavor\u003dlb_flavor,"},{"line_number":68,"context_line":"                     # TODO(johnsom) Add QoS"},{"line_number":69,"context_line":"                     # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":70,"context_line":"                     const.NAME: lb_name}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self._setup_lb_network_kwargs(lb_kwargs, ip_version, use_fixed_ip\u003dTrue)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_37d0b21f","side":"PARENT","line":70,"updated":"2020-07-08 21:27:26.000000000","message":"Did this need to change?","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        \"\"\""},{"line_number":552,"context_line":"        lb_name \u003d data_utils.rand_name(\"lb_member_lb1-update\")"},{"line_number":553,"context_line":"        lb_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        lb_kwargs \u003d {const.ADMIN_STATE_UP: False,"},{"line_number":556,"context_line":"                     const.DESCRIPTION: lb_description,"},{"line_number":557,"context_line":"                     const.PROVIDER: CONF.load_balancer.provider,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_77c6aa6a","side":"PARENT","line":554,"updated":"2020-07-08 21:27:26.000000000","message":"whitespace","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                     # flavor\u003dlb_flavor,"},{"line_number":560,"context_line":"                     # TODO(johnsom) Add QoS"},{"line_number":561,"context_line":"                     # vip_qos_policy_id\u003dlb_qos_policy_id)"},{"line_number":562,"context_line":"                     const.NAME: lb_name}"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        self._setup_lb_network_kwargs(lb_kwargs, 4, use_fixed_ip\u003dTrue)"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_57c3a657","side":"PARENT","line":562,"updated":"2020-07-08 21:27:26.000000000","message":"Did this need to change?","commit_id":"beb1cbaebbe6138d7582a596dbee8895fbc48599"}],"octavia_tempest_plugin/tests/api/v2/test_member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            self.assertEqual(member_kwargs[item], member[item])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u00279ce7ad78-915b-42ce-b0d8-44d88a929f3d\u0027)"},{"line_number":223,"context_line":"    def test_member_list(self):"},{"line_number":224,"context_line":"        \"\"\"Tests member list API and field filtering."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        * Create a clean pool."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f1dce347","line":223,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            self.assertEqual(member_kwargs[item], member[item])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u00279ce7ad78-915b-42ce-b0d8-44d88a929f3d\u0027)"},{"line_number":223,"context_line":"    def test_member_list(self):"},{"line_number":224,"context_line":"        \"\"\"Tests member list API and field filtering."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        * Create a clean pool."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6d9f4c50","line":223,"in_reply_to":"bf51134e_f1dce347","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        if monitor:"},{"line_number":708,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":709,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d \\"},{"line_number":710,"context_line":"                member[const.MONITOR_PORT] + 1"},{"line_number":711,"context_line":"        member \u003d self.mem_member_client.update_member("},{"line_number":712,"context_line":"            member[const.ID], **member_update_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_11e35707","line":709,"range":{"start_line":709,"start_character":55,"end_line":709,"end_character":56},"updated":"2020-06-16 18:36:45.000000000","message":"The Octavia team does not use \u0027\\\u0027 line breaks.\nThis should be reverted.\n\nhttps://github.com/openstack/octavia/blob/master/HACKING.rst#octavia-specific-commandments\n\n[O346] rule","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        if monitor:"},{"line_number":708,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":709,"context_line":"            member_update_kwargs[const.MONITOR_PORT] \u003d \\"},{"line_number":710,"context_line":"                member[const.MONITOR_PORT] + 1"},{"line_number":711,"context_line":"        member \u003d self.mem_member_client.update_member("},{"line_number":712,"context_line":"            member[const.ID], **member_update_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4d008868","line":709,"range":{"start_line":709,"start_character":55,"end_line":709,"end_character":56},"in_reply_to":"bf51134e_11e35707","updated":"2020-06-23 07:09:50.000000000","message":"I removed the backslash.\nIf I just revert it, it becomes too long, so I just didn\u0027t use the backslash with the \\n (after the \u0027[\u0027 character)","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        self.assertEqual(const.NO_MONITOR, member[const.OPERATING_STATUS])"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        # Test changed items"},{"line_number":738,"context_line":"        equal_items \u003d [const.NAME, const.TAGS,"},{"line_number":739,"context_line":"                       const.ADMIN_STATE_UP, const.WEIGHT]"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        if self.mem_member_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_91a5a7b8","line":738,"updated":"2020-06-16 18:36:45.000000000","message":"TAGS are only available in 2.5 or newer of the API. I think you want to revert this as you are adding it on line 745 below.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        self.assertEqual(const.NO_MONITOR, member[const.OPERATING_STATUS])"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        # Test changed items"},{"line_number":738,"context_line":"        equal_items \u003d [const.NAME, const.TAGS,"},{"line_number":739,"context_line":"                       const.ADMIN_STATE_UP, const.WEIGHT]"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        if self.mem_member_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4d6d2803","line":738,"in_reply_to":"bf51134e_91a5a7b8","updated":"2020-06-23 07:09:50.000000000","message":"Exactly, I removed it, thanks!","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            list_of_members \u003d [member1, member2, member3]"},{"line_number":473,"context_line":"            test_list \u003d []"},{"line_number":474,"context_line":"            for member in list_of_members:"},{"line_number":475,"context_line":"                if \"English\" in member[const.TAGS] and \"Creativity\" \\"},{"line_number":476,"context_line":"                    in member[const.TAGS] and \"Spanish\" not in \\"},{"line_number":477,"context_line":"                        member[const.TAGS]:"},{"line_number":478,"context_line":"                    test_list.append(member[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_09d6aef2","line":475,"updated":"2020-06-30 17:50:11.000000000","message":"Same, () please","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            list_of_members \u003d [member1, member2, member3]"},{"line_number":473,"context_line":"            test_list \u003d []"},{"line_number":474,"context_line":"            for member in list_of_members:"},{"line_number":475,"context_line":"                if \"English\" in member[const.TAGS] and \"Creativity\" \\"},{"line_number":476,"context_line":"                    in member[const.TAGS] and \"Spanish\" not in \\"},{"line_number":477,"context_line":"                        member[const.TAGS]:"},{"line_number":478,"context_line":"                    test_list.append(member[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e0cffd26","line":475,"in_reply_to":"bf51134e_09d6aef2","updated":"2020-07-07 11:17:32.000000000","message":"Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            member_monitor_address \u003d \u00272001:db8:0:0:0:0:0:2\u0027"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        member_name \u003d data_utils.rand_name(\"lb_member_member1-create\")"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        member_kwargs \u003d {"},{"line_number":142,"context_line":"            const.NAME: member_name,"},{"line_number":143,"context_line":"            const.ADMIN_STATE_UP: True,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_f7a75abb","line":140,"updated":"2020-07-08 21:27:26.000000000","message":"whitespace","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        if monitor:"},{"line_number":746,"context_line":"            member_update_kwargs[const.MONITOR_ADDRESS] \u003d \u0027192.0.2.3\u0027"},{"line_number":747,"context_line":"            member_update_kwargs["},{"line_number":748,"context_line":"                const.MONITOR_PORT] \u003d member[const.MONITOR_PORT] + 1"},{"line_number":749,"context_line":"        member \u003d self.mem_member_client.update_member("},{"line_number":750,"context_line":"            member[const.ID], **member_update_kwargs)"},{"line_number":751,"context_line":"        waiters.wait_for_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_779b4a72","line":748,"updated":"2020-07-08 21:27:26.000000000","message":"Did this need to change?","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"octavia_tempest_plugin/tests/api/v2/test_pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"73c304b1fde9c72e8b246e43df5b1a1de5d7ef0a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self.assertEqual(pool_tags, pool[const.TAGS])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @decorators.idempotent_id(\u00276959a32e-fb34-4f3e-be68-8880c6450016\u0027)"},{"line_number":195,"context_line":"    def test_pool_list(self):"},{"line_number":196,"context_line":"        \"\"\"Tests pool list API and field filtering."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        * Create a clean loadbalancer."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_11919753","line":195,"updated":"2020-06-16 18:36:45.000000000","message":"Tags are commonly used to filter API list actions.\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#filtering-by-tags\n\nAre tests for the list actions coming in a follow up patch or should they be added here?","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1b0154827ec10b1406670572193ade70ed5d864","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self.assertEqual(pool_tags, pool[const.TAGS])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @decorators.idempotent_id(\u00276959a32e-fb34-4f3e-be68-8880c6450016\u0027)"},{"line_number":195,"context_line":"    def test_pool_list(self):"},{"line_number":196,"context_line":"        \"\"\"Tests pool list API and field filtering."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        * Create a clean loadbalancer."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2d1394b7","line":195,"in_reply_to":"bf51134e_11919753","updated":"2020-06-23 07:09:50.000000000","message":"I will add them - they will be the same as the ones on the test_listener file.","commit_id":"5a324470e3ee124d084dd7fa220b9b557842cf6d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d73f28084dde48995c5af582df9f2289a564db5c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            list_of_pools \u003d [pool1, pool2, pool3]"},{"line_number":457,"context_line":"            test_list \u003d []"},{"line_number":458,"context_line":"            for pool in list_of_pools:"},{"line_number":459,"context_line":"                if \"English\" in pool[const.TAGS] and \"Creativity\" \\"},{"line_number":460,"context_line":"                    in pool[const.TAGS] and \"Spanish\" not in \\"},{"line_number":461,"context_line":"                        pool[const.TAGS]:"},{"line_number":462,"context_line":"                    test_list.append(pool[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_69048a7f","line":459,"updated":"2020-06-30 17:50:11.000000000","message":"Same, () please","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"21dcffb506a6254d75d51cf59f2748feb3c9fd68","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            list_of_pools \u003d [pool1, pool2, pool3]"},{"line_number":457,"context_line":"            test_list \u003d []"},{"line_number":458,"context_line":"            for pool in list_of_pools:"},{"line_number":459,"context_line":"                if \"English\" in pool[const.TAGS] and \"Creativity\" \\"},{"line_number":460,"context_line":"                    in pool[const.TAGS] and \"Spanish\" not in \\"},{"line_number":461,"context_line":"                        pool[const.TAGS]:"},{"line_number":462,"context_line":"                    test_list.append(pool[const.NAME])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_60e3eda5","line":459,"in_reply_to":"bf51134e_69048a7f","updated":"2020-07-07 11:17:32.000000000","message":"Done","commit_id":"e93e818da1cfe4e794a477512c525637677d22aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13909acd84cd8a00160f8e478b764273eea519e4","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        if self.lb_feature_enabled.session_persistence_enabled:"},{"line_number":743,"context_line":"            self.assertIsNone(pool.get(const.SESSION_PERSISTENCE))"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        # Test tags"},{"line_number":746,"context_line":"        if self.mem_lb_client.is_version_supported(self.api_version, \u00272.5\u0027):"},{"line_number":747,"context_line":"            self.assertEqual(new_tags, pool[const.TAGS])"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_5771e643","line":745,"range":{"start_line":745,"start_character":8,"end_line":745,"end_character":19},"updated":"2020-07-08 21:27:26.000000000","message":"nit: shouldn\u0027t need this comment before every code addition, the assert is enough.","commit_id":"1deb1df5693df17acf5cf9282897d0b7d1400fb6"}],"releasenotes/notes/add-tags-api-tests-1130aab82bb0f7f2.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d112a3887d9f80264e32e16d4d1ade7eb75631a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API tests for tags were added on this patch."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_6514584f","line":4,"range":{"start_line":4,"start_character":34,"end_line":4,"end_character":48},"updated":"2020-07-07 11:34:34.000000000","message":"The rendered release note page does not link to this patch so the reader will not know which patch the note refers to. Consider rewording to simply \"API tests for tags were added\".","commit_id":"408412832d47b21b39e970c8a69aa4e120204fa1"}]}