)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"996a54432ee9bce7dd56965218c4b527b0d5393b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"These tests require:"},{"line_number":16,"context_line":"- \"load_balancer.test_sctp_protocol \u003d True\" in tempest.conf"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Notes:"},{"line_number":19,"context_line":"* on CentOS-Stream the optional package \u0027kernel-modules-extra\u0027 is"},{"line_number":20,"context_line":"  required to get SCTP support in the kernel."},{"line_number":21,"context_line":"* cirros \u003e\u003d0.6.0 is required for the SCTP support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"cf966418_dd9bff04","line":18,"updated":"2023-07-12 00:09:36.000000000","message":"These could go in the release notes","commit_id":"38aefe11304478d109e291230d8b34acbd45be57"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2ff641de5b7ad1098324373595b8d502b2040857","unresolved":false,"context_lines":[{"line_number":15,"context_line":"These tests require:"},{"line_number":16,"context_line":"- \"load_balancer.test_sctp_protocol \u003d True\" in tempest.conf"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Notes:"},{"line_number":19,"context_line":"* on CentOS-Stream the optional package \u0027kernel-modules-extra\u0027 is"},{"line_number":20,"context_line":"  required to get SCTP support in the kernel."},{"line_number":21,"context_line":"* cirros \u003e\u003d0.6.0 is required for the SCTP support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"830ff755_f7435718","line":18,"in_reply_to":"cf966418_dd9bff04","updated":"2023-07-13 16:16:45.000000000","message":"Done","commit_id":"38aefe11304478d109e291230d8b34acbd45be57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d6a33028511df586eb6544c47d376b98c293a9c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"1db60cf6_3f078f84","updated":"2022-01-17 13:47:00.000000000","message":"recheck\n\ntimeout in sctp job","commit_id":"5b93ff4219555e7c830a31ea09dd2f9abe0fafba"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"377df8a791eeee0ddaabfb5e6d6d8bebb6c07ee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"be1fc059_966c46b4","updated":"2022-09-30 10:56:20.000000000","message":"recheck octavia-v2-sctp-dsvm-scenario checking weird CI failure","commit_id":"f0ec297ea8abbbcc125ad6dcbad743e3117589cf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"996a54432ee9bce7dd56965218c4b527b0d5393b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"8fedd4cc_0ff49414","updated":"2023-07-12 00:09:36.000000000","message":"LGTM except maybe adding a release note","commit_id":"38aefe11304478d109e291230d8b34acbd45be57"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"65136fe9b5518772cb9bf023fa48470496347476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"550868d9_330b39b9","in_reply_to":"8fedd4cc_0ff49414","updated":"2023-07-12 14:08:26.000000000","message":"Done!","commit_id":"38aefe11304478d109e291230d8b34acbd45be57"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35b090b4435288fc768b65fc64840f41c6949d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"5de8e847_7f083140","updated":"2023-07-12 16:13:21.000000000","message":"LGTM, thanks for adding the release note","commit_id":"7a059c440abf74a2ca1fb583dbd73c13144cf93d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8239ef76a5a9e3c8530a13d6d0d012c5f6414367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"704f6b6c_4c8eb8be","updated":"2023-07-13 06:54:53.000000000","message":"Added a small fix for test_source_ip_port_sctp_traffic with the ovn-provider","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2ff641de5b7ad1098324373595b8d502b2040857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"26e91ede_c0128b92","updated":"2023-07-13 16:16:45.000000000","message":"LGTM","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"5acaa9decf8cb209598306500c86fc7341b6b7be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"1ab85827_35220358","updated":"2023-07-13 06:56:00.000000000","message":"Note that the ovn-octavia-provider has already enabled those sctp tests: https://opendev.org/openstack/ovn-octavia-provider/src/branch/master/zuul.d/base.yaml#L104","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5d468a09fdd39d67ba0795c54b8c25848f7b7a80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"ad50d7ca_b943fdcb","updated":"2023-10-26 13:28:57.000000000","message":"Thanks Greg","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"39d77a681677dfd3f260a7c6799153491ba6447e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"75215409_3172b407","updated":"2023-07-13 10:12:07.000000000","message":"recheck random issue with ovn-provider job","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"27f9e985_11291cba","updated":"2023-12-05 18:08:59.000000000","message":"Just a few minor comments.","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"157d34d688665afca092491b28a47362df1a33bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"8da5d148_6dc82957","updated":"2023-12-05 13:16:18.000000000","message":"The function name can be fixed in a follow-up change","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"}],"devstack/functions.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"39460871f69e0b19a16cb294dc3bf4716238be91","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    local new_name\u003d$2"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Saving the same function again after redefining it could produce a"},{"line_number":14,"context_line":"    # recorsive function in case for example this plugin is sourced twice"},{"line_number":15,"context_line":"    if type -t \"${new_name}\"; then"},{"line_number":16,"context_line":"        # Prevent copying the same function twice"},{"line_number":17,"context_line":"        return 0"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f621f24_9635a1fa","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":15},"updated":"2020-10-30 15:36:05.000000000","message":"super nit: recursive","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3105396737c939a31d07307c665c941ba7c9a87c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    local new_name\u003d$2"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Saving the same function again after redefining it could produce a"},{"line_number":14,"context_line":"    # recorsive function in case for example this plugin is sourced twice"},{"line_number":15,"context_line":"    if type -t \"${new_name}\"; then"},{"line_number":16,"context_line":"        # Prevent copying the same function twice"},{"line_number":17,"context_line":"        return 0"}],"source_content_type":"text/x-sh","patch_set":13,"id":"e74dc1f7_1381ad8a","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":15},"in_reply_to":"1f621f24_9635a1fa","updated":"2020-12-11 16:17:06.000000000","message":"done","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"}],"octavia_tempest_plugin/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":249,"context_line":"                deprecated_reason\u003d\u0027Consolidated into the RBAC_test_type \u0027"},{"line_number":250,"context_line":"                                  \u0027setting.\u0027,"},{"line_number":251,"context_line":"                deprecated_since\u003d\u0027bobcat\u0027),"},{"line_number":252,"context_line":"    cfg.BoolOpt(\u0027test_sctp_protocol\u0027,"},{"line_number":253,"context_line":"                default\u003dFalse,"},{"line_number":254,"context_line":"                help\u003d\u0027When true the SCTP scenario tests with testing servers \u0027"},{"line_number":255,"context_line":"                     \u0027will be run.\u0027),"}],"source_content_type":"text/x-python","patch_set":36,"id":"2138b7e7_02074911","line":252,"updated":"2023-12-05 18:08:59.000000000","message":"Can we add a comment that the only reason this is needed is for the kernel module and cirros version?\nI don\u0027t want people to come along and start adding a bunch of these instead of checking the API version. It will help us remember why we needed to do this and maybe point out to people that their tempest hosts will need additional packages installed.","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"}],"octavia_tempest_plugin/contrib/test_server/test_server.go":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5d468a09fdd39d67ba0795c54b8c25848f7b7a80","unresolved":true,"context_lines":[{"line_number":271,"context_line":"\t\t\tfmt.Println(err)"},{"line_number":272,"context_line":"\t\t\treturn"},{"line_number":273,"context_line":"\t\t}"},{"line_number":274,"context_line":"\t\tconn.Close()"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"}"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-go","patch_set":35,"id":"a9015b86_5729f54d","line":274,"range":{"start_line":274,"start_character":2,"end_line":274,"end_character":14},"updated":"2023-10-26 13:28:57.000000000","message":"Do we have to accept (#259) and close (#274) every time?\nCan\u0027t we accept the connection before that for {} loop and defer conn.Close?","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"67675274b2e123a71e40adcefc2c2a8066e613c9","unresolved":true,"context_lines":[{"line_number":271,"context_line":"\t\t\tfmt.Println(err)"},{"line_number":272,"context_line":"\t\t\treturn"},{"line_number":273,"context_line":"\t\t}"},{"line_number":274,"context_line":"\t\tconn.Close()"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"}"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-go","patch_set":35,"id":"bf57a73d_458f4b95","line":274,"range":{"start_line":274,"start_character":2,"end_line":274,"end_character":14},"in_reply_to":"974c4fb7_8ea3106e","updated":"2023-12-05 10:56:40.000000000","message":"yes, it accepts one sctp connection at a time, the behavior is similar to the udp tests","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7fd21846660908a6c588ab1315168927c814a8ae","unresolved":true,"context_lines":[{"line_number":271,"context_line":"\t\t\tfmt.Println(err)"},{"line_number":272,"context_line":"\t\t\treturn"},{"line_number":273,"context_line":"\t\t}"},{"line_number":274,"context_line":"\t\tconn.Close()"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"}"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-go","patch_set":35,"id":"974c4fb7_8ea3106e","line":274,"range":{"start_line":274,"start_character":2,"end_line":274,"end_character":14},"in_reply_to":"a9015b86_5729f54d","updated":"2023-10-26 13:29:53.000000000","message":"btw I can test it on my env if you would like to give it a try","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"157d34d688665afca092491b28a47362df1a33bf","unresolved":true,"context_lines":[{"line_number":326,"context_line":"\t}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"\tgo httpServe(*portPtr, *idPtr)"},{"line_number":329,"context_line":"\tgo sctp_serve(*portPtr, *idPtr)"},{"line_number":330,"context_line":"\tudpServe(*portPtr, *idPtr)"},{"line_number":331,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":36,"id":"446d75cb_2192cc42","line":329,"range":{"start_line":329,"start_character":4,"end_line":329,"end_character":14},"updated":"2023-12-05 13:16:18.000000000","message":"Naming scheme should be consistent. Better use `sctpServe`[1].\n\n[1]: https://go.dev/doc/effective_go#mixed-caps","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f65e4c12344236a0de221dc373da065f7ef2a73c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"\t}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"\tgo httpServe(*portPtr, *idPtr)"},{"line_number":329,"context_line":"\tgo sctp_serve(*portPtr, *idPtr)"},{"line_number":330,"context_line":"\tudpServe(*portPtr, *idPtr)"},{"line_number":331,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":36,"id":"deb7afeb_fcb83d19","line":329,"range":{"start_line":329,"start_character":4,"end_line":329,"end_character":14},"in_reply_to":"446d75cb_2192cc42","updated":"2023-12-05 13:19:40.000000000","message":"Done","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"}],"octavia_tempest_plugin/tests/scenario/v2/test_ipv6_traffic_ops.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"484664b4e525ee214c4493dc5150cb21b0486891","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if (protocol \u003d\u003d const.SCTP and"},{"line_number":91,"context_line":"                not self.mem_listener_client.is_version_supported("},{"line_number":92,"context_line":"                    self.api_version, \u00272.23\u0027)):"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_e43f5e83","line":91,"updated":"2020-09-24 17:38:57.000000000","message":"pep8: F821 undefined name \u0027self\u0027","commit_id":"f4e6c906a96d122b9957016d0896b115a019473b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"484664b4e525ee214c4493dc5150cb21b0486891","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if (protocol \u003d\u003d const.SCTP and"},{"line_number":91,"context_line":"                not self.mem_listener_client.is_version_supported("},{"line_number":92,"context_line":"                    self.api_version, \u00272.23\u0027)):"},{"line_number":93,"context_line":"            return"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        waiters.wait_for_status(cls.mem_lb_client.show_loadbalancer,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_444a8a26","line":92,"updated":"2020-09-24 17:38:57.000000000","message":"pep8: F821 undefined name \u0027self\u0027","commit_id":"f4e6c906a96d122b9957016d0896b115a019473b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"39460871f69e0b19a16cb294dc3bf4716238be91","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        cls._listener_pool_create(const.UDP, 8080)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        cls._listener_pool_create(const.SCTP, 8080)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def _listener_pool_create(cls, protocol, protocol_port,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f621f24_99515212","line":80,"range":{"start_line":80,"start_character":46,"end_line":80,"end_character":50},"updated":"2020-10-30 15:36:05.000000000","message":"Obviously this works, but should it be 8081 just for clarity?","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3105396737c939a31d07307c665c941ba7c9a87c","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        cls._listener_pool_create(const.UDP, 8080)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        cls._listener_pool_create(const.SCTP, 8080)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def _listener_pool_create(cls, protocol, protocol_port,"}],"source_content_type":"text/x-python","patch_set":13,"id":"011c53fc_d4d4a983","line":80,"range":{"start_line":80,"start_character":46,"end_line":80,"end_character":50},"in_reply_to":"1f621f24_99515212","updated":"2020-12-11 16:17:06.000000000","message":"TCP and HTTP must obviously use different port numbers, UDP uses another port number because of a bug in stein(?) that was fixed in recent releases by changing a primary key the DB.\nSo I think it\u0027s pretty safe to use 8080 for SCTP","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"}],"octavia_tempest_plugin/tests/scenario/v2/test_listener.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"157d34d688665afca092491b28a47362df1a33bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"84ab571f_ebddfb11","updated":"2023-12-05 13:16:18.000000000","message":"We could avoiding creating copies of essentially the same test method (DRY) by parametrizing one single test method. It seems `unittest` cannot do it without an extra package like https://github.com/wolever/parameterized. That\u0027s sad. Other test frameworks have built in support for that.","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"16019355_4dbbb1df","in_reply_to":"84ab571f_ebddfb11","updated":"2023-12-05 18:08:59.000000000","message":"We can\u0027t use tools like that because we need to maintain the idempotent_id for the refstack tracking. We can use private methods however to keep the code DRY.","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"}],"octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"95fd42156bb42cd50246edec29547b8fd974d99b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"    @decorators.idempotent_id(\u0027469c4b35-6d5a-492b-aa5d-622400e9a585\u0027)"},{"line_number":514,"context_line":"    def test_healthmonitor_sctp_traffic(self):"},{"line_number":515,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create(const.SCTP, 8081)"},{"line_number":516,"context_line":"        self._test_healthmonitor_traffic(const.SCTP, 8081, listener_id, pool_id)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    @decorators.idempotent_id(\u00273558186d-6dcd-4d9d-b7f7-adc190b66149\u0027)"},{"line_number":519,"context_line":"    def test_http_l7policies_and_l7rules(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_df4fc18f","line":516,"updated":"2020-09-22 10:31:13.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"f53972d91f6263f243043409a63570dc603aff66"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"39460871f69e0b19a16cb294dc3bf4716238be91","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u002767f7942a-cb79-4f8a-91b5-cd8238725ae0\u0027)"},{"line_number":242,"context_line":"    def test_basic_sctp_traffic(self):"},{"line_number":243,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create(const.SCTP, 8080)"},{"line_number":244,"context_line":"        self._test_basic_traffic(const.SCTP, 8080, listener_id, pool_id)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _test_healthmonitor_traffic(self, protocol, protocol_port,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f621f24_d9a90ae0","line":243,"range":{"start_line":243,"start_character":70,"end_line":243,"end_character":74},"updated":"2020-10-30 15:36:05.000000000","message":"Same comment about port numbers being unique, and 808x below too.","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5d468a09fdd39d67ba0795c54b8c25848f7b7a80","unresolved":true,"context_lines":[{"line_number":510,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":511,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027469c4b35-6d5a-492b-aa5d-622400e9a585\u0027)"},{"line_number":513,"context_line":"    def test_healthmonitor_sctp_traffic(self):"},{"line_number":514,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create(const.SCTP, 8081)"},{"line_number":515,"context_line":"        self._test_healthmonitor_traffic(const.SCTP, 8081, pool_id)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    @decorators.idempotent_id(\u00273558186d-6dcd-4d9d-b7f7-adc190b66149\u0027)"},{"line_number":518,"context_line":"    def test_http_l7policies_and_l7rules(self):"}],"source_content_type":"text/x-python","patch_set":35,"id":"1f384d93_1925a5a1","line":515,"range":{"start_line":513,"start_character":4,"end_line":515,"end_character":67},"updated":"2023-10-26 13:28:57.000000000","message":"should it have a \n@testtools.skipIf(CONF.load_balancer.test_with_noop,\n                      \u0027Traffic tests will not work in noop mode.\u0027)\nas well?","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"67675274b2e123a71e40adcefc2c2a8066e613c9","unresolved":true,"context_lines":[{"line_number":510,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":511,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027469c4b35-6d5a-492b-aa5d-622400e9a585\u0027)"},{"line_number":513,"context_line":"    def test_healthmonitor_sctp_traffic(self):"},{"line_number":514,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create(const.SCTP, 8081)"},{"line_number":515,"context_line":"        self._test_healthmonitor_traffic(const.SCTP, 8081, pool_id)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    @decorators.idempotent_id(\u00273558186d-6dcd-4d9d-b7f7-adc190b66149\u0027)"},{"line_number":518,"context_line":"    def test_http_l7policies_and_l7rules(self):"}],"source_content_type":"text/x-python","patch_set":35,"id":"acae5714_132410b8","line":515,"range":{"start_line":513,"start_character":4,"end_line":515,"end_character":67},"in_reply_to":"1f384d93_1925a5a1","updated":"2023-12-05 10:56:40.000000000","message":"this condition is checked at the class-level, we don\u0027t need to have it for each method","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":294,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":295,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":296,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u002767f7942a-cb79-4f8a-91b5-cd8238725ae0\u0027)"},{"line_number":298,"context_line":"    def test_basic_sctp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"b10d2921_f2ef1f4e","line":295,"updated":"2023-12-05 18:08:59.000000000","message":"Why do we need this? Isn\u0027t it already covered on line 47 in the skip_checks?","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"92efbdbecd851389fd1d378bfb0e5a3cfded5178","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":294,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":295,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":296,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u002767f7942a-cb79-4f8a-91b5-cd8238725ae0\u0027)"},{"line_number":298,"context_line":"    def test_basic_sctp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"b2a9975b_9873b4f9","line":295,"in_reply_to":"b10d2921_f2ef1f4e","updated":"2025-09-11 13:03:24.000000000","message":"ack, it\u0027s also included in the other traffic tests, I\u0027m going to remove it and I\u0027ll propose a followup patch to remove it from the other test functions","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":864,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":865,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":866,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":867,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_with_ipv6,"},{"line_number":868,"context_line":"                          \u0027Mixed IPv4/IPv6 member test requires IPv6.\u0027)"}],"source_content_type":"text/x-python","patch_set":36,"id":"3d94f84b_661e3881","line":865,"updated":"2023-12-05 18:08:59.000000000","message":"Why do we need this? Isn\u0027t it already covered on line 47 in the skip_checks?","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":914,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":915,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":916,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":917,"context_line":"    @decorators.idempotent_id(\u00277d21dfb2-48c3-4096-99f4-ffeccef409e4\u0027)"},{"line_number":918,"context_line":"    def test_least_connections_sctp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ee62c40c_f59f383a","line":915,"updated":"2023-12-05 18:08:59.000000000","message":"Why do we need this? Isn\u0027t it already covered on line 47 in the skip_checks?","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":958,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":959,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":960,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":961,"context_line":"    @decorators.idempotent_id(\u0027c1420dda-6d5b-4f87-9218-b8ac5e687168\u0027)"},{"line_number":962,"context_line":"    def test_source_ip_sctp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ceeded9e_a14962b5","line":959,"updated":"2023-12-05 18:08:59.000000000","message":"Why do we need this? Isn\u0027t it already covered on line 47 in the skip_checks?","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3c7b16a4e6ffd4233de16074eb3d773027a1f014","unresolved":true,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    @testtools.skipUnless(CONF.load_balancer.test_sctp_protocol,"},{"line_number":1042,"context_line":"                          \u0027SCTP testing is disabled.\u0027)"},{"line_number":1043,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":1044,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":1045,"context_line":"    @decorators.idempotent_id(\u00270d4b743f-bbe6-4c4c-b1dd-5936768d544a\u0027)"},{"line_number":1046,"context_line":"    def test_source_ip_port_sctp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"8a1426da_261e6861","line":1043,"updated":"2023-12-05 18:08:59.000000000","message":"Why do we need this? Isn\u0027t it already covered on line 47 in the skip_checks?","commit_id":"9e11c84cb26ea56073e655a497f0b35cdad8cfa1"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8f052a6600da7ca0ccf930fd9e8e6c0b83e3074b","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"                                             timeout\u003d2)"},{"line_number":1037,"context_line":"                elif protocol \u003d\u003d const.SCTP:"},{"line_number":1038,"context_line":"                    data \u003d self._sctp_request(vip_address, port\u003dprotocol_port,"},{"line_number":1039,"context_line":"                                             timeout\u003d2)"},{"line_number":1040,"context_line":"                else:"},{"line_number":1041,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":1042,"context_line":"                        protocol.lower(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_732637bd","line":1039,"updated":"2020-06-30 15:51:56.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"b0a869c7fc7920846e1d68b73dda79d48845e816"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8f052a6600da7ca0ccf930fd9e8e6c0b83e3074b","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                                             timeout\u003d2)"},{"line_number":1078,"context_line":"                elif protocol \u003d\u003d const.SCTP:"},{"line_number":1079,"context_line":"                    data \u003d self._sctp_request(vip_address, port\u003dprotocol_port,"},{"line_number":1080,"context_line":"                                             timeout\u003d2)"},{"line_number":1081,"context_line":"                else:"},{"line_number":1082,"context_line":"                    url \u003d \"{0}://{1}{2}{3}\".format("},{"line_number":1083,"context_line":"                        protocol.lower(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_532b3381","line":1080,"updated":"2020-06-30 15:51:56.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"b0a869c7fc7920846e1d68b73dda79d48845e816"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"39460871f69e0b19a16cb294dc3bf4716238be91","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                protocol\u003d\u0027sctp\u0027,"},{"line_number":577,"context_line":"                ethertype\u003d\u0027IPv4\u0027,"},{"line_number":578,"context_line":"                port_range_min\u003d80,"},{"line_number":579,"context_line":"                port_range_max\u003d81)[\u0027security_group_rule\u0027]"},{"line_number":580,"context_line":"            cls.addClassResourceCleanup("},{"line_number":581,"context_line":"                waiters.wait_for_not_found,"},{"line_number":582,"context_line":"                cls.lb_mem_SGr_client.delete_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f621f24_79e6f646","line":579,"updated":"2020-10-30 15:36:05.000000000","message":"I think it\u0027s Ok to do this not under the conf setting, since it should succeed regardless.","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3105396737c939a31d07307c665c941ba7c9a87c","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                protocol\u003d\u0027sctp\u0027,"},{"line_number":577,"context_line":"                ethertype\u003d\u0027IPv4\u0027,"},{"line_number":578,"context_line":"                port_range_min\u003d80,"},{"line_number":579,"context_line":"                port_range_max\u003d81)[\u0027security_group_rule\u0027]"},{"line_number":580,"context_line":"            cls.addClassResourceCleanup("},{"line_number":581,"context_line":"                waiters.wait_for_not_found,"},{"line_number":582,"context_line":"                cls.lb_mem_SGr_client.delete_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1e01b761_e7b7b578","line":579,"in_reply_to":"1f621f24_79e6f646","updated":"2020-12-11 16:17:06.000000000","message":"Yes, I could add a condition on test_sctp_protocol here, because SCTP traffic tests are only used when test_sctp_protocol is set (but SCTP API tests are always run).","commit_id":"fa6ba36a5f0ae139dc322d4d101c3e4ec26756dd"}],"octavia_tempest_plugin/tests/validators.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"95fd42156bb42cd50246edec29547b8fd974d99b","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @classmethod"},{"line_number":178,"context_line":"    def make_sctp_request(cls, vip_address, port\u003d80, timeout\u003dNone,"},{"line_number":179,"context_line":"                         source_port\u003dNone):"},{"line_number":180,"context_line":"        if ipaddress.ip_address(vip_address).version \u003d\u003d 6:"},{"line_number":181,"context_line":"            family \u003d socket.AF_INET6"},{"line_number":182,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_ff4a8580","line":179,"updated":"2020-09-22 10:31:13.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"f53972d91f6263f243043409a63570dc603aff66"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5d468a09fdd39d67ba0795c54b8c25848f7b7a80","unresolved":true,"context_lines":[{"line_number":421,"context_line":"                parsed_url \u003d urlparse(url)"},{"line_number":422,"context_line":"                if expect_connection_error:"},{"line_number":423,"context_line":"                    self.assertRaises(exceptions.TimeoutException,"},{"line_number":424,"context_line":"                                      self.make_udp_request,"},{"line_number":425,"context_line":"                                      parsed_url.hostname,"},{"line_number":426,"context_line":"                                      port\u003dparsed_url.port, timeout\u003dtimeout)"},{"line_number":427,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":35,"id":"d7fc53a9_6e35a27b","line":424,"range":{"start_line":424,"start_character":48,"end_line":424,"end_character":51},"updated":"2023-10-26 13:28:57.000000000","message":"sctp","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"67675274b2e123a71e40adcefc2c2a8066e613c9","unresolved":true,"context_lines":[{"line_number":421,"context_line":"                parsed_url \u003d urlparse(url)"},{"line_number":422,"context_line":"                if expect_connection_error:"},{"line_number":423,"context_line":"                    self.assertRaises(exceptions.TimeoutException,"},{"line_number":424,"context_line":"                                      self.make_udp_request,"},{"line_number":425,"context_line":"                                      parsed_url.hostname,"},{"line_number":426,"context_line":"                                      port\u003dparsed_url.port, timeout\u003dtimeout)"},{"line_number":427,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":35,"id":"530b6a50_6933906e","line":424,"range":{"start_line":424,"start_character":48,"end_line":424,"end_character":51},"in_reply_to":"d7fc53a9_6e35a27b","updated":"2023-12-05 10:56:40.000000000","message":"good catch","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5d468a09fdd39d67ba0795c54b8c25848f7b7a80","unresolved":true,"context_lines":[{"line_number":1189,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":1190,"context_line":"            load_balancer:"},{"line_number":1191,"context_line":"              test_sctp_protocol: True"},{"line_number":1192,"context_line":"      tempest_test_regex: ^octavia_tempest_plugin.tests.scenario.v2.*sctp"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"######### Third party jobs ##########"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"8cf6c635_0c5edc01","line":1192,"range":{"start_line":1192,"start_character":27,"end_line":1192,"end_character":73},"updated":"2023-10-26 13:28:57.000000000","message":"I don\u0027t see any file with that suffix","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"67675274b2e123a71e40adcefc2c2a8066e613c9","unresolved":true,"context_lines":[{"line_number":1189,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":1190,"context_line":"            load_balancer:"},{"line_number":1191,"context_line":"              test_sctp_protocol: True"},{"line_number":1192,"context_line":"      tempest_test_regex: ^octavia_tempest_plugin.tests.scenario.v2.*sctp"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"######### Third party jobs ##########"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2928d154_57768ece","line":1192,"range":{"start_line":1192,"start_character":27,"end_line":1192,"end_character":73},"in_reply_to":"8cf6c635_0c5edc01","updated":"2023-12-05 10:56:40.000000000","message":"it matches the test_healthmonitor_sctp_traffic method for instance","commit_id":"cdeb82c9b3d3832454b2eaba37588bdfe229403d"}]}