)]}'
{"id":"openstack%2Foctavia-tempest-plugin~738678","triplet_id":"openstack%2Foctavia-tempest-plugin~master~Ic103d8bededfec77ec0034d7c167ac1e49954a5c","project":"openstack/octavia-tempest-plugin","branch":"master","hashtags":[],"change_id":"Ic103d8bededfec77ec0034d7c167ac1e49954a5c","subject":"Apply Octavia hacking checks to the tempest plugin","status":"MERGED","created":"2020-06-30 17:30:31.000000000","updated":"2020-07-01 22:34:59.000000000","submitted":"2020-07-01 22:33:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"738678-1593642789155-260f2999","meta_rev_id":"22bc404dc4e9d1dbe65814350883b6f1a9a992b0","_number":738678,"virtual_id_number":738678,"owner":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-01 22:33:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2020-07-01 09:50:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":2,"date":"2020-07-01 20:16:48.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":1,"date":"2020-07-01 16:14:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":1,"date":"2020-07-01 20:16:48.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-01 09:50:49.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2020-07-01 16:14:10.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2020-07-01 20:16:48.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2020-07-01 22:33:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"06bea7902a6851881aa206194becbf06096c18af","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-30 17:30:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9bda9d0e4be3d63589ad40ddf34ef7a3ba3b2dbb","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-30 17:53:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"71823a7ce7e57adf6ae08ba708bea9afd4983fc9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 20:35:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a8a1c8341a249d3b3f33d68b9a23573 : SUCCESS in 10m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2d81c1d3ea034e81974ed124f6b30194 : SUCCESS in 5m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6e4966a645e9427289fe30506a132644 : SUCCESS in 5m 05s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/0802f429de844d11a78d11cffa7b52e0 : SUCCESS in 54m 09s\n- octavia-v2-dsvm-noop-api-stable-train https://zuul.opendev.org/t/openstack/build/bbfd8da005d14d70977ab073176cf094 : SUCCESS in 45m 43s\n- octavia-v2-dsvm-noop-api-stable-stein https://zuul.opendev.org/t/openstack/build/adc5903ebd7e428794b66fe5919884fe : SUCCESS in 48m 58s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/007de97bb0de44db91714498fc15f375 : SUCCESS in 1h 51m 38s\n- octavia-v2-dsvm-scenario-stable-train https://zuul.opendev.org/t/openstack/build/ea46d0ad1b8342bbb90e640a3652c73e : SUCCESS in 1h 55m 21s\n- octavia-v2-dsvm-scenario-stable-stein https://zuul.opendev.org/t/openstack/build/123de54180b940739759d901b22b1f4b : SUCCESS in 1h 37m 17s\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/bca03d3397c54dcaa0918e950389d6c0 : TIMED_OUT in 2h 33m 18s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/cd7d0e5b4a0647bfb4cabbcde86cab70 : FAILURE in 46m 59s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/f6f5f6186a054d079f92e3b93b9c6b23 : SUCCESS in 1h 18m 20s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/4ca9ea3949b94309bb58222249326933 : SUCCESS in 52m 19s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-stable-train https://zuul.opendev.org/t/openstack/build/24cf00c8b82a4055a92876880806bc4c : SUCCESS in 1h 04m 06s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-stable-stein https://zuul.opendev.org/t/openstack/build/5ccbaed19ad749fd8e492b7b74fc94c4 : FAILURE in 41m 20s (non-voting)\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/da6a95d7fb7c4dd9bb9be81e32dac49f : SUCCESS in 56m 55s (non-voting)\n- octavia-v2-dsvm-tls-barbican-stable-train https://zuul.opendev.org/t/openstack/build/28b6ff7882be4f859427f1e5ca25321f : SUCCESS in 57m 06s (non-voting)\n- octavia-v2-dsvm-tls-barbican-stable-stein https://zuul.opendev.org/t/openstack/build/bb57cbdfc38a41a19e8469b3e9357295 : SUCCESS in 1h 03m 43s (non-voting)\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/aecaa559b4d84556a0819b5604fb48eb : SUCCESS in 57m 50s (non-voting)\n- octavia-v2-dsvm-spare-pool-stable-train https://zuul.opendev.org/t/openstack/build/af230778b4154f5a85903ee328cf804d : SUCCESS in 37m 38s (non-voting)\n- octavia-v2-dsvm-spare-pool-stable-stein https://zuul.opendev.org/t/openstack/build/4fb5568c6b1a4e6abd75314f51e04cab : SUCCESS in 56m 51s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/7b5f09a611114f5697c4b762c434c02d : SUCCESS in 1h 45m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0e216d608cc649d6f1a7f6e4b5bf4fb6a9cb4870","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2020-07-01 09:50:49.000000000","message":"Patch Set 2: Code-Review+2\n\nWow, yeah, thanks!","accounts_in_message":[],"_revision_number":2},{"id":"39ce735d7f497ae483506c88381c659478ebc6ad","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2020-07-01 16:14:10.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1ed6f6c374606113409df4a167587566b2668871","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-07-01 20:16:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0a5506649cebe19159ccb84eb055d29bc5696f19","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 20:17:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"df3490b126e1175463bda4b7d14f7858623eba3c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 22:33:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1142555fd46f4a50a20269ad0239e690 : SUCCESS in 6m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1474f916e9884ab19f0add8b4d55d5d8 : SUCCESS in 3m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4f6df50f67a94571b8e3b6c28f11dfd5 : SUCCESS in 5m 02s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/892294e8c05e4cf5b11ff8f8c77194ca : SUCCESS in 42m 25s\n- octavia-v2-dsvm-noop-api-stable-train https://zuul.opendev.org/t/openstack/build/27804c6f1022404f9e78724fdae6fc5b : SUCCESS in 45m 14s\n- octavia-v2-dsvm-noop-api-stable-stein https://zuul.opendev.org/t/openstack/build/d26c8d8d095f40a7a9f658e00a37bf65 : SUCCESS in 44m 10s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/062bfd6ea05c4ef1919c3aa53ebf2765 : SUCCESS in 1h 44m 56s\n- octavia-v2-dsvm-scenario-stable-train https://zuul.opendev.org/t/openstack/build/5cb4ab0a7b8d4326869a34d03b26efe9 : SUCCESS in 2h 12m 09s\n- octavia-v2-dsvm-scenario-stable-stein https://zuul.opendev.org/t/openstack/build/3723a8e04e64457aa3815dee525c78c7 : SUCCESS in 1h 05m 20s","accounts_in_message":[],"_revision_number":2},{"id":"8bcbce12cdf46155aa62d46f636bc9446d849648","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 22:33:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"22bc404dc4e9d1dbe65814350883b6f1a9a992b0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 22:34:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6babe4998f2444ea8fd9afaf19dc9b5a : SUCCESS in 1m 34s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fd3e5c030dc8406d85bf2ca39bbff172 : SUCCESS in 1m 30s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a5074259fb686f92057ae6313fa620471840de0e","revisions":{"baec8cc9a27278e68a1f78b5f3c527fa69080e3c":{"kind":"REWORK","_number":1,"created":"2020-06-30 17:30:31.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/78/738678/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-tempest-plugin","ref":"refs/changes/78/738678/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/1"}}},"commit":{"parents":[{"commit":"5506c00b8d8972e6223499dd5a5da4c85c1ff836","subject":"Merge \"Fix hacking min version to 3.0.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/5506c00b8d8972e6223499dd5a5da4c85c1ff836"}]}],"author":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-30 17:28:09.000000000","tz":-420},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-30 17:30:30.000000000","tz":-420},"subject":"Apply Octavia hacking checks to the tempest plugin","message":"Apply Octavia hacking checks to the tempest plugin\n\nCurrently we are not applying the custom hacking checks we use in\nOctavia to the octavia-tempest-plugin. This leads to style issues\nsneaking into the plugin.\nThis patch copies the same checks from Octavia (for simpler\nmanagement) into octavia-tempest-plugin and resolves some of the\nexisting style violations.\n\nChange-Id: Ic103d8bededfec77ec0034d7c167ac1e49954a5c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/baec8cc9a27278e68a1f78b5f3c527fa69080e3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/baec8cc9a27278e68a1f78b5f3c527fa69080e3c"}]},"branch":"refs/heads/master"},"a5074259fb686f92057ae6313fa620471840de0e":{"kind":"REWORK","_number":2,"created":"2020-06-30 17:53:00.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/78/738678/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-tempest-plugin","ref":"refs/changes/78/738678/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/78/738678/2"}}},"commit":{"parents":[{"commit":"5506c00b8d8972e6223499dd5a5da4c85c1ff836","subject":"Merge \"Fix hacking min version to 3.0.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/5506c00b8d8972e6223499dd5a5da4c85c1ff836"}]}],"author":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-30 17:28:09.000000000","tz":-420},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-30 17:52:55.000000000","tz":-420},"subject":"Apply Octavia hacking checks to the tempest plugin","message":"Apply Octavia hacking checks to the tempest plugin\n\nCurrently we are not applying the custom hacking checks we use in\nOctavia to the octavia-tempest-plugin. This leads to style issues\nsneaking into the plugin.\nThis patch copies the same checks from Octavia (for simpler\nmanagement) into octavia-tempest-plugin and resolves some of the\nexisting style violations.\n\nChange-Id: Ic103d8bededfec77ec0034d7c167ac1e49954a5c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/a5074259fb686f92057ae6313fa620471840de0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/a5074259fb686f92057ae6313fa620471840de0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}