)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3eaa28238834772d511b6f60ee77daec5434a3a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adjust API tests for NotImplemented skip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a patch to restructrue the API tests to use the"},{"line_number":10,"context_line":"new skip_if_not_implemented capability."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/745239"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9f560f44_729fba01","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":30},"updated":"2020-09-08 18:09:02.000000000","message":"nit: restructure","commit_id":"5d92feb223b83cd246f4ac2df8361db2dec5902c"}],"octavia_tempest_plugin/tests/api/v2/test_healthmonitor.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def skip_checks(cls):"},{"line_number":38,"context_line":"        super(HealthMonitorAPITest, cls).skip_checks()"},{"line_number":39,"context_line":"        if not CONF.loadbalancer_feature_enabled.health_monitor_enabled:"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Health Monitors not supported\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_b57269af","side":"PARENT","line":39,"range":{"start_line":39,"start_character":49,"end_line":39,"end_character":71},"updated":"2020-09-15 07:49:15.000000000","message":"Config option no longer used. Please either deprecate or simply remove it in config.py","commit_id":"89bdbcd1252dbce8645c24fa6db3e2d32fa779c3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b9ab89be27b9f6546b6a3812306257f18ea83d1a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def skip_checks(cls):"},{"line_number":38,"context_line":"        super(HealthMonitorAPITest, cls).skip_checks()"},{"line_number":39,"context_line":"        if not CONF.loadbalancer_feature_enabled.health_monitor_enabled:"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Health Monitors not supported\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_64e005fa","side":"PARENT","line":39,"range":{"start_line":39,"start_character":49,"end_line":39,"end_character":71},"in_reply_to":"9f560f44_b57269af","updated":"2020-09-16 17:20:38.000000000","message":"Yeah, the removal of all of the \"feature_enabled\" settings is planned for a follow up patch.","commit_id":"89bdbcd1252dbce8645c24fa6db3e2d32fa779c3"}],"octavia_tempest_plugin/tests/api/v2/test_l7policy.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027[loadbalancer-feature-enabled] \u0027"},{"line_number":40,"context_line":"                \u0027\"l7_protocol_enabled\" is set to False in the Tempest \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_156355df","side":"PARENT","line":37,"range":{"start_line":37,"start_character":49,"end_line":37,"end_character":68},"updated":"2020-09-15 07:49:15.000000000","message":"Config option no longer used. Please either deprecate or simply remove it in config.py","commit_id":"89bdbcd1252dbce8645c24fa6db3e2d32fa779c3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b9ab89be27b9f6546b6a3812306257f18ea83d1a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(L7PolicyAPITest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.loadbalancer_feature_enabled.l7_protocol_enabled:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027[loadbalancer-feature-enabled] \u0027"},{"line_number":40,"context_line":"                \u0027\"l7_protocol_enabled\" is set to False in the Tempest \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_a4ea1dd5","side":"PARENT","line":37,"range":{"start_line":37,"start_character":49,"end_line":37,"end_character":68},"in_reply_to":"9f560f44_156355df","updated":"2020-09-16 17:20:38.000000000","message":"The removal of the feature enabled settings is planned for a follow up patch.","commit_id":"89bdbcd1252dbce8645c24fa6db3e2d32fa779c3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        pool_kwargs \u003d {"},{"line_number":78,"context_line":"            const.NAME: pool_name,"},{"line_number":79,"context_line":"            const.PROTOCOL: const.HTTP,"},{"line_number":80,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":81,"context_line":"            const.LOADBALANCER_ID: cls.lb_id,"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_b2c39f06","line":80,"updated":"2020-09-15 07:49:15.000000000","message":"Hmm, this would fail for provider drivers not implementing round-robin.","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b9ab89be27b9f6546b6a3812306257f18ea83d1a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        pool_kwargs \u003d {"},{"line_number":78,"context_line":"            const.NAME: pool_name,"},{"line_number":79,"context_line":"            const.PROTOCOL: const.HTTP,"},{"line_number":80,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":81,"context_line":"            const.LOADBALANCER_ID: cls.lb_id,"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_c4c63169","line":80,"in_reply_to":"9f560f44_b2c39f06","updated":"2020-09-16 17:20:38.000000000","message":"Yes. There is more work to do for sure.\nI\u0027m just a bit concerned with patch size.","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"}],"octavia_tempest_plugin/tests/api/v2/test_l7rule.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        pool_kwargs \u003d {"},{"line_number":78,"context_line":"            const.NAME: pool_name,"},{"line_number":79,"context_line":"            const.PROTOCOL: const.HTTP,"},{"line_number":80,"context_line":"            const.LB_ALGORITHM: const.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":81,"context_line":"            const.LISTENER_ID: cls.listener_id,"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_92c81b22","line":80,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3eaa28238834772d511b6f60ee77daec5434a3a2","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        self._test_listener_delete(const.TCP, 8072)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    @decorators.idempotent_id(\u002786bd9717-e3e9-41e3-86c4-888c64455926\u0027)"},{"line_number":1116,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":1117,"context_line":"    def test_udp_listener_delete(self):"},{"line_number":1118,"context_line":"        self._test_listener_delete(const.UDP, 8073)"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_72b85a74","line":1116,"updated":"2020-09-08 18:09:02.000000000","message":"Seems to be missing the skip decorator used other places in this file.","commit_id":"5d92feb223b83cd246f4ac2df8361db2dec5902c"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.protocol \u003d const.HTTP"},{"line_number":46,"context_line":"        lb_feature_enabled \u003d CONF.loadbalancer_feature_enabled"},{"line_number":47,"context_line":"        if not lb_feature_enabled.l7_protocol_enabled:"},{"line_number":48,"context_line":"            cls.protocol \u003d lb_feature_enabled.l4_protocol"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        lb \u003d cls.mem_lb_client.create_loadbalancer(**lb_kwargs)"},{"line_number":51,"context_line":"        cls.lb_id \u003d lb[const.ID]"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_959c85c0","side":"PARENT","line":48,"range":{"start_line":48,"start_character":46,"end_line":48,"end_character":57},"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"89bdbcd1252dbce8645c24fa6db3e2d32fa779c3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._test_listener_create(const.TCP, 8002)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @decorators.idempotent_id(\u00277b53f336-47bc-45ae-bbd7-4342ef0673fc\u0027)"},{"line_number":75,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":76,"context_line":"    @decorators.skip_because("},{"line_number":77,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":78,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_b291dffa","line":75,"updated":"2020-09-15 07:49:15.000000000","message":"Bug fixed in master branch. Skip can be removed.\nhttps://review.opendev.org/#/c/744948/","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        self._test_listener_list(const.TCP, 8030)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @decorators.idempotent_id(\u0027c08fb77e-b317-4d6f-b430-91f5b27ebac6\u0027)"},{"line_number":375,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":376,"context_line":"    @decorators.skip_because("},{"line_number":377,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":378,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_f26997f8","line":375,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    @decorators.idempotent_id(\u00271dea3a6b-c95b-4e91-b591-1aa9cbcd0d1d\u0027)"},{"line_number":684,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":685,"context_line":"    @decorators.skip_because("},{"line_number":686,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":687,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"},{"line_number":688,"context_line":"        condition\u003dCONF.load_balancer.provider in const.AMPHORA_PROVIDERS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_d26e13ff","line":685,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":848,"context_line":""},{"line_number":849,"context_line":"    @decorators.idempotent_id(\u0027fd02dbfd-39ce-41c2-b181-54fc7ad91707\u0027)"},{"line_number":850,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":851,"context_line":"    @decorators.skip_because("},{"line_number":852,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":853,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"},{"line_number":854,"context_line":"        condition\u003dCONF.load_balancer.provider in const.AMPHORA_PROVIDERS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_12708bda","line":851,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    @decorators.idempotent_id(\u002786bd9717-e3e9-41e3-86c4-888c64455926\u0027)"},{"line_number":1116,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":1117,"context_line":"    @decorators.skip_because("},{"line_number":1118,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":1119,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"},{"line_number":1120,"context_line":"        condition\u003dCONF.load_balancer.provider in const.AMPHORA_PROVIDERS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_72a8e71f","line":1117,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"    @decorators.idempotent_id(\u0027a4c1f199-923b-41e4-a134-c91e590e20c4\u0027)"},{"line_number":1197,"context_line":"    # Skipping due to a status update bug in the amphora driver."},{"line_number":1198,"context_line":"    @decorators.skip_because("},{"line_number":1199,"context_line":"        bug\u003d\u00272007979\u0027,"},{"line_number":1200,"context_line":"        bug_type\u003d\u0027storyboard\u0027,"},{"line_number":1201,"context_line":"        condition\u003dCONF.load_balancer.provider in const.AMPHORA_PROVIDERS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_b25f1f4c","line":1198,"updated":"2020-09-15 07:49:15.000000000","message":"ditto","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"}],"octavia_tempest_plugin/tests/api/v2/test_member.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            raise cls.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":87,"context_line":"                                    \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Cache listener/pool combinations we have already created as"},{"line_number":90,"context_line":"        # they can be reused for member test permutations"},{"line_number":91,"context_line":"        listener_pool_key \u003d listener_protocol + pool_protocol + algorithm"},{"line_number":92,"context_line":"        pool_id \u003d cls.listener_pool_cache.get(listener_pool_key, None)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_1259ab5a","line":89,"updated":"2020-09-15 07:49:15.000000000","message":"Good stuff!","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a25ba7b5896992e3cf8fc0e8b71480297455cc43","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                \"Configuration value test_network_override must be \""},{"line_number":155,"context_line":"                \"specified if test_subnet_override is used.\")"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # TODO(johnsom) Remove this"},{"line_number":158,"context_line":"        # Get loadbalancing algorithms supported by provider driver."},{"line_number":159,"context_line":"        try:"},{"line_number":160,"context_line":"            algorithms \u003d const.SUPPORTED_LB_ALGORITHMS["}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_55166d4b","line":157,"updated":"2020-09-15 07:49:15.000000000","message":"TODO in this change?","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b9ab89be27b9f6546b6a3812306257f18ea83d1a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                \"Configuration value test_network_override must be \""},{"line_number":155,"context_line":"                \"specified if test_subnet_override is used.\")"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # TODO(johnsom) Remove this"},{"line_number":158,"context_line":"        # Get loadbalancing algorithms supported by provider driver."},{"line_number":159,"context_line":"        try:"},{"line_number":160,"context_line":"            algorithms \u003d const.SUPPORTED_LB_ALGORITHMS["}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_44da214b","line":157,"in_reply_to":"9f560f44_55166d4b","updated":"2020-09-16 17:20:38.000000000","message":"I was planning to do the cleanup in a follow up patch.","commit_id":"6a9236ad9ae72cea6add0845c4462a9e44690a42"}]}