)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28777cb910a5543e4aa14c0a95f5036495ce446c","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"        self.assertConsistentResponse("},{"line_number":1329,"context_line":"            (None, None), url_for_vip, repeat\u003d3, expect_connection_error\u003dTrue)"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":1332,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":1333,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1334,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_75a71f52","line":1331,"updated":"2020-09-30 16:54:04.000000000","message":"This is not needed as the whole class will skip if noop is enabled. See line 46.","commit_id":"e989ce5ead532a03d75de3298cc2b16ee2abc6a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28777cb910a5543e4aa14c0a95f5036495ce446c","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"},{"line_number":1332,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":1333,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1334,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1335,"context_line":"        common_port \u003d 80"},{"line_number":1336,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1337,"context_line":"                self.api_version, \u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_954c739e","line":1334,"updated":"2020-09-30 16:54:04.000000000","message":"This is very similar to the existing test in API: https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/api/v2/test_listener.py#L222","commit_id":"e989ce5ead532a03d75de3298cc2b16ee2abc6a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28777cb910a5543e4aa14c0a95f5036495ce446c","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":1333,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1334,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1335,"context_line":"        common_port \u003d 80"},{"line_number":1336,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1337,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1338,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_15586355","line":1335,"updated":"2020-09-30 16:54:04.000000000","message":"Listener ports need to be unique inside a test class as we share a load balancer.\nThis speeds up the test runs and also tests load balancers with multiple listeners configured.","commit_id":"e989ce5ead532a03d75de3298cc2b16ee2abc6a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28777cb910a5543e4aa14c0a95f5036495ce446c","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1338,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":1339,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, common_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic(const.UDP, common_port, listener_id, pool_id)"},{"line_number":1343,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1506a322","line":1340,"updated":"2020-09-30 16:54:04.000000000","message":"Any time we create a resource, like a listener, we must register a cleanup for it. See line 1194 above.","commit_id":"e989ce5ead532a03d75de3298cc2b16ee2abc6a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28777cb910a5543e4aa14c0a95f5036495ce446c","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, common_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic(const.UDP, common_port, listener_id, pool_id)"},{"line_number":1343,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1344,"context_line":"            const.TCP, common_port)"},{"line_number":1345,"context_line":"        self._test_basic_traffic(const.TCP, common_port, listener_id, pool_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f50faf36","line":1342,"updated":"2020-09-30 16:54:04.000000000","message":"You probably need to add some waiters here to make sure the load balancer has transitioned to ACTIVE before testing traffic. See line 1300 above.","commit_id":"e989ce5ead532a03d75de3298cc2b16ee2abc6a6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"baeb00e156bf91b873524e9d665ba8adec94d1de","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"            (None, None), url_for_vip, repeat\u003d3, expect_connection_error\u003dTrue)"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1334,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1335,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1336,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1337,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_edcd0431","line":1334,"range":{"start_line":1334,"start_character":8,"end_line":1334,"end_character":45},"updated":"2020-10-02 17:59:34.000000000","message":"note that stable/stein has a bug that prevents creating listeners of different protocols on the same port number.\nso this test must be skipped on stein","commit_id":"f02f17125ef9fe44b6fd5a14862eccdcf60ed6d6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"eb262ddcdb9951eaf1d8f6abd6a97c147e76087f","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"            (None, None), url_for_vip, repeat\u003d3, expect_connection_error\u003dTrue)"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1334,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1335,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1336,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1337,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0d579829","line":1334,"range":{"start_line":1334,"start_character":8,"end_line":1334,"end_character":45},"in_reply_to":"9f560f44_edcd0431","updated":"2020-10-02 18:13:30.000000000","message":"Now I understand why \"stein\" and \"train\" gates fails :-)\nHow do I skip this test basing on OSP version?\nDo we have some example code, so I\u0027ll just add the same into this test?","commit_id":"f02f17125ef9fe44b6fd5a14862eccdcf60ed6d6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d50cc12ada90aba49d8700f1ad2604b026deaf72","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    common_vip_port \u003d 102  # Used in test_tcp_and_udp_traffic_on_same_port"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_baaaa515","line":38,"updated":"2020-11-12 15:15:03.000000000","message":"I saw Michael\u0027s comment about this port needing to be unique, but I don\u0027t think putting it in the class definition does that.  Maybe just define it in the test and use 8124?  At least I see 8123 used on L992 so +1 from that should be OK.  Is that good Michael?","commit_id":"1b0499ccf853ba438d52d9b8486ddb1cf632e275"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2e52e393e6070e3ab52b48975bfb1ecce75309b4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    common_vip_port \u003d 102  # Used in test_tcp_and_udp_traffic_on_same_port"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_e565a2b6","line":38,"in_reply_to":"1f621f24_baaaa515","updated":"2020-11-12 15:38:25.000000000","message":"Brian - please take a look on: https://review.opendev.org/#/c/755326/8/octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py Lines: 37-44 \n\nI\u0027m waiting for +1/2 on the above patch, once this mechanism will be accepted, I\u0027ll refactor all the existing tests, including this one.\n\nSo as by now in this specific patch, line 38 is a kind of temporal usage.\n\nBTW - you can also pass through the comments in #755326, I think that having this \"pool of ports\" as class attribute is OK for Gregory and Michael (originally it was his suggestion) as far as I understand.","commit_id":"1b0499ccf853ba438d52d9b8486ddb1cf632e275"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d50cc12ada90aba49d8700f1ad2604b026deaf72","unresolved":false,"context_lines":[{"line_number":1335,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1336,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1337,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":1338,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":1339,"context_line":"        # Using listeners on the same port for TCP and UDP was not supported"},{"line_number":1340,"context_line":"        # before Train. Use 2.11 API version as reference to detect previous"},{"line_number":1341,"context_line":"        # releases and skip the test."}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_faba5dbe","line":1338,"updated":"2020-11-12 15:15:03.000000000","message":"The above check doesn\u0027t seem necessary with the below 2.11 one.","commit_id":"1b0499ccf853ba438d52d9b8486ddb1cf632e275"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"88bfe8183caca42f6db12791fc6b5f493664a4c8","unresolved":true,"context_lines":[{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1327,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1328,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1329,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1330,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":1331,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":1332,"context_line":"        # Using listeners on the same port for TCP and UDP was not supported"},{"line_number":1333,"context_line":"        # before Train. Use 2.11 API version as reference to detect previous"},{"line_number":1334,"context_line":"        # releases and skip the test."},{"line_number":1335,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1336,"context_line":"                self.api_version, \u00272.11\u0027):"},{"line_number":1337,"context_line":"            raise self.skipException(\u0027Using listeners on the same port is only\u0027"},{"line_number":1338,"context_line":"                                     \u0027 available in Octavia API version 2.11\u0027"},{"line_number":1339,"context_line":"                                     \u0027 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, self.common_vip_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic("}],"source_content_type":"text/x-python","patch_set":7,"id":"82ddacd4_0747ab43","line":1339,"range":{"start_line":1328,"start_character":8,"end_line":1339,"end_character":49},"updated":"2021-03-08 13:57:46.000000000","message":"now that train is the oldest stable branch still active, we probably don\u0027t need that, perhaps other reviewers would agree?","commit_id":"9c0ed42e9b97995ede1013f88824af6e5b3e523d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"42edda03cb6a646d49162eb95581b5ffd588fe32","unresolved":true,"context_lines":[{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"    @decorators.idempotent_id(\u00272b05229c-0254-11eb-8610-74e5f9e2a801\u0027)"},{"line_number":1327,"context_line":"    def test_tcp_and_udp_traffic_on_same_port(self):"},{"line_number":1328,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1329,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":1330,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":1331,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":1332,"context_line":"        # Using listeners on the same port for TCP and UDP was not supported"},{"line_number":1333,"context_line":"        # before Train. Use 2.11 API version as reference to detect previous"},{"line_number":1334,"context_line":"        # releases and skip the test."},{"line_number":1335,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":1336,"context_line":"                self.api_version, \u00272.11\u0027):"},{"line_number":1337,"context_line":"            raise self.skipException(\u0027Using listeners on the same port is only\u0027"},{"line_number":1338,"context_line":"                                     \u0027 available in Octavia API version 2.11\u0027"},{"line_number":1339,"context_line":"                                     \u0027 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, self.common_vip_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic("}],"source_content_type":"text/x-python","patch_set":7,"id":"1024d033_57409add","line":1339,"range":{"start_line":1328,"start_character":8,"end_line":1339,"end_character":49},"in_reply_to":"82ddacd4_0747ab43","updated":"2021-03-08 14:51:15.000000000","message":"Agree, I\u0027ll remove all this \"skip\" stuff.","commit_id":"9c0ed42e9b97995ede1013f88824af6e5b3e523d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"88bfe8183caca42f6db12791fc6b5f493664a4c8","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"                                     \u0027 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, self.common_vip_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic("},{"line_number":1343,"context_line":"            const.UDP, self.common_vip_port, listener_id, pool_id)"},{"line_number":1344,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1345,"context_line":"            const.TCP, self.common_vip_port)"},{"line_number":1346,"context_line":"        waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"}],"source_content_type":"text/x-python","patch_set":7,"id":"415dea35_b850f300","line":1343,"range":{"start_line":1342,"start_character":8,"end_line":1343,"end_character":66},"updated":"2021-03-08 13:57:46.000000000","message":"wouldn\u0027t it make more sense to move this call after creating both listeners/pools? this way any _test_basic_traffic call would use a LB with 2 listeners/pools\n\nI believe this flow would be more pertinent:\n- create listener/pool 1\n- wait for ACTIVE\n- create listener/pool 2\n- wait for ACTIVE\n- test traffic 1\n- test traffic 2","commit_id":"9c0ed42e9b97995ede1013f88824af6e5b3e523d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"42edda03cb6a646d49162eb95581b5ffd588fe32","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"                                     \u0027 or newer\u0027)"},{"line_number":1340,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1341,"context_line":"            const.UDP, self.common_vip_port)"},{"line_number":1342,"context_line":"        self._test_basic_traffic("},{"line_number":1343,"context_line":"            const.UDP, self.common_vip_port, listener_id, pool_id)"},{"line_number":1344,"context_line":"        listener_id, pool_id \u003d self._listener_pool_create("},{"line_number":1345,"context_line":"            const.TCP, self.common_vip_port)"},{"line_number":1346,"context_line":"        waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcbeb5ba_6531870e","line":1343,"range":{"start_line":1342,"start_character":8,"end_line":1343,"end_character":66},"in_reply_to":"415dea35_b850f300","updated":"2021-03-08 14:51:15.000000000","message":"Agree, it makes sense running the traffic when both listeners/pools are already set and ACTIVE.","commit_id":"9c0ed42e9b97995ede1013f88824af6e5b3e523d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9f9af58a804335d3afcd1b1d029070c85600e888","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    common_vip_port \u003d 102  # Used in test_tcp_and_udp_traffic_on_same_port"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"20cc0540_b72e0212","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":19},"updated":"2021-03-08 18:43:35.000000000","message":"I\u0027m ok with that for now, but it will need to be updated","commit_id":"20cacf165a289f853052b26461f195fd77b724c9"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"153fdf0abf9820ceebf07ca98041731c31d70dc1","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"            const.UDP, common_vip_port)"},{"line_number":1400,"context_line":"        listener_id_tcp, pool_id_tcp \u003d self._listener_pool_create("},{"line_number":1401,"context_line":"            const.TCP, common_vip_port)"},{"line_number":1402,"context_line":"        waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"},{"line_number":1403,"context_line":"                                self.lb_id, const.PROVISIONING_STATUS,"},{"line_number":1404,"context_line":"                                const.ACTIVE,"},{"line_number":1405,"context_line":"                                CONF.load_balancer.build_interval,"},{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"2e00d691_a1402e4f","line":1406,"range":{"start_line":1402,"start_character":8,"end_line":1406,"end_character":65},"updated":"2021-06-01 08:28:26.000000000","message":"The _listener_pool_create call above will already ensure the load balancer is in provisioning status ACTIVE. In principle running this check again wouldn\u0027t hurt but it is unnecessary and takes up a bit more resources and time which we\u0027ve been trying to cut back due to limited CI resources.","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ace6b3fe75d5d37bcdccb7877c36bd72ffe03f0","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"            const.UDP, common_vip_port)"},{"line_number":1400,"context_line":"        listener_id_tcp, pool_id_tcp \u003d self._listener_pool_create("},{"line_number":1401,"context_line":"            const.TCP, common_vip_port)"},{"line_number":1402,"context_line":"        waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"},{"line_number":1403,"context_line":"                                self.lb_id, const.PROVISIONING_STATUS,"},{"line_number":1404,"context_line":"                                const.ACTIVE,"},{"line_number":1405,"context_line":"                                CONF.load_balancer.build_interval,"},{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"c74c935d_958b9fc8","line":1406,"range":{"start_line":1402,"start_character":8,"end_line":1406,"end_character":65},"in_reply_to":"2e00d691_a1402e4f","updated":"2021-06-01 13:24:20.000000000","message":"Agree, the same waiter is already a part of \"_listener_pool_create\", I\u0027m about to remove those lines.","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72130f25fe4c32bd8665399b7e449d22ac4dc3c5","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"            const.UDP, common_vip_port)"},{"line_number":1400,"context_line":"        listener_id_tcp, pool_id_tcp \u003d self._listener_pool_create("},{"line_number":1401,"context_line":"            const.TCP, common_vip_port)"},{"line_number":1402,"context_line":"        waiters.wait_for_status(self.mem_lb_client.show_loadbalancer,"},{"line_number":1403,"context_line":"                                self.lb_id, const.PROVISIONING_STATUS,"},{"line_number":1404,"context_line":"                                const.ACTIVE,"},{"line_number":1405,"context_line":"                                CONF.load_balancer.build_interval,"},{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"249d011d_eb676830","line":1406,"range":{"start_line":1402,"start_character":8,"end_line":1406,"end_character":65},"in_reply_to":"c74c935d_958b9fc8","updated":"2021-06-01 13:24:37.000000000","message":"Done","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"153fdf0abf9820ceebf07ca98041731c31d70dc1","unresolved":true,"context_lines":[{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7b68d9c_a789c77a","line":1409,"range":{"start_line":1409,"start_character":33,"end_line":1409,"end_character":49},"updated":"2021-06-01 08:28:26.000000000","message":"Any particular reason to disable session persistence?","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e4b40d8f4513acfcd012ce66b1106e8ef5fec2ee","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3402cd36_06d07c07","line":1409,"range":{"start_line":1409,"start_character":33,"end_line":1409,"end_character":49},"in_reply_to":"18d302de_57ed5b58","updated":"2021-06-01 13:44:13.000000000","message":"That\u0027s not correct, without \"persistence \u003d False\" test is failed.\nWe need to have the same amount of requests on 2 members for \"check_members_balanced\" to PASS.\nWhen \"persistence\" is not set, we\u0027ll have all the requests sent on the same TCP connection, so it won\u0027t work.\nBTW - all tests based on: \"_test_basic_traffic\" + TCP protocol having \"persistence \u003d False\", so.","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"62aee4e7ebedc0584cc6c89a82e9e91f1fe5116d","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"2e8286c9_b6fd99e9","line":1409,"range":{"start_line":1409,"start_character":33,"end_line":1409,"end_character":49},"in_reply_to":"3402cd36_06d07c07","updated":"2021-06-01 14:08:18.000000000","message":"Ah, yeah. I missed that. Thanks!","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72130f25fe4c32bd8665399b7e449d22ac4dc3c5","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"18d302de_57ed5b58","line":1409,"range":{"start_line":1409,"start_character":33,"end_line":1409,"end_character":49},"in_reply_to":"4e27f734_b6a1402a","updated":"2021-06-01 13:24:37.000000000","message":"Done","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ace6b3fe75d5d37bcdccb7877c36bd72ffe03f0","unresolved":true,"context_lines":[{"line_number":1406,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":1407,"context_line":"        self._test_basic_traffic(const.UDP, common_vip_port, pool_id_udp)"},{"line_number":1408,"context_line":"        self._test_basic_traffic(const.TCP, common_vip_port, pool_id_tcp,"},{"line_number":1409,"context_line":"                                 persistent\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"4e27f734_b6a1402a","line":1409,"range":{"start_line":1409,"start_character":33,"end_line":1409,"end_character":49},"in_reply_to":"c7b68d9c_a789c77a","updated":"2021-06-01 13:24:20.000000000","message":"Actually I think that it shouldn\u0027t matter, but I\u0027ll remove this in my next patch.","commit_id":"93fd31dbb8792557a4e022a7c41e8cbadf88eb25"}]}