)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"605da734aa50acabe6b7c1df5bb57c37b8eeebcf","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"            (None, None), url_for_vip, repeat\u003d3, expect_connection_error\u003dTrue)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"    @decorators.idempotent_id(\u0027c79f2cd0-0324-11eb-bc8e-74e5f9e2a801\u0027)"},{"line_number":1369,"context_line":"    def test_udp_update_pool_healthmonitor_listener(self):"},{"line_number":1370,"context_line":"        \"\"\"Test scenario:"},{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"        * Create: UDP listener, pool, healtmonitor and validate UDP traffic"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_2b5ea8e5","side":"PARENT","line":1369,"updated":"2020-11-04 19:58:36.000000000","message":"This patch should be independent and not removing other tests. This is an un-related change to the purpose of the patch.","commit_id":"1041e550d0254ccff2a72cf36562bf249451bd38"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"605da734aa50acabe6b7c1df5bb57c37b8eeebcf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from octavia_tempest_plugin.common import constants as const"},{"line_number":29,"context_line":"from octavia_tempest_plugin.tests import test_base"},{"line_number":30,"context_line":"from octavia_tempest_plugin.tests import waiters"},{"line_number":31,"context_line":"from threading import Thread"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_2b450818","line":31,"updated":"2020-11-04 19:58:36.000000000","message":"Threading is a base module, it should be in the top block of imports.","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1db3cea2c18527706f8115601660b238cb6a3f5a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_83673326","line":38,"updated":"2020-10-22 13:35:47.000000000","message":"In this new commit, you\u0027re deleting everything you added in the previous commit.","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"05034a77424bcb4f2f23cfcb4e0771f784d93e06","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_d734414d","line":38,"in_reply_to":"3f65232a_83673326","updated":"2020-10-22 16:39:19.000000000","message":"It would be great to have my previous commit reviewed and merged, unfortunately it\u0027s not going to happen soon :-(\n\nThere are too many code changes: 3 new tests, new functions, port mechanism...\n\nI\u0027m taking a break with \"Octavia tempest plugin\" as by now I don\u0027t really have any progress with that. \n\nI\u0027ll keep monitoring all my patches (will take care to get +1 from Zuul prior to raising them on IRC upstream meeting) and in meanwhile I\u0027ll switch to Tobiko.\n\nAs for this patch I don\u0027t really care about that, I mean it doesn\u0027t really matter to me if it will be reviewed/merged before the old one or after, I\u0027m OK with all options.","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"605da734aa50acabe6b7c1df5bb57c37b8eeebcf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class TrafficOperationsScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_8b4b7c29","line":38,"in_reply_to":"3f65232a_d734414d","updated":"2020-11-04 19:58:36.000000000","message":"Yeah, it seems like the git patch chain is broken here.","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"}],"octavia_tempest_plugin/tests/validators.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"605da734aa50acabe6b7c1df5bb57c37b8eeebcf","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        LOG.error(message)"},{"line_number":420,"context_line":"        raise Exception(message)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _http_requests_single_connection("},{"line_number":423,"context_line":"            self, dst_ip, dst_port, request_number, delay, result,"},{"line_number":424,"context_line":"            index, tcp_timeout\u003d1):"},{"line_number":425,"context_line":"        \"\"\"This function is used as a worker, target thread function."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_cbe73440","line":422,"updated":"2020-11-04 19:58:36.000000000","message":"This is a private method that isn\u0027t called from this class?","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"605da734aa50acabe6b7c1df5bb57c37b8eeebcf","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            s \u003d requests.Session()"},{"line_number":442,"context_line":"            responses \u003d []"},{"line_number":443,"context_line":"            for req in range(0, request_number):"},{"line_number":444,"context_line":"                r \u003d s.get(\u0027http://\u0027+dst_ip+\u0027:\u0027+str(dst_port),"},{"line_number":445,"context_line":"                          timeout\u003dtcp_timeout)"},{"line_number":446,"context_line":"                responses.append({"},{"line_number":447,"context_line":"                    \u0027RequestNumber\u0027: req, \u0027ResponseCode\u0027: r.status_code,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_abbbd80b","line":444,"updated":"2020-11-04 19:58:36.000000000","message":"It might be better to leverage the above validate_URL_response or make_request methods.","commit_id":"48c84b70dace262f676551578ea20b8c4496cb14"}]}