)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d9d24f4d07be1c2fd5fc376f9822fffdc35c3f81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"711bbd8e_58f59870","updated":"2023-07-11 20:21:27.000000000","message":"Minor nit about logging a skipped protocol","commit_id":"ece5ab4369aeb559725a43c859a5f313b79ce0ec"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"9ffc901b6b6dc5a585a152fa6e5a382c436d16d6","unresolved":true,"context_lines":[{"line_number":296,"context_line":"        # Using listeners on the same port for TCP and UDP was not supported"},{"line_number":297,"context_line":"        # before Train. Use 2.11 API version as reference to detect previous"},{"line_number":298,"context_line":"        # releases and skip the test."},{"line_number":299,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":300,"context_line":"                self.api_version, \u00272.11\u0027):"},{"line_number":301,"context_line":"            raise self.skipException(\u0027TCP and UDP listeners on same port fix \u0027"},{"line_number":302,"context_line":"                                     \u0027is only available on Octavia API \u0027"},{"line_number":303,"context_line":"                                     \u0027version 2.11 or newer.\u0027)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if not skip_protocol1:"},{"line_number":306,"context_line":"            listener_name \u003d data_utils.rand_name(\"lb_member_listener1-create\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"585fda3f_a54e1168","line":303,"range":{"start_line":299,"start_character":8,"end_line":303,"end_character":62},"updated":"2022-10-18 15:53:23.000000000","message":"nit: If we use _validate_listener_protocol for each protocol, maybe we can move lines 299-303 this into that method? (_validate_listener_protocol)","commit_id":"07455dc620846620e5285d242fbdc00eea88809d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"9ffc901b6b6dc5a585a152fa6e5a382c436d16d6","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                        listener_kwargs[const.PROTOCOL]))"},{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    raise e"},{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                waiters.wait_for_status("},{"line_number":329,"context_line":"                    self.mem_lb_client.show_loadbalancer, self.lb_id,"},{"line_number":330,"context_line":"                    const.PROVISIONING_STATUS, const.ACTIVE,"}],"source_content_type":"text/x-python","patch_set":12,"id":"625addb1_8a058cd8","line":327,"range":{"start_line":327,"start_character":12,"end_line":327,"end_character":17},"updated":"2022-10-18 15:53:23.000000000","message":"Should there also be cleanups after creating the listeners?","commit_id":"07455dc620846620e5285d242fbdc00eea88809d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"da86cfd5ac533ed4bb997047332d550192f3f65a","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                        listener_kwargs[const.PROTOCOL]))"},{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    raise e"},{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                waiters.wait_for_status("},{"line_number":329,"context_line":"                    self.mem_lb_client.show_loadbalancer, self.lb_id,"},{"line_number":330,"context_line":"                    const.PROVISIONING_STATUS, const.ACTIVE,"}],"source_content_type":"text/x-python","patch_set":12,"id":"59a02a8f_fd4b9780","line":327,"range":{"start_line":327,"start_character":12,"end_line":327,"end_character":17},"in_reply_to":"625addb1_8a058cd8","updated":"2023-12-05 11:28:36.000000000","message":"in this class, we delete the LB with cascade\u003dTrue, it\u0027s fine to delete everything at this moment (one DELETE LB cascade\u003dtrue caller is faster than many DELETE listeners/pools/members + one DELETE LB call)\nnote that we have adjusted the connection limit for the listeners to ensure that we don\u0027t allocate to much memory in the LB","commit_id":"07455dc620846620e5285d242fbdc00eea88809d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d9d24f4d07be1c2fd5fc376f9822fffdc35c3f81","unresolved":true,"context_lines":[{"line_number":310,"context_line":"                                     \u0027is only available on Octavia API \u0027"},{"line_number":311,"context_line":"                                     \u0027version 2.11 or newer.\u0027)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if not skip_protocol1:"},{"line_number":314,"context_line":"            listener_name \u003d data_utils.rand_name(\"lb_member_listener1-create\")"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            listener_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"23a8144c_9fa5892f","line":313,"updated":"2023-07-11 20:21:27.000000000","message":"It would be nice to log that a protocol was skipped","commit_id":"ece5ab4369aeb559725a43c859a5f313b79ce0ec"}]}