)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"454ce5cf473d6a571b34866eca8c6d0d78e88bb8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        test_basic_tls_SNI_traffic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I643ea5c9debad08df6c6734cfc7decbbbec608a6"},{"line_number":20,"context_line":"Depends-On: https://review.opendev.org/767338"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"271f08ad_d751f462","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"updated":"2021-02-24 13:39:46.000000000","message":"Patch merged, we can now remove this line.","commit_id":"070edffbb90f8fe146f3eadd40ff4c1f7bcc71fb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2320bf67e330cc1ed973a607c26e7f98844d11a1","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        test_basic_tls_SNI_traffic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I643ea5c9debad08df6c6734cfc7decbbbec608a6"},{"line_number":20,"context_line":"Depends-On: https://review.opendev.org/767338"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da191a53_1af4cc86","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"in_reply_to":"271f08ad_d751f462","updated":"2021-02-24 14:44:32.000000000","message":"Thanks","commit_id":"070edffbb90f8fe146f3eadd40ff4c1f7bcc71fb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1cd7a04b4681341790173b5c901c235959495f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06a39f43_5b68946c","updated":"2023-05-10 15:28:34.000000000","message":"Do we test certificate updates in any other place? Is this patch not relevant today?","commit_id":"435509b16f179ffec3564b3cafda06e6e51ab005"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c51751d1990181b65e3d7fcd04dbd8ee005499f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cb7abc5b_542e22c2","updated":"2023-05-09 17:24:03.000000000","message":"this patch has been sitting around awhile, abandon?","commit_id":"435509b16f179ffec3564b3cafda06e6e51ab005"}],"octavia_tempest_plugin/tests/barbican_scenario/v2/test_tls_barbican.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        self.check_members_balanced(self.lb_vip_address, protocol\u003dconst.HTTPS,"},{"line_number":360,"context_line":"                                    HTTPS_verify\u003dFalse, protocol_port\u003d443)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        def _verify_cb(connection, x509, errno, errdepth, retcode):"},{"line_number":363,"context_line":"            \"\"\"Callback for certificate validation.\"\"\""},{"line_number":364,"context_line":"            # don\u0027t validate names of root certificates"},{"line_number":365,"context_line":"            if errdepth !\u003d 0:"},{"line_number":366,"context_line":"                return True"},{"line_number":367,"context_line":"            if errno \u003d\u003d 0:"},{"line_number":368,"context_line":"                received_cn \u003d x509.get_subject().commonName"},{"line_number":369,"context_line":"                received_name \u003d self._get_cert_name(received_cn)"},{"line_number":370,"context_line":"                expected_cn \u003d \u0027{}.example.com\u0027.format(self.server_uuid)"},{"line_number":371,"context_line":"                msg \u003d (\u0027ERROR: Received certificate \"{received_name}\" with CN \u0027"},{"line_number":372,"context_line":"                       \u0027{received_cn} is not the expected certificate \u0027"},{"line_number":373,"context_line":"                       \u0027\"default\" with CN {expected_cn}.\u0027.format("},{"line_number":374,"context_line":"                        received_name\u003dreceived_name,"},{"line_number":375,"context_line":"                        received_cn\u003dreceived_cn,"},{"line_number":376,"context_line":"                        expected_cn\u003dexpected_cn))"},{"line_number":377,"context_line":"                # Make sure the certificate is the one we generated"},{"line_number":378,"context_line":"                self.assertEqual(expected_cn, received_cn, message\u003dmsg)"},{"line_number":379,"context_line":"            else:"},{"line_number":380,"context_line":"                LOG.error(\u0027Certificate with CN: {0} failed validation with \u0027"},{"line_number":381,"context_line":"                          \u0027OpenSSL verify errno {1}\u0027.format("},{"line_number":382,"context_line":"                           x509.get_subject().commonName, errno))"},{"line_number":383,"context_line":"                return False"},{"line_number":384,"context_line":"            return True"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":387,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":388,"context_line":"                           _verify_cb)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5437ebbb_0d772358","line":385,"range":{"start_line":362,"start_character":7,"end_line":385,"end_character":0},"updated":"2021-03-10 07:59:31.000000000","message":"a similar function is already defined in the class (_verify_server_cb)","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":387,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":388,"context_line":"                           _verify_cb)"},{"line_number":389,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":390,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":391,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"26ebf3d1_78410d3e","line":388,"range":{"start_line":388,"start_character":27,"end_line":388,"end_character":37},"updated":"2021-03-10 07:59:31.000000000","message":"we can probably use _verify_server_cb","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        new_server_uuid \u003d uuidutils.generate_uuid()"},{"line_number":399,"context_line":"        LOG.debug(\u0027New server (default) UUID: %s\u0027, new_server_uuid)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        server_cert, server_key, new_server_secret_ref \u003d ("},{"line_number":402,"context_line":"            self._generate_load_certificate(self.barbican_mgr, self.ca_cert,"},{"line_number":403,"context_line":"                                            self.ca_key, new_server_uuid))"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"4d83aaac_210b793e","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":31},"updated":"2021-03-10 07:59:31.000000000","message":"those 2 variables are unused.\nI believe that \"new_server_secret_ref \u003d blahblah[2]\" will look better","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":421,"context_line":"        current_server_uuid \u003d self.server_uuid"},{"line_number":422,"context_line":"        self.server_uuid \u003d new_server_uuid"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # # Validate the certificate is signed by the ca_cert we created"},{"line_number":425,"context_line":"        # self._test_and_validate_certificate("},{"line_number":426,"context_line":"        #     ssl_method\u003dSSL.SSLv23_METHOD,"},{"line_number":427,"context_line":"        #     verify_method\u003dself._verify_server_cb)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":430,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"a886b39a_34d12a12","line":427,"range":{"start_line":424,"start_character":7,"end_line":427,"end_character":51},"updated":"2021-03-10 07:59:31.000000000","message":"Need some cleanup","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":430,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":431,"context_line":"                           _verify_cb)"},{"line_number":432,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":433,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":434,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7dfdbe6c_5331ab65","line":431,"range":{"start_line":431,"start_character":27,"end_line":431,"end_character":37},"updated":"2021-03-10 07:59:31.000000000","message":"we can probably use _verify_server_cb","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        new_server_uuid \u003d uuidutils.generate_uuid()"},{"line_number":552,"context_line":"        LOG.debug(\u0027New server (default) UUID: %s\u0027, new_server_uuid)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        server_cert, server_key, new_server_secret_ref \u003d ("},{"line_number":555,"context_line":"            self._generate_load_certificate(self.barbican_mgr, self.ca_cert,"},{"line_number":556,"context_line":"                                            self.ca_key, new_server_uuid))"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"693acce2_62d4eb68","line":554,"range":{"start_line":554,"start_character":8,"end_line":554,"end_character":32},"updated":"2021-03-10 07:59:31.000000000","message":"unused vars","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":578,"context_line":"        # Update the certificate"},{"line_number":579,"context_line":"        current_server_uuid \u003d self.server_uuid"},{"line_number":580,"context_line":"        self.server_uuid \u003d new_server_uuid"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # Validate the certificate is signed by the ca_cert we created"},{"line_number":583,"context_line":"        # self._test_and_validate_certificate("},{"line_number":584,"context_line":"        #     ssl_method\u003dSSL.SSLv23_METHOD,"},{"line_number":585,"context_line":"        #     verify_method\u003dself._verify_server_cb)"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":588,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"72d04f31_06e37dc3","line":585,"range":{"start_line":581,"start_character":0,"end_line":585,"end_character":51},"updated":"2021-03-10 07:59:31.000000000","message":"cleanup","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":790,"context_line":"        self.check_members_balanced(self.lb_vip_address, protocol\u003dconst.HTTPS,"},{"line_number":791,"context_line":"                                    HTTPS_verify\u003dFalse, protocol_port\u003d443)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        def _verify_server_cb(connection, x509, errno, errdepth, retcode):"},{"line_number":794,"context_line":"            return _verify_cb(connection, x509, errno, errdepth, retcode,"},{"line_number":795,"context_line":"                              name\u003dself.server_uuid)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        def _verify_SNI1_cb(connection, x509, errno, errdepth, retcode):"},{"line_number":798,"context_line":"            return _verify_cb(connection, x509, errno, errdepth, retcode,"},{"line_number":799,"context_line":"                              name\u003dself.SNI1_uuid)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        def _verify_SNI2_cb(connection, x509, errno, errdepth, retcode):"},{"line_number":802,"context_line":"            return _verify_cb(connection, x509, errno, errdepth, retcode,"},{"line_number":803,"context_line":"                              name\u003dself.SNI2_uuid)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        def _verify_cb(connection, x509, errno, errdepth, retcode, name):"},{"line_number":806,"context_line":"            \"\"\"Callback for certificate validation.\"\"\""},{"line_number":807,"context_line":"            # don\u0027t validate names of root certificates"},{"line_number":808,"context_line":"            if errdepth !\u003d 0:"},{"line_number":809,"context_line":"                return True"},{"line_number":810,"context_line":"            if errno \u003d\u003d 0:"},{"line_number":811,"context_line":"                received_cn \u003d x509.get_subject().commonName"},{"line_number":812,"context_line":"                received_name \u003d self._get_cert_name(received_cn)"},{"line_number":813,"context_line":"                LOG.debug(\"the received name is: \" + received_name)"},{"line_number":814,"context_line":"                expected_cn \u003d \u0027{}.example.com\u0027.format(name)"},{"line_number":815,"context_line":"                expected_name \u003d self._get_cert_name(name)"},{"line_number":816,"context_line":"                msg \u003d (\u0027ERROR: Received certificate \"{received_name}\" with CN \u0027"},{"line_number":817,"context_line":"                       \u0027{received_cn} is not the expected certificate \u0027"},{"line_number":818,"context_line":"                       \u0027\"{expected_name}\" with CN {expected_cn}.\u0027.format("},{"line_number":819,"context_line":"                        received_name\u003dreceived_name,"},{"line_number":820,"context_line":"                        received_cn\u003dreceived_cn,"},{"line_number":821,"context_line":"                        expected_name\u003dexpected_name,"},{"line_number":822,"context_line":"                        expected_cn\u003dexpected_cn))"},{"line_number":823,"context_line":"                # Make sure the certificate is the one we generated"},{"line_number":824,"context_line":"                self.assertEqual(expected_cn, received_cn, message\u003dmsg)"},{"line_number":825,"context_line":"            else:"},{"line_number":826,"context_line":"                LOG.error(\u0027Certificate with CN: {0} failed validation with \u0027"},{"line_number":827,"context_line":"                          \u0027OpenSSL verify errno {1}\u0027.format("},{"line_number":828,"context_line":"                           x509.get_subject().commonName, errno))"},{"line_number":829,"context_line":"                return False"},{"line_number":830,"context_line":"            return True"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # Test that the default certificate is used with no SNI host request"},{"line_number":833,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"}],"source_content_type":"text/x-python","patch_set":7,"id":"160b2f90_5b094df0","line":830,"range":{"start_line":793,"start_character":7,"end_line":830,"end_character":23},"updated":"2021-03-10 07:59:31.000000000","message":"those functions already exist in the class","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":832,"context_line":"        # Test that the default certificate is used with no SNI host request"},{"line_number":833,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":834,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":835,"context_line":"                           _verify_server_cb)"},{"line_number":836,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":837,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":838,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"33125150_f86fac77","line":835,"range":{"start_line":835,"start_character":27,"end_line":835,"end_character":44},"updated":"2021-03-10 07:59:31.000000000","message":"self.","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        # Test that the default certificate is used with bogus SNI host request"},{"line_number":845,"context_line":"        context \u003d SSL.Context(SSL.TLSv1_2_METHOD)"},{"line_number":846,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":847,"context_line":"                           _verify_server_cb)"},{"line_number":848,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":849,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":850,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcad46e3_d1cc68db","line":847,"range":{"start_line":847,"start_character":27,"end_line":847,"end_character":44},"updated":"2021-03-10 07:59:31.000000000","message":"same","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":857,"context_line":"        # Test that the SNI1 certificate is used when SNI1 host is specified"},{"line_number":858,"context_line":"        context \u003d SSL.Context(SSL.TLSv1_2_METHOD)"},{"line_number":859,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":860,"context_line":"                           _verify_SNI1_cb)"},{"line_number":861,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":862,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":863,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"b19f0a2c_7e3faebe","line":860,"range":{"start_line":860,"start_character":27,"end_line":860,"end_character":42},"updated":"2021-03-10 07:59:31.000000000","message":"same","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":871,"context_line":"        # Test that the SNI2 certificate is used when SNI2 host is specified"},{"line_number":872,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":873,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":874,"context_line":"                           _verify_SNI2_cb)"},{"line_number":875,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":876,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":877,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bb474861_dcdcb70f","line":874,"range":{"start_line":874,"start_character":27,"end_line":874,"end_character":42},"updated":"2021-03-10 07:59:31.000000000","message":"same","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":886,"context_line":"        new_server_uuid \u003d uuidutils.generate_uuid()"},{"line_number":887,"context_line":"        LOG.debug(\u0027New server (default) UUID: %s\u0027, new_server_uuid)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"        server_cert, server_key, new_server_secret_ref \u003d ("},{"line_number":890,"context_line":"            self._generate_load_certificate(self.barbican_mgr, self.ca_cert,"},{"line_number":891,"context_line":"                                            self.ca_key, new_server_uuid))"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d7c9a9cd_cfbd952c","line":889,"range":{"start_line":889,"start_character":8,"end_line":889,"end_character":31},"updated":"2021-03-10 07:59:31.000000000","message":"unused","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        new_SNI1_uuid \u003d uuidutils.generate_uuid()"},{"line_number":895,"context_line":"        LOG.debug(\u0027New SNI1 (default) UUID: %s\u0027, new_SNI1_uuid)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        new_SNI1_cert, new_SNI1_key, new_SNI1_secret_ref \u003d ("},{"line_number":898,"context_line":"            self._generate_load_certificate(self.barbican_mgr, self.ca_cert,"},{"line_number":899,"context_line":"                                            self.ca_key, new_SNI1_uuid))"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"31cc19bd_db32cdc9","line":897,"range":{"start_line":897,"start_character":8,"end_line":897,"end_character":35},"updated":"2021-03-10 07:59:31.000000000","message":"unused","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":901,"context_line":"        new_SNI2_uuid \u003d uuidutils.generate_uuid()"},{"line_number":902,"context_line":"        LOG.debug(\u0027New SNI2 (default) UUID: %s\u0027, new_SNI2_uuid)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        new_SNI2_cert, new_SNI2_key, new_SNI2_secret_ref \u003d ("},{"line_number":905,"context_line":"            self._generate_load_certificate(self.barbican_mgr, self.ca_cert,"},{"line_number":906,"context_line":"                                            self.ca_key, new_SNI2_uuid))"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1c26a6fd_2159dd9b","line":904,"range":{"start_line":904,"start_character":8,"end_line":904,"end_character":35},"updated":"2021-03-10 07:59:31.000000000","message":"unused","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":931,"context_line":"        # Test that the SNI1 certificate is used when SNI1 host is specified"},{"line_number":932,"context_line":"        context \u003d SSL.Context(SSL.TLSv1_2_METHOD)"},{"line_number":933,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":934,"context_line":"                           _verify_SNI1_cb)"},{"line_number":935,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":936,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":937,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"99cb8bf3_21cdf15d","line":934,"range":{"start_line":934,"start_character":27,"end_line":934,"end_character":42},"updated":"2021-03-10 07:59:31.000000000","message":"self.","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        # Test that the SNI2 certificate is used when SNI2 host is specified"},{"line_number":951,"context_line":"        context \u003d SSL.Context(SSL.SSLv23_METHOD)"},{"line_number":952,"context_line":"        context.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT,"},{"line_number":953,"context_line":"                           _verify_SNI2_cb)"},{"line_number":954,"context_line":"        ca_store \u003d context.get_cert_store()"},{"line_number":955,"context_line":"        ca_store.add_cert(X509.from_cryptography(self.ca_cert))"},{"line_number":956,"context_line":"        sock \u003d socket.socket()"}],"source_content_type":"text/x-python","patch_set":7,"id":"270037bd_c953b32c","line":953,"range":{"start_line":953,"start_character":27,"end_line":953,"end_character":42},"updated":"2021-03-10 07:59:31.000000000","message":"self.","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"786952d09f89e05695e8dc06a3fd680d1f034808","unresolved":true,"context_lines":[{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        self.SNI2_uuid \u003d current_SNI2_uuid"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        # # Test that the SNI1 certificate is used when SNI1 host is specified"},{"line_number":967,"context_line":"        # # We change the self.SNI1_uuid so the _verify_SNI1_cb"},{"line_number":968,"context_line":"        # # method will verify the new_SNI1_uuid"},{"line_number":969,"context_line":"        # current_SNI1_uuid \u003d self.SNI1_uuid"},{"line_number":970,"context_line":"        # self.SNI1_uuid \u003d new_SNI1_uuid"},{"line_number":971,"context_line":"        #"},{"line_number":972,"context_line":"        # self._test_and_validate_certificate("},{"line_number":973,"context_line":"        #     ssl_method\u003dSSL.TLSv1_2_METHOD,"},{"line_number":974,"context_line":"        #     verify_method\u003dself._verify_SNI1_cb,"},{"line_number":975,"context_line":"        #     tls_ext_host_name\u003d\u0027{}.example.com\u0027.format(self.SNI1_uuid).encode())"},{"line_number":976,"context_line":"        #"},{"line_number":977,"context_line":"        # self.SNI1_uuid \u003d current_SNI1_uuid"},{"line_number":978,"context_line":"        #"},{"line_number":979,"context_line":"        # # Test that the SNI2 certificate is used when SNI2 host is specified"},{"line_number":980,"context_line":"        # # We change the self.SNI2_uuid so the _verify_SNI2_cb"},{"line_number":981,"context_line":"        # # method will verify the new_SNI2_uuid"},{"line_number":982,"context_line":"        # current_SNI2_uuid \u003d self.SNI2_uuid"},{"line_number":983,"context_line":"        # self.SNI2_uuid \u003d new_SNI2_uuid"},{"line_number":984,"context_line":"        #"},{"line_number":985,"context_line":"        # self._test_and_validate_certificate("},{"line_number":986,"context_line":"        #     ssl_method\u003dSSL.SSLv23_METHOD,"},{"line_number":987,"context_line":"        #     verify_method\u003dself._verify_SNI2_cb,"},{"line_number":988,"context_line":"        #     tls_ext_host_name\u003d\u0027{}.example.com\u0027.format(self.SNI2_uuid).encode())"},{"line_number":989,"context_line":"        #"},{"line_number":990,"context_line":"        # self.SNI2_uuid \u003d current_SNI2_uuid"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    def _get_cert_name(self, lookup_string):"},{"line_number":993,"context_line":"        if self.server_uuid in lookup_string:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7475fc0c_690068b3","line":990,"range":{"start_line":966,"start_character":7,"end_line":990,"end_character":44},"updated":"2021-03-10 07:59:31.000000000","message":"those lines need to be removed","commit_id":"ed68bb40501e42106d96ffb6446774aeeac48818"}]}