)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f8c5cd29c88e235342545339ddfbbbebc3e2ddb1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arieh Maron \u003camaron@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-11 19:36:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating _test_pool_CRUD:"},{"line_number":8,"context_line":"Added a new parameter \"next_algorithm\" that defaults to None."},{"line_number":9,"context_line":"If next_algorithm is not None then the update of the pool"},{"line_number":10,"context_line":"will also update the pool\u0027s loadbalancing algorithm."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"95c0f950_a886d89a","line":7,"updated":"2021-01-11 21:11:07.000000000","message":"We\u0027ve deleted one extra empty line here 😊\nSo #8 should be empty line","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"253753a38012d5c3c69dcdce4d4998aa0c38bbbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arieh Maron \u003camaron@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-11 19:36:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating _test_pool_CRUD:"},{"line_number":8,"context_line":"Added a new parameter \"next_algorithm\" that defaults to None."},{"line_number":9,"context_line":"If next_algorithm is not None then the update of the pool"},{"line_number":10,"context_line":"will also update the pool\u0027s loadbalancing algorithm."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fc216763_4c215dc3","line":7,"in_reply_to":"95c0f950_a886d89a","updated":"2021-02-10 07:47:55.000000000","message":"Done","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0d6e4c157cab8a5e7c2f6a077a44ea58f624e5b2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2021-01-11 16:15:27 +0200"},{"line_number":4,"context_line":"Commit:     Arieh Maron \u003camaron@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-12 17:34:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating _test_pool_CRUD:"},{"line_number":8,"context_line":"Added a new parameter \"next_algorithm\" that defaults to None."},{"line_number":9,"context_line":"If next_algorithm is not None then the update of the pool"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b24e5423_bee4adbc","line":6,"updated":"2021-01-12 21:10:28.000000000","message":"Can you add a short one-line description?  Followed by a blank line?  Otherwise zuul puts the title as the entire paragraph.","commit_id":"20a104a3004052835985b99f1004fa3a24826ce3"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2021-01-11 16:15:27 +0200"},{"line_number":4,"context_line":"Commit:     Arieh Maron \u003camaron@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-12 17:34:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating _test_pool_CRUD:"},{"line_number":8,"context_line":"Added a new parameter \"next_algorithm\" that defaults to None."},{"line_number":9,"context_line":"If next_algorithm is not None then the update of the pool"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3c85c648_5e9e527d","line":6,"in_reply_to":"b24e5423_bee4adbc","updated":"2021-01-14 07:10:53.000000000","message":"Done","commit_id":"20a104a3004052835985b99f1004fa3a24826ce3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"393c6b7724c049a8a151d13dbf0516208e488039","unresolved":true,"context_lines":[{"line_number":15,"context_line":"test_UDP_SIP_to_LC_pool_with_listener_CRUD"},{"line_number":16,"context_line":"tests the result of updating the pool\u0027s"},{"line_number":17,"context_line":"loadbalancing algorithm"},{"line_number":18,"context_line":"* commented out the restriction in line 553 that algorithm"},{"line_number":19,"context_line":"  cannot change"},{"line_number":20,"context_line":"* got rid of various \"noise\" characters that somehow got"},{"line_number":21,"context_line":"  inserted"},{"line_number":22,"context_line":"* cancelled checks that wouldn\u0027t allow algorithm change"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ia2f62ce38d96b72f2b9d81b555708564fdf90550"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"8527722b_b0744c8b","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":55},"updated":"2021-02-01 14:28:06.000000000","message":"you don\u0027t have to detail what you\u0027ve fixed in your commit after the reviews/CI issues, just explain the changes between the base commit (master) and your commit.","commit_id":"28ac45771327af5c12a93a8ced489b4a4c9b3cc0"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"253753a38012d5c3c69dcdce4d4998aa0c38bbbd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"test_UDP_SIP_to_LC_pool_with_listener_CRUD"},{"line_number":16,"context_line":"tests the result of updating the pool\u0027s"},{"line_number":17,"context_line":"loadbalancing algorithm"},{"line_number":18,"context_line":"* commented out the restriction in line 553 that algorithm"},{"line_number":19,"context_line":"  cannot change"},{"line_number":20,"context_line":"* got rid of various \"noise\" characters that somehow got"},{"line_number":21,"context_line":"  inserted"},{"line_number":22,"context_line":"* cancelled checks that wouldn\u0027t allow algorithm change"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ia2f62ce38d96b72f2b9d81b555708564fdf90550"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"916e00cc_12f81a69","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":55},"in_reply_to":"8527722b_b0744c8b","updated":"2021-02-10 07:47:55.000000000","message":"Done","commit_id":"28ac45771327af5c12a93a8ced489b4a4c9b3cc0"}],"octavia_tempest_plugin/tests/scenario/v2/test_pool.py":[{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        Provides automated coverage for RHELOSP-63931"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5488da48_11490995","line":335,"in_reply_to":"939c07cf_ad08be55","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: H404: multi line docstring should start without a leading new line\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        Provides automated coverage for RHELOSP-63931"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6847f9f6_a311272e","line":335,"in_reply_to":"aa119d24_4d7b6d42","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: H405: multi line docstring summary not separated with an empty line\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        Provides automated coverage for RHELOSP-63931"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"56c739b4_9115e40f","line":336,"in_reply_to":"cadfc833_e2c889f0","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: H404: multi line docstring should start without a leading new line\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        Provides automated coverage for RHELOSP-63931"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":340,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f34a8587_626d2a3e","line":337,"in_reply_to":"53bcb384_3b8ba728","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: H404: multi line docstring should start without a leading new line\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":340,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"},{"line_number":341,"context_line":"                             algorithm\u003dconst.LB_ALGORITHM_SOURCE_IP_PORT,"},{"line_number":342,"context_line":"                             next_algorithm\u003dconst.LB_ALGORITHM_LEAST_CONNECTIONS)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":345,"context_line":"                        algorithm, session_persistence\u003dNone, next_algorithm\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a0e1d91_755534f2","line":342,"in_reply_to":"311c34ff_82d504bf","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                             next_algorithm\u003dconst.LB_ALGORITHM_LEAST_CONNECTIONS)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":345,"context_line":"                        algorithm, session_persistence\u003dNone, next_algorithm\u003dNone):"},{"line_number":346,"context_line":"        \"\"\"Tests pool create, read, update, delete"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        * Create a fully populated pool."}],"source_content_type":"text/x-python","patch_set":1,"id":"dbcd4c1e_14e25925","line":345,"in_reply_to":"db305139_9ea261be","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: E501 line too long (82 \u003e 79 characters)\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":357,"context_line":"                \u0027Skipping this test as load balancing algorithm \u0027"},{"line_number":358,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":359,"context_line":"        "},{"line_number":360,"context_line":"        # set next_algorithm to algorithm if it wasn\u0027t defined    "},{"line_number":361,"context_line":"        next_algorithm \u003d next_algorithm or algorithm"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a7945174_12f04651","line":359,"in_reply_to":"79e0d94c_ff187d7f","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":367,"context_line":"                \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":368,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":369,"context_line":"        "},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # Listener create"},{"line_number":372,"context_line":"        if listener_protocol is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ce47e48_29978dea","line":369,"in_reply_to":"bd2ebb23_2fbf7c58","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":369,"context_line":"        "},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # Listener create"},{"line_number":372,"context_line":"        if listener_protocol is not None:"},{"line_number":373,"context_line":"            listener_name \u003d data_utils.rand_name(\"lb_member_listener1_pool\")"},{"line_number":374,"context_line":"            listener_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"07536586_3548b6fd","line":371,"in_reply_to":"5f5cbe05_555b927d","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: E303 too many blank lines (2)\n\nPlease fix.","commit_id":"4c0f9b094c7a973dbad8651f3d208ed51390ac6d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0d6e4c157cab8a5e7c2f6a077a44ea58f624e5b2","unresolved":true,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Provides automated coverage for RHELOSP-63931"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        LC \u003d const.LB_ALGORITHM_LEAST_CONNECTIONS"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ac3a1ee_b59f37e4","line":335,"range":{"start_line":335,"start_character":43,"end_line":335,"end_character":56},"updated":"2021-01-12 21:10:28.000000000","message":"Is there an upstream story?  No one will know what this means.","commit_id":"20a104a3004052835985b99f1004fa3a24826ce3"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Provides automated coverage for RHELOSP-63931"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        LC \u003d const.LB_ALGORITHM_LEAST_CONNECTIONS"}],"source_content_type":"text/x-python","patch_set":3,"id":"bea58d78_7d1607be","line":335,"range":{"start_line":335,"start_character":43,"end_line":335,"end_character":56},"in_reply_to":"4ac3a1ee_b59f37e4","updated":"2021-01-14 07:10:53.000000000","message":"Done","commit_id":"20a104a3004052835985b99f1004fa3a24826ce3"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the updating of the pool\u0027s loadbalancing algorithm"},{"line_number":336,"context_line":"        "},{"line_number":337,"context_line":"           Tests the update on an active loadbalancer pool and "},{"line_number":338,"context_line":"           verifies that the netwok pesumes running"},{"line_number":339,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f7729afd_7be32ede","line":336,"in_reply_to":"981ed634_19662dc4","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"d76c0fd9df1ebc50b125bd5e51c5c78175017d87"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the updating of the pool\u0027s loadbalancing algorithm"},{"line_number":336,"context_line":"        "},{"line_number":337,"context_line":"           Tests the update on an active loadbalancer pool and "},{"line_number":338,"context_line":"           verifies that the netwok pesumes running"},{"line_number":339,"context_line":"        \"\"\""},{"line_number":340,"context_line":"        LC \u003d const.LB_ALGORITHM_LEAST_CONNECTIONS"}],"source_content_type":"text/x-python","patch_set":4,"id":"248b8413_96af489d","line":337,"in_reply_to":"1dd9fee5_7037b8e9","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: W291 trailing whitespace\n\nPlease fix.","commit_id":"d76c0fd9df1ebc50b125bd5e51c5c78175017d87"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"9221024cb37991e16b430219abd5d0f770a58864","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_SIP_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the updating of the pool\u0027s loadbalancing algorithm"},{"line_number":336,"context_line":"        "},{"line_number":337,"context_line":"           Tests the update on an active loadbalancer pool and"},{"line_number":338,"context_line":"           verifies that the netwok pesumes running"},{"line_number":339,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"eb9ac29b_04a93dac","line":336,"in_reply_to":"3685161d_26f3a104","updated":"2021-01-14 07:10:53.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"c227ccda845616d78bb0d5fe563ec65621b9ebf4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45e4a3419512189f167b04c48a05dc72d5a3429c","unresolved":true,"context_lines":[{"line_number":335,"context_line":"        \"\"\"Tests the updating of the pool\u0027s loadbalancing algorithm"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"           Tests the update on an active loadbalancer pool and"},{"line_number":338,"context_line":"           verifies that the netwok pesumes running"},{"line_number":339,"context_line":"        \"\"\""},{"line_number":340,"context_line":"        LC \u003d const.LB_ALGORITHM_LEAST_CONNECTIONS"},{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5730db11_a42d8370","line":338,"range":{"start_line":338,"start_character":29,"end_line":338,"end_character":43},"updated":"2021-01-15 02:35:22.000000000","message":"nit: network resumes","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"cb127953e5dc1678438784383ea5be53d4c06c98","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        \"\"\"Tests the updating of the pool\u0027s loadbalancing algorithm"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"           Tests the update on an active loadbalancer pool and"},{"line_number":338,"context_line":"           verifies that the netwok pesumes running"},{"line_number":339,"context_line":"        \"\"\""},{"line_number":340,"context_line":"        LC \u003d const.LB_ALGORITHM_LEAST_CONNECTIONS"},{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f83f857c_bd0d56c5","line":338,"range":{"start_line":338,"start_character":29,"end_line":338,"end_character":43},"in_reply_to":"5730db11_a42d8370","updated":"2021-01-17 12:58:20.000000000","message":"Done","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45e4a3419512189f167b04c48a05dc72d5a3429c","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":342,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"},{"line_number":343,"context_line":"                             algorithm\u003dconst.LB_ALGORITHM_SOURCE_IP_PORT,"},{"line_number":344,"context_line":"                             next_algorithm\u003dLC)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":347,"context_line":"                        algorithm, session_persistence\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"49a4a01d_0aeb1e83","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":46},"updated":"2021-01-15 02:35:22.000000000","message":"I don\u0027t see a reason to not just use the constant directly here","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"cb127953e5dc1678438784383ea5be53d4c06c98","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":342,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"},{"line_number":343,"context_line":"                             algorithm\u003dconst.LB_ALGORITHM_SOURCE_IP_PORT,"},{"line_number":344,"context_line":"                             next_algorithm\u003dLC)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":347,"context_line":"                        algorithm, session_persistence\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ebd4b43c_368ac209","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":46},"in_reply_to":"49a4a01d_0aeb1e83","updated":"2021-01-17 12:58:20.000000000","message":"The only reason is that I was hitting the PEP8 line length limitation and couldn\u0027t get around it without violating the indentation rules.","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45e4a3419512189f167b04c48a05dc72d5a3429c","unresolved":true,"context_lines":[{"line_number":493,"context_line":"            const.NAME: new_name,"},{"line_number":494,"context_line":"            const.DESCRIPTION: new_description,"},{"line_number":495,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":496,"context_line":"            const.LB_ALGORITHM: next_algorithm,"},{"line_number":497,"context_line":"        }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # We have to set it to the same protocol as not all"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e889821_b6a4ac57","line":496,"updated":"2021-01-15 02:35:22.000000000","message":"This might be causing the problem, perhaps don\u0027t do this here, but instead update the kwargs if it is set?  Just taking a guess.","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"cb127953e5dc1678438784383ea5be53d4c06c98","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            const.NAME: new_name,"},{"line_number":494,"context_line":"            const.DESCRIPTION: new_description,"},{"line_number":495,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":496,"context_line":"            const.LB_ALGORITHM: next_algorithm,"},{"line_number":497,"context_line":"        }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # We have to set it to the same protocol as not all"}],"source_content_type":"text/x-python","patch_set":6,"id":"18a943e8_f7a7c932","line":496,"in_reply_to":"4e889821_b6a4ac57","updated":"2021-01-17 12:58:20.000000000","message":"Thanks, tried that - no change","commit_id":"e921aa1dda072dc4501b3661767e0abaf7ab1d65"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"878ad86e2ddab827d4c1f0716f4cbb85b990425c","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":342,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"},{"line_number":343,"context_line":"                             algorithm\u003dconst.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":344,"context_line":"                             next_algorithm\u003dLC)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":347,"context_line":"                        algorithm, session_persistence\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e2d8cb8a_f6f6dd4a","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":46},"updated":"2021-01-18 13:27:45.000000000","message":"you can use the same alignment as the previous function (test_UDP_RR_source_ip_pool_with_listener_CRUD) it wouldn\u0027t break pep8","commit_id":"24b41d23244d4023f76c64e99ff9ee752ce0316b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"fe112d47f4ce78e5e2d86ed8eb5164e95b62bbee","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self._test_pool_CRUD(listener_protocol\u003dconst.UDP,"},{"line_number":342,"context_line":"                             pool_protocol\u003dconst.UDP, protocol_port\u003d54,"},{"line_number":343,"context_line":"                             algorithm\u003dconst.LB_ALGORITHM_ROUND_ROBIN,"},{"line_number":344,"context_line":"                             next_algorithm\u003dLC)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _test_pool_CRUD(self, listener_protocol, pool_protocol, protocol_port,"},{"line_number":347,"context_line":"                        algorithm, session_persistence\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e0caa3fc_ad3de1e2","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":46},"in_reply_to":"e2d8cb8a_f6f6dd4a","updated":"2021-01-19 13:27:47.000000000","message":"Done","commit_id":"24b41d23244d4023f76c64e99ff9ee752ce0316b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"878ad86e2ddab827d4c1f0716f4cbb85b990425c","unresolved":true,"context_lines":[{"line_number":493,"context_line":"            const.NAME: new_name,"},{"line_number":494,"context_line":"            const.DESCRIPTION: new_description,"},{"line_number":495,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":496,"context_line":"            const.LB_ALGORITHM: next_algorithm,"},{"line_number":497,"context_line":"        }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # We have to set it to the same protocol as not all"}],"source_content_type":"text/x-python","patch_set":8,"id":"6c8548c7_511c04b1","line":496,"range":{"start_line":496,"start_character":12,"end_line":496,"end_character":47},"updated":"2021-01-18 13:27:45.000000000","message":"I agree with Brian\u0027s comment in a previous patchset, I would only set LB_ALGORITHM if it\u0027s different from the previous value","commit_id":"24b41d23244d4023f76c64e99ff9ee752ce0316b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"fe112d47f4ce78e5e2d86ed8eb5164e95b62bbee","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            const.NAME: new_name,"},{"line_number":494,"context_line":"            const.DESCRIPTION: new_description,"},{"line_number":495,"context_line":"            const.ADMIN_STATE_UP: True,"},{"line_number":496,"context_line":"            const.LB_ALGORITHM: next_algorithm,"},{"line_number":497,"context_line":"        }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # We have to set it to the same protocol as not all"}],"source_content_type":"text/x-python","patch_set":8,"id":"95f5f17e_05aab8ee","line":496,"range":{"start_line":496,"start_character":12,"end_line":496,"end_character":47},"in_reply_to":"6c8548c7_511c04b1","updated":"2021-01-19 13:27:47.000000000","message":"Done","commit_id":"24b41d23244d4023f76c64e99ff9ee752ce0316b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_RR_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the update on an active loadbalancer pool and"},{"line_number":336,"context_line":"           verifies that the network resumes running"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self._test_pool_CRUD("}],"source_content_type":"text/x-python","patch_set":9,"id":"b5048508_fd5c39f9","line":335,"in_reply_to":"32ff4591_f8dc9359","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: H405: multi line docstring summary not separated with an empty line\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    @decorators.idempotent_id(\u00271868a57c-a124-4011-bc7d-9e05b5b45104\u0027)"},{"line_number":334,"context_line":"    def test_UDP_RR_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the update on an active loadbalancer pool and"},{"line_number":336,"context_line":"           verifies that the network resumes running"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self._test_pool_CRUD("},{"line_number":339,"context_line":"            listener_protocol\u003dconst.UDP,"}],"source_content_type":"text/x-python","patch_set":9,"id":"d3a6ee90_0e6e375b","line":336,"in_reply_to":"0ac5d1f8_d0caf459","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: H405: multi line docstring summary not separated with an empty line\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    def test_UDP_RR_to_LC_pool_with_listener_CRUD(self):"},{"line_number":335,"context_line":"        \"\"\"Tests the update on an active loadbalancer pool and"},{"line_number":336,"context_line":"           verifies that the network resumes running"},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self._test_pool_CRUD("},{"line_number":339,"context_line":"            listener_protocol\u003dconst.UDP,"},{"line_number":340,"context_line":"            pool_protocol\u003dconst.UDP, protocol_port\u003d54,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ab03a932_3ae4d0ec","line":337,"in_reply_to":"5611c8bf_6a036d9f","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: H405: multi line docstring summary not separated with an empty line\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_pool1-update\")"},{"line_number":487,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":488,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":489,"context_line":"      # if the LB algorithm is being updated "},{"line_number":490,"context_line":"        if next_algorithm is not None:"},{"line_number":491,"context_line":"        "},{"line_number":492,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"}],"source_content_type":"text/x-python","patch_set":9,"id":"35458fb9_b0158839","line":489,"in_reply_to":"2eb5e4d8_505d09ca","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: E114 indentation is not a multiple of four (comment)\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_pool1-update\")"},{"line_number":487,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":488,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":489,"context_line":"      # if the LB algorithm is being updated "},{"line_number":490,"context_line":"        if next_algorithm is not None:"},{"line_number":491,"context_line":"        "},{"line_number":492,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"}],"source_content_type":"text/x-python","patch_set":9,"id":"a7e4bb5d_99f8847e","line":489,"in_reply_to":"441e8454_6f8c673b","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: W291 trailing whitespace\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":489,"context_line":"      # if the LB algorithm is being updated "},{"line_number":490,"context_line":"        if next_algorithm is not None:"},{"line_number":491,"context_line":"        "},{"line_number":492,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":493,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":494,"context_line":"                    self.api_version, \u00272.13\u0027)):"}],"source_content_type":"text/x-python","patch_set":9,"id":"cf9e8f68_97ae4d2d","line":491,"in_reply_to":"8a159bc0_ddffb74e","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":503,"context_line":"                const.LB_ALGORITHM: next_algorithm,"},{"line_number":504,"context_line":"            }"},{"line_number":505,"context_line":"        "},{"line_number":506,"context_line":"      # No update of the algorithm"},{"line_number":507,"context_line":"        else:     "},{"line_number":508,"context_line":"            pool_update_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"9d13b34a_b1caf755","line":505,"in_reply_to":"9d14cc02_883f95c6","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                const.LB_ALGORITHM: next_algorithm,"},{"line_number":504,"context_line":"            }"},{"line_number":505,"context_line":"        "},{"line_number":506,"context_line":"      # No update of the algorithm"},{"line_number":507,"context_line":"        else:     "},{"line_number":508,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":509,"context_line":"                const.NAME: new_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"25e1ef77_17b917f7","line":506,"in_reply_to":"957a0097_51c499da","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: E114 indentation is not a multiple of four (comment)\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            }"},{"line_number":505,"context_line":"        "},{"line_number":506,"context_line":"      # No update of the algorithm"},{"line_number":507,"context_line":"        else:     "},{"line_number":508,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":509,"context_line":"                const.NAME: new_name,"},{"line_number":510,"context_line":"                const.DESCRIPTION: new_description,"}],"source_content_type":"text/x-python","patch_set":9,"id":"36c692c2_f87f722c","line":507,"in_reply_to":"e6c7d008_1bae78e9","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: W291 trailing whitespace\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4afafc41b227d08e4253e06c768ca92ebd54bfa","unresolved":true,"context_lines":[{"line_number":509,"context_line":"                const.NAME: new_name,"},{"line_number":510,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":511,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":512,"context_line":"            }"},{"line_number":513,"context_line":"      "},{"line_number":514,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":515,"context_line":"        # drivers support more than one pool algorithm"}],"source_content_type":"text/x-python","patch_set":9,"id":"77d4f0da_4a7d321a","line":512,"updated":"2021-01-21 16:25:43.000000000","message":"Let\u0027s not copy all this code, we can define this dict all the time, then just add the algorithm element.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"253753a38012d5c3c69dcdce4d4998aa0c38bbbd","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                const.NAME: new_name,"},{"line_number":510,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":511,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":512,"context_line":"            }"},{"line_number":513,"context_line":"      "},{"line_number":514,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":515,"context_line":"        # drivers support more than one pool algorithm"}],"source_content_type":"text/x-python","patch_set":9,"id":"45db114c_a83251d9","line":512,"in_reply_to":"77d4f0da_4a7d321a","updated":"2021-02-10 07:47:55.000000000","message":"Done","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":511,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":512,"context_line":"            }"},{"line_number":513,"context_line":"      "},{"line_number":514,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":515,"context_line":"        # drivers support more than one pool algorithm"},{"line_number":516,"context_line":"        pool_update_kwargs[const.LB_ALGORITHM] \u003d (new_algorithm or algorithm)"}],"source_content_type":"text/x-python","patch_set":9,"id":"63050858_f9e25623","line":513,"in_reply_to":"9d2e67b9_b697889e","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"a555120406df0f2fd19dbbec912d07ebd180e108","unresolved":false,"context_lines":[{"line_number":513,"context_line":"      "},{"line_number":514,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":515,"context_line":"        # drivers support more than one pool algorithm"},{"line_number":516,"context_line":"        pool_update_kwargs[const.LB_ALGORITHM] \u003d (new_algorithm or algorithm)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":519,"context_line":"            pool_update_kwargs[const.SESSION_PERSISTENCE] \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"56c2af76_9d514b17","line":516,"in_reply_to":"dc4d48d4_f2068c8e","updated":"2021-01-25 15:48:30.000000000","message":"\u003e pep8: F821 undefined name \u0027new_algorithm\u0027\n\nPlease fix.","commit_id":"0b40141e24a41415b4190a85750bb8a1bcc46f7b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"41e26b09ed89a206d2cf1e46baf91cb8cecf3a47","unresolved":true,"context_lines":[{"line_number":488,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":16,"id":"7af498ca_4a218423","line":491,"updated":"2021-05-02 08:48:42.000000000","message":"nit: to remove a little bit of duplicated code I would remove lines: 491, 500-505, 508 and add:\n\nif next_algorithm:\n    pool_update_kwargs[const.LB_ALGORITHM] \u003d next_algorithm","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":16,"id":"0de15c1a_16fe06ed","line":491,"in_reply_to":"7af498ca_4a218423","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"41e26b09ed89a206d2cf1e46baf91cb8cecf3a47","unresolved":true,"context_lines":[{"line_number":550,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":551,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":552,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":553,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":554,"context_line":"        if listener_protocol is not None:"},{"line_number":555,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":556,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1915383f_4b33acd1","line":553,"updated":"2021-05-02 08:48:42.000000000","message":"This way lb_algorithm is not being checked after pool update.\nI would add:\n\nif next_algorithm:\n    assertEqual...","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":551,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":552,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":553,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":554,"context_line":"        if listener_protocol is not None:"},{"line_number":555,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":556,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":16,"id":"2032028c_3714a3e8","line":553,"in_reply_to":"1915383f_4b33acd1","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"41e26b09ed89a206d2cf1e46baf91cb8cecf3a47","unresolved":true,"context_lines":[{"line_number":558,"context_line":"                const.ONLINE,"},{"line_number":559,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":560,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":561,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":564,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"}],"source_content_type":"text/x-python","patch_set":16,"id":"bd84b2d5_e682454e","line":561,"updated":"2021-05-02 08:48:42.000000000","message":"Why does this line repeat? Do we want to make sure waiting for pool operating status to be active doesn\u0027t change the lb_algorithm?","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                const.ONLINE,"},{"line_number":559,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":560,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":561,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":564,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9e6935d2_2736c666","line":561,"in_reply_to":"bd84b2d5_e682454e","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"6fc01c9b5b82e35a185186fec9264bf135e69394"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f33005d5a246c13cd613341fd611a54587bb456e","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        * Update the pool."},{"line_number":353,"context_line":"        * Delete the pool."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if (algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":356,"context_line":"            self.mem_listener_client.is_version_supported("},{"line_number":357,"context_line":"                self.api_version, \u00272.13\u0027)):"},{"line_number":358,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":359,"context_line":"                \u0027Skipping this test as load balancing algorithm \u0027"},{"line_number":360,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        # same test for next_algorithm if it exists"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":365,"context_line":"            self.mem_listener_client.is_version_supported("},{"line_number":366,"context_line":"                self.api_version, \u00272.13\u0027)):"},{"line_number":367,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":368,"context_line":"                \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":369,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # Listener create"},{"line_number":372,"context_line":"        if listener_protocol is not None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"a65f9929_61147681","line":369,"range":{"start_line":355,"start_character":0,"end_line":369,"end_character":69},"updated":"2021-05-02 14:12:11.000000000","message":"Maybe we can combine both into one skip check as these are exactly the same lines?\nI mean:\n\nalgorithms\u003d[algorithm]\nif next_algorithm !\u003d None:\n    algorithms.append(next_algorithm)\nfor alg in algorithms:\n    # CHECK SKIP\n     if (alg ...\n     paka paka...","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        * Update the pool."},{"line_number":353,"context_line":"        * Delete the pool."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        if (algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":356,"context_line":"            self.mem_listener_client.is_version_supported("},{"line_number":357,"context_line":"                self.api_version, \u00272.13\u0027)):"},{"line_number":358,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":359,"context_line":"                \u0027Skipping this test as load balancing algorithm \u0027"},{"line_number":360,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        # same test for next_algorithm if it exists"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":365,"context_line":"            self.mem_listener_client.is_version_supported("},{"line_number":366,"context_line":"                self.api_version, \u00272.13\u0027)):"},{"line_number":367,"context_line":"            raise testtools.TestCase.skipException("},{"line_number":368,"context_line":"                \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":369,"context_line":"                \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # Listener create"},{"line_number":372,"context_line":"        if listener_protocol is not None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"c3904541_e1e263fd","line":369,"range":{"start_line":355,"start_character":0,"end_line":369,"end_character":69},"in_reply_to":"a65f9929_61147681","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f33005d5a246c13cd613341fd611a54587bb456e","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":495,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":496,"context_line":"                raise testtools.TestCase.skipException("},{"line_number":497,"context_line":"                    \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":498,"context_line":"                    \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":501,"context_line":"                const.NAME: new_name,"},{"line_number":502,"context_line":"                const.DESCRIPTION: new_description,"}],"source_content_type":"text/x-python","patch_set":17,"id":"2777bdf6_75c74744","line":499,"range":{"start_line":492,"start_character":0,"end_line":499,"end_character":0},"updated":"2021-05-02 14:12:11.000000000","message":"We already have this skip check in L364, don\u0027t we?","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":495,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":496,"context_line":"                raise testtools.TestCase.skipException("},{"line_number":497,"context_line":"                    \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":498,"context_line":"                    \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":501,"context_line":"                const.NAME: new_name,"},{"line_number":502,"context_line":"                const.DESCRIPTION: new_description,"}],"source_content_type":"text/x-python","patch_set":17,"id":"74624dac_e3e05872","line":499,"range":{"start_line":492,"start_character":0,"end_line":499,"end_character":0},"in_reply_to":"2777bdf6_75c74744","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f33005d5a246c13cd613341fd611a54587bb456e","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_pool1-update\")"},{"line_number":488,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":495,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":496,"context_line":"                raise testtools.TestCase.skipException("},{"line_number":497,"context_line":"                    \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":498,"context_line":"                    \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":501,"context_line":"                const.NAME: new_name,"},{"line_number":502,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":503,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":504,"context_line":"                const.LB_ALGORITHM: next_algorithm,"},{"line_number":505,"context_line":"            }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        # No update of the algorithm"},{"line_number":508,"context_line":"        else:"},{"line_number":509,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":510,"context_line":"                const.NAME: new_name,"},{"line_number":511,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":512,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":513,"context_line":"            }"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":516,"context_line":"        # drivers support more than one pool algorithm"},{"line_number":517,"context_line":"        pool_update_kwargs[const.LB_ALGORITHM] \u003d (next_algorithm or algorithm)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":520,"context_line":"            pool_update_kwargs[const.SESSION_PERSISTENCE] \u003d {"}],"source_content_type":"text/x-python","patch_set":17,"id":"f7368377_543b4afb","line":517,"range":{"start_line":490,"start_character":0,"end_line":517,"end_character":78},"updated":"2021-05-02 14:12:11.000000000","message":"Will this code implementing the same logic?\n\npool_update_kwargs \u003d {\n    const.NAME: new_name,\n    const.DESCRIPTION: new_description,\n    const.ADMIN_STATE_UP: True,\n    const.LB_ALGORITHM: algorithm}\n\nif next_algorithm is not None:\n    pool_update_kwargs[const.LB_ALGORITHM] \u003d (next_algorithm)","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        new_name \u003d data_utils.rand_name(\"lb_member_pool1-update\")"},{"line_number":488,"context_line":"        new_description \u003d data_utils.arbitrary_string(size\u003d255,"},{"line_number":489,"context_line":"                                                      base_text\u003d\u0027new\u0027)"},{"line_number":490,"context_line":"        # if the LB algorithm is being updated"},{"line_number":491,"context_line":"        if next_algorithm is not None:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            if (next_algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":494,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":495,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":496,"context_line":"                raise testtools.TestCase.skipException("},{"line_number":497,"context_line":"                    \u0027Skipping this test as next load balancing algorithm \u0027"},{"line_number":498,"context_line":"                    \u0027SOURCE_IP_PORT requires API version 2.13 or newer.\u0027)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":501,"context_line":"                const.NAME: new_name,"},{"line_number":502,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":503,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":504,"context_line":"                const.LB_ALGORITHM: next_algorithm,"},{"line_number":505,"context_line":"            }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        # No update of the algorithm"},{"line_number":508,"context_line":"        else:"},{"line_number":509,"context_line":"            pool_update_kwargs \u003d {"},{"line_number":510,"context_line":"                const.NAME: new_name,"},{"line_number":511,"context_line":"                const.DESCRIPTION: new_description,"},{"line_number":512,"context_line":"                const.ADMIN_STATE_UP: True,"},{"line_number":513,"context_line":"            }"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # We have to set it to the same protocol as not all"},{"line_number":516,"context_line":"        # drivers support more than one pool algorithm"},{"line_number":517,"context_line":"        pool_update_kwargs[const.LB_ALGORITHM] \u003d (next_algorithm or algorithm)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":520,"context_line":"            pool_update_kwargs[const.SESSION_PERSISTENCE] \u003d {"}],"source_content_type":"text/x-python","patch_set":17,"id":"2f1b7e45_7c734c24","line":517,"range":{"start_line":490,"start_character":0,"end_line":517,"end_character":78},"in_reply_to":"f7368377_543b4afb","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f33005d5a246c13cd613341fd611a54587bb456e","unresolved":true,"context_lines":[{"line_number":550,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":551,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":552,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":553,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":554,"context_line":"        if listener_protocol is not None:"},{"line_number":555,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":556,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff9c9b5f_3803c236","line":553,"range":{"start_line":553,"start_character":6,"end_line":553,"end_character":63},"updated":"2021-05-02 14:12:11.000000000","message":"Why not removing this comment line?","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":551,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":552,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":553,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":554,"context_line":"        if listener_protocol is not None:"},{"line_number":555,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":556,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":17,"id":"baf52378_9a15c1bf","line":553,"range":{"start_line":553,"start_character":6,"end_line":553,"end_character":63},"in_reply_to":"ff9c9b5f_3803c236","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f33005d5a246c13cd613341fd611a54587bb456e","unresolved":true,"context_lines":[{"line_number":558,"context_line":"                const.ONLINE,"},{"line_number":559,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":560,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":561,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":564,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9876d90c_e57c0d1d","line":561,"range":{"start_line":561,"start_character":0,"end_line":561,"end_character":63},"updated":"2021-05-02 14:12:11.000000000","message":"Same as in L:553","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                const.ONLINE,"},{"line_number":559,"context_line":"                CONF.load_balancer.build_interval,"},{"line_number":560,"context_line":"                CONF.load_balancer.build_timeout)"},{"line_number":561,"context_line":"        # self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":564,"context_line":"            self.assertIsNotNone(pool.get(const.SESSION_PERSISTENCE))"}],"source_content_type":"text/x-python","patch_set":17,"id":"70e3a15e_3a165c51","line":561,"range":{"start_line":561,"start_character":0,"end_line":561,"end_character":63},"in_reply_to":"9876d90c_e57c0d1d","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3ceae99ba91cdf15335f3b7d53e6cc3263939702"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3f039679ac9e4f6834cdb918df40400c34836759","unresolved":true,"context_lines":[{"line_number":357,"context_line":"        if next_algorithm is not None:"},{"line_number":358,"context_line":"            algorithms.append(next_algorithm)"},{"line_number":359,"context_line":"        for alg in algorithms:"},{"line_number":360,"context_line":"            if (algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":361,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":362,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":363,"context_line":"                raise testtools.TestCase.skipException("}],"source_content_type":"text/x-python","patch_set":19,"id":"998ae846_7d66523b","line":360,"range":{"start_line":360,"start_character":16,"end_line":360,"end_character":26},"updated":"2021-05-06 07:55:20.000000000","message":"Should be \"alg\" instead of \"algorithm\"","commit_id":"640564de526b5f4a4080175f453e4f869c5ec6a7"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        if next_algorithm is not None:"},{"line_number":358,"context_line":"            algorithms.append(next_algorithm)"},{"line_number":359,"context_line":"        for alg in algorithms:"},{"line_number":360,"context_line":"            if (algorithm \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":361,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":362,"context_line":"                    self.api_version, \u00272.13\u0027)):"},{"line_number":363,"context_line":"                raise testtools.TestCase.skipException("}],"source_content_type":"text/x-python","patch_set":19,"id":"ef7c3909_400cf5ea","line":360,"range":{"start_line":360,"start_character":16,"end_line":360,"end_character":26},"in_reply_to":"998ae846_7d66523b","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"640564de526b5f4a4080175f453e4f869c5ec6a7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"cabdb68d8191e48a5436e31b3a08fb044cba1845","unresolved":true,"context_lines":[{"line_number":509,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":510,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":511,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":512,"context_line":"        self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":513,"context_line":"        if listener_protocol is not None:"},{"line_number":514,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":515,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":20,"id":"258e85c6_b2568e5c","side":"PARENT","line":512,"range":{"start_line":512,"start_character":8,"end_line":512,"end_character":61},"updated":"2021-05-06 08:42:00.000000000","message":"You removed the only check that could verify that the algorithm has been correctly updated","commit_id":"3497f6cb7067eab4e37aaeb376e56ef3fa7cf395"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        self.assertEqual(new_name, pool[const.NAME])"},{"line_number":510,"context_line":"        self.assertEqual(new_description, pool[const.DESCRIPTION])"},{"line_number":511,"context_line":"        self.assertTrue(pool[const.ADMIN_STATE_UP])"},{"line_number":512,"context_line":"        self.assertEqual(algorithm, pool[const.LB_ALGORITHM])"},{"line_number":513,"context_line":"        if listener_protocol is not None:"},{"line_number":514,"context_line":"            pool \u003d waiters.wait_for_status("},{"line_number":515,"context_line":"                self.mem_pool_client.show_pool,"}],"source_content_type":"text/x-python","patch_set":20,"id":"e0729d9b_51a1160a","side":"PARENT","line":512,"range":{"start_line":512,"start_character":8,"end_line":512,"end_character":61},"in_reply_to":"258e85c6_b2568e5c","updated":"2021-05-09 14:01:24.000000000","message":"Done","commit_id":"3497f6cb7067eab4e37aaeb376e56ef3fa7cf395"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"cabdb68d8191e48a5436e31b3a08fb044cba1845","unresolved":true,"context_lines":[{"line_number":356,"context_line":"        algorithms \u003d [algorithm]"},{"line_number":357,"context_line":"        if next_algorithm is not None:"},{"line_number":358,"context_line":"            algorithms.append(next_algorithm)"},{"line_number":359,"context_line":"        for alg in algorithms:"},{"line_number":360,"context_line":"            if (alg \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":361,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":362,"context_line":"                    self.api_version, \u00272.13\u0027)):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7ad6a1b9_2ab18bab","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":30},"updated":"2021-05-06 08:42:00.000000000","message":"nit: you don\u0027t need a loop to evaluate algorithm and next_algorithm","commit_id":"b88bce2375610e7d427a159510c4b27a464d839c"},{"author":{"_account_id":32137,"name":"Arieh Maron","email":"amaron@redhat.com","username":"amaron"},"change_message_id":"e1b43939b971067c7f47da9147ab68ff050d812c","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        algorithms \u003d [algorithm]"},{"line_number":357,"context_line":"        if next_algorithm is not None:"},{"line_number":358,"context_line":"            algorithms.append(next_algorithm)"},{"line_number":359,"context_line":"        for alg in algorithms:"},{"line_number":360,"context_line":"            if (alg \u003d\u003d const.LB_ALGORITHM_SOURCE_IP_PORT and not"},{"line_number":361,"context_line":"                self.mem_listener_client.is_version_supported("},{"line_number":362,"context_line":"                    self.api_version, \u00272.13\u0027)):"}],"source_content_type":"text/x-python","patch_set":20,"id":"4aafdf91_2e9cd267","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":30},"in_reply_to":"7ad6a1b9_2ab18bab","updated":"2021-05-09 14:01:24.000000000","message":"true but, this \"leaves room\" for further expansion","commit_id":"b88bce2375610e7d427a159510c4b27a464d839c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"cabdb68d8191e48a5436e31b3a08fb044cba1845","unresolved":true,"context_lines":[{"line_number":491,"context_line":"            }"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        if next_algorithm is not None:"},{"line_number":494,"context_line":"            pool_update_kwargs[const.LB_ALGORITHM] \u003d (next_algorithm)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if session_persistence \u003d\u003d const.SESSION_PERSISTENCE_APP_COOKIE:"},{"line_number":497,"context_line":"            pool_update_kwargs[const.SESSION_PERSISTENCE] \u003d {"}],"source_content_type":"text/x-python","patch_set":20,"id":"58421b07_ce5ebd8d","line":494,"range":{"start_line":494,"start_character":12,"end_line":494,"end_character":69},"updated":"2021-05-06 08:42:00.000000000","message":"here you\u0027re changing the behavior of the other tests, if next_algorithm is None, we need to set lb_algorithm to \u0027algorithm\u0027","commit_id":"b88bce2375610e7d427a159510c4b27a464d839c"}]}