)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1ebca38c1d367c91ebf7013ebe09ad1b52a070fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c359cbf6_6c5dadf2","updated":"2023-08-23 21:31:56.000000000","message":"LGTM","commit_id":"38b6917f191d2350a61f59dab1d4ed18c2fa3edd"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b816a0f35535bce12fd5210ffeb6ac24f92e8c38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7e6a783_3dbdddc5","updated":"2023-08-15 12:35:21.000000000","message":"recheck (long time since last run)","commit_id":"38b6917f191d2350a61f59dab1d4ed18c2fa3edd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"03be99f2f15ce7fc9d3b72234476e99864435313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d273043c_0108a43e","updated":"2024-09-24 11:34:19.000000000","message":"Thanks for the review, I\u0027ve just updated the patch","commit_id":"22c7f4f1c9c6e859f22ecf3ec5a8b523ec75e73a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"33de5740439e418bf8470c907516806d36a91fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87c15c84_8ae2894f","updated":"2024-09-30 17:09:51.000000000","message":"LGTM","commit_id":"5010dc07d2f87bbf8382151bd1ba4c99b672d58d"}],"octavia_tempest_plugin/tests/scenario/v2/test_load_balancer.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a0f3a82b263f9196c65150ef65bccf2521ef7cd","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                    raise cls.skipException(msg)"},{"line_number":90,"context_line":"                flavor_id \u003d None"},{"line_number":91,"context_line":"            return flavor_id"},{"line_number":92,"context_line":"        return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @decorators.idempotent_id(\u0027a5e2e120-4f7e-4c8b-8aac-cf09cb56711c\u0027)"},{"line_number":95,"context_line":"    def test_load_balancer_ipv4_CRUD(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0faf96d_67d16bc5","line":92,"updated":"2021-02-02 14:54:11.000000000","message":"nit: not required since None is implied, although it\u0027s probably a pep8 thing.  Unless you just initialize flavor_id\u003dNone above and have a single return.","commit_id":"0448a40f0685dcd19d346a10bad15fb20ddfc81c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f2f1aeb3c70ce224b1237274093943bb6ae5206b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                    raise cls.skipException(msg)"},{"line_number":90,"context_line":"                flavor_id \u003d None"},{"line_number":91,"context_line":"            return flavor_id"},{"line_number":92,"context_line":"        return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @decorators.idempotent_id(\u0027a5e2e120-4f7e-4c8b-8aac-cf09cb56711c\u0027)"},{"line_number":95,"context_line":"    def test_load_balancer_ipv4_CRUD(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d7466f1_47da4f45","line":92,"in_reply_to":"f0faf96d_67d16bc5","updated":"2021-02-02 17:38:37.000000000","message":"thanks, I simplified this function","commit_id":"0448a40f0685dcd19d346a10bad15fb20ddfc81c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a0f3a82b263f9196c65150ef65bccf2521ef7cd","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    @decorators.idempotent_id(\u0027c9d8b6dd-ef29-40d8-b329-86d31857df3f\u0027)"},{"line_number":105,"context_line":"    def test_load_balancer_ipv4_CRUD_with_compute_flavor(self):"},{"line_number":106,"context_line":"        self._test_load_balancer_CRUD(4,"},{"line_number":107,"context_line":"                                      use_custom_compute_flavor\u003dTrue)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _test_load_balancer_CRUD(self, ip_version,"},{"line_number":110,"context_line":"                                 use_custom_compute_flavor\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c4cd641_67702cd6","line":107,"updated":"2021-02-02 14:54:11.000000000","message":"Where\u0027s the IPv6 test :)","commit_id":"0448a40f0685dcd19d346a10bad15fb20ddfc81c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f2f1aeb3c70ce224b1237274093943bb6ae5206b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @decorators.idempotent_id(\u0027c9d8b6dd-ef29-40d8-b329-86d31857df3f\u0027)"},{"line_number":105,"context_line":"    def test_load_balancer_ipv4_CRUD_with_compute_flavor(self):"},{"line_number":106,"context_line":"        self._test_load_balancer_CRUD(4,"},{"line_number":107,"context_line":"                                      use_custom_compute_flavor\u003dTrue)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _test_load_balancer_CRUD(self, ip_version,"},{"line_number":110,"context_line":"                                 use_custom_compute_flavor\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"68808dd3_cb72cd4b","line":107,"in_reply_to":"1c4cd641_67702cd6","updated":"2021-02-02 17:38:37.000000000","message":"Done","commit_id":"0448a40f0685dcd19d346a10bad15fb20ddfc81c"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"98c567a466b8f228dde2f20ed7826a25f3ea6199","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                return flavor[const.ID]"},{"line_number":83,"context_line":"            except (testtools.TestCase.skipException,"},{"line_number":84,"context_line":"                    exceptions.NotImplemented):"},{"line_number":85,"context_line":"                msg \u003d \"Provider driver {} doesn\u0027t support flavors.\".format("},{"line_number":86,"context_line":"                    CONF.load_balancer.provider)"},{"line_number":87,"context_line":"                LOG.debug(msg)"},{"line_number":88,"context_line":"                if skip_on_not_implemented:"},{"line_number":89,"context_line":"                    raise cls.skipException(msg)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e917546f_96372932","line":87,"range":{"start_line":85,"start_character":16,"end_line":87,"end_character":30},"updated":"2024-09-24 10:23:56.000000000","message":"nit, it was better the way it was before, and we should prefer f-strings over string `format()` in general, but it is test code so it is not really a problem.","commit_id":"357ec7e0d005040a877e4a418f4d9d612be341a3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"03be99f2f15ce7fc9d3b72234476e99864435313","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                return flavor[const.ID]"},{"line_number":83,"context_line":"            except (testtools.TestCase.skipException,"},{"line_number":84,"context_line":"                    exceptions.NotImplemented):"},{"line_number":85,"context_line":"                msg \u003d \"Provider driver {} doesn\u0027t support flavors.\".format("},{"line_number":86,"context_line":"                    CONF.load_balancer.provider)"},{"line_number":87,"context_line":"                LOG.debug(msg)"},{"line_number":88,"context_line":"                if skip_on_not_implemented:"},{"line_number":89,"context_line":"                    raise cls.skipException(msg)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4d4468c6_f5beaf58","line":87,"range":{"start_line":85,"start_character":16,"end_line":87,"end_character":30},"in_reply_to":"e917546f_96372932","updated":"2024-09-24 11:34:19.000000000","message":"Acknowledged","commit_id":"357ec7e0d005040a877e4a418f4d9d612be341a3"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"98c567a466b8f228dde2f20ed7826a25f3ea6199","unresolved":true,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if use_custom_compute_flavor:"},{"line_number":196,"context_line":"            amphorae \u003d self.lb_admin_amphora_client.list_amphorae("},{"line_number":197,"context_line":"                query_params\u003d\u0027{loadbalancer_id}\u003d{lb_id}\u0027.format("},{"line_number":198,"context_line":"                    loadbalancer_id\u003dconst.LOADBALANCER_ID, lb_id\u003dlb[const.ID]))"},{"line_number":199,"context_line":"            amphora \u003d amphorae[0]"},{"line_number":200,"context_line":"            self.assertEqual(compute_flavor[const.ID],"}],"source_content_type":"text/x-python","patch_set":4,"id":"899eed23_07f61267","line":197,"range":{"start_line":197,"start_character":31,"end_line":197,"end_character":46},"updated":"2024-09-24 10:23:56.000000000","message":"Nit, I think even in tempest we should stop using string `format()` in new code.","commit_id":"357ec7e0d005040a877e4a418f4d9d612be341a3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"03be99f2f15ce7fc9d3b72234476e99864435313","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if use_custom_compute_flavor:"},{"line_number":196,"context_line":"            amphorae \u003d self.lb_admin_amphora_client.list_amphorae("},{"line_number":197,"context_line":"                query_params\u003d\u0027{loadbalancer_id}\u003d{lb_id}\u0027.format("},{"line_number":198,"context_line":"                    loadbalancer_id\u003dconst.LOADBALANCER_ID, lb_id\u003dlb[const.ID]))"},{"line_number":199,"context_line":"            amphora \u003d amphorae[0]"},{"line_number":200,"context_line":"            self.assertEqual(compute_flavor[const.ID],"}],"source_content_type":"text/x-python","patch_set":4,"id":"e019f198_d1c26b37","line":197,"range":{"start_line":197,"start_character":31,"end_line":197,"end_character":46},"in_reply_to":"899eed23_07f61267","updated":"2024-09-24 11:34:19.000000000","message":"Done","commit_id":"357ec7e0d005040a877e4a418f4d9d612be341a3"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"57bf9c1125502f1c4f169212082eafb35a964989","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            lb_admin_prefix.FlavorProfileClient())"},{"line_number":194,"context_line":"        cls.lb_admin_flavor_client \u003d lb_admin_prefix.FlavorClient()"},{"line_number":195,"context_line":"        # flavors_client (note the \u0027s\u0027) is the nova flavor client"},{"line_number":196,"context_line":"        cls.os_admin_compute_flavor_client \u003d cls.os_admin.flavors_client"},{"line_number":197,"context_line":"        cls.mem_flavor_client \u003d ("},{"line_number":198,"context_line":"            cls.os_roles_lb_member.load_balancer_v2.FlavorClient())"},{"line_number":199,"context_line":"        cls.mem_provider_client \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3102e621_59433bab","line":196,"range":{"start_line":196,"start_character":29,"end_line":196,"end_character":42},"updated":"2024-01-10 11:14:27.000000000","message":"why don\u0027t we call this `os_admin_compute_flavors_client` then?","commit_id":"38b6917f191d2350a61f59dab1d4ed18c2fa3edd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b00c64f813f128fbebde0538fcacd3f636dc073c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            lb_admin_prefix.FlavorProfileClient())"},{"line_number":194,"context_line":"        cls.lb_admin_flavor_client \u003d lb_admin_prefix.FlavorClient()"},{"line_number":195,"context_line":"        # flavors_client (note the \u0027s\u0027) is the nova flavor client"},{"line_number":196,"context_line":"        cls.os_admin_compute_flavor_client \u003d cls.os_admin.flavors_client"},{"line_number":197,"context_line":"        cls.mem_flavor_client \u003d ("},{"line_number":198,"context_line":"            cls.os_roles_lb_member.load_balancer_v2.FlavorClient())"},{"line_number":199,"context_line":"        cls.mem_provider_client \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ae34e416_e6c190a8","line":196,"range":{"start_line":196,"start_character":29,"end_line":196,"end_character":42},"in_reply_to":"3102e621_59433bab","updated":"2024-09-20 14:36:03.000000000","message":"Done","commit_id":"38b6917f191d2350a61f59dab1d4ed18c2fa3edd"}]}