)]}'
{"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"68e722be06c4a0ee48f61b0c64ef20e4679cf921","unresolved":true,"context_lines":[{"line_number":746,"context_line":"            # if lb_member_vip_ipv6_subnet uses devstack\u0027s subnetpool,"},{"line_number":747,"context_line":"            # plug the subnet into router1"},{"line_number":748,"context_line":"            router \u003d cls.os_admin.routers_client.list_routers("},{"line_number":749,"context_line":"                name\u003d\"router1\")[\u0027routers\u0027]"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            if len(router) \u003d\u003d 1:"},{"line_number":752,"context_line":"                router \u003d router[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"344f921c_ac8535e6","line":749,"updated":"2021-03-12 02:57:30.000000000","message":"The only problem I see with using \u0027router1\u0027 is that it\u0027s just a default for Q_ROUTER_NAME, so in theory it could change and break things even if it most likely won\u0027t.  Is the only other router in the list the one we just created above?","commit_id":"7f4a2f052581dff7f1a0720f46845bc814ce8746"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"bf3a9094ad79534492cd196d40c38588413fa80d","unresolved":true,"context_lines":[{"line_number":746,"context_line":"            # if lb_member_vip_ipv6_subnet uses devstack\u0027s subnetpool,"},{"line_number":747,"context_line":"            # plug the subnet into router1"},{"line_number":748,"context_line":"            router \u003d cls.os_admin.routers_client.list_routers("},{"line_number":749,"context_line":"                name\u003d\"router1\")[\u0027routers\u0027]"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            if len(router) \u003d\u003d 1:"},{"line_number":752,"context_line":"                router \u003d router[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f956bd38_1760a303","line":749,"in_reply_to":"27081645_334d49ec","updated":"2021-03-16 14:36:09.000000000","message":"I\u0027ve updated the patch, it adds 2 configuration options to specify the default ipv6 subnetpool and the default router, the values are populated in etc/tempest.conf from the devstack configuration in devstack/plugin.sh.","commit_id":"7f4a2f052581dff7f1a0720f46845bc814ce8746"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3b69e48b3d69f0b7b4ebd449725fdd5499bd8263","unresolved":true,"context_lines":[{"line_number":746,"context_line":"            # if lb_member_vip_ipv6_subnet uses devstack\u0027s subnetpool,"},{"line_number":747,"context_line":"            # plug the subnet into router1"},{"line_number":748,"context_line":"            router \u003d cls.os_admin.routers_client.list_routers("},{"line_number":749,"context_line":"                name\u003d\"router1\")[\u0027routers\u0027]"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            if len(router) \u003d\u003d 1:"},{"line_number":752,"context_line":"                router \u003d router[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"27081645_334d49ec","line":749,"in_reply_to":"344f921c_ac8535e6","updated":"2021-03-15 11:17:19.000000000","message":"We already had the same possible issue before this commit, because we used the \"ipv6-private-subnet\" subnet ($IPV6_PRIVATE_SUBNET_NAME) to plug the VIPs.\nI would not assume that any routers other than router1 and octavia-tempest-plugin\u0027s routers are present on the node.\nPerhaps we can add the detection of Q_ROUTER_NAME in devstack/plugin.sh, and add it as a config option in tempest.conf?","commit_id":"7f4a2f052581dff7f1a0720f46845bc814ce8746"}]}