)]}'
{"octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"740f3d074af704d16133d598a84c1aac5c59273b","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7a0bfff_3fdc53f5","line":206,"updated":"2021-03-02 19:55:23.000000000","message":"This should be something like:\n\n_, pool_id \u003d ...\n\nBut I can see why it was done this way to just make them all the same, and without passing the arg it would generate a pep8 error.  So not sure how important it is to change it.","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ad54780143966ad3d388c8445d1a1417fc214ee5","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a438bd5_21f01c9e","line":206,"in_reply_to":"16faef6a_04b4ce2e","updated":"2021-03-03 02:27:00.000000000","message":"\u003e We don\u0027t use \"_\" as a throw away variable in Octavia. It is a bad practice and leads to errors.\n\ngrep for \u0027 _, \u0027 and \u0027, _ \u0027 found 33 occurrences in the octavia tree, only 3 in tempest though in the go server...  \u0027__\u0027 ? :)\n\nI was trying to base my comments on the existing code.","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ef151c5eb768303ef87078233cf7e061e222f8ab","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"16faef6a_04b4ce2e","line":206,"in_reply_to":"188493c0_839294fd","updated":"2021-03-02 23:38:34.000000000","message":"We don\u0027t use \"_\" as a throw away variable in Octavia. It is a bad practice and leads to errors.\n\"_\" has multiple meanings in python, including being used for I18n. This causes linting failures as well as potential runtime issues.\nThe best practice is to use the index like Arkady did here.","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ac07911df361c08e7fd1553b66ba3d29b5281249","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"69b04e5b_e978abcc","line":206,"in_reply_to":"1a438bd5_21f01c9e","updated":"2021-03-03 10:03:09.000000000","message":"Done","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a4395ac7fd3cb0fc651f467a40fce531083c881f","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f954f857_9adca438","line":206,"in_reply_to":"e7a0bfff_3fdc53f5","updated":"2021-03-02 21:57:59.000000000","message":"Maybe that instead of using \"_\" as a throwaway variable (not a good practice) it was decided to have not used \"listener_id\" instead, but why not simply indexing what we actually need to call  functions, like: pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]?","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31d47ae7aa16244a787bada354955bb796aa5c95","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                      \u0027Traffic tests will not work in noop mode.\u0027)"},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00276751135d-e15a-4e22-89f4-bfcc3408d424\u0027)"},{"line_number":205,"context_line":"    def test_basic_http_traffic(self):"},{"line_number":206,"context_line":"        pool_id \u003d self._listener_pool_create(const.HTTP, 80)[1]"},{"line_number":207,"context_line":"        self._test_basic_traffic(const.HTTP, 80, pool_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @testtools.skipIf(CONF.load_balancer.test_with_noop,"}],"source_content_type":"text/x-python","patch_set":4,"id":"188493c0_839294fd","line":206,"in_reply_to":"f954f857_9adca438","updated":"2021-03-02 22:35:40.000000000","message":"Personally I think a throw-away is cleaner, and it\u0027s done elsewhere.  I\u0027m not sure what others think.","commit_id":"c2f481104affe1f7b12fbd1a61e6b041bdea31b1"}]}