)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dc91cf165157bd3f495257b7d263d97747d4db29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0fd9ca5_1e817c75","updated":"2022-11-14 17:29:23.000000000","message":"Also, maybe we should do a little input validation, if you use /data/15k you get a golang panic:\n2022/11/14 17:25:28 http: panic serving 172.24.4.69:44027: runtime error: index out of range [1] with length 0\n","commit_id":"3ed2c4e1f1ca23ae3a288586a14795387da91017"}],"octavia_tempest_plugin/contrib/test_server/test_server.go":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1048259308006f829c9b93b953ccac11f6822dfe","unresolved":true,"context_lines":[{"line_number":152,"context_line":"\tw.WriteHeader(http.StatusOK)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"\tbufferLen :\u003d len(bufferResp)"},{"line_number":155,"context_line":"\tfor i :\u003d 0; i \u003c size; i +\u003d bufferLen {"},{"line_number":156,"context_line":"\t\tif size - i \u003c bufferLen {"},{"line_number":157,"context_line":"\t\t\tw.Write(bufferResp[0:size - i])"},{"line_number":158,"context_line":"\t\t} else {"}],"source_content_type":"text/x-go","patch_set":1,"id":"672c1dae_0d75fdd4","line":155,"updated":"2021-04-29 22:19:18.000000000","message":"This could introduce some extra latency for sizes over 1024*1024. We should document that request over the buffer size may incur a penalty.","commit_id":"3ed2c4e1f1ca23ae3a288586a14795387da91017"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1048259308006f829c9b93b953ccac11f6822dfe","unresolved":true,"context_lines":[{"line_number":167,"context_line":"\trequestSize :\u003d strings.SplitN(r.URL.Path, \"/\", 3)[2]"},{"line_number":168,"context_line":"\tmatches :\u003d re.FindStringSubmatch(requestSize)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"\tvalue, err :\u003d strconv.Atoi(matches[1])"},{"line_number":171,"context_line":"\tif err !\u003d nil {"},{"line_number":172,"context_line":"\t\tvalue \u003d 0"},{"line_number":173,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"7151ac2f_a5615ed3","line":170,"updated":"2021-04-29 22:19:18.000000000","message":"This panics if no size matches.\ncurl -v http://127.0.0.1:8080/data/\n2021/04/29 21:51:33 http: panic serving 127.0.0.1:55888: runtime error: index out of range [1] with length 0\nMaybe we could provide a little more user friendly error?","commit_id":"3ed2c4e1f1ca23ae3a288586a14795387da91017"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1048259308006f829c9b93b953ccac11f6822dfe","unresolved":true,"context_lines":[{"line_number":172,"context_line":"\t\tvalue \u003d 0"},{"line_number":173,"context_line":"\t}"},{"line_number":174,"context_line":"\tswitch matches[2] {"},{"line_number":175,"context_line":"\tcase \"G\":"},{"line_number":176,"context_line":"\t\tvalue *\u003d 1024 * 1024 * 1024"},{"line_number":177,"context_line":"\tcase \"M\":"},{"line_number":178,"context_line":"\t\tvalue *\u003d 1024 * 1024"}],"source_content_type":"text/x-go","patch_set":1,"id":"53fc0836_2b43d02c","line":175,"updated":"2021-04-29 22:19:18.000000000","message":"What about lower case, like \u0027g\u0027?","commit_id":"3ed2c4e1f1ca23ae3a288586a14795387da91017"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1048259308006f829c9b93b953ccac11f6822dfe","unresolved":true,"context_lines":[{"line_number":177,"context_line":"\tcase \"M\":"},{"line_number":178,"context_line":"\t\tvalue *\u003d 1024 * 1024"},{"line_number":179,"context_line":"\tcase \"K\":"},{"line_number":180,"context_line":"\t\tvalue *\u003d 1024"},{"line_number":181,"context_line":"\t}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"\tbytesHandler(w, r, value)"}],"source_content_type":"text/x-go","patch_set":1,"id":"9c1f841c_cbecdda2","line":180,"range":{"start_line":180,"start_character":11,"end_line":180,"end_character":15},"updated":"2021-04-29 22:19:18.000000000","message":"We need to document that these base 2 vs. base 10.","commit_id":"3ed2c4e1f1ca23ae3a288586a14795387da91017"}]}