)]}'
{"id":"openstack%2Foctavia-tempest-plugin~783612","triplet_id":"openstack%2Foctavia-tempest-plugin~master~I212931cc9f1d60c868f3442b1b6e6260789c763e","project":"openstack/octavia-tempest-plugin","branch":"master","attention_set":{"29244":{"account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"last_update":"2022-11-14 17:29:23.000000000","reason":"\u003cGERRIT_ACCOUNT_11628\u003e replied on the change","reason_account":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I212931cc9f1d60c868f3442b1b6e6260789c763e","subject":"Add a new endpoint in test_server to download huge buffer","status":"NEW","created":"2021-03-29 07:42:37.000000000","updated":"2022-11-14 17:29:23.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":5,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"dc91cf165157bd3f495257b7d263d97747d4db29","_number":783612,"virtual_id_number":783612,"owner":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-03-29 09:54:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":-1,"date":"2021-03-30 16:46:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":-1,"date":"2021-03-30 17:55:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-29 09:54:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-29 14:10:33.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2021-03-30 16:46:37.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"edcaf37ff950de10abfc8958c1852f3c4438f27a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-03-29 07:42:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9780bf8b9def5d340fbe37269ee07da46f5fd9ba","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 09:54:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b3c70e13c7a44578943aacf3068c98e2 : SUCCESS in 7m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8fae9b5051a24a4bb7e9c30c3452a480 : SUCCESS in 4m 11s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/3ce5052247b848868ee3b170eff15ea7 : SUCCESS in 1h 41m 46s\n- octavia-v2-dsvm-noop-api-stable-victoria https://zuul.opendev.org/t/openstack/build/10ddecb9f4114006bddb4e2bf8ef0e3e : SUCCESS in 1h 16m 06s\n- octavia-v2-dsvm-noop-api-stable-ussuri https://zuul.opendev.org/t/openstack/build/9d3b0e533e7b4a1fa79a62b1a67bc516 : SUCCESS in 1h 27m 47s\n- octavia-v2-dsvm-noop-api-stable-train https://zuul.opendev.org/t/openstack/build/3e34de6eb58b4d98a52c33492168ae22 : SUCCESS in 1h 13m 50s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/08043638b8ed4d2fa6eb65241e74dc49 : SUCCESS in 1h 58m 00s\n- octavia-v2-dsvm-scenario-stable-victoria https://zuul.opendev.org/t/openstack/build/ddab989faaab4b79a05ec64d4965dc3c : SUCCESS in 1h 41m 56s\n- octavia-v2-dsvm-scenario-stable-ussuri https://zuul.opendev.org/t/openstack/build/ab3f80af7372465094d408659f684609 : SUCCESS in 1h 49m 20s\n- octavia-v2-dsvm-scenario-stable-train https://zuul.opendev.org/t/openstack/build/768b47625f1a45bf81b6d9bc66cf9ddd : SUCCESS in 1h 51m 35s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/11b40f86e6de4945a04daa92ada60ac2 : SUCCESS in 41m 44s\n- octavia-v2-dsvm-tls-barbican-stable-victoria https://zuul.opendev.org/t/openstack/build/0326319155254a9c97067196fa345cfc : SUCCESS in 39m 44s\n- octavia-v2-dsvm-tls-barbican-stable-ussuri https://zuul.opendev.org/t/openstack/build/f778d4e67ac8453383df3f3834ccf718 : SUCCESS in 46m 08s\n- octavia-v2-dsvm-tls-barbican-stable-train https://zuul.opendev.org/t/openstack/build/e003ad2ec1944948a1bd0e45d4c6c103 : SUCCESS in 46m 40s\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/9d0dc531ce39481c974d88fe28d0f361 : FAILURE in 1h 47m 36s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/020b8b75c09447caa62a4540c7d6d89c : FAILURE in 37m 42s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/f18374b21e1a4bc2979500078ce74e7e : FAILURE in 47m 58s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/63fa05fe1b4240b680c2ddaa0a4fdde2 : SUCCESS in 40m 23s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-stable-victoria https://zuul.opendev.org/t/openstack/build/97c500e61c3d45b3860403f37ab1c6bb : SUCCESS in 47m 49s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-stable-ussuri https://zuul.opendev.org/t/openstack/build/45b5d820ff114a3d89ec3ef84f27fd90 : SUCCESS in 46m 13s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario-stable-train https://zuul.opendev.org/t/openstack/build/13f3fab51aad46a8b69a95caa92bcedf : SUCCESS in 37m 49s (non-voting)\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/d6e1d3db068f4f68ba0d4bf3f141598e : SUCCESS in 39m 55s (non-voting)\n- octavia-v2-dsvm-spare-pool-stable-victoria https://zuul.opendev.org/t/openstack/build/36376303e5094e988389fe614ea1c65c : SUCCESS in 36m 26s (non-voting)\n- octavia-v2-dsvm-spare-pool-stable-ussuri https://zuul.opendev.org/t/openstack/build/b0aa031136c14297aae969296dfccf05 : SUCCESS in 32m 58s (non-voting)\n- octavia-v2-dsvm-spare-pool-stable-train https://zuul.opendev.org/t/openstack/build/596b8bf8d46848faab6ef8731152049e : SUCCESS in 35m 47s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/670637df52ff4ac7a86e2aa9580c7e5e : FAILURE in 2h 04m 24s (non-voting)\n- neutron-ovn-provider-v2-api https://zuul.opendev.org/t/openstack/build/dd4a98193ce3469597f9f64727eb1528 : SUCCESS in 41m 46s (non-voting)\n- neutron-ovn-provider-v2-scenario https://zuul.opendev.org/t/openstack/build/40c04c8c38794f81bf1f6ccc1ab0e711 : SUCCESS in 50m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1fafb8c7b93d2f71300b57244086503963b0bb78","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2021-03-30 16:46:37.000000000","message":"Patch Set 1: Code-Review-1\n\nHmm, interesting.\n\nThis patch however will not be great for benchmarking as each call will be doing a memory allocation and random generation which may have entropy issues at volume. This could also lead to some data flow optimizations to not be available, such as a zerocopy/DMA transfer. This will also incur the wrath of the go garbage collector overhead.\n\nI would rather pick some fixed sizes, maybe based on other commonly used sizes for benchmarks, and add those instead. That way those can be pre-allocated at startup and reused across requests. Some proposals would be: 128B, 1KB, 2KB, 8KB, 64KB, 512KB, 1MB. Random content is good though, as it helps remove compression influencing the results.\n\nIf we add this, I think it would be misleading for users that are looking for a server to use for benchmarking, as it will produce artificially lower results.","accounts_in_message":[],"_revision_number":1},{"id":"b02c656aa430244d6a7e100fa0d17a2b17614992","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-03-30 17:55:41.000000000","message":"Patch Set 1: Workflow-1\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Hmm, interesting.\n\u003e \n\u003e This patch however will not be great for benchmarking as each call will be doing a memory allocation and random generation which may have entropy issues at volume. This could also lead to some data flow optimizations to not be available, such as a zerocopy/DMA transfer. This will also incur the wrath of the go garbage collector overhead.\n\nAllocation and memory randomization is only performed during the first call (then the buffer is stored in bufferResp). I use a 1MB buffer because it performed better than a smaller buffer.\n\n \n\u003e I would rather pick some fixed sizes, maybe based on other commonly used sizes for benchmarks, and add those instead. That way those can be pre-allocated at startup and reused across requests. Some proposals would be: 128B, 1KB, 2KB, 8KB, 64KB, 512KB, 1MB. Random content is good though, as it helps remove compression influencing the results.\n\u003e \n\u003e If we add this, I think it would be misleading for users that are looking for a server to use for benchmarking, as it will produce artificially lower results.\n\nIn my VM, wget downloaded a 1GB buffer (HTTP) at 1.7GB/s (~14Gb/s)\nusing HTTPS, it achieved 1.3GB/s (~10Gb/s)\nSo the data transfer looks good enough for bandwidth tests, but scalability of the golang server is still unknown to me.\n\nadded W-1","accounts_in_message":[],"_revision_number":1},{"id":"1048259308006f829c9b93b953ccac11f6822dfe","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2021-04-29 22:19:18.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nOk, I have looked at this a bit closer and updated my comments.\nAlso, please update the readme to describe this feature.","accounts_in_message":[],"_revision_number":1},{"id":"dc91cf165157bd3f495257b7d263d97747d4db29","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2022-11-14 17:29:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3ed2c4e1f1ca23ae3a288586a14795387da91017","revisions":{"3ed2c4e1f1ca23ae3a288586a14795387da91017":{"kind":"REWORK","_number":1,"created":"2021-03-29 07:42:37.000000000","uploader":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"ref":"refs/changes/12/783612/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-tempest-plugin","ref":"refs/changes/12/783612/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/12/783612/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/12/783612/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/12/783612/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-tempest-plugin refs/changes/12/783612/1"}}},"commit":{"parents":[{"commit":"434170a8e0740aae2d6c31a9063a5c8db7616809","subject":"Merge \"Fix testing IPv6 VIP network connectivity\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/434170a8e0740aae2d6c31a9063a5c8db7616809"}]}],"author":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-03-29 07:39:25.000000000","tz":120},"committer":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-03-29 07:41:55.000000000","tz":120},"subject":"Add a new endpoint in test_server to download huge buffer","message":"Add a new endpoint in test_server to download huge buffer\n\nAdd a new /data/ endpoint in test_server.go, allowing the user to\ndownload a random buffer of a user-requested size:\nFor instance /data/100KB returns a 100KB data buffer, /data/1GB returns\na 1GB data buffer, etc...\n\nThis could enable performance tests to use test_server.go. This could\nalso help testing stats API in Octavia.\n\nChange-Id: I212931cc9f1d60c868f3442b1b6e6260789c763e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/3ed2c4e1f1ca23ae3a288586a14795387da91017"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-tempest-plugin/commit/3ed2c4e1f1ca23ae3a288586a14795387da91017"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}