)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d65b75e0e3af6db8a558f3baf0b43a8890a139ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ca3afa5_a81686a2","updated":"2022-02-01 00:14:25.000000000","message":"recheck","commit_id":"2662a9abcce957f28114d9124b5e319cb6ed3621"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7d2e8934595ded7a1e070a3b5ca62cb0c8642b5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d48c8100_c1be5b4a","updated":"2022-02-03 19:21:27.000000000","message":"recheck\npip 22 / devstack fix merged\n","commit_id":"2662a9abcce957f28114d9124b5e319cb6ed3621"}],"octavia_tempest_plugin/tests/scenario/v2/test_ipv6_traffic_ops.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21ea855b14e0fea1ace3c18d2efc053e9fd33725","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Setup a cache of listeners and pools to allow reuse"},{"line_number":74,"context_line":"        cls.listener_pool_cache \u003d {}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Setup some common port numbers for the listeners."},{"line_number":77,"context_line":"        cls.http_port \u003d 80"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4b9ed64_28a1bce5","line":74,"updated":"2021-05-07 20:29:24.000000000","message":"Wonder whether this should be in the mixin or parent class if we (might) use it in other places.","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fdaf0538c5709c7709881b7d518649b6c40fce2e","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Setup a cache of listeners and pools to allow reuse"},{"line_number":74,"context_line":"        cls.listener_pool_cache \u003d {}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Setup some common port numbers for the listeners."},{"line_number":77,"context_line":"        cls.http_port \u003d 80"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e63914d_2e47fdba","line":74,"in_reply_to":"a4b9ed64_28a1bce5","updated":"2021-05-07 20:41:46.000000000","message":"I think we need to limit the blast radius to just this test class. Not to mention the LB will be deleted as part of the cleanup of this class.","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21ea855b14e0fea1ace3c18d2efc053e9fd33725","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            const.TCP, self.tcp_port, const.TCP,"},{"line_number":248,"context_line":"            const.LB_ALGORITHM_ROUND_ROBIN)"},{"line_number":249,"context_line":"        self._test_ipv6_vip_ipv6_members_traffic("},{"line_number":250,"context_line":"            const.TCP, self.tcp_port, pool_id, persistent\u003dFalse)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @decorators.idempotent_id(\u002726317013-a9b5-4a00-a993-d4c55b764e40\u0027)"},{"line_number":253,"context_line":"    def test_ipv6_vip_ipv6_members_udp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b29fa12_0273efe3","line":250,"updated":"2021-05-07 20:29:24.000000000","message":"So I guess we only ever test this with RR, which is the same as the IPv4 equivalent, wonder whether a follow-on would be to add more algorithms.","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fdaf0538c5709c7709881b7d518649b6c40fce2e","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            const.TCP, self.tcp_port, const.TCP,"},{"line_number":248,"context_line":"            const.LB_ALGORITHM_ROUND_ROBIN)"},{"line_number":249,"context_line":"        self._test_ipv6_vip_ipv6_members_traffic("},{"line_number":250,"context_line":"            const.TCP, self.tcp_port, pool_id, persistent\u003dFalse)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @decorators.idempotent_id(\u002726317013-a9b5-4a00-a993-d4c55b764e40\u0027)"},{"line_number":253,"context_line":"    def test_ipv6_vip_ipv6_members_udp_traffic(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ca11764_2f60a195","line":250,"in_reply_to":"3b29fa12_0273efe3","updated":"2021-05-07 20:41:46.000000000","message":"Yes, someone should. grin\nI was trying to limit the amount of change here, but given OVN can\u0027t run the cidr tests, I will need to expand these in this patch so OVN can test *something*.","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6e715a3a1c0ccb34f55080d81c22a27e33f18e6c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                                CONF.load_balancer.build_interval,"},{"line_number":71,"context_line":"                                CONF.load_balancer.build_timeout)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Setup the starting listener port number for this load balancer"},{"line_number":74,"context_line":"        cls.current_listener_port \u003d 80"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Setup a cache of listeners and pools to allow reuse"},{"line_number":77,"context_line":"        cls.listener_pool_cache \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _test_ipv6_vip_mixed_ipv4_ipv6_members_traffic("},{"line_number":80,"context_line":"            self, protocol, protocol_port, pool_id, persistent\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"b767210f_b2aeab0c","line":77,"range":{"start_line":73,"start_character":8,"end_line":77,"end_character":36},"updated":"2022-02-15 07:43:59.000000000","message":"(nit) I agree with the previous comment, it would be more appropriate in the mixin class","commit_id":"433b7705201dac20846f8b7aa66d14ddf7e12477"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6e715a3a1c0ccb34f55080d81c22a27e33f18e6c","unresolved":true,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @decorators.idempotent_id(\u00276869e3d7-4678-4bcd-bca9-0185016f8fce\u0027)"},{"line_number":409,"context_line":"    def test_udp_LC_ipv6_vip_ipv6_members_traffic(self):"},{"line_number":410,"context_line":"        if not self.mem_listener_client.is_version_supported("},{"line_number":411,"context_line":"                self.api_version, \u00272.1\u0027):"},{"line_number":412,"context_line":"            raise self.skipException(\u0027UDP listener support is only available \u0027"},{"line_number":413,"context_line":"                                     \u0027in Octavia API version 2.1 or newer\u0027)"},{"line_number":414,"context_line":"        listener_port, pool_id \u003d self.caching_listener_pool_create("},{"line_number":415,"context_line":"            const.UDP, const.UDP, const.LB_ALGORITHM_LEAST_CONNECTIONS)"},{"line_number":416,"context_line":"        self._test_ipv6_vip_ipv6_members_traffic("}],"source_content_type":"text/x-python","patch_set":7,"id":"caf7265d_5c512130","line":413,"range":{"start_line":410,"start_character":8,"end_line":413,"end_character":75},"updated":"2022-02-15 07:43:59.000000000","message":"this is no longer required, it is already checked in caching_listener_pool_create (note: there are 8 occurrences of this test in the patch)","commit_id":"433b7705201dac20846f8b7aa66d14ddf7e12477"}],"octavia_tempest_plugin/tests/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21ea855b14e0fea1ace3c18d2efc053e9fd33725","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestUtilsMixin(test.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def caching_listener_pool_create(cls, listener_protocol, listener_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"99ae7322_21d3607b","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":38},"updated":"2021-05-07 20:29:24.000000000","message":"Is this needed as the LoadBalancerBaseTest class is already doing it?","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fdaf0538c5709c7709881b7d518649b6c40fce2e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestUtilsMixin(test.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def caching_listener_pool_create(cls, listener_protocol, listener_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a413f85f_32fc8291","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":38},"in_reply_to":"99ae7322_21d3607b","updated":"2021-05-07 20:41:46.000000000","message":"No, probably not.","commit_id":"ca1835703c24da12afa996937cb2355c9e09861c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f92576584ada5a1cf3be39bfb8b297b204dceb1c","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                       \"test.\".format(driver\u003dCONF.load_balancer.provider))"},{"line_number":114,"context_line":"            if hasattr(e, \u0027resp_body\u0027):"},{"line_number":115,"context_line":"                message \u003d e.resp_body.get(\u0027faultstring\u0027, message)"},{"line_number":116,"context_line":"            cls.mem_listener_client.delete_listener(listener[const.ID])"},{"line_number":117,"context_line":"            waiters.wait_for_status(cls.mem_lb_client.show_loadbalancer,"},{"line_number":118,"context_line":"                                    cls.lb_id, const.PROVISIONING_STATUS,"},{"line_number":119,"context_line":"                                    const.ACTIVE,"},{"line_number":120,"context_line":"                                    CONF.load_balancer.build_interval,"},{"line_number":121,"context_line":"                                    CONF.load_balancer.build_timeout)"},{"line_number":122,"context_line":"            raise testtools.TestCase.skipException(message)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        waiters.wait_for_status(cls.mem_lb_client.show_loadbalancer,"}],"source_content_type":"text/x-python","patch_set":4,"id":"18a55b56_b4711b58","line":121,"range":{"start_line":116,"start_character":12,"end_line":121,"end_character":69},"updated":"2021-05-10 15:48:03.000000000","message":"Can this block just be at the beginning of the exception code?  Seems odd to duplicate it here and at L104 unless I\u0027m missing something.","commit_id":"3643155f6a9eb828670efb099eab7af39f1e1739"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f4e717f0ac1a317b704861ed101d88adc6e790b5","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                       \"test.\".format(driver\u003dCONF.load_balancer.provider))"},{"line_number":114,"context_line":"            if hasattr(e, \u0027resp_body\u0027):"},{"line_number":115,"context_line":"                message \u003d e.resp_body.get(\u0027faultstring\u0027, message)"},{"line_number":116,"context_line":"            cls.mem_listener_client.delete_listener(listener[const.ID])"},{"line_number":117,"context_line":"            waiters.wait_for_status(cls.mem_lb_client.show_loadbalancer,"},{"line_number":118,"context_line":"                                    cls.lb_id, const.PROVISIONING_STATUS,"},{"line_number":119,"context_line":"                                    const.ACTIVE,"},{"line_number":120,"context_line":"                                    CONF.load_balancer.build_interval,"},{"line_number":121,"context_line":"                                    CONF.load_balancer.build_timeout)"},{"line_number":122,"context_line":"            raise testtools.TestCase.skipException(message)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        waiters.wait_for_status(cls.mem_lb_client.show_loadbalancer,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8bd4f580_52f9d38e","line":121,"range":{"start_line":116,"start_character":12,"end_line":121,"end_character":69},"in_reply_to":"18a55b56_b4711b58","updated":"2021-05-10 17:31:49.000000000","message":"Sure, I see it\u0027s basically duplicate here.","commit_id":"3643155f6a9eb828670efb099eab7af39f1e1739"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6e715a3a1c0ccb34f55080d81c22a27e33f18e6c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"                                    const.ACTIVE,"},{"line_number":107,"context_line":"                                    CONF.load_balancer.build_interval,"},{"line_number":108,"context_line":"                                    CONF.load_balancer.build_timeout)"},{"line_number":109,"context_line":"            if algorithm !\u003d const.LB_ALGORITHM_SOURCE_IP_PORT:"},{"line_number":110,"context_line":"                raise"},{"line_number":111,"context_line":"            message \u003d (\"The configured provider driver \u0027{driver}\u0027 \""},{"line_number":112,"context_line":"                       \"does not support a feature required for this \""}],"source_content_type":"text/x-python","patch_set":7,"id":"53a16036_ef146fba","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":62},"updated":"2022-02-15 07:43:59.000000000","message":"what does it mean for providers that don\u0027t support ROUND_ROBIN for instance, will it be considered as an ERROR?","commit_id":"433b7705201dac20846f8b7aa66d14ddf7e12477"}]}