)]}'
{"octavia_tempest_plugin/tests/spare_pool_scenario/v2/test_spare_pool.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"575ae717754c1b94faf1f9e5c3e99c3031cc2ab9","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        * Send traffic through load balancer"},{"line_number":58,"context_line":"        * Validate amphora spare pool size is restored"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        amphora_client \u003d self.os_admin.load_balancer_v2.AmphoraClient()"},{"line_number":61,"context_line":"        # Check there is at least one amphora in spare pool"},{"line_number":62,"context_line":"        spare_amps \u003d waiters.wait_for_spare_amps("},{"line_number":63,"context_line":"            amphora_client.list_amphorae,"}],"source_content_type":"text/x-python","patch_set":10,"id":"13d19197_534511b0","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":71},"updated":"2021-07-02 13:52:45.000000000","message":"qq: why is this os_admin[..].AmphoraClient defined here and not in test_base.py?\n\nside question: in some files, we use amphora_client with the admin role, and in other files we use the lb_admin role, any reasons for that?","commit_id":"29d8e61ca27859b70a4350e87022442a78f8fa8c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f8ea91bbf9612ada0b0f35fa192c1bf91d17ad7a","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        * Send traffic through load balancer"},{"line_number":58,"context_line":"        * Validate amphora spare pool size is restored"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        amphora_client \u003d self.os_admin.load_balancer_v2.AmphoraClient()"},{"line_number":61,"context_line":"        # Check there is at least one amphora in spare pool"},{"line_number":62,"context_line":"        spare_amps \u003d waiters.wait_for_spare_amps("},{"line_number":63,"context_line":"            amphora_client.list_amphorae,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a526d0d_8ea69b79","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":71},"in_reply_to":"13d19197_534511b0","updated":"2021-07-07 15:59:42.000000000","message":"There are a number of places we create another client instead of using the list setup in base.\nThese all should be cleaned up in the future.\n\nos_admin is the tempest credential setup with the admin role and system scope.\nlb_admin is a credential we create, using the load-balancer_admin role, which is a service specific admin role in Octavia[1]. It is part of advanced RBAC.\n\n[1] https://docs.openstack.org/octavia/latest/configuration/policy.html#term-role-load-balancer_admin","commit_id":"29d8e61ca27859b70a4350e87022442a78f8fa8c"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0a280d58053838cafa3883ff38ef2a67d27996c1","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from tempest import test"},{"line_number":31,"context_line":"import tenacity"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from octavia_tempest_plugin import clients"},{"line_number":34,"context_line":"from octavia_tempest_plugin.common import cert_utils"},{"line_number":35,"context_line":"from octavia_tempest_plugin.common import constants as const"},{"line_number":36,"context_line":"from octavia_tempest_plugin.tests import RBAC_tests"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2cb59a4_1c15d52d","line":33,"updated":"2021-06-23 16:25:16.000000000","message":"So can this go away?  looks like it\u0027s unused now","commit_id":"4700f8399fe627ed5e39a11c748fb0d57f59a532"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dd04decfa63f0f4ddfee10fa485ff4993afae4e1","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from tempest import test"},{"line_number":31,"context_line":"import tenacity"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from octavia_tempest_plugin import clients"},{"line_number":34,"context_line":"from octavia_tempest_plugin.common import cert_utils"},{"line_number":35,"context_line":"from octavia_tempest_plugin.common import constants as const"},{"line_number":36,"context_line":"from octavia_tempest_plugin.tests import RBAC_tests"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0ffc9da_807f61cf","line":33,"in_reply_to":"c2cb59a4_1c15d52d","updated":"2021-06-23 18:16:06.000000000","message":"I think that is what pep8 is telling me.","commit_id":"4700f8399fe627ed5e39a11c748fb0d57f59a532"}]}