)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ab8b11bc6fb311923750651cb4aeeb3f301c28ad","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adding QoS Bandwidth Limit API tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding API tests for creating and updating a Load Balancer"},{"line_number":10,"context_line":"with Quality of Service QoS policy and Bandwidth Limit rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I30ecb919431d848ba6061badfb9c185822140c79"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"54592ae8_34936d26","line":10,"range":{"start_line":10,"start_character":24,"end_line":10,"end_character":27},"updated":"2021-12-08 17:53:17.000000000","message":"We can remove \"Quality of Service\", I mean we can stay with:\n\nAdding API tests for creating and updating a Load Balancer\nwith QoS policy and Bandwidth Limit rule","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29681,"name":"Bruna Bonguardo","display_name":"Bruna Bonguardo","email":"bbonguar@redhat.com","username":"bonguardo"},"change_message_id":"0d2c64b63a26aea12646575b0fc3af2cc013cec3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding QoS Bandwidth Limit API tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding API tests for creating and updating a Load Balancer"},{"line_number":10,"context_line":"with Quality of Service QoS policy and Bandwidth Limit rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I30ecb919431d848ba6061badfb9c185822140c79"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a1e930f1_434d82a7","line":10,"range":{"start_line":10,"start_character":24,"end_line":10,"end_character":27},"in_reply_to":"54592ae8_34936d26","updated":"2021-12-14 10:35:26.000000000","message":"I added both ways, so that if someone searches for \"QoS\" or \"Quality of Service\", hey can find it both ways.","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8dd17a598bcb7aa81d40d8e0211392ccad64a735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"633c17a8_18eaec44","updated":"2021-11-16 22:18:52.000000000","message":"A few comments. Also, for these tests to run addtional neutron extensions will need to be installed (QoS) for the job(s).","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"10ab34cf9e1a47e5083cf2c63c0c8a698ef6d22a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf09ec06_2a9c8f27","updated":"2021-12-08 18:06:29.000000000","message":"Michael, Greg - what about \"test_load_balancer_delete_cascade\"?\nDoes it mean that on \"cascade\", we need to delete QoS related stuff?\nIf yes, we\u0027ll need to modify this test accordingly.","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8086c4321283e4d5ea8869d05102829e788c876f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43fbd2b5_4e26e964","updated":"2021-11-17 16:26:51.000000000","message":"This patch should be reconciled with the existing QoS patch:\nhttps://review.opendev.org/c/openstack/octavia-tempest-plugin/+/757449","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"bfe8090cfea84670e7397c385837d8628b71ad22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb246adc_07eeecfa","updated":"2021-11-19 09:21:14.000000000","message":"We also need to enable q-qos in the parameters of the octavia-dsvm-base job","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3f062a33a2bda0aa668bb02d586381fecf02b351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"009fb0e6_b9e729be","updated":"2022-01-05 09:37:36.000000000","message":"recheck","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":29681,"name":"Bruna Bonguardo","display_name":"Bruna Bonguardo","email":"bbonguar@redhat.com","username":"bonguardo"},"change_message_id":"8691255e914913577bd7edb3f04b6cf75f6a1730","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f4a3b5f_598cd7d3","updated":"2021-12-20 12:27:58.000000000","message":"recheck","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"}],"octavia_tempest_plugin/tests/api/v2/test_load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8086c4321283e4d5ea8869d05102829e788c876f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self._test_load_balancer_create(6)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u0027f3b9eae8-3a3d-11ec-9de7-52540016e074\u0027)"},{"line_number":52,"context_line":"    def test_load_balancer_qos_bwlimit_create(self):"},{"line_number":53,"context_line":"        self._test_load_balancer_create(4, lb_qos_policy_bwlimit\u003dTrue)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _test_load_balancer_create(self, ip_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7a228ce_40e5c215","line":52,"updated":"2021-11-17 16:26:51.000000000","message":"These tests should check if QoS is enabled in neutron and automatically skip the tests if the extension is not enabled.\n\nhttps://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dshow-extension-details-detail#show-extension-details","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29681,"name":"Bruna Bonguardo","display_name":"Bruna Bonguardo","email":"bbonguar@redhat.com","username":"bonguardo"},"change_message_id":"0d2c64b63a26aea12646575b0fc3af2cc013cec3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self._test_load_balancer_create(6)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u0027f3b9eae8-3a3d-11ec-9de7-52540016e074\u0027)"},{"line_number":52,"context_line":"    def test_load_balancer_qos_bwlimit_create(self):"},{"line_number":53,"context_line":"        self._test_load_balancer_create(4, lb_qos_policy_bwlimit\u003dTrue)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _test_load_balancer_create(self, ip_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb5d7498_44e309fe","line":52,"in_reply_to":"c7a228ce_40e5c215","updated":"2021-12-14 10:35:26.000000000","message":"Done","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"38812140f48a371d48b686968f2f832a57371e21","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                     const.NAME: lb_name}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":79,"context_line":"            # Create QoS policy"},{"line_number":80,"context_line":"            policy \u003d self.lb_admin_qos_client.create_qos_policy("},{"line_number":81,"context_line":"                name\u003ddata_utils.rand_name(\u0027lb_qos\u0027), shared\u003dTrue)[\u0027policy\u0027]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            self.addCleanup(self.lb_admin_qos_client.delete_qos_policy,"},{"line_number":84,"context_line":"                            policy[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Create a bandwidth limit rule"},{"line_number":87,"context_line":"            rule_kwargs \u003d {\u0027max_kbps\u0027: \u00272000\u0027, \u0027max_burst_kbps\u0027: \u00271600\u0027,"},{"line_number":88,"context_line":"                           \u0027direction\u0027: \u0027ingress\u0027}"},{"line_number":89,"context_line":"            rule \u003d ("},{"line_number":90,"context_line":"                self.lb_admin_qos_limit_bw_client.create_limit_bandwidth_rule("},{"line_number":91,"context_line":"                    policy[\u0027id\u0027], **rule_kwargs)[\u0027bandwidth_limit_rule\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            self.addCleanup("},{"line_number":94,"context_line":"                self.lb_admin_qos_limit_bw_client.delete_limit_bandwidth_rule,"},{"line_number":95,"context_line":"                policy[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Create load balancer with an associated VIP QoS policy"},{"line_number":98,"context_line":"            lb_kwargs[const.VIP_QOS_POLICY_ID] \u003d policy[\u0027id\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7451f946_c7326cbb","line":96,"range":{"start_line":79,"start_character":12,"end_line":96,"end_character":0},"updated":"2021-11-19 09:14:06.000000000","message":"I think it\u0027s worth it to create a function for the qos policy creation, this code is duplicated 3 times in this file.","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29681,"name":"Bruna Bonguardo","display_name":"Bruna Bonguardo","email":"bbonguar@redhat.com","username":"bonguardo"},"change_message_id":"0d2c64b63a26aea12646575b0fc3af2cc013cec3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                     const.NAME: lb_name}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":79,"context_line":"            # Create QoS policy"},{"line_number":80,"context_line":"            policy \u003d self.lb_admin_qos_client.create_qos_policy("},{"line_number":81,"context_line":"                name\u003ddata_utils.rand_name(\u0027lb_qos\u0027), shared\u003dTrue)[\u0027policy\u0027]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            self.addCleanup(self.lb_admin_qos_client.delete_qos_policy,"},{"line_number":84,"context_line":"                            policy[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Create a bandwidth limit rule"},{"line_number":87,"context_line":"            rule_kwargs \u003d {\u0027max_kbps\u0027: \u00272000\u0027, \u0027max_burst_kbps\u0027: \u00271600\u0027,"},{"line_number":88,"context_line":"                           \u0027direction\u0027: \u0027ingress\u0027}"},{"line_number":89,"context_line":"            rule \u003d ("},{"line_number":90,"context_line":"                self.lb_admin_qos_limit_bw_client.create_limit_bandwidth_rule("},{"line_number":91,"context_line":"                    policy[\u0027id\u0027], **rule_kwargs)[\u0027bandwidth_limit_rule\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            self.addCleanup("},{"line_number":94,"context_line":"                self.lb_admin_qos_limit_bw_client.delete_limit_bandwidth_rule,"},{"line_number":95,"context_line":"                policy[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Create load balancer with an associated VIP QoS policy"},{"line_number":98,"context_line":"            lb_kwargs[const.VIP_QOS_POLICY_ID] \u003d policy[\u0027id\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10c5e599_d8876a88","line":96,"range":{"start_line":79,"start_character":12,"end_line":96,"end_character":0},"in_reply_to":"7451f946_c7326cbb","updated":"2021-12-14 10:35:26.000000000","message":"Done","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ab8b11bc6fb311923750651cb4aeeb3f301c28ad","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                self.lb_admin_qos_limit_bw_client.delete_limit_bandwidth_rule,"},{"line_number":95,"context_line":"                policy[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # Create load balancer with an associated VIP QoS policy"},{"line_number":98,"context_line":"            lb_kwargs[const.VIP_QOS_POLICY_ID] \u003d policy[\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if self.mem_listener_client.is_version_supported("}],"source_content_type":"text/x-python","patch_set":1,"id":"bb7d2554_c389b74e","line":97,"range":{"start_line":97,"start_character":14,"end_line":97,"end_character":68},"updated":"2021-12-08 17:53:17.000000000","message":"In L98 we just adding QoS policy to LB kwargs, LB creation is done in L129, so maybe changing this comment to:\n# Add QoS policy to LB kwargs\nor maybe removing this one at all?","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8dd17a598bcb7aa81d40d8e0211392ccad64a735","unresolved":true,"context_lines":[{"line_number":691,"context_line":"    def test_load_balancer_qos_bwlimit_update(self):"},{"line_number":692,"context_line":"        self._test_load_balancer_update(lb_qos_policy_bwlimit\u003dTrue)"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    @decorators.idempotent_id(\u00272e0e1ca0-e1f3-400b-9835-25c77b9216f0\u0027)"},{"line_number":695,"context_line":"    def test_load_balancer_update(self):"},{"line_number":696,"context_line":"        self._test_load_balancer_update()"},{"line_number":697,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b6bacf26_e9b4a33d","line":694,"updated":"2021-11-16 22:18:52.000000000","message":"This UUID is incorrect. It should be the same as it was before:\nb75a4d15-49d2-4149-a745-635eed1aacc3","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8dd17a598bcb7aa81d40d8e0211392ccad64a735","unresolved":true,"context_lines":[{"line_number":695,"context_line":"    def test_load_balancer_update(self):"},{"line_number":696,"context_line":"        self._test_load_balancer_update()"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    @decorators.idempotent_id(\u0027b75a4d15-49d2-4149-a745-635eed1aacc3\u0027)"},{"line_number":699,"context_line":"    def _test_load_balancer_update(self, lb_qos_policy_bwlimit\u003dFalse):"},{"line_number":700,"context_line":"        \"\"\"Tests load balancer update and show APIs."},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9616e609_3128ad3b","line":698,"updated":"2021-11-16 22:18:52.000000000","message":"Private methods should not be tagged with a UUID","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ab8b11bc6fb311923750651cb4aeeb3f301c28ad","unresolved":true,"context_lines":[{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":785,"context_line":"            if lb_kwargs[const.VIP_QOS_POLICY_ID]:"},{"line_number":786,"context_line":"                self.assertEqual(lb_kwargs[const.VIP_QOS_POLICY_ID],"},{"line_number":787,"context_line":"                                 lb[const.VIP_QOS_POLICY_ID])"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":790,"context_line":"                self.api_version, \u00272.5\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"42d5c887_33a2fd1b","line":787,"range":{"start_line":786,"start_character":0,"end_line":787,"end_character":61},"updated":"2021-12-08 17:53:17.000000000","message":"I would recommend adding assertion message here.","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        * Creates a quality of service policy."},{"line_number":44,"context_line":"        * Creates a quality of service rule connected to the policy."},{"line_number":45,"context_line":"        * Returns policy and rule."},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        # Create QoS policy"},{"line_number":48,"context_line":"        policy \u003d self.os_admin_qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":3,"id":"500a187c_994c6b6d","line":45,"range":{"start_line":45,"start_character":10,"end_line":45,"end_character":34},"updated":"2022-01-05 13:07:35.000000000","message":"Nit.\nAfter reading this comment I thought that this function returns a tuple of policy and rule, but \nL66 returns policy only.\nMaybe rephrasing to \"Returns policy with associated QoS rule?","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        self.addCleanup(self.os_admin_qos_client.delete_qos_policy,"},{"line_number":60,"context_line":"                        policy[\u0027id\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.addCleanup("},{"line_number":63,"context_line":"            self.os_admin_qos_limit_bw_client.delete_limit_bandwidth_rule,"},{"line_number":64,"context_line":"            policy[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return policy"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7598b34a_e673ce6f","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":37},"updated":"2022-01-05 13:07:35.000000000","message":"As far as I remember, when you delete QoS Policy it will also delete all the associated rules for that policy, therefore (if I\u0027m not mistaken) we can simply remove \"rule\u0027s\" cleanup.\nNeeded to be checked first.","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":778,"context_line":"                             lb[const.VIP_SUBNET_ID])"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":781,"context_line":"            if lb_kwargs[const.VIP_QOS_POLICY_ID]:"},{"line_number":782,"context_line":"                self.assertEqual(lb_kwargs[const.VIP_QOS_POLICY_ID],"},{"line_number":783,"context_line":"                                 lb[const.VIP_QOS_POLICY_ID])"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dd2bcffe_29b4459b","line":781,"range":{"start_line":781,"start_character":0,"end_line":781,"end_character":50},"updated":"2022-01-05 13:07:35.000000000","message":"Why do we need this additional \"if\" statement?\nAny reason that the previous \"if\" in L780 won\u0027t be enough?","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":780,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":781,"context_line":"            if lb_kwargs[const.VIP_QOS_POLICY_ID]:"},{"line_number":782,"context_line":"                self.assertEqual(lb_kwargs[const.VIP_QOS_POLICY_ID],"},{"line_number":783,"context_line":"                                 lb[const.VIP_QOS_POLICY_ID])"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":786,"context_line":"                self.api_version, \u00272.5\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"475ef3e2_933c7405","line":783,"range":{"start_line":783,"start_character":0,"end_line":783,"end_character":61},"updated":"2022-01-05 13:07:35.000000000","message":"I would recommend adding a clear assertion message here.","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":853,"context_line":"        self.assertCountEqual(lb_update_kwargs[const.TAGS], lb[const.TAGS])"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":856,"context_line":"            if lb_kwargs[const.VIP_QOS_POLICY_ID]:"},{"line_number":857,"context_line":"                self.assertEqual(lb_update_kwargs[const.VIP_QOS_POLICY_ID],"},{"line_number":858,"context_line":"                                 lb[const.VIP_QOS_POLICY_ID])"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"16a71c75_d3395c43","line":856,"range":{"start_line":856,"start_character":0,"end_line":856,"end_character":50},"updated":"2022-01-05 13:07:35.000000000","message":"Same as my comment in L781","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8c6ad366024503f0bdfdd0def343b90633e0dc96","unresolved":true,"context_lines":[{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if lb_qos_policy_bwlimit:"},{"line_number":856,"context_line":"            if lb_kwargs[const.VIP_QOS_POLICY_ID]:"},{"line_number":857,"context_line":"                self.assertEqual(lb_update_kwargs[const.VIP_QOS_POLICY_ID],"},{"line_number":858,"context_line":"                                 lb[const.VIP_QOS_POLICY_ID])"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        # Attempt to clean up so that one full test run doesn\u0027t start 10+"},{"line_number":861,"context_line":"        # amps before the cleanup phase fires"}],"source_content_type":"text/x-python","patch_set":3,"id":"843746b2_c4ad4ee6","line":858,"range":{"start_line":857,"start_character":0,"end_line":858,"end_character":61},"updated":"2022-01-05 13:07:35.000000000","message":"Same comment as for L783","commit_id":"b2a41dc938cc23da118571509f8fe7f58f81e670"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"38812140f48a371d48b686968f2f832a57371e21","unresolved":true,"context_lines":[{"line_number":209,"context_line":"            lb_admin_prefix.AvailabilityZoneClient())"},{"line_number":210,"context_line":"        cls.mem_availability_zone_client \u003d ("},{"line_number":211,"context_line":"            cls.os_roles_lb_member.load_balancer_v2.AvailabilityZoneClient())"},{"line_number":212,"context_line":"        cls.lb_admin_qos_client \u003d cls.os_roles_lb_admin.qos_client"},{"line_number":213,"context_line":"        cls.lb_admin_qos_limit_bw_client \u003d ("},{"line_number":214,"context_line":"                cls.os_roles_lb_admin.qos_limit_bw_client)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"09f3c2a1_7e8117ed","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":31},"updated":"2021-11-19 09:14:06.000000000","message":"we should use the os_admin client because the lb_admin user should not have access to the QoS API","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"},{"author":{"_account_id":29681,"name":"Bruna Bonguardo","display_name":"Bruna Bonguardo","email":"bbonguar@redhat.com","username":"bonguardo"},"change_message_id":"0d2c64b63a26aea12646575b0fc3af2cc013cec3","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            lb_admin_prefix.AvailabilityZoneClient())"},{"line_number":210,"context_line":"        cls.mem_availability_zone_client \u003d ("},{"line_number":211,"context_line":"            cls.os_roles_lb_member.load_balancer_v2.AvailabilityZoneClient())"},{"line_number":212,"context_line":"        cls.lb_admin_qos_client \u003d cls.os_roles_lb_admin.qos_client"},{"line_number":213,"context_line":"        cls.lb_admin_qos_limit_bw_client \u003d ("},{"line_number":214,"context_line":"                cls.os_roles_lb_admin.qos_limit_bw_client)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfb20065_d3238246","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":31},"in_reply_to":"09f3c2a1_7e8117ed","updated":"2021-12-14 10:35:26.000000000","message":"Done","commit_id":"35705211e14f2c54d989a1abe07f527ddc2ac1ec"}]}