)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"64a00e2f50b1984883b1724c2731c9e90209c95f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc4f24b0_0115a673","updated":"2022-02-09 17:09:45.000000000","message":"Actually, I change my mind on this.\nSince this is in the branchless tempest plugin, these are still valid for some older Octavia branches.","commit_id":"20dc19b669484a5852df48d4ae3e4857a67df030"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ae2505880f77d8a4ca9a804f8decdca9eb0436d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55ed9d6f_fd815c8b","updated":"2022-02-09 17:08:35.000000000","message":"I agree the deprecation period has probably expired for this alias.\n\nCan you please add a release note that highlights this deprecation has expired and upgrades will need to make sure they are not using the \"octavia\" alias?","commit_id":"20dc19b669484a5852df48d4ae3e4857a67df030"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2b1d48acbd36e54df920383952a392f00c8245ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecfdad92_c20762af","in_reply_to":"cc4f24b0_0115a673","updated":"2022-02-10 09:51:45.000000000","message":"Thx for your review. \n\nSo in order to keep that older versions backward compatibility I just change the parameter used in some tests that was failing over newer version.","commit_id":"20dc19b669484a5852df48d4ae3e4857a67df030"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"25d9b0b6d61fb5bf109ce23d24eaa1dd6f07419b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"adc462f7_9e51d992","updated":"2022-02-11 07:56:47.000000000","message":"makes sense to move the default from octavia to amphora. \n\nJust a nit, perhaps the tittle of the commit message is not that representative of what the patch is doing. Or at least it should include why this was making netowrking-ovn-octavia-v2-dsvm-scenario to fail","commit_id":"2cec97895fb9664ed505906ed73c1ce037e84940"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bd66f9baf9d3ede22c864c0dceeaa418c6e3af01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da5ae06c_2b22d5f4","in_reply_to":"adc462f7_9e51d992","updated":"2022-02-11 08:19:04.000000000","message":"done","commit_id":"2cec97895fb9664ed505906ed73c1ce037e84940"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e3c302912b0153115cc7f6fb972e8953de42096b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e177a941_76111b6c","updated":"2022-07-12 17:12:17.000000000","message":"So, I\u0027m not sure this patch is needed given the \"octavia\" entrypoint is still defined in the Octavia repo.\nThere is no bug attached to this patch, but I understand that the OVN provider devstack plugin is overwriting the default provider drivers setting in the octavia.conf file instead of appending the OVN provider to the list.\nSee:\nhttps://opendev.org/openstack/ovn-octavia-provider/src/branch/stable/wallaby/devstack/plugin.sh#L15\nand\nhttps://opendev.org/openstack/ovn-octavia-provider/src/branch/stable/wallaby/devstack/settings#L3\n\nOne approach that does not break backward compatibility in the Octavia tempest plugin would be to fix the ovn provider devstack plugin to append instead of overwrite this setting, or add \"octavia\" as a valid option. Much like was done here:\nhttps://opendev.org/openstack/ovn-octavia-provider/commit/6f569afc021020c2aa9fa84738cef540f59daeaf\n\nIf this is not the reason you have proposed this patch, please open a story and attach it to the patch such that we can understand what the problem is that this change would resolve.\n\nIf we feel strongly about changing this default (it has been deprecated since Rocky), this patch must include a release note stating that as of this version it will no longer work against versions older than rocky by default and the setting must be overridden in the tempest.conf file back to \"octavia\".","commit_id":"19df248302a0240e9190520c11ba34dbe47875b1"}],"octavia_tempest_plugin/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e3c302912b0153115cc7f6fb972e8953de42096b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"               default\u003d20,"},{"line_number":101,"context_line":"               help\u003d\u0027Retries for scp to attempt to connect.\u0027),"},{"line_number":102,"context_line":"    cfg.StrOpt(\u0027provider\u0027,"},{"line_number":103,"context_line":"               default\u003d\u0027amphora\u0027,"},{"line_number":104,"context_line":"               help\u003d\u0027The provider driver to use for the tests.\u0027),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027RBAC_test_type\u0027, default\u003dconst.ADVANCED,"},{"line_number":106,"context_line":"               choices\u003d[const.ADVANCED, const.KEYSTONE_DEFAULT_ROLES,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0595ab7c_8fe96d89","line":103,"updated":"2022-07-12 17:12:17.000000000","message":"This should not matter, it is an alias defined in the entrypoints for Octavia. It has been left \"octavia\" to test the backward compatibility and to maintain support for this tempest plugin to run against versions of Octavia that did not define the \"amphora\" provider (older than Rocky).\nFunctionally they are equivalent.\nhttps://github.com/openstack/octavia/blob/master/setup.cfg#L64","commit_id":"19df248302a0240e9190520c11ba34dbe47875b1"}]}