)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1c31aae4128a03389cfbf92f0691625472359e81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28b64b06_8d1fcbf3","updated":"2022-07-13 15:14:51.000000000","message":"we should avoid using a condition based on the provider.\nhere is what we should do:\neach test that uses the allowed_cidrs parameter will be split into 2 tests: 1 test that still uses the allowed_cidrs params (same test, same uuid), 1 other test that doesn\u0027t use it (this is the new test).\n\nfor instance in api/v2/test_listener.py:\nwe have\ndef _test_listener_create(self, protocol, protocol_port):\n\nwe could add a use_allowed_cidrs param (default True)\n\nand add new tests such as\n\ndef test_tcp_listener_create_no_allowed_cidrs()\nthat calls\ntest_listener_create(XXX, XXX, use_allowed_cidrs\u003dFalse)","commit_id":"9ee378252ba04b4fb48dde64821930fad55440b3"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"60b90569f3566d286b1cb2109e7824688c2dbd45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2ba4fa4_ed8ba968","in_reply_to":"28b64b06_8d1fcbf3","updated":"2025-02-24 11:27:17.000000000","message":"I\u0027ve been trying to go that way, can you take a look at it?","commit_id":"9ee378252ba04b4fb48dde64821930fad55440b3"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"068019e33e7ac13dd7f72386b8494264408a2b0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04917ce8_654c80d4","updated":"2025-05-21 09:37:49.000000000","message":"recheck\nanother round to compare logs timing","commit_id":"7fe9b7c643c0e4b244864fc5a9d7b5a668811bc3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3859be87c168a5f2515e136b31ee5c57ebe137cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f22a30cc_9b9ea0fc","updated":"2025-05-16 11:39:53.000000000","message":"recheck\nrefreshing the logs\nI would like to review the duration of the tests","commit_id":"7fe9b7c643c0e4b244864fc5a9d7b5a668811bc3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0f9148bb95816b2ce52dd37399ab52a52a483bca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1cfe2566_ce0f3663","updated":"2025-07-10 12:25:12.000000000","message":"I have that one comment, except for that the patch LGTM","commit_id":"081898908a3ad849dd862157fc42a4d78191695a"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"42af3784012092a03f82ad9e4b3aefa76c5df330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"470fcc6d_6f05589d","updated":"2025-07-11 11:50:09.000000000","message":"Looks good to me","commit_id":"afffce19230077433c7c0f7e35b635fd22d18c25"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2b02f787366e0296dc975f857de68fbd44ce192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8b837c07_f49c1d30","updated":"2025-07-11 21:57:06.000000000","message":"This LGTM\nThank you for updating this to be more complete","commit_id":"afffce19230077433c7c0f7e35b635fd22d18c25"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1c31aae4128a03389cfbf92f0691625472359e81","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        cls.test_allowed_cidrs \u003d False"},{"line_number":62,"context_line":"        if (cls.mem_listener_client.is_version_supported("},{"line_number":63,"context_line":"                cls.api_version, \u00272.12\u0027) and"},{"line_number":64,"context_line":"                CONF.load_balancer.provider !\u003d \u0027ovn\u0027):"},{"line_number":65,"context_line":"            cls.test_allowed_cidrs \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"f52cba88_ff94bf1d","line":64,"updated":"2022-07-13 15:14:51.000000000","message":"we should not add conditionals that rely on the provider, the test should be provider agnostic","commit_id":"9ee378252ba04b4fb48dde64821930fad55440b3"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c33f5fcee11117ceedbf53562a7a6c63e0e0ea10","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        cls.test_allowed_cidrs \u003d False"},{"line_number":62,"context_line":"        if (cls.mem_listener_client.is_version_supported("},{"line_number":63,"context_line":"                cls.api_version, \u00272.12\u0027) and"},{"line_number":64,"context_line":"                CONF.load_balancer.provider !\u003d \u0027ovn\u0027):"},{"line_number":65,"context_line":"            cls.test_allowed_cidrs \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2c31e53_1df01711","line":64,"in_reply_to":"23c842bb_93aa269a","updated":"2025-07-11 09:41:49.000000000","message":"Done","commit_id":"9ee378252ba04b4fb48dde64821930fad55440b3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"115d987f62df46d79dcb9ccb5a78c271722f2a55","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        cls.test_allowed_cidrs \u003d False"},{"line_number":62,"context_line":"        if (cls.mem_listener_client.is_version_supported("},{"line_number":63,"context_line":"                cls.api_version, \u00272.12\u0027) and"},{"line_number":64,"context_line":"                CONF.load_balancer.provider !\u003d \u0027ovn\u0027):"},{"line_number":65,"context_line":"            cls.test_allowed_cidrs \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"23c842bb_93aa269a","line":64,"in_reply_to":"f52cba88_ff94bf1d","updated":"2022-07-13 15:26:38.000000000","message":"+100, not to mention this would leave the allowed_cidrs parameter untested in the OVN provider which we have seen leads to user facing breakage.","commit_id":"9ee378252ba04b4fb48dde64821930fad55440b3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0f9148bb95816b2ce52dd37399ab52a52a483bca","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u00274aaf06a4-a9e0-440d-9ff8-d4be13ddea96\u0027)"},{"line_number":249,"context_line":"    def test_http_listener_create_no_allowed_cidrs(self):"},{"line_number":250,"context_line":"        self._test_listener_create(const.HTTP, 8000, use_allowed_cidrs\u003dFalse)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @decorators.idempotent_id(\u00272cc89237-fc6b-434d-b38e-b3309823e71f\u0027)"},{"line_number":253,"context_line":"    def test_https_listener_create(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"d681f71f_4a2efa99","line":250,"updated":"2025-07-10 12:25:12.000000000","message":"Those 3 first tests use the same port as the use_allowed_cidrs\u003dTrue ones, yet CI passes. Is that separation even needed then?","commit_id":"081898908a3ad849dd862157fc42a4d78191695a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c33f5fcee11117ceedbf53562a7a6c63e0e0ea10","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u00274aaf06a4-a9e0-440d-9ff8-d4be13ddea96\u0027)"},{"line_number":249,"context_line":"    def test_http_listener_create_no_allowed_cidrs(self):"},{"line_number":250,"context_line":"        self._test_listener_create(const.HTTP, 8000, use_allowed_cidrs\u003dFalse)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @decorators.idempotent_id(\u00272cc89237-fc6b-434d-b38e-b3309823e71f\u0027)"},{"line_number":253,"context_line":"    def test_https_listener_create(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ce4ece14_a3acee27","line":250,"in_reply_to":"596cf44c_bb21fe40","updated":"2025-07-11 09:41:49.000000000","message":"Done","commit_id":"081898908a3ad849dd862157fc42a4d78191695a"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"45b7b7791c857ebcea6c4fc7b0c62d8aff561c04","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u00274aaf06a4-a9e0-440d-9ff8-d4be13ddea96\u0027)"},{"line_number":249,"context_line":"    def test_http_listener_create_no_allowed_cidrs(self):"},{"line_number":250,"context_line":"        self._test_listener_create(const.HTTP, 8000, use_allowed_cidrs\u003dFalse)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @decorators.idempotent_id(\u00272cc89237-fc6b-434d-b38e-b3309823e71f\u0027)"},{"line_number":253,"context_line":"    def test_https_listener_create(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"596cf44c_bb21fe40","line":250,"in_reply_to":"d681f71f_4a2efa99","updated":"2025-07-10 12:29:39.000000000","message":"The listeners should be destroyed when the test is complete (it uses addCleanup), so it should be ok.\nbut yeah maybe for consistency, we could set a different port number here","commit_id":"081898908a3ad849dd862157fc42a4d78191695a"}]}