)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"38aac4fb7191c4bad602a1b3eed2a1bbc7a7b243","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5239ac5_41a1f56c","updated":"2022-07-12 15:23:13.000000000","message":"I like the idea, just a comment about the group of the option","commit_id":"1a58825366a530f0d8e2368de721c8137365dcfe"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8b3ba44ed54c552a1178de71ce7be1cab930527a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"818fa20b_0207f4b0","updated":"2022-07-12 16:01:03.000000000","message":"We cannot do this, it would mean we are not testing that the provider drivers are properly declaring they do not support a feature.","commit_id":"1a58825366a530f0d8e2368de721c8137365dcfe"}],"octavia_tempest_plugin/config.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"38aac4fb7191c4bad602a1b3eed2a1bbc7a7b243","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    cfg.BoolOpt(\u0027test_with_ipv6\u0027,"},{"line_number":153,"context_line":"                default\u003dTrue,"},{"line_number":154,"context_line":"                help\u003d\u0027When true the IPv6 tests will be run.\u0027),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027test_allowed_cidrs\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\u0027When true the Load Balancer listener will include this \u0027"},{"line_number":158,"context_line":"                     \u0027parameter on creation/update.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"950cf8b2_a094b4f6","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":35},"updated":"2022-07-12 15:23:13.000000000","message":"I think this option should belong to the loadbalancer-feature-enabled group (bellow)","commit_id":"1a58825366a530f0d8e2368de721c8137365dcfe"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"8ad157991247139c9bbb76f12010138a2b50194b","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    cfg.BoolOpt(\u0027test_with_ipv6\u0027,"},{"line_number":153,"context_line":"                default\u003dTrue,"},{"line_number":154,"context_line":"                help\u003d\u0027When true the IPv6 tests will be run.\u0027),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027test_allowed_cidrs\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\u0027When true the Load Balancer listener will include this \u0027"},{"line_number":158,"context_line":"                     \u0027parameter on creation/update.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1deac1b3_eff94fda","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":35},"in_reply_to":"00096940_4fa07664","updated":"2022-07-12 16:22:46.000000000","message":"I think you are mixing the concept \"support this feature\" with the \"test this feature\". The ovn-provider cannot support it, and it will raise the exception, and one additional test should evaluate that specific behaviour. But we want that project octavia-tempest-plugin could be enough generic to be run over all providers, so after our chat conversation about it, let me abandon this one and go through the addition of tests without allowed_cidrs.","commit_id":"1a58825366a530f0d8e2368de721c8137365dcfe"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8b3ba44ed54c552a1178de71ce7be1cab930527a","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    cfg.BoolOpt(\u0027test_with_ipv6\u0027,"},{"line_number":153,"context_line":"                default\u003dTrue,"},{"line_number":154,"context_line":"                help\u003d\u0027When true the IPv6 tests will be run.\u0027),"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027test_allowed_cidrs\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                help\u003d\u0027When true the Load Balancer listener will include this \u0027"},{"line_number":158,"context_line":"                     \u0027parameter on creation/update.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"00096940_4fa07664","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":35},"in_reply_to":"950cf8b2_a094b4f6","updated":"2022-07-12 16:01:03.000000000","message":"We cannot add options like this. This feature is part of the Octavia API specification and ALL providers must handle it properly. If the provider cannot support this feature, it must raise not-implemented or unsupported-option such that the tests are skipped.","commit_id":"1a58825366a530f0d8e2368de721c8137365dcfe"}]}