)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"28ff118fc23a54834439ab9296a9068728aca43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26f309d7_5542cae8","updated":"2024-09-25 09:05:24.000000000","message":"Hey, the test looks good to me, but I wonder if it really worth the precious testing time because it does not test that much really. \n\n[1] is very similar. It doesn\u0027t pause the compute, but sets the ports down, which is not much different. It is more comprehensive than this one because it covers the failover circuit breaker functionality as well.\n\n[1]: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/837878","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e990f8d16b712dee50c980194a0105ce8fd740cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b85956e_44dd1984","updated":"2022-12-15 15:32:44.000000000","message":"I see now that there is already an octavia-tempest-plugin/octavia_tempest_plugin/tests/scenario/v2/test_healthmonitor.py with the same class name: \"HealthMonitorScenarioTest\" from 2018 more or less.\n\nCan you move the changes to that file? It might make the change shorter and easier to review.","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c95dfaa84bb675040820ed299693a61e21ec179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c63a71d8_6f61c4f2","updated":"2022-12-18 11:33:51.000000000","message":"Unlike the tests in https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/scenario/v2/test_healthmonitor.py\nthis is a traffic based test, reason for naming a file: \"test_healthmonitor_traffic.py\"\nIn addition, since this test pauses LB members, keeping such a stuff “isolated”, makes sense because of parallel test execution or potential failures it may have (for example resuming LB members fails for some reason)\n","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7e22866758978f3f7cc3d4e94aa44d69161ef41a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"614ddf29_a2a4609f","updated":"2023-11-28 10:12:36.000000000","message":"recheck","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c9a052ee63b353663ead894915ab642fc5a21c64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da2222db_235d570b","updated":"2023-04-16 16:30:14.000000000","message":"recheck","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b0b2efa71001663cb62adb589e9265fbef51e4f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dfdd1afe_4650f15d","updated":"2023-06-20 09:09:51.000000000","message":"recheck","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c75406f6f906e509d6ce058bd8b312cdf7043267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e96d7848_6fb934c0","updated":"2024-03-05 08:28:14.000000000","message":"recheck\nEnsure that the code is still valid and works","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"92bb1c99dbf658441c5b3c0a5b39d54c342ff835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b484293d_5e22a360","updated":"2023-07-20 08:59:11.000000000","message":"recheck\nGates\u0027 failures doesn\u0027t seem to be related to the code changes.","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"00f047bb082dac964cebd826745982874c43c0af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a93b3aeb_1a43b729","updated":"2022-11-21 09:18:26.000000000","message":"recheck\nRecheck the results.","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"de6e988accddf45a2767fca776cd295c675bccbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9b3868f_5522f558","in_reply_to":"c63a71d8_6f61c4f2","updated":"2023-07-20 14:37:18.000000000","message":"ok then","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6995c80ebcea7403832ae257c4c2f6ed6fb8fbe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b76506e4_65737d09","in_reply_to":"dfdd1afe_4650f15d","updated":"2023-06-20 09:44:01.000000000","message":"@Arkady, please don\u0027t use bare rechecks, there are some stats about bare rechecks and the projects are blamed when people abuse of them","commit_id":"56de13e5cea920dfcb2a36ba1930d95ae3bb1b79"}]}
