)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27824803ac849ac9d6040f0d877be0ce8860e67f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a67c0b2d_f8682d5d","updated":"2022-12-18 22:35:08.000000000","message":"I don\u0027t think this is a good idea. This test suite is for Octavia and not individual providers. We have discussed this at one of the Octavia meetings and decided it was not a good idea. This is why we have been working to remove any of the provider specific code that was added.\n\nHere are a couple of reasons I can think of off my head:\n1. Our test jobs already run up against the maximum runtime allowed in zuul, so we would not be able to use this in opendev zuul.\n2. It confuses what this test suite is for, Octavia, and not a specific provider driver.\n3. It will confuse users about where to report bugs with the third-party provider drivers. I.e. they should not report test failures caused by a specific provider driver to the Octavia team, but instead to the provider driver owner.","commit_id":"2a8a23503f2ca30344871f7b4991a54f818d6968"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6ed8dd69cf0f62e189fffa05c626ad55ea431f5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54377eab_1c32957c","in_reply_to":"574b6ac4_8c00d97c","updated":"2023-01-03 17:01:18.000000000","message":"We just run multiple jobs, each with all of the supported providers enabled, each configuring tempest to use the provider under test.\nThis way the test UUIDs are consistent (again, testing Octavia and not a provider).","commit_id":"2a8a23503f2ca30344871f7b4991a54f818d6968"},{"author":{"_account_id":35087,"name":"Bas de Bruijne","email":"bas.debruijne@canonical.com","username":"basdbruijne"},"change_message_id":"9f2c228b0162d11c29fc9fb8fb18dccfe6de9661","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"574b6ac4_8c00d97c","in_reply_to":"a67c0b2d_f8682d5d","updated":"2023-01-03 12:43:06.000000000","message":"Thanks for the review Michael. \n\nI would argue that 1 is not a valid reason not to extend the number of tests for Octavia.\nFor points 2 and 3, this patch does not make it easier or harder to test third-party providers. It only makes it easier to test multiple providers, but they should be tested anyway if they are used in a production environment.\n\nI do get the point that we are testing Octavia itself and not necessarily the individual providers. From a practical standpoint, however, this is also the perfect tool to perform validation testing on Octavia instances, at which point we are not only interested in Octavia itself but also its compatibility with the providers we intend to use. If someone wants to use multiple providers, they should be able to test that.\n\nAnyway, I don\u0027t want to beat a dead horse. If this decision is made then I will implement this downstream somewhere instead.","commit_id":"2a8a23503f2ca30344871f7b4991a54f818d6968"}]}