)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"722e18108050fab026442599592d4678040021d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18f56319_4b29dedc","updated":"2023-01-09 18:16:32.000000000","message":"I gladly suggest changes for the parent patch to make it running on all clouds and not just default devstack setup(I have these changes locally), but they are not related to this scenario. This scenario is to test multiAZ active_standby loadbalancer defined using loadbalancer flavor. And it does check that we have two amphoras and they are in different availability zones.\n","commit_id":"0d4b1702c4b0203d01ce4d809ccf9c304b2ead20"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f43a35f6359f7bc2563a9b0d725f58a66101f0f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aca82f6b_62cd4caa","updated":"2023-03-27 17:13:45.000000000","message":"recheck get new CI results","commit_id":"0d4b1702c4b0203d01ce4d809ccf9c304b2ead20"}],"octavia_tempest_plugin/tests/az_scenario/v2/test_load_balancer.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7bc7a9f72adc0e962daca4510b6d6606e1b051d4","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        amphorae \u003d self.lb_admin_amphora_client.list_amphorae("},{"line_number":186,"context_line":"            query_params\u003d\u0027loadbalancer_id\u003d%s\u0027 % lb[const.ID])"},{"line_number":187,"context_line":"        self.assertEqual(2, len(amphorae))"},{"line_number":188,"context_line":"        used_zones \u003d []"},{"line_number":189,"context_line":"        for created_amph in amphorae:"},{"line_number":190,"context_line":"            compute_id \u003d created_amph[\u0027compute_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4032409d_388a6935","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":42},"updated":"2023-01-09 17:22:49.000000000","message":"Reviewers/Denys, should we use some skippers on this module? If a job will run the whole module (both tests for a single az and multiaz flavor), it will probably either fail on this line or on line 150 (depends on the Octavia topology)","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"722e18108050fab026442599592d4678040021d3","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        amphorae \u003d self.lb_admin_amphora_client.list_amphorae("},{"line_number":186,"context_line":"            query_params\u003d\u0027loadbalancer_id\u003d%s\u0027 % lb[const.ID])"},{"line_number":187,"context_line":"        self.assertEqual(2, len(amphorae))"},{"line_number":188,"context_line":"        used_zones \u003d []"},{"line_number":189,"context_line":"        for created_amph in amphorae:"},{"line_number":190,"context_line":"            compute_id \u003d created_amph[\u0027compute_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"aef93bc5_4fbef4e2","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":42},"in_reply_to":"4032409d_388a6935","updated":"2023-01-09 18:16:32.000000000","message":"on line 150 - yes, if the env has active_standby by default, it will fail. And I asked this question regarding parent patch I am basing on. I just tried to minimize the amount of changes.\n\nHowever here it does not matter what you have in your config, topology is specified in the flavor. Check line 249. And it must be 2 for active_standby variant.","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7bc7a9f72adc0e962daca4510b6d6606e1b051d4","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                                                availability_zone\u003daz1_name)"},{"line_number":223,"context_line":"            aggregate2 \u003d self._create_aggregate(name\u003daggregate2_name,"},{"line_number":224,"context_line":"                                                availability_zone\u003daz2_name)"},{"line_number":225,"context_line":"            # We probably need to check if these hosts are not assigne to any"},{"line_number":226,"context_line":"            # aggregate"},{"line_number":227,"context_line":"            hosts \u003d self._get_hosts()"},{"line_number":228,"context_line":"            self.assertGreaterEqual(len(hosts), 2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0f3882c_a2261ac6","line":225,"range":{"start_line":225,"start_character":63,"end_line":225,"end_character":70},"updated":"2023-01-09 17:22:49.000000000","message":"nit: typo in assigned","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"722e18108050fab026442599592d4678040021d3","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                                availability_zone\u003daz1_name)"},{"line_number":223,"context_line":"            aggregate2 \u003d self._create_aggregate(name\u003daggregate2_name,"},{"line_number":224,"context_line":"                                                availability_zone\u003daz2_name)"},{"line_number":225,"context_line":"            # We probably need to check if these hosts are not assigne to any"},{"line_number":226,"context_line":"            # aggregate"},{"line_number":227,"context_line":"            hosts \u003d self._get_hosts()"},{"line_number":228,"context_line":"            self.assertGreaterEqual(len(hosts), 2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83ada87b_d99018cc","line":225,"range":{"start_line":225,"start_character":63,"end_line":225,"end_character":70},"in_reply_to":"b0f3882c_a2261ac6","updated":"2023-01-09 18:16:32.000000000","message":"Done","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7bc7a9f72adc0e962daca4510b6d6606e1b051d4","unresolved":true,"context_lines":[{"line_number":334,"context_line":"        * Get or create two nova availability zones"},{"line_number":335,"context_line":"        * Create flavor with availability zones list"},{"line_number":336,"context_line":"        * Create LB with defined flavor"},{"line_number":337,"context_line":"        * Confirm that amphoras uses different avaialability zones"},{"line_number":338,"context_line":"        \"\"\""},{"line_number":339,"context_line":"        aggregates \u003d self._get_or_create_aggregates()"},{"line_number":340,"context_line":"        az_list \u003d [az[\u0027name\u0027] for az in aggregates.values()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"db571404_11ef15fa","line":337,"range":{"start_line":337,"start_character":47,"end_line":337,"end_character":60},"updated":"2023-01-09 17:22:49.000000000","message":"nit: typo in availability","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"722e18108050fab026442599592d4678040021d3","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        * Get or create two nova availability zones"},{"line_number":335,"context_line":"        * Create flavor with availability zones list"},{"line_number":336,"context_line":"        * Create LB with defined flavor"},{"line_number":337,"context_line":"        * Confirm that amphoras uses different avaialability zones"},{"line_number":338,"context_line":"        \"\"\""},{"line_number":339,"context_line":"        aggregates \u003d self._get_or_create_aggregates()"},{"line_number":340,"context_line":"        az_list \u003d [az[\u0027name\u0027] for az in aggregates.values()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"566c4609_e64a5e6a","line":337,"range":{"start_line":337,"start_character":47,"end_line":337,"end_character":60},"in_reply_to":"db571404_11ef15fa","updated":"2023-01-09 18:16:32.000000000","message":"Done","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7bc7a9f72adc0e962daca4510b6d6606e1b051d4","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        az_list \u003d [az[\u0027name\u0027] for az in aggregates.values()]"},{"line_number":341,"context_line":"        self.assertEqual(2, len(az_list))"},{"line_number":342,"context_line":"        # Create a shared flavor profile. (resource_setup?)"},{"line_number":343,"context_line":"        flavor \u003d self._create_multiaz_falvor(az_list)"},{"line_number":344,"context_line":"        self.assertIsNotNone(flavor, \"Can\u0027t proceed without flavor created\")"},{"line_number":345,"context_line":"        self._test_load_balancer_create_multiaz_flavor(flavor[const.ID])"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7f6e5c6_993e38bc","line":343,"range":{"start_line":343,"start_character":38,"end_line":343,"end_character":44},"updated":"2023-01-09 17:22:49.000000000","message":"nit: typo in flavor","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"722e18108050fab026442599592d4678040021d3","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        az_list \u003d [az[\u0027name\u0027] for az in aggregates.values()]"},{"line_number":341,"context_line":"        self.assertEqual(2, len(az_list))"},{"line_number":342,"context_line":"        # Create a shared flavor profile. (resource_setup?)"},{"line_number":343,"context_line":"        flavor \u003d self._create_multiaz_falvor(az_list)"},{"line_number":344,"context_line":"        self.assertIsNotNone(flavor, \"Can\u0027t proceed without flavor created\")"},{"line_number":345,"context_line":"        self._test_load_balancer_create_multiaz_flavor(flavor[const.ID])"}],"source_content_type":"text/x-python","patch_set":2,"id":"44a1d708_f1e2ec4e","line":343,"range":{"start_line":343,"start_character":38,"end_line":343,"end_character":44},"in_reply_to":"e7f6e5c6_993e38bc","updated":"2023-01-09 18:16:32.000000000","message":"Done","commit_id":"c06c26f6a4352738ce8475d71af7397794e5adb5"}]}
