)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0d4535d724df6f296f765b13c5747ff48521edc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2b54a95_1a7d6cfc","updated":"2023-04-27 10:44:57.000000000","message":"recheck dependent change was updated","commit_id":"1d202d9977bf222cfdbc19a0e226680a575cc068"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"911002c136097d67cc44a6b9ae4d54ff95b5697f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87819274_3c386924","updated":"2023-05-03 13:21:59.000000000","message":"recheck depends-on patches were updated","commit_id":"c801a69482b9c7f9340a110fe651e4ac96e30398"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"939657bb43ebd63d276eaeb38df0e2f03f003103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93cbce55_698a6858","updated":"2023-05-03 15:04:09.000000000","message":"recheck merge should work now","commit_id":"c801a69482b9c7f9340a110fe651e4ac96e30398"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"116eb4e2e8d4f67130ae94768b0a7dca7bea00ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d1241a42_3e193f71","updated":"2023-05-05 11:20:04.000000000","message":"recheck again","commit_id":"e645f12db457bb5b23cd9c4c68416a05308d33ea"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b3609ef770c48f7f2bcff405954ce59ccb1f7c54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9027b58c_2870fa2a","updated":"2023-05-05 06:49:46.000000000","message":"recheck conflict resolved","commit_id":"e645f12db457bb5b23cd9c4c68416a05308d33ea"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"3ddacf7b9c5f4dafdf82204014e6aaaf9e6745d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"09b091dd_99ad5a6f","updated":"2023-05-08 11:48:45.000000000","message":"recheck node failures","commit_id":"e645f12db457bb5b23cd9c4c68416a05308d33ea"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"81c58508ca4479dd9ad17d3678788f6e61e35767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"77e6b180_68347f5d","updated":"2023-07-19 15:53:10.000000000","message":"recheck test again","commit_id":"e645f12db457bb5b23cd9c4c68416a05308d33ea"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"1b4f353bfd80c99788b2068f9bc40d88f204fbd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"90c5384c_2bfe6e6b","updated":"2023-05-08 06:37:26.000000000","message":"recheck timeout","commit_id":"e645f12db457bb5b23cd9c4c68416a05308d33ea"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"957af75953758fbd723958feaa3c7312fb3df85d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"57fe2c5e_f304b1db","updated":"2023-08-23 20:46:58.000000000","message":"Even though it seems redundant to the scenario test, I would like to see the listener API tests updated as well. There are scenarios where we only run API tests, etc.\nOtherwise it looks good, with one minor comment.","commit_id":"e65bcc62015796f2a45b96de561c010bd0663c51"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"a11efc2af37a189e1a5bf7659fdc5e76f2322c83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7a5aa37f_93361bcf","updated":"2023-08-23 12:02:10.000000000","message":"recheck regenerate data","commit_id":"e65bcc62015796f2a45b96de561c010bd0663c51"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"819d627b084b64a988e8f5874d41ad58e2d9107d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"29334ffc_0c7d77cc","updated":"2023-10-12 13:48:17.000000000","message":"recheck get more data. Failed test octavia_tempest_plugin.tests.scenario.v2.test_ipv6_traffic_ops.IPv6TrafficOperationsScenarioTest.test_ipv6_tcp_LC_listener_with_allowed_cidrs not related to this change.","commit_id":"dccfc3aa9386a266fcab573abbd5f5fb88247078"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"397ea2671e08830a34d100c14abf997e21132397","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e82afca8_82c30a64","updated":"2023-10-30 11:52:51.000000000","message":"Looks good to me","commit_id":"5bc677c4beb4a626ac906440b18221dd687cdad5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"95113d5cf52badea153b2ab5bb2e9be349f860c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2f5c6f6b_ee3f2833","updated":"2024-02-06 07:57:15.000000000","message":"The latest tempet plugin should support all active stable branches(which means zed and later at this moment)\nSo this may need to be opt-in for now","commit_id":"dd14c051ea93d92aadcd28a5b4930f0b35544c2b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ffdd5820493fe4b29c2d63ee4ad1ec7aeaf6b8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a26b37bb_8d8a62c4","in_reply_to":"2f5c6f6b_ee3f2833","updated":"2024-02-06 08:03:27.000000000","message":"hm.  probably that version check should address this.","commit_id":"dd14c051ea93d92aadcd28a5b4930f0b35544c2b"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"dd71a515574601d4a76b19c935f42bf5c0ed3168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"cdded86e_e0566935","updated":"2024-02-12 09:27:41.000000000","message":"recheck yoga job has been replaced","commit_id":"dafc1e7072239c201522df55b6723c9ac1e6fc8d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2a7020bcc7fee6dfba05bc01f4e4314bbc23fc47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"d8895e6f_982c1b34","updated":"2024-04-16 16:02:56.000000000","message":"Looks good to me","commit_id":"e4728b52ebb084e3dc826002903aff60f8d84abf"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2d661db7ed9d42fc3d9a4d8ccee3a1e3ef1e62ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"2283c489_1875da1e","updated":"2024-04-23 11:56:18.000000000","message":"small detail and questions","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7353dd764b1853219501338c6b9ed8c1f10cf614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"57b7deb7_51e876f2","updated":"2024-04-24 17:05:29.000000000","message":"I am ok with this. LGTM","commit_id":"c03e9c39d24feffae9ac246f947e0655b7224547"}],"octavia_tempest_plugin/tests/act_stdby_scenario/v2/test_active_standby.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"957af75953758fbd723958feaa3c7312fb3df85d","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from octavia_tempest_plugin.services.load_balancer import v2"},{"line_number":23,"context_line":"from tempest import config"},{"line_number":24,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":25,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":10,"id":"30d9e446_7e75accb","line":22,"updated":"2023-08-23 20:46:58.000000000","message":"This should be down below with the other octavia_tempest_plugin imports.\nI wonder why pep8 didn\u0027t flag this....","commit_id":"e65bcc62015796f2a45b96de561c010bd0663c51"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"329c737cef134637bf615fd6a5c47f53586b9485","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from octavia_tempest_plugin.services.load_balancer import v2"},{"line_number":23,"context_line":"from tempest import config"},{"line_number":24,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":25,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":10,"id":"d971337a_fc840e02","line":22,"in_reply_to":"30d9e446_7e75accb","updated":"2023-08-30 16:40:00.000000000","message":"Maybe it doesn\u0027t understand that it is checking the `octavia_tempest_plugin` package. PyCharm obviously didn\u0027t either. Done.","commit_id":"e65bcc62015796f2a45b96de561c010bd0663c51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e682eddc1eaa7861370666e3d5b095a0b5eb8f73","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    CONF.validation.run_validation,"},{"line_number":37,"context_line":"    \u0027Active-Standby tests will not work without run_validation enabled.\u0027)"},{"line_number":38,"context_line":"class ActiveStandbyScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":"    mem_listener_client: v2.ListenerClient"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":31,"id":"7bcf944c_9b7664d9","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":42},"updated":"2024-04-16 13:32:33.000000000","message":"Is that class variable being used in the code?","commit_id":"e4728b52ebb084e3dc826002903aff60f8d84abf"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2a7020bcc7fee6dfba05bc01f4e4314bbc23fc47","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    CONF.validation.run_validation,"},{"line_number":37,"context_line":"    \u0027Active-Standby tests will not work without run_validation enabled.\u0027)"},{"line_number":38,"context_line":"class ActiveStandbyScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":"    mem_listener_client: v2.ListenerClient"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":31,"id":"322e00df_da016524","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":42},"in_reply_to":"4561fbe3_600a624d","updated":"2024-04-16 16:02:56.000000000","message":"ok, adding type annotations to the class doesn\u0027t look bad to me.","commit_id":"e4728b52ebb084e3dc826002903aff60f8d84abf"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f0ebe0424adb0323b21e34b5926aec9a5b22041c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    CONF.validation.run_validation,"},{"line_number":37,"context_line":"    \u0027Active-Standby tests will not work without run_validation enabled.\u0027)"},{"line_number":38,"context_line":"class ActiveStandbyScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":"    mem_listener_client: v2.ListenerClient"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":31,"id":"4561fbe3_600a624d","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":42},"in_reply_to":"7bcf944c_9b7664d9","updated":"2024-04-16 15:22:33.000000000","message":"Yes, look for `cls.mem_listener_client` and you\u0027ll find some uses.","commit_id":"e4728b52ebb084e3dc826002903aff60f8d84abf"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2d661db7ed9d42fc3d9a4d8ccee3a1e3ef1e62ac","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    CONF.validation.run_validation,"},{"line_number":37,"context_line":"    \u0027Active-Standby tests will not work without run_validation enabled.\u0027)"},{"line_number":38,"context_line":"class ActiveStandbyScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":"    mem_listener_client: v2.ListenerClient"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"12539dc5_f331961b","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":42},"updated":"2024-04-23 11:56:18.000000000","message":"while I think it\u0027s great to add this type of annotation there, it seems unrelated to this patch","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f7b9f374b480eae57b2b02af6f50f5ce8cf53ae8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    CONF.validation.run_validation,"},{"line_number":37,"context_line":"    \u0027Active-Standby tests will not work without run_validation enabled.\u0027)"},{"line_number":38,"context_line":"class ActiveStandbyScenarioTest(test_base.LoadBalancerBaseTestWithCompute):"},{"line_number":39,"context_line":"    mem_listener_client: v2.ListenerClient"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"96ae3f39_7efbe8f1","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":42},"in_reply_to":"12539dc5_f331961b","updated":"2024-04-23 12:27:35.000000000","message":"Done","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fae732f1d843495da2f36c41cfd21057e4f695ab","unresolved":true,"context_lines":[{"line_number":949,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":950,"context_line":"                self.api_version, \u00272.12\u0027):"},{"line_number":951,"context_line":"            show_listener_response_fields.append(\u0027allowed_cidrs\u0027)"},{"line_number":952,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":953,"context_line":"                self.api_version, \u00272.17\u0027):"},{"line_number":954,"context_line":"            show_listener_response_fields.append(const.HSTS_PRELOAD)"},{"line_number":955,"context_line":"            show_listener_response_fields.append(const.HSTS_MAX_AGE)"},{"line_number":956,"context_line":"            show_listener_response_fields.append(const.HSTS_INCLUDE_SUBDOMAINS)"},{"line_number":957,"context_line":"        for field in show_listener_response_fields:"},{"line_number":958,"context_line":"            if field in (const.DEFAULT_POOL_ID, const.L7_POLICIES):"},{"line_number":959,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":18,"id":"a3e0ffee_dbc8efc8","line":956,"range":{"start_line":952,"start_character":8,"end_line":956,"end_character":79},"updated":"2023-10-26 14:45:46.000000000","message":"if I understand it correctly, we add the fields to the show_listener_response_fields, and then we iterate all fields and make sure the listeners have the same fields.\n\nOn this patch we add the HSTS fields to the fields we check/compare, but we don\u0027t add those fields to the listener kwargs, so we basically make sure none of the listeners have the HSTS fields (?)","commit_id":"5bc677c4beb4a626ac906440b18221dd687cdad5"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5d3d0fd66aac8a8b75adb238ff0d27c166bbd33","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":950,"context_line":"                self.api_version, \u00272.12\u0027):"},{"line_number":951,"context_line":"            show_listener_response_fields.append(\u0027allowed_cidrs\u0027)"},{"line_number":952,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":953,"context_line":"                self.api_version, \u00272.17\u0027):"},{"line_number":954,"context_line":"            show_listener_response_fields.append(const.HSTS_PRELOAD)"},{"line_number":955,"context_line":"            show_listener_response_fields.append(const.HSTS_MAX_AGE)"},{"line_number":956,"context_line":"            show_listener_response_fields.append(const.HSTS_INCLUDE_SUBDOMAINS)"},{"line_number":957,"context_line":"        for field in show_listener_response_fields:"},{"line_number":958,"context_line":"            if field in (const.DEFAULT_POOL_ID, const.L7_POLICIES):"},{"line_number":959,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":18,"id":"adc56688_7a09b277","line":956,"range":{"start_line":952,"start_character":8,"end_line":956,"end_character":79},"in_reply_to":"2efd92f0_b76a798a","updated":"2023-10-30 11:52:43.000000000","message":"ok, so that would be another thing to test - making sure those flags are not enabled by default.","commit_id":"5bc677c4beb4a626ac906440b18221dd687cdad5"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"5e43be737db0d1764646d25dc53eb0b25299e4aa","unresolved":true,"context_lines":[{"line_number":949,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":950,"context_line":"                self.api_version, \u00272.12\u0027):"},{"line_number":951,"context_line":"            show_listener_response_fields.append(\u0027allowed_cidrs\u0027)"},{"line_number":952,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":953,"context_line":"                self.api_version, \u00272.17\u0027):"},{"line_number":954,"context_line":"            show_listener_response_fields.append(const.HSTS_PRELOAD)"},{"line_number":955,"context_line":"            show_listener_response_fields.append(const.HSTS_MAX_AGE)"},{"line_number":956,"context_line":"            show_listener_response_fields.append(const.HSTS_INCLUDE_SUBDOMAINS)"},{"line_number":957,"context_line":"        for field in show_listener_response_fields:"},{"line_number":958,"context_line":"            if field in (const.DEFAULT_POOL_ID, const.L7_POLICIES):"},{"line_number":959,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":18,"id":"2efd92f0_b76a798a","line":956,"range":{"start_line":952,"start_character":8,"end_line":956,"end_character":79},"in_reply_to":"a3e0ffee_dbc8efc8","updated":"2023-10-30 11:30:58.000000000","message":"No, the response always contains these new fields, even if they were not set during listener creation. The Listener data model always has these new field. If they are not set explicitly in the request the default values will be used.","commit_id":"5bc677c4beb4a626ac906440b18221dd687cdad5"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"e0b85e837174fea166cd05dc9903a5847ecc6b93","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":950,"context_line":"                self.api_version, \u00272.12\u0027):"},{"line_number":951,"context_line":"            show_listener_response_fields.append(\u0027allowed_cidrs\u0027)"},{"line_number":952,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":953,"context_line":"                self.api_version, \u00272.17\u0027):"},{"line_number":954,"context_line":"            show_listener_response_fields.append(const.HSTS_PRELOAD)"},{"line_number":955,"context_line":"            show_listener_response_fields.append(const.HSTS_MAX_AGE)"},{"line_number":956,"context_line":"            show_listener_response_fields.append(const.HSTS_INCLUDE_SUBDOMAINS)"},{"line_number":957,"context_line":"        for field in show_listener_response_fields:"},{"line_number":958,"context_line":"            if field in (const.DEFAULT_POOL_ID, const.L7_POLICIES):"},{"line_number":959,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":18,"id":"80def8ec_11538736","line":956,"range":{"start_line":952,"start_character":8,"end_line":956,"end_character":79},"in_reply_to":"adc56688_7a09b277","updated":"2023-10-30 12:08:34.000000000","message":"That is done by functional tests here https://review.opendev.org/c/openstack/octavia/+/880806/38/octavia/tests/functional/api/v2/test_load_balancer.py","commit_id":"5bc677c4beb4a626ac906440b18221dd687cdad5"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2d661db7ed9d42fc3d9a4d8ccee3a1e3ef1e62ac","unresolved":true,"context_lines":[{"line_number":1370,"context_line":"        listener_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":1371,"context_line":"        hsts_supported \u003d self.mem_listener_client.is_version_supported("},{"line_number":1372,"context_line":"            self.api_version, \u00272.27\u0027) and protocol \u003d\u003d const.TERMINATED_HTTPS"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"        listener_kwargs \u003d {"},{"line_number":1375,"context_line":"            const.NAME: listener_name,"},{"line_number":1376,"context_line":"            const.DESCRIPTION: listener_description,"}],"source_content_type":"text/x-python","patch_set":32,"id":"e37e3fcd_08f298d0","line":1373,"updated":"2024-04-23 11:56:18.000000000","message":"maybe in listener_update, we could pass the default values for the hsts fields (None, False, False) in the POST and check that the default values are crrectly set in the response, wdyt?","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ea590dd1f80b3db7080042c7fa1af60a4da8dc2e","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"        listener_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":1371,"context_line":"        hsts_supported \u003d self.mem_listener_client.is_version_supported("},{"line_number":1372,"context_line":"            self.api_version, \u00272.27\u0027) and protocol \u003d\u003d const.TERMINATED_HTTPS"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"        listener_kwargs \u003d {"},{"line_number":1375,"context_line":"            const.NAME: listener_name,"},{"line_number":1376,"context_line":"            const.DESCRIPTION: listener_description,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9271bec4_2efd6ea3","line":1373,"in_reply_to":"c653ef53_34b7c98e","updated":"2024-04-23 16:57:48.000000000","message":"My comment above was wrong. Unset values in the update method will not change the values of course. I adjusted the code accordingly.","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f7b9f374b480eae57b2b02af6f50f5ce8cf53ae8","unresolved":true,"context_lines":[{"line_number":1370,"context_line":"        listener_description \u003d data_utils.arbitrary_string(size\u003d255)"},{"line_number":1371,"context_line":"        hsts_supported \u003d self.mem_listener_client.is_version_supported("},{"line_number":1372,"context_line":"            self.api_version, \u00272.27\u0027) and protocol \u003d\u003d const.TERMINATED_HTTPS"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"        listener_kwargs \u003d {"},{"line_number":1375,"context_line":"            const.NAME: listener_name,"},{"line_number":1376,"context_line":"            const.DESCRIPTION: listener_description,"}],"source_content_type":"text/x-python","patch_set":32,"id":"c653ef53_34b7c98e","line":1373,"in_reply_to":"e37e3fcd_08f298d0","updated":"2024-04-23 12:27:35.000000000","message":"I agree, we could adjust it to test the default. If we want to check for the correct default (ie. the value that is used if not set otherwise) in the response, we shouldn\u0027t have to set the attribute values in the POST.","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"}],"octavia_tempest_plugin/tests/barbican_scenario/v2/test_tls_barbican.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0d4535d724df6f296f765b13c5747ff48521edc2","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":53,"context_line":"            raise cls.skipException(\u0027Traffic tests will not work without \u0027"},{"line_number":54,"context_line":"                                    \u0027run_validation enabled.\u0027)"},{"line_number":55,"context_line":"        # if not getattr(CONF.service_available, \u0027barbican\u0027, False):"},{"line_number":56,"context_line":"        #     raise cls.skipException(\u0027TLS with Barbican tests require the \u0027"},{"line_number":57,"context_line":"        #                             \u0027barbican service.\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def _store_secret(cls, barbican_mgr, secret):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3387d5c_ebec2017","line":57,"range":{"start_line":55,"start_character":8,"end_line":57,"end_character":58},"updated":"2023-04-27 10:44:57.000000000","message":"FIXME undo","commit_id":"1d202d9977bf222cfdbc19a0e226680a575cc068"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"6869be04de9ad841c45007aeb867794652a8ccc9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":53,"context_line":"            raise cls.skipException(\u0027Traffic tests will not work without \u0027"},{"line_number":54,"context_line":"                                    \u0027run_validation enabled.\u0027)"},{"line_number":55,"context_line":"        # if not getattr(CONF.service_available, \u0027barbican\u0027, False):"},{"line_number":56,"context_line":"        #     raise cls.skipException(\u0027TLS with Barbican tests require the \u0027"},{"line_number":57,"context_line":"        #                             \u0027barbican service.\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def _store_secret(cls, barbican_mgr, secret):"}],"source_content_type":"text/x-python","patch_set":1,"id":"488e2cf8_f1080c8b","line":57,"range":{"start_line":55,"start_character":8,"end_line":57,"end_character":58},"in_reply_to":"b3387d5c_ebec2017","updated":"2023-05-04 16:26:45.000000000","message":"Done","commit_id":"1d202d9977bf222cfdbc19a0e226680a575cc068"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2d661db7ed9d42fc3d9a4d8ccee3a1e3ef1e62ac","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            const.DEFAULT_TLS_CONTAINER_REF: self.server_secret_ref,"},{"line_number":1239,"context_line":"            const.ALPN_PROTOCOLS: alpn_protos,"},{"line_number":1240,"context_line":"        }"},{"line_number":1241,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":1242,"context_line":"                self.api_version, \u00272.27\u0027):"},{"line_number":1243,"context_line":"            listener_kwargs[const.HSTS_MAX_AGE] \u003d 100 if hsts else None"},{"line_number":1244,"context_line":"            listener_kwargs[const.HSTS_INCLUDE_SUBDOMAINS] \u003d hsts"},{"line_number":1245,"context_line":"            listener_kwargs[const.HSTS_PRELOAD] \u003d hsts"}],"source_content_type":"text/x-python","patch_set":32,"id":"59ae32aa_c8168bad","line":1242,"range":{"start_line":1241,"start_character":11,"end_line":1242,"end_character":42},"updated":"2024-04-23 11:56:18.000000000","message":"why not\n\n```\nif hsts and self.mem_listener_client.is_version_supported(xx):\n```\n?","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f7b9f374b480eae57b2b02af6f50f5ce8cf53ae8","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            const.DEFAULT_TLS_CONTAINER_REF: self.server_secret_ref,"},{"line_number":1239,"context_line":"            const.ALPN_PROTOCOLS: alpn_protos,"},{"line_number":1240,"context_line":"        }"},{"line_number":1241,"context_line":"        if self.mem_listener_client.is_version_supported("},{"line_number":1242,"context_line":"                self.api_version, \u00272.27\u0027):"},{"line_number":1243,"context_line":"            listener_kwargs[const.HSTS_MAX_AGE] \u003d 100 if hsts else None"},{"line_number":1244,"context_line":"            listener_kwargs[const.HSTS_INCLUDE_SUBDOMAINS] \u003d hsts"},{"line_number":1245,"context_line":"            listener_kwargs[const.HSTS_PRELOAD] \u003d hsts"}],"source_content_type":"text/x-python","patch_set":32,"id":"0b5206eb_0bd3b4ff","line":1242,"range":{"start_line":1241,"start_character":11,"end_line":1242,"end_character":42},"in_reply_to":"59ae32aa_c8168bad","updated":"2024-04-23 12:27:35.000000000","message":"Because this way those attributes get set also in non-HSTS tests. The end result is the same, because these are the default values, but still I think it\u0027s okay to set it explicitly here, especially if we test the default as suggested in the discussion for the `update` test.","commit_id":"4d6c7caaafbd99ec28b488facbfe122b78a52c6a"}]}