)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2f3906719ece4ea39bf3db9623a9bd5fbd91a993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"406db246_329c1516","updated":"2023-08-29 17:33:31.000000000","message":"Looks like we would have to add the Barbican service to the failing u/s jobs if we would like them to pass, currently they fail as they don\u0027t have it.","commit_id":"5ba4f3b351ca40f119ebc7c79831136ec7da508d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"86f6c5d420bdfbe758e5d863b367a3f299a5f15e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6e78ee5_12dfdff0","updated":"2023-08-31 12:27:03.000000000","message":"Thanks Greg","commit_id":"651060e06f1d5e4020e677f6db71ec4de2e77302"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"837717d5cf43d4defaaf379ea8868ef1c7bd1343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2194f25d_9cd97109","updated":"2023-08-31 15:20:00.000000000","message":"The cert manager tries to validate the certificates even when it is running noop","commit_id":"651060e06f1d5e4020e677f6db71ec4de2e77302"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d70ad24aee71dfcc47109190cbc1f391a70d4d21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b69da35e_ab8bb9d9","updated":"2023-09-21 14:03:01.000000000","message":"Even though it failed after adding a \"Depends-On\" line, on my devstack the failed tests did pass. I am not sure what\u0027s going on.","commit_id":"e5d9f16ad1f6b2b2ddd06eac9b1fd14e32b79f05"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"6460a0ceb8e50cdf27ee82d184800cac275cc1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"80352e2c_2f101e02","updated":"2023-10-11 17:10:44.000000000","message":"I didn\u0027t fully review it yet.","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8e00f7b1b57ee078a25900b11d1d6a4acf4f3fc4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e12629d3_5b7c75d7","updated":"2023-10-14 20:27:17.000000000","message":"Note the failing neutron-ovn-provider test, their failure seems to be related to this new test and I guess it should be fixed.","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"d3ab2d58242fd45a7f969c483c720837434f1655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"53973e24_9a0ab3ba","in_reply_to":"e12629d3_5b7c75d7","updated":"2023-10-24 15:54:18.000000000","message":"Done","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"df07282baf874096d71431bf93780f82a3d75d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"423aa855_01b72822","updated":"2023-10-19 12:09:32.000000000","message":"Thanks Tom, I changed this patch according to your comments (partial) review, and I changed the Noop Cetificate Manager patch according to Michael\u0027s comments, so let\u0027s see if the check pipepline will pass here","commit_id":"602baffcc1305ce01c14db24f03bedb568b325e2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b34ca3f87b16797b750b852e0fb49b19ebdbefd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8f73d3b3_aaff8f08","updated":"2023-11-06 20:58:10.000000000","message":"I don\u0027t think we need to split out this noop config into another parameter.","commit_id":"7b43812a2c15c5a75d605aee8ec7ba4d20610d88"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d4f722545008a6c0fdc85fd1f46a929f5b2b39e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b3e1869d_f1f15cdf","updated":"2023-11-13 16:58:05.000000000","message":"Thanks Michael, I removed that extra config setting, let\u0027s see the CI results","commit_id":"bd42c13648a5a48748a48944e30ac7d53a0a821c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e72b5265973e49b4190d4b90bfec0d726e34bba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d7445c0e_55a2823b","updated":"2023-12-01 16:48:40.000000000","message":"recheck Noop Certificate Manager backports are merged in stable branches","commit_id":"bd42c13648a5a48748a48944e30ac7d53a0a821c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e023b4ed88936987b943b66b3fa08e465b8567c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b9f17f02_24a89c4e","updated":"2023-12-04 14:26:02.000000000","message":"recheck one-timer failure with greenlet on octavia-v2-dsvm-noop-api-keystone-default-roles","commit_id":"bd42c13648a5a48748a48944e30ac7d53a0a821c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b67aeb7bfad84af9598e9b5b50d7f3c9ee53e935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5295c80b_dddecf8b","updated":"2023-12-04 10:28:13.000000000","message":"recheck see if those member issues in stable/yoga reoccur","commit_id":"bd42c13648a5a48748a48944e30ac7d53a0a821c"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f3135e0bf894cb852eb180ddc7cb567c22f24e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8d021ade_f0d0a070","updated":"2024-01-08 13:28:18.000000000","message":"recheck get more data","commit_id":"88e78e9015f2e3a0f49dc4de2765bf41674b54ab"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"d2610b6c2556b798826b179825f481f1b5a11359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"d9776100_b3cb1dcc","updated":"2024-02-06 06:54:47.000000000","message":"recheck looks like know issue","commit_id":"fa820adf265486e33c42d0f53d0e36ec15883610"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"46aabf4ad0d366f3a0658decdf23642fc09235df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f293164f_28f8d56a","updated":"2024-02-07 08:16:08.000000000","message":"recheck \"ImportError: cannot import name \u0027security_groups_rules_belongs_to_default_sg\u0027 from \u0027neutron_lib.api.definitions\u0027\" not related to octavia","commit_id":"664ada9bdbc134b57d6882e4548425b27efe2bd8"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"c4c84d6cb7d65844aff56a34f914ad5affce6d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"42486e36_98287557","updated":"2024-02-12 12:01:51.000000000","message":"recheck yoga job has been replaced","commit_id":"664ada9bdbc134b57d6882e4548425b27efe2bd8"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"af1a041dad8857659dd317d6c22c2e61608313e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"acda98b0_8a50d970","updated":"2024-03-26 14:01:13.000000000","message":"recheck get new data","commit_id":"c32683be6793df8b7488bc1102a5e247d1dd73df"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3e7c8820875fe2e7df645790f3898bdda1267004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"386aa4de_45b74277","updated":"2024-04-15 10:49:25.000000000","message":"Except for the tests names, looks good to me. Thanks for all the help with this patch!","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ce6bd7e395cca1f3da84965c9469088d824869e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"e209465f_9c107731","updated":"2024-04-15 10:55:57.000000000","message":"Thanks","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"77fc76020e724a80f77698292908fc555bfb3a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"222426b3_c01914ca","updated":"2024-04-15 11:14:21.000000000","message":"Looks good to me","commit_id":"5bb75afc3ff8a84e9cbe95d763501683c8d0a923"}],"octavia_tempest_plugin/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b34ca3f87b16797b750b852e0fb49b19ebdbefd3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d\u0027Runs the tests assuming no-op drivers are being used. \u0027"},{"line_number":77,"context_line":"                     \u0027Tests will assume no actual amphora are created.\u0027),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027test_with_cert_noop\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Runs the tests assuming no-op certificate manager is\u0027"},{"line_number":81,"context_line":"                     \u0027 being used. Tests won\\\u0027t validate certificates.\u0027),"}],"source_content_type":"text/x-python","patch_set":15,"id":"704a2cff_5c1e95b8","line":78,"updated":"2023-11-06 20:58:10.000000000","message":"Why does this need to be a separate config setting? It seems like it should be bundled in with \"test_with_noop\".","commit_id":"515f76190b64ead5e2a100a27a752ebb5d29654b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d4f722545008a6c0fdc85fd1f46a929f5b2b39e4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d\u0027Runs the tests assuming no-op drivers are being used. \u0027"},{"line_number":77,"context_line":"                     \u0027Tests will assume no actual amphora are created.\u0027),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027test_with_cert_noop\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Runs the tests assuming no-op certificate manager is\u0027"},{"line_number":81,"context_line":"                     \u0027 being used. Tests won\\\u0027t validate certificates.\u0027),"}],"source_content_type":"text/x-python","patch_set":15,"id":"19202810_2c8eae3e","line":78,"in_reply_to":"704a2cff_5c1e95b8","updated":"2023-11-13 16:58:05.000000000","message":"Done","commit_id":"515f76190b64ead5e2a100a27a752ebb5d29654b"}],"octavia_tempest_plugin/tests/api/v2/test_listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e8d5108846ca3875e6b681bb1935a1afe7f9ad1f","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def terminated_https_apply(cls, protocol\u003dNone):"},{"line_number":141,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":142,"context_line":"            return False"},{"line_number":143,"context_line":"        return CONF.load_balancer.test_with_noop or ("},{"line_number":144,"context_line":"            not CONF.load_balancer.test_with_noop and"},{"line_number":145,"context_line":"            getattr(CONF.service_available, \u0027barbican\u0027, False))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def resource_setup(cls):"},{"line_number":149,"context_line":"        \"\"\"Setup resources needed by the tests.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"f71380e2_6d2b9fc4","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":0},"updated":"2023-08-31 10:39:22.000000000","message":"this expression can be simplified.\nit \u0027s the same as:\n```\n  return (CONF.load_balancer.test_with_noop or\n          getattr(CONF.service_available, \u0027barbican\u0027, False))\n```","commit_id":"0660229fa26b10888b44182ea57a183e3cc711f7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"86f6c5d420bdfbe758e5d863b367a3f299a5f15e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def terminated_https_apply(cls, protocol\u003dNone):"},{"line_number":141,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":142,"context_line":"            return False"},{"line_number":143,"context_line":"        return CONF.load_balancer.test_with_noop or ("},{"line_number":144,"context_line":"            not CONF.load_balancer.test_with_noop and"},{"line_number":145,"context_line":"            getattr(CONF.service_available, \u0027barbican\u0027, False))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @classmethod"},{"line_number":148,"context_line":"    def resource_setup(cls):"},{"line_number":149,"context_line":"        \"\"\"Setup resources needed by the tests.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"20badd21_1d344cbc","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":0},"in_reply_to":"f71380e2_6d2b9fc4","updated":"2023-08-31 12:27:03.000000000","message":"Done","commit_id":"0660229fa26b10888b44182ea57a183e3cc711f7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e8d5108846ca3875e6b681bb1935a1afe7f9ad1f","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        \"\"\"Setup resources needed by the tests.\"\"\""},{"line_number":150,"context_line":"        super(ListenerAPITest, cls).resource_setup()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if cls.terminated_https_apply():"},{"line_number":153,"context_line":"            # Create a CA self-signed cert and key"},{"line_number":154,"context_line":"            cls.ca_cert, ca_key \u003d cert_utils.generate_ca_cert_and_key()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"51a45fe1_80cbdd3b","line":152,"range":{"start_line":152,"start_character":15,"end_line":152,"end_character":37},"updated":"2023-08-31 10:39:22.000000000","message":"we need real certificates only if barbican is used.\nin case of noop, we can generate random IDs to simulate barbican refs","commit_id":"0660229fa26b10888b44182ea57a183e3cc711f7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"86f6c5d420bdfbe758e5d863b367a3f299a5f15e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\"Setup resources needed by the tests.\"\"\""},{"line_number":150,"context_line":"        super(ListenerAPITest, cls).resource_setup()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if cls.terminated_https_apply():"},{"line_number":153,"context_line":"            # Create a CA self-signed cert and key"},{"line_number":154,"context_line":"            cls.ca_cert, ca_key \u003d cert_utils.generate_ca_cert_and_key()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fb2b4d4e_55d06b20","line":152,"range":{"start_line":152,"start_character":15,"end_line":152,"end_character":37},"in_reply_to":"51a45fe1_80cbdd3b","updated":"2023-08-31 12:27:03.000000000","message":"Done","commit_id":"0660229fa26b10888b44182ea57a183e3cc711f7"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"6460a0ceb8e50cdf27ee82d184800cac275cc1a1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            msg \u003d \u0027Only one user named \"{0}\" should exist, {1} found.\u0027.format("},{"line_number":62,"context_line":"                CONF.load_balancer.octavia_svc_username,"},{"line_number":63,"context_line":"                len(user_list[\u0027users\u0027]))"},{"line_number":64,"context_line":"            assert 1 \u003d\u003d len(user_list[\u0027users\u0027]), msg"},{"line_number":65,"context_line":"            barbican_mgr.add_acl(new_secret_ref, user_list[\u0027users\u0027][0][\u0027id\u0027])"},{"line_number":66,"context_line":"        return new_secret_ref"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"408d948a_3610ddbc","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":52},"updated":"2023-10-11 17:10:44.000000000","message":"I assume you need to use `assert` because this is a classmethod? Personally, I would always use raw `assert`s. I don\u0027t understand how `self.assertEqual(1, len(user_list[\u0027users\u0027]), msg)` is any better than this. That\u0027s just my two cents.","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d4f722545008a6c0fdc85fd1f46a929f5b2b39e4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            msg \u003d \u0027Only one user named \"{0}\" should exist, {1} found.\u0027.format("},{"line_number":62,"context_line":"                CONF.load_balancer.octavia_svc_username,"},{"line_number":63,"context_line":"                len(user_list[\u0027users\u0027]))"},{"line_number":64,"context_line":"            assert 1 \u003d\u003d len(user_list[\u0027users\u0027]), msg"},{"line_number":65,"context_line":"            barbican_mgr.add_acl(new_secret_ref, user_list[\u0027users\u0027][0][\u0027id\u0027])"},{"line_number":66,"context_line":"        return new_secret_ref"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f8dddf48_a6546e32","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":52},"in_reply_to":"2e2180c3_0aa02645","updated":"2023-11-13 16:58:05.000000000","message":"Done","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"df07282baf874096d71431bf93780f82a3d75d1d","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            msg \u003d \u0027Only one user named \"{0}\" should exist, {1} found.\u0027.format("},{"line_number":62,"context_line":"                CONF.load_balancer.octavia_svc_username,"},{"line_number":63,"context_line":"                len(user_list[\u0027users\u0027]))"},{"line_number":64,"context_line":"            assert 1 \u003d\u003d len(user_list[\u0027users\u0027]), msg"},{"line_number":65,"context_line":"            barbican_mgr.add_acl(new_secret_ref, user_list[\u0027users\u0027][0][\u0027id\u0027])"},{"line_number":66,"context_line":"        return new_secret_ref"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a087ac7_6ba097ce","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":52},"in_reply_to":"408d948a_3610ddbc","updated":"2023-10-19 12:09:32.000000000","message":"I copied it from octavia-tempest-plugin, but I guess that as you mentioned, raw assert was probably used because it is a class method.","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b34ca3f87b16797b750b852e0fb49b19ebdbefd3","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            msg \u003d \u0027Only one user named \"{0}\" should exist, {1} found.\u0027.format("},{"line_number":62,"context_line":"                CONF.load_balancer.octavia_svc_username,"},{"line_number":63,"context_line":"                len(user_list[\u0027users\u0027]))"},{"line_number":64,"context_line":"            assert 1 \u003d\u003d len(user_list[\u0027users\u0027]), msg"},{"line_number":65,"context_line":"            barbican_mgr.add_acl(new_secret_ref, user_list[\u0027users\u0027][0][\u0027id\u0027])"},{"line_number":66,"context_line":"        return new_secret_ref"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2e2180c3_0aa02645","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":52},"in_reply_to":"7a087ac7_6ba097ce","updated":"2023-11-06 20:58:10.000000000","message":"Using raw assert means the test runner cannot collect the test results. They should be avoided and it is probably bug if they are used elsewhere in the tests.\nhttps://docs.python.org/3/library/unittest.html#basic-example","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"6460a0ceb8e50cdf27ee82d184800cac275cc1a1","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            cls.member_crl.public_bytes(serialization.Encoding.PEM))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def terminated_https_apply(cls, protocol\u003dNone):"},{"line_number":141,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":142,"context_line":"            return False"},{"line_number":143,"context_line":"        test_with_noop \u003d (CONF.load_balancer.test_with_noop and"}],"source_content_type":"text/x-python","patch_set":10,"id":"6cd7fea5_ef64d050","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":30},"updated":"2023-10-11 17:10:44.000000000","message":"It\u0027s only a style kind of thing, but I would put the verb first in the name, and since it returns a bool I\u0027d probably call it `should_apply_terminated_https` or `can_apply_terminated_https` something like that.","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"df07282baf874096d71431bf93780f82a3d75d1d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            cls.member_crl.public_bytes(serialization.Encoding.PEM))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def terminated_https_apply(cls, protocol\u003dNone):"},{"line_number":141,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":142,"context_line":"            return False"},{"line_number":143,"context_line":"        test_with_noop \u003d (CONF.load_balancer.test_with_noop and"}],"source_content_type":"text/x-python","patch_set":10,"id":"5bd88407_06ba7f30","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":30},"in_reply_to":"6cd7fea5_ef64d050","updated":"2023-10-19 12:09:32.000000000","message":"Done","commit_id":"2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b34ca3f87b16797b750b852e0fb49b19ebdbefd3","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    def should_apply_terminated_https(cls, protocol\u003dNone):"},{"line_number":126,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":127,"context_line":"            return False"},{"line_number":128,"context_line":"        test_with_noop \u003d (CONF.load_balancer.test_with_noop and"},{"line_number":129,"context_line":"                          CONF.load_balancer.test_with_cert_noop)"},{"line_number":130,"context_line":"        return (test_with_noop or"},{"line_number":131,"context_line":"                getattr(CONF.service_available, \u0027barbican\u0027, False))"}],"source_content_type":"text/x-python","patch_set":15,"id":"d3f41811_38ace72f","line":128,"updated":"2023-11-06 20:58:10.000000000","message":"This is another hint that maybe we don\u0027t need to split out the cert_noop option.","commit_id":"515f76190b64ead5e2a100a27a752ebb5d29654b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d4f722545008a6c0fdc85fd1f46a929f5b2b39e4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def should_apply_terminated_https(cls, protocol\u003dNone):"},{"line_number":126,"context_line":"        if protocol and protocol !\u003d const.TERMINATED_HTTPS:"},{"line_number":127,"context_line":"            return False"},{"line_number":128,"context_line":"        test_with_noop \u003d (CONF.load_balancer.test_with_noop and"},{"line_number":129,"context_line":"                          CONF.load_balancer.test_with_cert_noop)"},{"line_number":130,"context_line":"        return (test_with_noop or"},{"line_number":131,"context_line":"                getattr(CONF.service_available, \u0027barbican\u0027, False))"}],"source_content_type":"text/x-python","patch_set":15,"id":"6457dfc3_153d575e","line":128,"in_reply_to":"d3f41811_38ace72f","updated":"2023-11-13 16:58:05.000000000","message":"Done","commit_id":"515f76190b64ead5e2a100a27a752ebb5d29654b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3e7c8820875fe2e7df645790f3898bdda1267004","unresolved":true,"context_lines":[{"line_number":473,"context_line":"        CONF.loadbalancer_feature_enabled.terminated_tls_enabled,"},{"line_number":474,"context_line":"        \u0027[loadbalancer-feature-enabled] \"terminated_tls_enabled\" is \u0027"},{"line_number":475,"context_line":"        \u0027False in the tempest configuration. TLS tests will be skipped.\u0027)"},{"line_number":476,"context_line":"    def test_http_udp_terminated_https_listener_create_on_same_port(self):"},{"line_number":477,"context_line":"        if not self.should_apply_terminated_https():"},{"line_number":478,"context_line":"            raise self.skipException("},{"line_number":479,"context_line":"                f\u0027Listener API tests with {const.TERMINATED_HTTPS} protocol\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"8cbdd55c_d205d2fc","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":67},"updated":"2024-04-15 10:49:25.000000000","message":"nit: the test name should have sctp protocol","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ce6bd7e395cca1f3da84965c9469088d824869e9","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        CONF.loadbalancer_feature_enabled.terminated_tls_enabled,"},{"line_number":474,"context_line":"        \u0027[loadbalancer-feature-enabled] \"terminated_tls_enabled\" is \u0027"},{"line_number":475,"context_line":"        \u0027False in the tempest configuration. TLS tests will be skipped.\u0027)"},{"line_number":476,"context_line":"    def test_http_udp_terminated_https_listener_create_on_same_port(self):"},{"line_number":477,"context_line":"        if not self.should_apply_terminated_https():"},{"line_number":478,"context_line":"            raise self.skipException("},{"line_number":479,"context_line":"                f\u0027Listener API tests with {const.TERMINATED_HTTPS} protocol\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"c58a0a3f_d9a7d79d","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":67},"in_reply_to":"8cbdd55c_d205d2fc","updated":"2024-04-15 10:55:57.000000000","message":"Acknowledged","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3e7c8820875fe2e7df645790f3898bdda1267004","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        CONF.loadbalancer_feature_enabled.terminated_tls_enabled,"},{"line_number":488,"context_line":"        \u0027[loadbalancer-feature-enabled] \"terminated_tls_enabled\" is \u0027"},{"line_number":489,"context_line":"        \u0027False in the tempest configuration. TLS tests will be skipped.\u0027)"},{"line_number":490,"context_line":"    def test_tcp_udp_terminated_https_listener_create_on_same_port(self):"},{"line_number":491,"context_line":"        if not self.should_apply_terminated_https():"},{"line_number":492,"context_line":"            raise self.skipException("},{"line_number":493,"context_line":"                f\u0027Listener API tests with {const.TERMINATED_HTTPS} protocol\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"c678ffff_0288ae00","line":490,"range":{"start_line":490,"start_character":8,"end_line":490,"end_character":66},"updated":"2024-04-15 10:49:25.000000000","message":"nit: the test name should have sctp protocol","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ce6bd7e395cca1f3da84965c9469088d824869e9","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        CONF.loadbalancer_feature_enabled.terminated_tls_enabled,"},{"line_number":488,"context_line":"        \u0027[loadbalancer-feature-enabled] \"terminated_tls_enabled\" is \u0027"},{"line_number":489,"context_line":"        \u0027False in the tempest configuration. TLS tests will be skipped.\u0027)"},{"line_number":490,"context_line":"    def test_tcp_udp_terminated_https_listener_create_on_same_port(self):"},{"line_number":491,"context_line":"        if not self.should_apply_terminated_https():"},{"line_number":492,"context_line":"            raise self.skipException("},{"line_number":493,"context_line":"                f\u0027Listener API tests with {const.TERMINATED_HTTPS} protocol\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"61469dae_88c79db6","line":490,"range":{"start_line":490,"start_character":8,"end_line":490,"end_character":66},"in_reply_to":"c678ffff_0288ae00","updated":"2024-04-15 10:55:57.000000000","message":"Acknowledged","commit_id":"17c3652647f20fd41519fccc9e35dcab18e1c569"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b34ca3f87b16797b750b852e0fb49b19ebdbefd3","unresolved":true,"context_lines":[{"line_number":484,"context_line":"              amphora_driver: amphora_noop_driver"},{"line_number":485,"context_line":"              compute_driver: compute_noop_driver"},{"line_number":486,"context_line":"              network_driver: network_noop_driver"},{"line_number":487,"context_line":"              image_driver: image_noop_driver"},{"line_number":488,"context_line":"            certificates:"},{"line_number":489,"context_line":"              cert_manager: local_cert_manager"},{"line_number":490,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"383e6824_447c2f38","line":487,"updated":"2023-11-06 20:58:10.000000000","message":"I think cert_manager should be set to noop here. Then the rest of these changes are not necessary.","commit_id":"7b43812a2c15c5a75d605aee8ec7ba4d20610d88"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d4f722545008a6c0fdc85fd1f46a929f5b2b39e4","unresolved":false,"context_lines":[{"line_number":484,"context_line":"              amphora_driver: amphora_noop_driver"},{"line_number":485,"context_line":"              compute_driver: compute_noop_driver"},{"line_number":486,"context_line":"              network_driver: network_noop_driver"},{"line_number":487,"context_line":"              image_driver: image_noop_driver"},{"line_number":488,"context_line":"            certificates:"},{"line_number":489,"context_line":"              cert_manager: local_cert_manager"},{"line_number":490,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bcfa1c4c_41a63507","line":487,"in_reply_to":"383e6824_447c2f38","updated":"2023-11-13 16:58:05.000000000","message":"Done","commit_id":"7b43812a2c15c5a75d605aee8ec7ba4d20610d88"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7d7d45bd97fa3c01f1ca3c5d91a822a530713a9f","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        post-config:"},{"line_number":845,"context_line":"          $OCTAVIA_CONF:"},{"line_number":846,"context_line":"            certificates:"},{"line_number":847,"context_line":"              cert_manager: noop_cert_manager"},{"line_number":848,"context_line":"      devstack_services:"},{"line_number":849,"context_line":"        barbican: true"},{"line_number":850,"context_line":"      devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"df0afd44_3f1034c5","line":847,"range":{"start_line":847,"start_character":28,"end_line":847,"end_character":45},"updated":"2024-04-10 15:10:55.000000000","message":"I think this is not correct, noop should be used only for API tests","commit_id":"c32683be6793df8b7488bc1102a5e247d1dd73df"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"89c5cb1b09b3df2fe4bb0c9e2c6a558afc09660f","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        post-config:"},{"line_number":845,"context_line":"          $OCTAVIA_CONF:"},{"line_number":846,"context_line":"            certificates:"},{"line_number":847,"context_line":"              cert_manager: noop_cert_manager"},{"line_number":848,"context_line":"      devstack_services:"},{"line_number":849,"context_line":"        barbican: true"},{"line_number":850,"context_line":"      devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"776e4245_7ab660d6","line":847,"range":{"start_line":847,"start_character":28,"end_line":847,"end_character":45},"in_reply_to":"df0afd44_3f1034c5","updated":"2024-04-15 11:03:14.000000000","message":"Done","commit_id":"c32683be6793df8b7488bc1102a5e247d1dd73df"}]}