)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4aa496de50cb95b4c9b83cd8388990eef9f9907c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2255b7b_8b7d7d05","updated":"2024-05-30 00:52:26.000000000","message":"We need a release note for this as now a configuration setting will be ignored.","commit_id":"4bc6c489d256297f3c9682c867c2c430bebd6a0c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6dbfcd9a30893c4edb42f979126a3b36f4c91763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1303c48_a1375198","updated":"2024-05-29 17:43:07.000000000","message":"recheck TIMEOUT","commit_id":"4bc6c489d256297f3c9682c867c2c430bebd6a0c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"85c6efe340d2926bf38f06acb2ed3f34c567bdaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48a14325_7d3d311d","updated":"2024-05-30 17:07:43.000000000","message":"I am not a huge fan of removing the configuration settings for this test setting, but I understand you want to focus on the keystone default roles.","commit_id":"cba3b22f636e02fc07a91317149daf58aa651f28"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0d0e3222a7b9d19803059a2f44f3b0f724e1fbb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64ac8a09_0353512a","updated":"2024-05-30 12:42:02.000000000","message":"Looks good to me","commit_id":"cba3b22f636e02fc07a91317149daf58aa651f28"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a5ba4b9016881cc87b3f337f8a47a65e6793c937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a36fc3fc_235ac8de","updated":"2024-05-30 20:27:51.000000000","message":"recheck TIMED_OUT","commit_id":"cba3b22f636e02fc07a91317149daf58aa651f28"}],"octavia_tempest_plugin/tests/test_base.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"281be3f0a1bcba5898afd7b63dd9105c036d028b","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            non_dyn_users.append(\u0027not_member\u0027)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Tests shall not mess with the list of allocated credentials"},{"line_number":196,"context_line":"        cls.allocated_credentials \u003d tuple(cls.allocated_creds)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if not CONF.load_balancer.log_user_roles:"},{"line_number":199,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"106d078c_d590e408","line":196,"updated":"2024-05-29 13:36:53.000000000","message":"Class variables should be pre-defined in the class definition (like it was done before). You could set it to an empty tuple as a default (and annotate it so it can be type-checked).","commit_id":"4c7b6b388947fe0b8de5be7f9df6a28f23fc4f73"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8cf3dcda70c980f82eb98507c4bdfc7c269d1780","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            non_dyn_users.append(\u0027not_member\u0027)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Tests shall not mess with the list of allocated credentials"},{"line_number":196,"context_line":"        cls.allocated_credentials \u003d tuple(cls.allocated_creds)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if not CONF.load_balancer.log_user_roles:"},{"line_number":199,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"94b6af84_9f84f534","line":196,"in_reply_to":"106d078c_d590e408","updated":"2024-05-29 13:41:20.000000000","message":"Done","commit_id":"4c7b6b388947fe0b8de5be7f9df6a28f23fc4f73"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4aa496de50cb95b4c9b83cd8388990eef9f9907c","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    elif CONF.load_balancer.RBAC_test_type \u003d\u003d const.KEYSTONE_DEFAULT_ROLES:"},{"line_number":63,"context_line":"        credentials \u003d ["},{"line_number":64,"context_line":"            \u0027admin\u0027, \u0027primary\u0027,"},{"line_number":65,"context_line":"            [\u0027lb_admin\u0027, \u0027admin\u0027],"},{"line_number":66,"context_line":"            [\u0027lb_observer\u0027, \u0027reader\u0027],"},{"line_number":67,"context_line":"            [\u0027lb_global_observer\u0027, \u0027reader\u0027],"},{"line_number":68,"context_line":"            [\u0027lb_member\u0027, \u0027member\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"68d83c17_562c3fbc","line":65,"updated":"2024-05-30 00:52:26.000000000","message":"We need a release note that calls out, when using RBAC_test_type \u003d\u003d KEYSTONE_DEFAULT_ROLES the configuration settings for custom roles will now be ignored. This is a big change to the functionality of the Octavia tempest tests.","commit_id":"4bc6c489d256297f3c9682c867c2c430bebd6a0c"}]}