)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2cfa570fff48adf3c5c3613f178e90861efe614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36007415_33978dfd","updated":"2024-08-22 22:18:56.000000000","message":"This does not look right, almost all of this patch is changing the Advanced RBAC rules to match the Keystone default roles configuration for the tempest plugin. If those are in fact the same after this switch, we should remove the Keystone default roles conditional from the configuration of the tempest plugin.","commit_id":"d4352b26a93c3fe939e4dcd4b5bdbd33110bc967"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"765d53f2838cfe076c167bc7b4093160f3d77785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84e3852c_0cf5ac23","in_reply_to":"36007415_33978dfd","updated":"2024-08-23 04:49:54.000000000","message":"yeah, you are right. those are same now. let me confirm again for all tests and remove the \u0027Keystone default roles\u0027 checks","commit_id":"d4352b26a93c3fe939e4dcd4b5bdbd33110bc967"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7a2fb199c10fc955035e28914d4be9772684ee8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"171a52d1_7cbb0023","updated":"2024-10-28 23:50:22.000000000","message":"This still needs some test job work to switch the defaults around.","commit_id":"d02dc426bcc0a73506ccbd33be1e4166b1cbc13c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3d450982b00cec41148367c25e8e58f5d88f0e00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"211acf36_dfacc284","updated":"2024-11-07 04:05:16.000000000","message":"recheck\ntempest fix for the docs job merged","commit_id":"313d6da2cbf71c204a6f54654df380b2d953a86e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"058e5964954c9c26256a54a95f29d3513fcdb562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5005a466_1c5b27e3","updated":"2025-02-13 16:46:24.000000000","message":"LGTM","commit_id":"5f36fabd794f7bdce2eadbd6563255c0dded17b3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4e134f1903116000f3deed6e0232c73011b1cfdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2dfda88c_f2bb0a92","updated":"2025-02-13 16:45:27.000000000","message":"recheck testing again","commit_id":"5f36fabd794f7bdce2eadbd6563255c0dded17b3"}],"octavia_tempest_plugin/config.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"bcc83cb47f8d47789a689b7fe449322ccbe9d28a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    cfg.StrOpt(\u0027provider\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027octavia\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027The provider driver to use for the tests.\u0027),"},{"line_number":108,"context_line":"    cfg.StrOpt(\u0027RBAC_test_type\u0027, default\u003dconst.KEYSTONE_DEFAULT_ROLES,"},{"line_number":109,"context_line":"               choices\u003d[const.ADVANCED, const.KEYSTONE_DEFAULT_ROLES,"},{"line_number":110,"context_line":"                        const.OWNERADMIN, const.NONE],"},{"line_number":111,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"d2d4b17e_5f62ed0a","line":108,"range":{"start_line":108,"start_character":47,"end_line":108,"end_character":69},"updated":"2024-11-05 10:52:48.000000000","message":"I think it requires a release note, especially for users on stable branches with tempest master.","commit_id":"439e2505ecccb3f48e21e87e290f81e77f297662"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"bcc83cb47f8d47789a689b7fe449322ccbe9d28a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    cfg.StrOpt(\u0027provider\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027octavia\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027The provider driver to use for the tests.\u0027),"},{"line_number":108,"context_line":"    cfg.StrOpt(\u0027RBAC_test_type\u0027, default\u003dconst.KEYSTONE_DEFAULT_ROLES,"},{"line_number":109,"context_line":"               choices\u003d[const.ADVANCED, const.KEYSTONE_DEFAULT_ROLES,"},{"line_number":110,"context_line":"                        const.OWNERADMIN, const.NONE],"},{"line_number":111,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"988687f5_297c7f63","line":108,"range":{"start_line":108,"start_character":47,"end_line":108,"end_character":69},"updated":"2024-11-05 10:52:48.000000000","message":"it sets KEYSTONE_DEFAULT_ROLES on stable branches. But the stable branches are still deployed with the Advanced RBAC\nShould we set RBAC_test_type\u003dadvanced in jobs.yaml for the stable branches (\u003c\u003d D)?","commit_id":"439e2505ecccb3f48e21e87e290f81e77f297662"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8a0dc36ccabd185db6a0c5007c0ffcdaf4f2dba5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.StrOpt(\u0027provider\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027octavia\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027The provider driver to use for the tests.\u0027),"},{"line_number":108,"context_line":"    cfg.StrOpt(\u0027RBAC_test_type\u0027, default\u003dconst.KEYSTONE_DEFAULT_ROLES,"},{"line_number":109,"context_line":"               choices\u003d[const.ADVANCED, const.KEYSTONE_DEFAULT_ROLES,"},{"line_number":110,"context_line":"                        const.OWNERADMIN, const.NONE],"},{"line_number":111,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"e68a0742_9eb8e156","line":108,"range":{"start_line":108,"start_character":47,"end_line":108,"end_character":69},"in_reply_to":"988687f5_297c7f63","updated":"2024-11-08 01:49:11.000000000","message":"Done","commit_id":"439e2505ecccb3f48e21e87e290f81e77f297662"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8a0dc36ccabd185db6a0c5007c0ffcdaf4f2dba5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.StrOpt(\u0027provider\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027octavia\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027The provider driver to use for the tests.\u0027),"},{"line_number":108,"context_line":"    cfg.StrOpt(\u0027RBAC_test_type\u0027, default\u003dconst.KEYSTONE_DEFAULT_ROLES,"},{"line_number":109,"context_line":"               choices\u003d[const.ADVANCED, const.KEYSTONE_DEFAULT_ROLES,"},{"line_number":110,"context_line":"                        const.OWNERADMIN, const.NONE],"},{"line_number":111,"context_line":"               help\u003d\u0027Type of RBAC tests to run. \"advanced\" runs the octavia \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"18119535_57c505fb","line":108,"range":{"start_line":108,"start_character":47,"end_line":108,"end_character":69},"in_reply_to":"d2d4b17e_5f62ed0a","updated":"2024-11-08 01:49:11.000000000","message":"Done","commit_id":"439e2505ecccb3f48e21e87e290f81e77f297662"}]}