)]}'
{"bin/octavia-api.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f71ad039b352fd789c48befef17e5d9a794609d3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    app \u003d api_app.setup_app()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    host, port \u003d cfg.CONF.bind_host, cfg.CONF.bind_port"},{"line_number":35,"context_line":"    LOG.info(u._LI(\"Starting API server on %(host)s:%(port)s\") %"},{"line_number":36,"context_line":"             {\"host\": host, \"port\": port})"},{"line_number":37,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_2f1725a5","line":35,"updated":"2014-12-06 20:20:12.000000000","message":"Are we deciding as a project to use a different standard for _LX than the rest of openstack, which import this bare?","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f06389d7e8d2da173d9b3cb72aba88afb3f85053","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    app \u003d api_app.setup_app()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    host, port \u003d cfg.CONF.bind_host, cfg.CONF.bind_port"},{"line_number":35,"context_line":"    LOG.info(u._LI(\"Starting API server on %(host)s:%(port)s\") %"},{"line_number":36,"context_line":"             {\"host\": host, \"port\": port})"},{"line_number":37,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_3c743667","line":35,"in_reply_to":"3a961159_2f1725a5","updated":"2014-12-11 04:26:27.000000000","message":"we should do whatever the rest of openstack does, but ive seen barbican do it this way and others do it another way.  I\u0027m not sure if there is a standard, if it is can you point to some kind of doc?","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"32ff962d928faf371a30b144b6af6212f4fdaa1d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    app \u003d api_app.setup_app()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    host, port \u003d cfg.CONF.bind_host, cfg.CONF.bind_port"},{"line_number":35,"context_line":"    LOG.info(u._LI(\"Starting API server on %(host)s:%(port)s\") %"},{"line_number":36,"context_line":"             {\"host\": host, \"port\": port})"},{"line_number":37,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_92efd1e8","line":35,"in_reply_to":"3a961159_3c743667","updated":"2014-12-11 06:48:51.000000000","message":"I guess that I use nova and neutron to define \"the rest of openstack\", and both use them bare.  Of course, I think they\u0027re stupid in general, since whatever they\u0027re doing could be plumbed into LOG.info directly.  That said, we could ping in the oslo channel tomorrow and see if there\u0027s a standard?","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}],"octavia/api/config.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f71ad039b352fd789c48befef17e5d9a794609d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# WSME Configurations"},{"line_number":24,"context_line":"# See https://wsme.readthedocs.org/en/latest/integrate.html#configuration"},{"line_number":25,"context_line":"wsme \u003d {"},{"line_number":26,"context_line":"    \u0027debug\u0027: True"},{"line_number":27,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_cf1f81b6","line":26,"updated":"2014-12-06 20:20:12.000000000","message":"This looks odd enough in committed code that it\u0027s worth a short note.  \"# Yes, debug true is correct, we want to see tracebacks\".","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f06389d7e8d2da173d9b3cb72aba88afb3f85053","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# WSME Configurations"},{"line_number":24,"context_line":"# See https://wsme.readthedocs.org/en/latest/integrate.html#configuration"},{"line_number":25,"context_line":"wsme \u003d {"},{"line_number":26,"context_line":"    \u0027debug\u0027: True"},{"line_number":27,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_7c6a3e82","line":26,"in_reply_to":"3a961159_cf1f81b6","updated":"2014-12-11 04:26:27.000000000","message":"can do, next ps","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}],"octavia/api/exc.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"609d471c91a5b7985a0e6b7eab9ba859a902082a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from wsme import exc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_99fc2474","line":14,"updated":"2014-09-28 07:43:07.000000000","message":"I need to remove this file.","commit_id":"23470d09609ae3dad2b53c245943d5c89157fdfa"}],"octavia/api/root_controller.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"39ab48ab9568400e418e82e64056c6471fdd48f7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class RootController(rest.RestController):"},{"line_number":21,"context_line":"    \"\"\"The controller in which the pecan wsgi app should be created with.\"\"\""},{"line_number":22,"context_line":"    v1 \u003d controllers.V1Controller()"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_fe31e90b","line":22,"updated":"2014-11-21 00:52:59.000000000","message":"doing a curl on the root returns a version string in libra, e.g \"{\"versions\": [{\"status\": \"DEPRECATED\", \"updated\": \"2014-01-13T16:55:25Z\", \"id\": \"v1\"}, {\"status\": \"CURRENT\", \"updated\": \"2014-01-13T16:55:25Z\", \"id\": \"v2.0\"}]}\"\n\nNot sure where we return the supported versions.","commit_id":"ea5229de6a9516522a70cfb91e97b743d9bced41"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e62a1d71d9a82e6d441bda4cb6b50d864e44ad07","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class RootController(rest.RestController):"},{"line_number":21,"context_line":"    \"\"\"The controller in which the pecan wsgi app should be created with.\"\"\""},{"line_number":22,"context_line":"    v1 \u003d controllers.V1Controller()"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_125daa79","line":22,"in_reply_to":"5a890539_fe31e90b","updated":"2014-11-21 21:12:24.000000000","message":"This would be the class to do so, that can definitely be something put in","commit_id":"ea5229de6a9516522a70cfb91e97b743d9bced41"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5c4bb7d66a74e29a6298a393c3ef398c5b0c60d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class RootController(rest.RestController):"},{"line_number":21,"context_line":"    \"\"\"The controller in which the pecan wsgi app should be created with.\"\"\""},{"line_number":22,"context_line":"    v1 \u003d controllers.V1Controller()"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_292f8189","line":22,"updated":"2014-12-11 17:10:09.000000000","message":"from a previous (unadressed) comment: doing a curl on the root returns a version string in libra, e.g \"{\"versions\": [{\"status\": \"DEPRECATED\", \"updated\": \"2014-01-13T16:55:25Z\", \"id\": \"v1\"}, {\"status\": \"CURRENT\", \"updated\": \"2014-01-13T16:55:25Z\", \"id\": \"v2.0\"}]}\"\nNot sure where we return the supported versions.","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}],"octavia/api/v1/controllers/__init__.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"39ab48ab9568400e418e82e64056c6471fdd48f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @wsme_pecan.wsexpose(wtypes.text)"},{"line_number":27,"context_line":"    def get(self):"},{"line_number":28,"context_line":"        # TODO(blogan): decide what exactly should be here, if anything"},{"line_number":29,"context_line":"        return \"V1\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_5eebddaf","line":28,"updated":"2014-11-21 00:52:59.000000000","message":"Please work out the todo","commit_id":"ea5229de6a9516522a70cfb91e97b743d9bced41"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e62a1d71d9a82e6d441bda4cb6b50d864e44ad07","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @wsme_pecan.wsexpose(wtypes.text)"},{"line_number":27,"context_line":"    def get(self):"},{"line_number":28,"context_line":"        # TODO(blogan): decide what exactly should be here, if anything"},{"line_number":29,"context_line":"        return \"V1\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_f2ce5e2c","line":28,"in_reply_to":"5a890539_5eebddaf","updated":"2014-11-21 21:12:24.000000000","message":"Still not sure what we want, but I can return some basic version info here.","commit_id":"ea5229de6a9516522a70cfb91e97b743d9bced41"}],"octavia/api/v1/types/listener.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f71ad039b352fd789c48befef17e5d9a794609d3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    protocol_port \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":60,"context_line":"    connection_limit \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":61,"context_line":"    tls_certificate_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":62,"context_line":"    tls_termination \u003d wtypes.wsattr(TLSTermination)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_4f5ab184","line":62,"updated":"2014-12-06 20:20:12.000000000","message":"This DSL is repetitive as heck.","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f06389d7e8d2da173d9b3cb72aba88afb3f85053","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    protocol_port \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":60,"context_line":"    connection_limit \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":61,"context_line":"    tls_certificate_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":62,"context_line":"    tls_termination \u003d wtypes.wsattr(TLSTermination)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_7c015eae","line":62,"in_reply_to":"3a961159_4f5ab184","updated":"2014-12-11 04:26:27.000000000","message":"i can get away without specifying wtypes.wsattr if i dont have to have a default value or make it mandatory.  i was just being consistent, though that might ahve been to a fault.","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}],"octavia/common/constants.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f71ad039b352fd789c48befef17e5d9a794609d3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"AMPHORA_VM \u003d \u0027VM\u0027"},{"line_number":56,"context_line":"AMPHORA_TYPES \u003d (AMPHORA_VM, )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"TEMP_FAKE_TENANT_ID \u003d \u00273a51c163-d295-4453-a8de-1629c07d8345\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_0fc7c913","line":58,"updated":"2014-12-06 20:20:12.000000000","message":"why is this is common/constants?  If this isn\u0027t a testing thing, it needs a # TODO","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f06389d7e8d2da173d9b3cb72aba88afb3f85053","unresolved":false,"context_lines":[{"line_number":55,"context_line":"AMPHORA_VM \u003d \u0027VM\u0027"},{"line_number":56,"context_line":"AMPHORA_TYPES \u003d (AMPHORA_VM, )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"TEMP_FAKE_TENANT_ID \u003d \u00273a51c163-d295-4453-a8de-1629c07d8345\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_dc3332a9","line":58,"in_reply_to":"3a961159_0fc7c913","updated":"2014-12-11 04:26:27.000000000","message":"agreed, this should be in tests.","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}],"octavia/common/data_models.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"609d471c91a5b7985a0e6b7eab9ba859a902082a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.load_balancer_id \u003d load_balancer_id"},{"line_number":193,"context_line":"        self.host_id \u003d host_id"},{"line_number":194,"context_line":"        self.status \u003d status"},{"line_number":195,"context_line":"        self.load_balancer \u003d load_balancer"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_b901e86b","line":195,"updated":"2014-09-28 07:43:07.000000000","message":"need to keep this change out of the review","commit_id":"23470d09609ae3dad2b53c245943d5c89157fdfa"}],"octavia/common/exceptions.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f71ad039b352fd789c48befef17e5d9a794609d3","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class NotFound(APIException):"},{"line_number":65,"context_line":"    msg \u003d _(\u0027%(resource)s %(id)s not found.\u0027)"},{"line_number":66,"context_line":"    code \u003d 404"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class NotAuthorized(APIException):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_2fcc8535","line":66,"updated":"2014-12-06 20:20:12.000000000","message":"You have an api exception for NotFound, and this.  Merge them?","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f06389d7e8d2da173d9b3cb72aba88afb3f85053","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class NotFound(APIException):"},{"line_number":65,"context_line":"    msg \u003d _(\u0027%(resource)s %(id)s not found.\u0027)"},{"line_number":66,"context_line":"    code \u003d 404"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class NotAuthorized(APIException):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_5c1f4208","line":66,"in_reply_to":"3a961159_2fcc8535","updated":"2014-12-11 04:26:27.000000000","message":"i dont follow you here.  What do you mean?","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"32ff962d928faf371a30b144b6af6212f4fdaa1d","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class NotFound(APIException):"},{"line_number":65,"context_line":"    msg \u003d _(\u0027%(resource)s %(id)s not found.\u0027)"},{"line_number":66,"context_line":"    code \u003d 404"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class NotAuthorized(APIException):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_32b8dde4","line":66,"in_reply_to":"3a961159_5c1f4208","updated":"2014-12-11 06:48:51.000000000","message":"In api/exc.py, you have NotFoundException.\nAnd here, you have NotFound.","commit_id":"28e340e9a5e0f37d70eea8dde5dede10f9f8dc54"}]}
