)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"adad5b21e7553fb3e7988a0cba853f8e3da96bfb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Al Miller \u003cal.miller@ajmiller.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-30 14:13:31 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Initial draft of compute driver spec."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Address comments by TrevorV, and fix tabification."},{"line_number":10,"context_line":"Try to make doc8 happy."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8c0949_e8f7b68a","line":7,"updated":"2014-10-30 22:58:46.000000000","message":"shouldn\u0027t be a period at the end :(\n\nThat gets everyone.","commit_id":"715107d0bf624ee6e8a1334ee5b59ef53082279a"}],"specs/version0.5/amphora-manager-interface.rst":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"d5f0776339c70d478a1b04d04b4d194ca928158e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This blueprint describes how a driver will interface with Nova to"},{"line_number":13,"context_line":"manage the creation and deletion of amphora instances.  It will"},{"line_number":14,"context_line":"describe the base class and other classes required to create, delete,"},{"line_number":15,"context_line":"and query the status of amphorae, but will not otherwise manage them."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_8630b79f","line":15,"updated":"2014-10-21 19:37:31.000000000","message":"From what I understand, methods below describe changing the status of the amphora.  Meaning its not just create/delete/check, it does in fact manage the status of the amphora, right?","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"ec97d76881f4bf9aee3bef6a786cd72583a23b5f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This blueprint describes how a driver will interface with Nova to"},{"line_number":13,"context_line":"manage the creation and deletion of amphora instances.  It will"},{"line_number":14,"context_line":"describe the base class and other classes required to create, delete,"},{"line_number":15,"context_line":"and query the status of amphorae, but will not otherwise manage them."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_d3aa7218","line":15,"in_reply_to":"9aa7fdbe_8630b79f","updated":"2014-10-22 02:59:07.000000000","message":"Yes, good point.  My understanding of what this interface would do evolved over time and I didn\u0027t go back and update this text.  I will edit it to make it more complete.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"d5f0776339c70d478a1b04d04b4d194ca928158e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t    \"\"\""},{"line_number":78,"context_line":"\t    raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tdef get_node(self, node_name):"},{"line_number":81,"context_line":"\t    \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\t    :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_66a2f3af","line":80,"updated":"2014-10-21 19:37:31.000000000","message":"This might be called \"get_amphora\" since node really isn\u0027t used in Octavia, and its argument would follow suit.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"ec97d76881f4bf9aee3bef6a786cd72583a23b5f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t    \"\"\""},{"line_number":78,"context_line":"\t    raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tdef get_node(self, node_name):"},{"line_number":81,"context_line":"\t    \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\t    :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_1364fa20","line":80,"in_reply_to":"9aa7fdbe_66a2f3af","updated":"2014-10-22 02:59:07.000000000","message":"Yes, good idea, \"node\" has certain connotations that are not necessarily appropriate here.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"d5f0776339c70d478a1b04d04b4d194ca928158e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\t    :param node_id: the id of the instance to suspend"},{"line_number":100,"context_line":"\t    \"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\t    raise NotImplementedError"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"\tdef stop(self, node_id):"},{"line_number":105,"context_line":"\t    \"\"\" stop the specified instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_495ee013","line":102,"updated":"2014-10-21 19:37:31.000000000","message":"Should probably include an unsuspend method.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"ec97d76881f4bf9aee3bef6a786cd72583a23b5f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\t    :param node_id: the id of the instance to suspend"},{"line_number":100,"context_line":"\t    \"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\t    raise NotImplementedError"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"\tdef stop(self, node_id):"},{"line_number":105,"context_line":"\t    \"\"\" stop the specified instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_f32a168f","line":102,"in_reply_to":"9aa7fdbe_495ee013","updated":"2014-10-22 02:59:07.000000000","message":"Oh where is the sport in that, LOL....  I\u0027ll add one.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"d5f0776339c70d478a1b04d04b4d194ca928158e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"\t    raise NotImplementedError"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"\tdef snapshot(self, node_id):"},{"line_number":113,"context_line":"\t    \"\"\" create a snapshot of the specified instance"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"\t    :param node_id: the id of the instance to snapshot"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_e6950341","line":112,"updated":"2014-10-21 19:37:31.000000000","message":"I\u0027m guessing this is for backup of an amphora, right?","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"ec97d76881f4bf9aee3bef6a786cd72583a23b5f","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"\t    raise NotImplementedError"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"\tdef snapshot(self, node_id):"},{"line_number":113,"context_line":"\t    \"\"\" create a snapshot of the specified instance"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"\t    :param node_id: the id of the instance to snapshot"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_d358b258","line":112,"in_reply_to":"9aa7fdbe_e6950341","updated":"2014-10-22 02:59:07.000000000","message":"Yes, the name here is coming from the idea of taking a VM snapshot, and in the initial release that is probably how it would be implemented, but the general case could be more general.  Should we change the name to be backup()?  Any other suggestions?","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"d5f0776339c70d478a1b04d04b4d194ca928158e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"-------------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":" * Non blocking IO - throw an appropriate exception instead"},{"line_number":139,"context_line":"   to wait forever; use timeouts on sockets"},{"line_number":140,"context_line":" * We might employ a circuit breaker to insulate driver"},{"line_number":141,"context_line":"   problems from controller problems [1]"},{"line_number":142,"context_line":" * Use appropriate logging"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_e6ca634e","line":139,"updated":"2014-10-21 19:37:31.000000000","message":"Is this supposed to have more lines here?  It doesn\u0027t seem like this was a complete sentence...\n\nmaybe supposed to be \"instead of waiting forever; example: use timeouts on sockets\"","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"ec97d76881f4bf9aee3bef6a786cd72583a23b5f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"-------------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":" * Non blocking IO - throw an appropriate exception instead"},{"line_number":139,"context_line":"   to wait forever; use timeouts on sockets"},{"line_number":140,"context_line":" * We might employ a circuit breaker to insulate driver"},{"line_number":141,"context_line":"   problems from controller problems [1]"},{"line_number":142,"context_line":" * Use appropriate logging"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_93254ac4","line":139,"in_reply_to":"9aa7fdbe_e6ca634e","updated":"2014-10-22 02:59:07.000000000","message":"Yes, I agree this doesn\u0027t read well and leaves one wondering what it is trying to say.  I\u0027ll improve it.","commit_id":"8246cd0c8708917e133e036b8418b7ca7d393a01"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"c67d9924a7f56a9c84f664fc920cc98c42fb31c9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"The controller needs to be able to create, delete, and monitor the"},{"line_number":20,"context_line":"status of amphora instances.  The amphorae may be virtual machines,"},{"line_number":21,"context_line":"containers, bare-metal servers, or dedicated hardware load balancers."},{"line_number":22,"context_line":"This interface should hide the implementation details of the amphorae"},{"line_number":23,"context_line":"from the caller to the maximum extent possible."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_f6fcbf40","line":21,"updated":"2014-10-22 08:47:34.000000000","message":"Is anyone seriously suggesting hardware load balancers here? Can Nova even interface with them?","commit_id":"c4db3e19f60ea2bb6b5c07ad1dd144afab557f99"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"76b79daf733b2a2e57e7effaa2d341441d31c66d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"The controller needs to be able to create, delete, and monitor the"},{"line_number":20,"context_line":"status of amphora instances.  The amphorae may be virtual machines,"},{"line_number":21,"context_line":"containers, bare-metal servers, or dedicated hardware load balancers."},{"line_number":22,"context_line":"This interface should hide the implementation details of the amphorae"},{"line_number":23,"context_line":"from the caller to the maximum extent possible."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_408853e7","line":21,"in_reply_to":"9aa7fdbe_f6fcbf40","updated":"2014-10-22 16:10:08.000000000","message":"Well i think the point was to just say that this interface is the abstraction layer that any implementation can use.  If one day someone actually wants to attempt hardware amphorae, then this allows them to at least try with an interface.","commit_id":"c4db3e19f60ea2bb6b5c07ad1dd144afab557f99"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"c67d9924a7f56a9c84f664fc920cc98c42fb31c9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"\"\""},{"line_number":78,"context_line":"            raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def get_node(self, node_name):"},{"line_number":81,"context_line":"            \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_76452f6f","line":80,"updated":"2014-10-22 08:47:34.000000000","message":"Re-emphasizing Trevor\u0027s point that we should use the name \u0027amphora\u0027 here instead of \u0027node.\u0027","commit_id":"c4db3e19f60ea2bb6b5c07ad1dd144afab557f99"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ab4c46b33fef055a7bd416ee961243a936e540ca","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_40a4d356","line":45,"updated":"2014-10-22 17:31:54.000000000","message":"Any particular reason why an abstract base class isn\u0027t being used?","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_4bde46de","line":45,"in_reply_to":"9aa7fdbe_40a4d356","updated":"2014-10-27 21:29:13.000000000","message":"No, other than me being a relative newbie to python and the spec I cloned this from (amphora-driver-interface.rst) did it this old-fashioned way.\n\nI am not opposed to using abstract base class, bit if we use it here, should we use it everywhere?  I\u0027m not going to change this in this patch, but let\u0027s discuss and decide if we want to make all the specs consistent.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5e4cd777fd435fda70e91348594686388613c2af","unresolved":false,"context_lines":[{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_a5a80821","line":48,"updated":"2014-10-23 20:22:24.000000000","message":"We\u0027ll also probably want to take a list of network_ids that the amphora should be created with.  This way we can immediately have the Amphora on the LB Management network so that it and the controller can communicate with each other.  There will also be the case where we may want to add it to multiple networks on build.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_0b827eff","line":48,"in_reply_to":"9aa7fdbe_a5a80821","updated":"2014-10-27 21:29:13.000000000","message":"OK, this sounds like a good idea.  I also changed the keys and secGroup comment to specify that a list of those objects can be given.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"c3d0d89078c597a38029998916213f2d5e490fe3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            version 0.5, only VM is supported.  In the future this"},{"line_number":54,"context_line":"            may support Container, BareMetal, and HWLoadBalancer."},{"line_number":55,"context_line":"            :param amphoraFlavor: Optionally specify a flavor"},{"line_number":56,"context_line":"            :param key: Optionally specify a key"},{"line_number":57,"context_line":"            :param secGroup: Optionally specify a security group"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            :returns: The id of the new instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_8535eddb","line":56,"updated":"2014-10-22 15:34:29.000000000","message":"I didn\u0027t notice this before, could you tell me what this \"key\" is?  Does it have to do with the nova command to build a vm?","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            version 0.5, only VM is supported.  In the future this"},{"line_number":54,"context_line":"            may support Container, BareMetal, and HWLoadBalancer."},{"line_number":55,"context_line":"            :param amphoraFlavor: Optionally specify a flavor"},{"line_number":56,"context_line":"            :param key: Optionally specify a key"},{"line_number":57,"context_line":"            :param secGroup: Optionally specify a security group"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            :returns: The id of the new instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_8bc74e63","line":56,"in_reply_to":"9aa7fdbe_8535eddb","updated":"2014-10-27 21:29:13.000000000","message":"Yes, nova can create an instance with an ssh key pre-populated.  I will clarify this.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ab4c46b33fef055a7bd416ee961243a936e540ca","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            raise NotImplementedError"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, amphora):"},{"line_number":66,"context_line":"            \"\"\"  delete the specified amphora"},{"line_number":67,"context_line":"            \"\"\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_80f4fb87","line":65,"updated":"2014-10-22 17:31:54.000000000","message":"is this an amphora_id or an actual amphora object that has id as an attribute?","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            raise NotImplementedError"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, amphora):"},{"line_number":66,"context_line":"            \"\"\"  delete the specified amphora"},{"line_number":67,"context_line":"            \"\"\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_0bab5e89","line":65,"in_reply_to":"9aa7fdbe_80f4fb87","updated":"2014-10-27 21:29:13.000000000","message":"This should be the amphora id.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ab4c46b33fef055a7bd416ee961243a936e540ca","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"\"\""},{"line_number":78,"context_line":"            raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def get_node(self, node_name):"},{"line_number":81,"context_line":"            \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_40edb38a","line":80,"updated":"2014-10-22 17:31:54.000000000","message":"s/node/amphora\n\nalso, why not get amphora by id?.  Or you can use **filters and pull out the actual possible filters.  Or you can just enumerate the filters if there aren\u0027t many.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"cfea12e5e44aff85f821a5a3e0288bf98ce03c31","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"\"\""},{"line_number":78,"context_line":"            raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def get_node(self, node_name):"},{"line_number":81,"context_line":"            \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_916d2b9b","line":80,"in_reply_to":"9aa7fdbe_40edb38a","updated":"2014-10-22 18:22:13.000000000","message":"The id will be provided by nova right?  Probably best to leave it at that IMO.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"\"\""},{"line_number":78,"context_line":"            raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def get_node(self, node_name):"},{"line_number":81,"context_line":"            \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_6b930a5b","line":80,"in_reply_to":"9aa7fdbe_40edb38a","updated":"2014-10-27 21:29:13.000000000","message":"yes, that is the intention.  I will clarify the name","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"7c8fcbe16e73cbb2bb079dad78e577ef4f900136","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"\"\""},{"line_number":78,"context_line":"            raise NotImplementedError"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def get_node(self, node_name):"},{"line_number":81,"context_line":"            \"\"\" Try to find a node given its name"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            :param node_name: the name of the desired node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_ab99727a","line":80,"in_reply_to":"9aa7fdbe_916d2b9b","updated":"2014-10-27 21:29:13.000000000","message":"yes.","commit_id":"ed7381d57c02826b4fd8240e8a290b5393c28453"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"33704270f6e99df5c5758aecdc04d7e03d5fcd82","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from the caller to the maximum extent possible."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This interface will provide means to specify:"},{"line_number":26,"context_line":" - type (VM, Container, bare metal)"},{"line_number":27,"context_line":" - flavor (provides means to specify memory and storage capacity)"},{"line_number":28,"context_line":" - what else?"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_745750ca","line":26,"updated":"2014-10-28 16:33:44.000000000","message":"Will this be a string type?  I\u0027d rather an enum type of class, but since python 2.x doesn\u0027t \"support\" enums, you would just make a class with class variables.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4b528b5fad4d12af517dc1c0a9b5f01466be64a7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from the caller to the maximum extent possible."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This interface will provide means to specify:"},{"line_number":26,"context_line":" - type (VM, Container, bare metal)"},{"line_number":27,"context_line":" - flavor (provides means to specify memory and storage capacity)"},{"line_number":28,"context_line":" - what else?"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_835c6eef","line":26,"in_reply_to":"9aa7fdbe_745750ca","updated":"2014-10-29 02:50:04.000000000","message":"Scratch that.  Looks like it\u0027ll just defined in the constants module.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_56998677","line":45,"updated":"2014-10-28 03:18:09.000000000","message":"Just continuing the discussion from last the last PS: I\u0027m inclined to agree we should use an abstract base class here as Brandon and Trevor have pointed out.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"5294c4b0108cea2845d2de6beccec78f8e1e0ec7","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_a76a67b0","line":45,"in_reply_to":"9aa7fdbe_54324ca7","updated":"2014-10-28 19:21:51.000000000","message":"Sorry, I agree with not having it explicitly here in this pseudo code, but should it be mentioned in the above descriptions as a suggestion maybe?","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"33704270f6e99df5c5758aecdc04d7e03d5fcd82","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_54324ca7","line":45,"in_reply_to":"9aa7fdbe_56998677","updated":"2014-10-28 16:33:44.000000000","message":"I think he mentioned it somewhere that it will be done in the implementation (which it has been).  So I am okay with it not really being done here as this is pretty much like pseudo code.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            :returns: the logger"},{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_11ffee02","line":45,"in_reply_to":"9aa7fdbe_a76a67b0","updated":"2014-10-29 23:03:12.000000000","message":"I am happy with this being an abstract base class.  For now, I will follow these suggestions and not explicitly write the code to implement it as an abc in this doc, but will add a note above in the text under \"Proposed change\" to call out that it is an abc.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"33704270f6e99df5c5758aecdc04d7e03d5fcd82","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_340868d9","line":47,"updated":"2014-10-28 16:33:44.000000000","message":"I think you just need type and flavor here (though type will override the built-in type method), so maybe type_?  also need to use _ instead of camelCase but this can be fixed in the code so I\u0027m not worried about it here.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"80aef6793f44ea6d2bd3d3578ea878c13f577082","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_83b8eee6","line":47,"in_reply_to":"9aa7fdbe_03687e86","updated":"2014-10-29 03:01:45.000000000","message":"Also, I believe this should also take in an image_id because every Compute Driver should be dumb and just do what it is told, and not decide which image to use.  That decision should be left up to the controller.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5064cb7d404ad4ef1f64f0eb6f0639323f22b0dc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_03687e86","line":47,"in_reply_to":"9aa7fdbe_0729739a","updated":"2014-10-29 02:52:09.000000000","message":"I believe its for specifying VM or Container or Baremetal","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_d11f26b6","line":47,"in_reply_to":"9aa7fdbe_0729739a","updated":"2014-10-29 23:03:12.000000000","message":"The type is meant to specify whether the amphora will be a VM, baremetal server, etc.  As discussed earlier, only VM is supported for now.  \n\nFlavor derives from nova flavors, and may not apply in all cases.  I added some text to try to clarify this.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_318dca32","line":47,"in_reply_to":"9aa7fdbe_340868d9","updated":"2014-10-29 23:03:12.000000000","message":"I fixed the annoying mix of camelCase and underscore_names in the parameters.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"06e9c5086451b327a0a0a25c2e5e646514d3ddfe","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphoraType \u003d VM, amphoraFlavor \u003d None,"},{"line_number":48,"context_line":"                  key \u003d None, secGroup \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_0729739a","line":47,"in_reply_to":"9aa7fdbe_340868d9","updated":"2014-10-28 19:40:05.000000000","message":"Is amphoraType here meant to be a UUID of a glance image or something?  If so, I could see a reason for having flavor (corresponding to Nova flavor?) be a separate parameter. However, this should be spelled out more clearly in the notes below.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"af4dbbeab79fedfa07d4d32ad5273d6350ae022e","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        def delete(self, amphora):"},{"line_number":69,"context_line":"            \"\"\"  delete the specified amphora"},{"line_number":70,"context_line":"            \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_6325ca5b","line":68,"updated":"2014-10-29 02:55:32.000000000","message":"amphora needs to be amphora_id","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        def delete(self, amphora):"},{"line_number":69,"context_line":"            \"\"\"  delete the specified amphora"},{"line_number":70,"context_line":"            \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_114d2e73","line":68,"in_reply_to":"9aa7fdbe_6325ca5b","updated":"2014-10-29 23:03:12.000000000","message":"Done","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"77c9d50f0896f3d1db539b83b7fd918e27aabe64","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"            raise NotImplementedError"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        def get_amphora_id(self, amphora_name):"},{"line_number":84,"context_line":"            \"\"\" Try to find a amphora given its name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            :param amphora_name: the name of the desired amphora"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_55b94aeb","line":83,"updated":"2014-10-29 15:51:55.000000000","message":"I didn\u0027t realize this before, but you have a defined way here to get an amphora by its name, but there is no method to retrieve the information of an amphora from nova.  Would it be better to have a standard \u0027get\u0027 method that took multiple parameters, \u0027name\u0027 and \u0027id\u0027, and in implementation it could enforce that one of them not be null?","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"            raise NotImplementedError"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        def get_amphora_id(self, amphora_name):"},{"line_number":84,"context_line":"            \"\"\" Try to find a amphora given its name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            :param amphora_name: the name of the desired amphora"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_b1645ae6","line":83,"in_reply_to":"9aa7fdbe_55b94aeb","updated":"2014-10-29 23:03:12.000000000","message":"Added a new method get_amphora that returns the amphora object given its name or id.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \"\"\""},{"line_number":89,"context_line":"            raise NotImplementedError"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        def start(self, amphora_id):"},{"line_number":92,"context_line":"            \"\"\" start the specified instance"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            :param amphora_id: the id of the instance to start"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_f6cc3a6c","line":91,"updated":"2014-10-28 03:18:09.000000000","message":"Does building an amphora imply starting it? If so, then what\u0027s the purpose of this method? If we have no purpose for this method at this time, we should remove it.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_56bee6ae","line":99,"updated":"2014-10-28 03:18:09.000000000","message":"Same as the above: If we have no purpose for this method right now, we should remove it.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"77c9d50f0896f3d1db539b83b7fd918e27aabe64","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_3b4595b3","line":99,"in_reply_to":"9aa7fdbe_4309a6dc","updated":"2014-10-29 15:51:55.000000000","message":"So Brandon is your final decision in favor of leaving this in the interface?","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"06e9c5086451b327a0a0a25c2e5e646514d3ddfe","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_62086d28","line":99,"in_reply_to":"9aa7fdbe_4718dbd2","updated":"2014-10-28 19:40:05.000000000","message":"If you think a suspend state is going to be useful for you from the beginning, then I can see a reason for having it here.\n\nHonestly, I\u0027m not looking for *much* justification for having these additional methods, just *any* justification that holds water (and isn\u0027t over-engineering from the start).","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"2e8cb3b54d2ad1818e9f395374edf06f5d0ee0f6","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_c8cce56c","line":99,"in_reply_to":"9aa7fdbe_56bee6ae","updated":"2014-10-28 15:01:25.000000000","message":"Rax specifically utilizes suspension in our current offering, so I can say I would like to see this method along with its counterpart \u0027resume.\u0027  I feel like this is the right time to include this method, rather than saving it for later.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5064cb7d404ad4ef1f64f0eb6f0639323f22b0dc","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_4309a6dc","line":99,"in_reply_to":"9aa7fdbe_62086d28","updated":"2014-10-29 02:52:09.000000000","message":"Probably best to keep it in the interface to keep the interface from changing often with new features.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_11a1aea9","line":99,"in_reply_to":"9aa7fdbe_62086d28","updated":"2014-10-29 23:03:12.000000000","message":"Stephen, one of the reasons I put these methods in here is that libra implements these (or similar, slightly differently-named) functions.  Now just because Libra did something doesn\u0027t necessarily make it a good idea (far from it -- based on personal experience), but these do seem like potentially useful features.\n\nThat said, I am not attached to them, but for not it feels to me like the consensus is to leave them in.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d39be835aa94ba7be0f90bb657e753c07d636208","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_4718dbd2","line":99,"in_reply_to":"9aa7fdbe_b4dff867","updated":"2014-10-28 19:27:55.000000000","message":"Thinking more out loud here, maybe once a suspension feature is in place this would then be added.  Because we wouldn\u0027t use this until then and we don\u0027t currently have a SUSPENDED state.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"33704270f6e99df5c5758aecdc04d7e03d5fcd82","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_b4dff867","line":99,"in_reply_to":"9aa7fdbe_c8cce56c","updated":"2014-10-28 16:33:44.000000000","message":"Agree with Trevor, we will need this.  When customers dont pay their bills this can be used.  Then again, deleting and recreating the amphora might be just as good, but depending on how we collect usage/stats, it could reset those numbers.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"88f26ac444b203a773dce109e49c004ced447558","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            raise NotImplementedError"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        def suspend(self, amphora_id):"},{"line_number":100,"context_line":"            \"\"\" suspend the specified instance"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d4f63cd6","line":99,"in_reply_to":"9aa7fdbe_c8cce56c","updated":"2014-10-28 16:31:43.000000000","message":"Trevor, could you please describe your reasoning for this? And specifically how do you see it applying to Octavia?","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            raise NotImplementedError"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def resume(self, amphora_id):"},{"line_number":108,"context_line":"            \"\"\" resume the specified instance"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            :param amphora_id: the id of the instance to suspend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_76e04acd","line":107,"updated":"2014-10-28 03:18:09.000000000","message":"Same as the above: If we have no purpose for this method right now, we should remove it.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            raise NotImplementedError"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        def stop(self, amphora_id):"},{"line_number":116,"context_line":"            \"\"\" stop the specified instance"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            :param amphora_id: the id of the instance to stop"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_b6e632e6","line":115,"updated":"2014-10-28 03:18:09.000000000","message":"Same as the above: If we have no purpose for this method right now, we should remove it.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bb14ac5df8012b191ddab558c9b88ea31dc4562","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            raise NotImplementedError"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def backup(self, amphora_id):"},{"line_number":124,"context_line":"            \"\"\" create a backup of the specified instance.  The"},{"line_number":125,"context_line":"            format of the backup is implementation-defined"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d6e9f6b7","line":123,"updated":"2014-10-28 03:18:09.000000000","message":"Same as the above: If we have no purpose for this method right now, we should remove it.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"2e8cb3b54d2ad1818e9f395374edf06f5d0ee0f6","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The driver is expected to raise the following well defined exceptions:"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* NotImplementedError - this functionality is not implemented/not supported"},{"line_number":138,"context_line":"* AmphoraComputeError - a super class for all other exceptions and the catch"},{"line_number":139,"context_line":"    all if no specific exception can be found"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_08a98d23","line":137,"updated":"2014-10-28 15:01:25.000000000","message":"If we change this to an abstract base class, there should be no reason for \"NotImplemented\" since ABC\u0027s handle that already.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"6eedab63ba0b8f402b93794f5b4f017ca402b6cf","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The driver is expected to raise the following well defined exceptions:"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* NotImplementedError - this functionality is not implemented/not supported"},{"line_number":138,"context_line":"* AmphoraComputeError - a super class for all other exceptions and the catch"},{"line_number":139,"context_line":"    all if no specific exception can be found"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a8c0949_f11c22c4","line":137,"in_reply_to":"9aa7fdbe_08a98d23","updated":"2014-10-29 23:03:12.000000000","message":"Trevor, how does this sound:  you implement the interface using ABC (I think you\u0027ve probably already gotten a start at this) and we can adopt the ABC syntax in your implementation into the spec.","commit_id":"ad430c6842f61fe38c792d56500b86abc468f93b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6f56d9800b03bb84ffd77f4f6bda2ec2c7b7fbd5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    class AmphoraComputeDriver(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        def getLogger(self):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            \"\"\" return the logger to use - this is a way to inject a"},{"line_number":41,"context_line":"            custom logger for testing, etc"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_dd02d7b3","line":38,"updated":"2014-10-30 03:38:49.000000000","message":"nit: get_logger","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"a8c04bdd8153dbf07a39925bfcbdd2a10889b0a4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    class AmphoraComputeDriver(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        def getLogger(self):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            \"\"\" return the logger to use - this is a way to inject a"},{"line_number":41,"context_line":"            custom logger for testing, etc"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_926823f7","line":38,"in_reply_to":"7a8c0949_dd02d7b3","updated":"2014-10-30 21:13:20.000000000","message":"Done","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6f56d9800b03bb84ffd77f4f6bda2ec2c7b7fbd5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphora_type \u003d VM, amphora_flavor \u003d None,"},{"line_number":48,"context_line":"                  keys \u003d None, sec_groups \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_bdf50bcd","line":48,"updated":"2014-10-30 03:38:49.000000000","message":"I still think you need image_id.  It is required to build a nova server and so should be a parameter here.  I don\u0027t think the implementations of this interface shoudl be responsible for deciding which image to use, it should come from whatever is consuming them.","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"a8c04bdd8153dbf07a39925bfcbdd2a10889b0a4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"             raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def build(self, amphora_type \u003d VM, amphora_flavor \u003d None,"},{"line_number":48,"context_line":"                  keys \u003d None, sec_groups \u003d None, network_ids \u003d None ):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            \"\"\" build a new amphora."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_8d52c411","line":48,"in_reply_to":"7a8c0949_bdf50bcd","updated":"2014-10-30 21:13:20.000000000","message":"Done","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6f56d9800b03bb84ffd77f4f6bda2ec2c7b7fbd5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \"\"\""},{"line_number":83,"context_line":"            raise NotImplementedError"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def get_amphora_id(self, amphora_name):"},{"line_number":86,"context_line":"            \"\"\" Try to find a amphora given its name"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            :param amphora_name: the name of the desired amphora"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_fdff93a8","line":85,"updated":"2014-10-30 03:38:49.000000000","message":"shouldn\u0027t this method be removed because the method directly below allows the same?","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"a8c04bdd8153dbf07a39925bfcbdd2a10889b0a4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \"\"\""},{"line_number":83,"context_line":"            raise NotImplementedError"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def get_amphora_id(self, amphora_name):"},{"line_number":86,"context_line":"            \"\"\" Try to find a amphora given its name"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            :param amphora_name: the name of the desired amphora"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_724ad784","line":85,"in_reply_to":"7a8c0949_fdff93a8","updated":"2014-10-30 21:13:20.000000000","message":"Yes, sorry, copy/paste fumble, meant to cut this out and missed it.","commit_id":"e6b1a5272f8c323726f7d95010052ba684af73e8"}]}
