)]}'
{"etc/octavia.conf":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"395e06469b773233bf40045550c5465929c78222","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# configuration file."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[certificates]"},{"line_number":22,"context_line":"# cert_generator_class \u003d"},{"line_number":23,"context_line":"# cert_manager_class \u003d"}],"source_content_type":"text/plain","patch_set":6,"id":"5a890539_90cd9a89","line":22,"updated":"2014-11-07 18:21:54.000000000","message":"Just a curiosity thing, is it not redundant to put \"cert_\" first in the \"certificates\" section, or is that the standard way to put values in config?","commit_id":"9c251b32dd487f9479c6895651222ee3bc67c033"}],"octavia/certificates/common/cert.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"18ebcc7395bfd681a01753c87791df2f3cc68200","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Cert(object):"},{"line_number":23,"context_line":"    \"\"\"Base class to represent all certificates.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def get_certificate(self):"},{"line_number":27,"context_line":"        \"\"\"Returns the certificate.\"\"\""},{"line_number":28,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_6093d8a3","line":25,"updated":"2014-11-11 05:04:14.000000000","message":"not a deal breaker, but any reason an abstractproperty is not used?","commit_id":"de66c85dec95ae2e7d2529ced4ac25e22e5d627c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"de450ae6bf92affbcacd29253f894999f1c410d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Cert(object):"},{"line_number":23,"context_line":"    \"\"\"Base class to represent all certificates.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def get_certificate(self):"},{"line_number":27,"context_line":"        \"\"\"Returns the certificate.\"\"\""},{"line_number":28,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_140a488a","line":25,"in_reply_to":"5a890539_6093d8a3","updated":"2014-11-11 18:02:57.000000000","message":"I was just following the model set up by KeyManager from Nova/Cinder, since eventually this will hopefully merge in with that.","commit_id":"de66c85dec95ae2e7d2529ced4ac25e22e5d627c"}],"octavia/certificates/manager/cert_mgr.py":[{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"4409fd826c1fcb9f2468586472c60ee10807a19b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Stores (i.e., registers) a cert with the cert manager."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        This method stores the specified cert and returns its UUID that"},{"line_number":37,"context_line":"        identifies it within the cert manager."},{"line_number":38,"context_line":"        If storage of the certificate data fails, a CertificateStorageException"},{"line_number":39,"context_line":"        should be raised."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_f05ede11","line":37,"updated":"2014-11-07 17:39:17.000000000","message":"wordiness nit: This could discard everything after UUID in the above sentence to just read \"This method stores the specified cert and returns its UUID.\"","commit_id":"9c251b32dd487f9479c6895651222ee3bc67c033"}],"octavia/certmgr/barbican.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"278c7c4e5c10bbb0db60d6fb6d9d7fcdeb5857d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Key manager implementation for Barbican"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from barbicanclient import client as barbican_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_edda68e8","line":17,"updated":"2014-10-30 22:03:05.000000000","message":"This should probably be changed to \"Cert manager\" or \"Certificate manager\" since it is in a certmgr folder and not a keymgr folder :).","commit_id":"bafbd2c015b482119aa4ec542f21c227884ea6e8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"903e5e00f3801c31e5ac312923f376a919d84c67","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Key manager implementation for Barbican"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from barbicanclient import client as barbican_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_0dadf431","line":17,"in_reply_to":"7a8c0949_edda68e8","updated":"2014-10-30 22:09:21.000000000","message":"Whoops, thought I cleaned up all of the copy/paste artifacts. Missed this one. :)","commit_id":"bafbd2c015b482119aa4ec542f21c227884ea6e8"}],"octavia/common/config.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5b389c032eb613c3d880f5a9be71324ec149e292","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Register the configuration options"},{"line_number":88,"context_line":"cfg.CONF.register_opts(core_opts)"},{"line_number":89,"context_line":"cfg.CONF.register_opts(keystone_opts, group\u003d\u0027keystone\u0027)"},{"line_number":90,"context_line":"cfg.CONF.register_cli_opts(core_cli_opts)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Ensure that the control exchange is set correctly"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8c0949_c73532f8","line":89,"updated":"2014-11-07 00:14:12.000000000","message":"probably needs a more descriptive group name thank keystone, bc it will probably get confused with keystone_authtoken.  maybe service_account_auth.  if this is to be used as service account credentials.","commit_id":"ee5b729e9f726967bb3825dfae144f0334e53a26"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c6b05473ce600ac1ef08b2c50e350d0d29bfc9b2","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Register the configuration options"},{"line_number":88,"context_line":"cfg.CONF.register_opts(core_opts)"},{"line_number":89,"context_line":"cfg.CONF.register_opts(keystone_opts, group\u003d\u0027keystone\u0027)"},{"line_number":90,"context_line":"cfg.CONF.register_cli_opts(core_cli_opts)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Ensure that the control exchange is set correctly"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8c0949_724a7ec6","line":89,"in_reply_to":"7a8c0949_c73532f8","updated":"2014-11-07 02:43:19.000000000","message":"Hmm, I will have to look at this in the morning, I think maybe this is supposed to BE keystone_authtoken.","commit_id":"ee5b729e9f726967bb3825dfae144f0334e53a26"}]}