)]}'
{"id":"openstack%2Foctavia~136184","triplet_id":"openstack%2Foctavia~master~I084f007bb8eb7f081d5ae56aa919f15f9596984b","project":"openstack/octavia","branch":"master","topic":"code_review_standard","hashtags":[],"change_id":"I084f007bb8eb7f081d5ae56aa919f15f9596984b","subject":"This is a reference for code review","status":"ABANDONED","created":"2014-11-20 23:51:12.000000000","updated":"2015-04-01 23:31:34.000000000","total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cb884585c21735717112f8c2012602eb2cc7327c","_number":136184,"virtual_id_number":136184,"owner":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-11-21 00:03:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},{"date":"2014-12-02 00:17:23.000000000","_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2014-11-30 00:52:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"value":-1,"date":"2014-11-25 00:38:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-11-21 00:03:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-11-25 00:38:55.000000000","updated_by":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"reviewer":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"state":"REVIEWER"},{"updated":"2014-11-30 00:52:00.000000000","updated_by":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"reviewer":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"state":"REVIEWER"}],"messages":[{"id":"77407583a5c00292083a77a105aab12925a3ad14","author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"date":"2014-11-20 23:51:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"369dec7418d5f4038bd4cf2d8713f66d290c9d88","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-21 00:03:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-octavia-pep8 http://logs.openstack.org/84/136184/1/check/gate-octavia-pep8/6b73eee : SUCCESS in 1m 09s\n- gate-octavia-python26 http://logs.openstack.org/84/136184/1/check/gate-octavia-python26/b515b7f : SUCCESS in 1m 28s\n- gate-octavia-python27 http://logs.openstack.org/84/136184/1/check/gate-octavia-python27/305292f : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":1},{"id":"c50e068a61c901ce0152b7c1537080ff6eeecc6d","author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"date":"2014-11-25 00:38:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nMin: It looks like most of this was pulled verbatim from the code standards here:  http://docs.openstack.org/developer/hacking/\n\nI started to comment to this effect, but I think it would actually be not very useful for us to just repeat this documentation in the code for this project. Also the HACKING.rst already makes reference to the main OpenStack hacking document, and points out the couple of Octavia-specific things we\u0027re doing with this project.\n\nI think this document should be more of a how-to or etiquette guide for people reviewing code in gerrit on this project. This should cover things like:\n\n* When is appropriate to \"-1\"\n* When is it appropriate to \"+1\"\n* What about features you would like to see added to a given spec?\n* What about \u0027short-term-code\u0027 or placeholder code which is meant to be replaced at a later date?\n* How large of a window should a core review allow after the first +2 before the code is merged?\n* What is you see a serious problem with code that was merged?\n\n...and other topics like this. The specific standards are covered elsewhere (and we should make reference to them, but not just repeat them here). This document should be about how to be an effective reviewer.","accounts_in_message":[],"_revision_number":1},{"id":"51683f5a627cf9e8efad7a4f0ef49227da3f8d5e","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2014-11-30 00:52:00.000000000","message":"Patch Set 1: Code-Review-2\n\nIs this typical for openstack projects?  If so, I\u0027ll remove my -2.","accounts_in_message":[],"_revision_number":1},{"id":"1225cdca18d7b124f705c5d112e9e3188a1b226e","author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"date":"2014-12-02 00:17:23.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"66482c1d5250e285dc2ddc5ed2a0c41a04476839","author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"date":"2014-12-02 04:52:53.000000000","message":"Patch Set 1:\n\nDoug-- I have no idea whether it\u0027s normal for there to be code review guidelines within projects. You may be right though-- this is probably something more appropriate for a generalized wiki article (or update of something existing) on the OpenStack wiki, since what I\u0027m thinking we\u0027re after here isn\u0027t unique to Octavia, and there are probably standards people are following with regard to code review that span projects.","accounts_in_message":[],"_revision_number":1},{"id":"9ddfabcdc270ef37ae5cdc880300c28c310cd434","author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"date":"2014-12-02 04:59:22.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0ec3c7b668c5884ce71d3f4b616b81af56c75382","author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"date":"2014-12-03 20:19:45.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1b73bf053620755ab06e15775abc1b01aa52897a","author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"date":"2014-12-05 04:10:48.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"cd9ac314f65a42f0b8582f65c8acacac0dd22049","author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"date":"2015-04-01 23:31:34.000000000","message":"Abandoned\n\nno need it anymore","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"688517a969e3e55167753aa111ea7c6b5c80e2a4","revisions":{"688517a969e3e55167753aa111ea7c6b5c80e2a4":{"kind":"REWORK","_number":1,"created":"2014-11-20 23:51:12.000000000","uploader":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"ref":"refs/changes/84/136184/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/84/136184/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/84/136184/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/84/136184/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/84/136184/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/84/136184/1"}}},"commit":{"parents":[{"commit":"ac4fe48813f98f0a2fb3212c4ad83ef84639f87c","subject":"Merge \"Local development implementation for Certificates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/ac4fe48813f98f0a2fb3212c4ad83ef84639f87c"}]}],"author":{"name":"minwang","email":"swiftwangster@gmail.com","date":"2014-11-20 23:48:04.000000000","tz":-480},"committer":{"name":"minwang","email":"swiftwangster@gmail.com","date":"2014-11-20 23:48:04.000000000","tz":-480},"subject":"This is a reference for code review","message":"This is a reference for code review\n\nIt wraps up some commonly used standard for python code and gerrit\ncode review requirements, this document is expected to help those\nwho submit their code and review others\u0027 code.\n\nChange-Id: I084f007bb8eb7f081d5ae56aa919f15f9596984b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/688517a969e3e55167753aa111ea7c6b5c80e2a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/688517a969e3e55167753aa111ea7c6b5c80e2a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}