)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d7a569d66a9d2114b85fdc61d6e9d9f3459de617","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"amphora driver interface v0.5 changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Delete the get_health, get_metrics, add wrap_up function"},{"line_number":10,"context_line":"Change-Id: Iafb6e8a508c82587db721833ffcd45b704c1ccd2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a961159_9843bd6b","line":9,"updated":"2014-12-30 18:43:10.000000000","message":"nit: newline between the last descriptive line and the meta-lines.","commit_id":"fa22d9e0e3b55c61792fcc4fea8d24b94025afe8"}],"octavia/amphorae/drivers/driver_base.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a08f72f952b2c34a6bb84c91899b3077395c1327","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        pass"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @abc.abstractmethod"},{"line_number":96,"context_line":"    def wrap_up(self, amphora, listener):"},{"line_number":97,"context_line":"        \"\"\"Amphora wrap up method"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param amphora: amphora object, need to use its id property"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_fc59d935","line":96,"updated":"2014-12-18 20:19:22.000000000","message":"Why are we rolling amphora and listener roll-back into a single method?  Doesn\u0027t it make more sense to call two different methods for these two very different operations?","commit_id":"f32f4895dc4a3a2c9678b368de2b467ba51e50a1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7200321220351b1121103606fc833fdc85f81b07","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def wrap_up_amphora(self, amphora):"},{"line_number":97,"context_line":"        \"\"\"Amphora wrap up method"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param amphora: amphora object, need to use its id property"},{"line_number":100,"context_line":"        :type amphora: object"},{"line_number":101,"context_line":"        :returns: return a value list (amphora.id, status flag)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_5255694e","line":99,"updated":"2014-12-19 06:47:05.000000000","message":"I wouldn\u0027t say an implementation needs to use its id property, though that will be the most common use case.  Some implementation my use the name property, who knows.\n\nAlso, I have a feeling that most implementations of this method will just loop through all listeners calling self.wrap_up_listener, but I can live with this here.  So I just want credit for calling it when it happens! (which will be a long way from now so we will never remember).","commit_id":"56d6eca198efd57155569bf3b6d3b7326a230204"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"caf50ef4e57ad5eea2463be8a84c79e7e967d9e7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def wrap_up_amphora(self, amphora):"},{"line_number":97,"context_line":"        \"\"\"Amphora wrap up method"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param amphora: amphora object, need to use its id property"},{"line_number":100,"context_line":"        :type amphora: object"},{"line_number":101,"context_line":"        :returns: return a value list (amphora.id, status flag)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_3a334463","line":99,"in_reply_to":"3a961159_5255694e","updated":"2014-12-19 17:57:04.000000000","message":"Brandon-- initially, yes. But wrapping up an amphora might also include shipping OS logs and some other non-listener-specific housecleaning.","commit_id":"56d6eca198efd57155569bf3b6d3b7326a230204"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"06b5440f575ee2aaecafec299527f34d145be697","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def wrap_up_amphora(self, amphora):"},{"line_number":97,"context_line":"        \"\"\"Amphora wrap up method"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param amphora: amphora object, need to use its id property"},{"line_number":100,"context_line":"        :type amphora: object"},{"line_number":101,"context_line":"        :returns: return a value list (amphora.id, status flag)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_7a278c12","line":99,"in_reply_to":"3a961159_5255694e","updated":"2014-12-19 17:59:22.000000000","message":"will change the description properly, but for the demo code, will use id as example because we need to pass some property to test the demo","commit_id":"56d6eca198efd57155569bf3b6d3b7326a230204"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d7a569d66a9d2114b85fdc61d6e9d9f3459de617","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @abc.abstractmethod"},{"line_number":96,"context_line":"    def wrap_up_amphora(self, amphora):"},{"line_number":97,"context_line":"        \"\"\"Amphora wrap up method"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param amphora: amphora object"},{"line_number":100,"context_line":"        :type amphora: object"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_1857cd27","line":97,"updated":"2014-12-30 18:43:10.000000000","message":"Can you describe what\u0027s supposed to happen for \"wrap up\"?","commit_id":"fa22d9e0e3b55c61792fcc4fea8d24b94025afe8"}],"octavia/amphorae/drivers/noop_driver/driver.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a08f72f952b2c34a6bb84c91899b3077395c1327","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.amphoraconfig[(listener.protocol_port,"},{"line_number":58,"context_line":"                            vip.ip_address)] \u003d (listener, vip, \u0027delete\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def wrap_up(self, amphora, listener):"},{"line_number":61,"context_line":"        LOG.debug(\"Amphora %s no-op, wrap up amphora %s, listener %s\","},{"line_number":62,"context_line":"                  self.__class__.__name__,"},{"line_number":63,"context_line":"                  amphora.id, listener.protocol_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_dc55fdc2","line":60,"updated":"2014-12-18 20:19:22.000000000","message":"Again, I think we should have two different methods for this.","commit_id":"f32f4895dc4a3a2c9678b368de2b467ba51e50a1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7200321220351b1121103606fc833fdc85f81b07","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                  amphora.id)"},{"line_number":64,"context_line":"        self.amphoraconfig[amphora.id] \u003d (amphora, \u0027amphora wrap up\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def wrap_up_litener(self, listener):"},{"line_number":67,"context_line":"        LOG.debug(\"Amphora %s no-op, wrap up listener %s\","},{"line_number":68,"context_line":"                  self.__class__.__name__, listener.protocol_port)"},{"line_number":69,"context_line":"        self.amphoraconfig[listener.protocol_port] \u003d (listener,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_12cf612a","line":66,"updated":"2014-12-19 06:47:05.000000000","message":"wrap_up_listener","commit_id":"56d6eca198efd57155569bf3b6d3b7326a230204"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"06b5440f575ee2aaecafec299527f34d145be697","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                  amphora.id)"},{"line_number":64,"context_line":"        self.amphoraconfig[amphora.id] \u003d (amphora, \u0027amphora wrap up\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def wrap_up_litener(self, listener):"},{"line_number":67,"context_line":"        LOG.debug(\"Amphora %s no-op, wrap up listener %s\","},{"line_number":68,"context_line":"                  self.__class__.__name__, listener.protocol_port)"},{"line_number":69,"context_line":"        self.amphoraconfig[listener.protocol_port] \u003d (listener,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_da1a40c5","line":66,"in_reply_to":"3a961159_12cf612a","updated":"2014-12-19 17:59:22.000000000","message":"will change it accordingly","commit_id":"56d6eca198efd57155569bf3b6d3b7326a230204"}],"specs/version0.5/amphora-driver-interface.rst":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"80060c327e7bf09d0457da63d75bb6b2bd2850f3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            raise NotImplementedError"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        def wrap_up_amphora(self,amphora):"},{"line_number":59,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":60,"context_line":"            raise NotImplementedError"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def wrap_up_listener(listener):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_23d419bc","line":59,"updated":"2014-12-19 01:16:42.000000000","message":"Let\u0027s use a slightly different comment than the next one, eh. :)\n\n# This function is to shutdown listeners, ship OS logs, and otherwise prepare for amphora to be deleted.","commit_id":"f428ee8962ce54e4a3d0119913d91552afea76f9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"b649d4496db0b1306462d5063a5b75de2a8d6ebe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            raise NotImplementedError"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        def wrap_up_amphora(self,amphora):"},{"line_number":59,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":60,"context_line":"            raise NotImplementedError"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def wrap_up_listener(listener):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_6300e134","line":59,"in_reply_to":"3a961159_23d419bc","updated":"2014-12-19 01:18:21.000000000","message":"ok, will do","commit_id":"f428ee8962ce54e4a3d0119913d91552afea76f9"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"80060c327e7bf09d0457da63d75bb6b2bd2850f3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":60,"context_line":"            raise NotImplementedError"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def wrap_up_listener(listener):"},{"line_number":63,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":64,"context_line":"            raise NotImplementedError"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_6352a168","line":62,"updated":"2014-12-19 01:16:42.000000000","message":"Nit: Args should be: self, listener","commit_id":"f428ee8962ce54e4a3d0119913d91552afea76f9"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"b649d4496db0b1306462d5063a5b75de2a8d6ebe","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":60,"context_line":"            raise NotImplementedError"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def wrap_up_listener(listener):"},{"line_number":63,"context_line":"            #this function is to shutdown processes, ship logs, and ship stats"},{"line_number":64,"context_line":"            raise NotImplementedError"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_83f94d50","line":62,"in_reply_to":"3a961159_6352a168","updated":"2014-12-19 01:18:21.000000000","message":"same here, thanks for the input :)","commit_id":"f428ee8962ce54e4a3d0119913d91552afea76f9"}]}