)]}'
{"specs/version0.5/amphora-driver-interface.rst":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"\"\""},{"line_number":45,"context_line":"            raise NotImplementedError"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def get_suspend_flow(self, listener, vip):"},{"line_number":48,"context_line":"            \"\"\""},{"line_number":49,"context_line":"                OPTIONAL - returns a task flow which stops the listener"},{"line_number":50,"context_line":"                on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_502013f7","line":47,"updated":"2014-12-18 19:29:57.000000000","message":"Could we go with get_stop_flow and get_start_flow instead of get_suspend_flow and get_enable_flow?  (I would be happy with \"enable\" and \"disable\" here as well, as that implies stop and start.)","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def get_suspend_flow(self, listener, vip):"},{"line_number":48,"context_line":"            \"\"\""},{"line_number":49,"context_line":"                OPTIONAL - returns a task flow which stops the listener"},{"line_number":50,"context_line":"                on the vip. The system will place both listener and vip"},{"line_number":51,"context_line":"                into the task flow engine (or as a result of previous tasks)"},{"line_number":52,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_b0a4d7b9","line":49,"updated":"2014-12-18 19:29:57.000000000","message":"I\u0027d like to see the \u0027OPTIONAL\u0027 note removed on these docstrings: If the individual driver writer decides the method isn\u0027t worth implementing, they can either make it a noop, or simply leave the method to raise an exception if it\u0027s ever called.","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \"\"\""},{"line_number":49,"context_line":"                OPTIONAL - returns a task flow which stops the listener"},{"line_number":50,"context_line":"                on the vip. The system will place both listener and vip"},{"line_number":51,"context_line":"                into the task flow engine (or as a result of previous tasks)"},{"line_number":52,"context_line":"            \"\"\""},{"line_number":53,"context_line":"            return None"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_f001ff6a","line":51,"updated":"2014-12-18 19:29:57.000000000","message":"Per our conversation, maybe: Both \"listener\" and \"vip\" become defined inputs for the flow.","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        def get_delete_flow(self, listener, vip):"},{"line_number":64,"context_line":"            \"\"\""},{"line_number":65,"context_line":"                returns a task flow which deletes  the listener on the vip."},{"line_number":66,"context_line":"                The system will place both listener and vip"},{"line_number":67,"context_line":"                into the task flow engine (or as a result of previous tasks)"},{"line_number":68,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_3068e720","line":65,"updated":"2014-12-18 19:29:57.000000000","message":"Nit: Extra space between \u0027deletes\" and \u0027the\u0027","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            \"\"\""},{"line_number":77,"context_line":"            raise NotImplementedError"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def get_config_flow(self, amphora):"},{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"                returns a task flow which returns the configuration to be inspected by"},{"line_number":82,"context_line":"                the controller and create missing network interfaces, etc."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_8b609036","line":79,"updated":"2014-12-18 19:29:57.000000000","message":"Can we call this \u0027get_network_config_flow\u0027 instead since it\u0027s specifically about network connectivity?","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def get_config_flow(self, amphora):"},{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"                returns a task flow which returns the configuration to be inspected by"},{"line_number":82,"context_line":"                the controller and create missing network interfaces, etc."},{"line_number":83,"context_line":"                The system will place the amphora"},{"line_number":84,"context_line":"                into the task flow engine (or as a result of previous tasks)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_eb01146b","line":81,"updated":"2014-12-18 19:29:57.000000000","message":"Nit: configuration -\u003e network configuration.\n\nUsing the word \u0027configuration\u0027 here is ambiguous about whether you\u0027re talking about something like an haproxy config, or something else.","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        def get_config_flow(self, amphora):"},{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"                returns a task flow which returns the configuration to be inspected by"},{"line_number":82,"context_line":"                the controller and create missing network interfaces, etc."},{"line_number":83,"context_line":"                The system will place the amphora"},{"line_number":84,"context_line":"                into the task flow engine (or as a result of previous tasks)"},{"line_number":85,"context_line":"                This will return/place the configuration into the task flow engine"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_70f7cf59","line":82,"updated":"2014-12-18 19:29:57.000000000","message":"Nit: creates","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"2ac25c5fd9a795293e3458cd7a462753255072ec","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \"\"\""},{"line_number":95,"context_line":"                OPTIONAL - run some expensive self tests to determine if the amphora and the"},{"line_number":96,"context_line":"                lbs are healthy the idea is that those tests are triggered more infrequent"},{"line_number":97,"context_line":"                than the health gathering"},{"line_number":98,"context_line":"            \"\"\""},{"line_number":99,"context_line":"            raise NotImplementedError"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_4b0308b8","line":97,"updated":"2014-12-18 19:29:57.000000000","message":"Nit: change \u0027health gathering\u0027 to \u0027heartbeat\u0027","commit_id":"5d972e76fad039f88e92eb699f8b8869d9037cd1"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"881e0c62ac0cc0cdac11196df6b21f9778f7115f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \"\"\""},{"line_number":53,"context_line":"            return None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        def get_stop_flow(self):"},{"line_number":56,"context_line":"            \"\"\""},{"line_number":57,"context_line":"                returns a task flow which enables the listener"},{"line_number":58,"context_line":"                on the vip. Both \"listener\" and \"vip\" become"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_af0b7122","line":55,"updated":"2014-12-19 21:47:17.000000000","message":"should it be get_start_flow(self)?","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e9bc5c10c62356e3514c708f71c9ab41a7fc8a33","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \"\"\""},{"line_number":53,"context_line":"            return None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        def get_stop_flow(self):"},{"line_number":56,"context_line":"            \"\"\""},{"line_number":57,"context_line":"                returns a task flow which enables the listener"},{"line_number":58,"context_line":"                on the vip. Both \"listener\" and \"vip\" become"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_a91b4d71","line":55,"in_reply_to":"3a961159_55053a78","updated":"2014-12-22 17:43:04.000000000","message":"Done","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"bb3706f36248f5d9e2d6350ffc7377fde85121a3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \"\"\""},{"line_number":53,"context_line":"            return None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        def get_stop_flow(self):"},{"line_number":56,"context_line":"            \"\"\""},{"line_number":57,"context_line":"                returns a task flow which enables the listener"},{"line_number":58,"context_line":"                on the vip. Both \"listener\" and \"vip\" become"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_55053a78","line":55,"in_reply_to":"3a961159_af0b7122","updated":"2014-12-20 00:20:18.000000000","message":"Either this one or the previous one should be, yes. Good catch, eh!","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"6d08a7aff92bf0396907c54367690ed64d68567c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \"\"\""},{"line_number":69,"context_line":"            raise NotImplementedError"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        def info(self, amphora):"},{"line_number":72,"context_line":"            \"\"\""},{"line_number":73,"context_line":"                returns information about the amphora, e.g. {\"Rest Interface\": \"1.0\", \"Amphorae\": \"1.0\","},{"line_number":74,"context_line":"                \"packages\":{\"ha proxy\":\"1.5\"}, \"network-interfaces\": {\"eth0\":{\"ip\":...}}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_254c2442","line":71,"updated":"2014-12-18 21:56:33.000000000","message":"Should this be get_info? instead of info?\n\nBelow is get_diagnostics which is not a task flow so let\u0027s just be consistent.","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e9bc5c10c62356e3514c708f71c9ab41a7fc8a33","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \"\"\""},{"line_number":69,"context_line":"            raise NotImplementedError"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        def info(self, amphora):"},{"line_number":72,"context_line":"            \"\"\""},{"line_number":73,"context_line":"                returns information about the amphora, e.g. {\"Rest Interface\": \"1.0\", \"Amphorae\": \"1.0\","},{"line_number":74,"context_line":"                \"packages\":{\"ha proxy\":\"1.5\"}, \"network-interfaces\": {\"eth0\":{\"ip\":...}}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_c916d948","line":71,"in_reply_to":"3a961159_254c2442","updated":"2014-12-22 17:43:04.000000000","message":"Done","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"bb3706f36248f5d9e2d6350ffc7377fde85121a3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        def get_config_network_flow(self, amphora):"},{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"                returns a task flow which returns the network configuration to be inspected by"},{"line_number":82,"context_line":"                the controller and create missing network interfaces, etc."},{"line_number":83,"context_line":"                \"amphora\" becomes a defined inputs for the flow and the flow will return"},{"line_number":84,"context_line":"                a list of network interface cards in the format {\"eth0\":{\"ip\":\"123.123.123.123\","},{"line_number":85,"context_line":"                \"netmask\":\"...\", \"mac\":\",,,\"))"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_95fb227a","line":82,"updated":"2014-12-20 00:20:18.000000000","message":"Nit: creates","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e9bc5c10c62356e3514c708f71c9ab41a7fc8a33","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        def get_config_network_flow(self, amphora):"},{"line_number":80,"context_line":"            \"\"\""},{"line_number":81,"context_line":"                returns a task flow which returns the network configuration to be inspected by"},{"line_number":82,"context_line":"                the controller and create missing network interfaces, etc."},{"line_number":83,"context_line":"                \"amphora\" becomes a defined inputs for the flow and the flow will return"},{"line_number":84,"context_line":"                a list of network interface cards in the format {\"eth0\":{\"ip\":\"123.123.123.123\","},{"line_number":85,"context_line":"                \"netmask\":\"...\", \"mac\":\",,,\"))"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_4922e9a3","line":82,"in_reply_to":"3a961159_95fb227a","updated":"2014-12-22 17:43:04.000000000","message":"Done","commit_id":"8f14f6ae5e4bb8c4401b037288ca9e5f093a1306"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"28cddd542f001290628cac88c61878d30d473f07","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_3bfde06e","line":38,"updated":"2014-12-22 18:59:00.000000000","message":"By returning a task flow does this imply that the caller will \u0027activate\u0027 the task?","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"1864a68483b5c2edaa7b11ede0e3633ea29054d5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_88f4cf87","line":38,"in_reply_to":"3a961159_3bfde06e","updated":"2015-01-07 16:23:31.000000000","message":"The caller will add this flow to the master flow and run it...","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"4338557ff1579acd8571dce6bfcd909cee6d1210","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"},{"line_number":42,"context_line":"                for the listener on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_5b7d61b1","line":39,"updated":"2015-01-07 04:03:32.000000000","message":"Will a listener, vip still be passed in? If not, could you please explain where i should retrieve the required data from.","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2eb11345d9d3cbc39bfdddb2a7564e4283a0f989","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"},{"line_number":42,"context_line":"                for the listener on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_7b2688cf","line":39,"in_reply_to":"3a961159_5b0d4c8e","updated":"2015-01-07 18:47:38.000000000","message":"Not sure I understand you. We always had to pass in listener and vip -- the controller doesn\u0027t need to know about other parameters. You return the flow we add it to our flow (which might include getting listener and vip from the DB to begin with) and then run that.\n\nNot clear what you mean with FunctorTask though --","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"1864a68483b5c2edaa7b11ede0e3633ea29054d5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"},{"line_number":42,"context_line":"                for the listener on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_88cdaf5f","line":39,"in_reply_to":"3a961159_5b7d61b1","updated":"2015-01-07 16:23:31.000000000","message":"We will add that to the flow. So if you implement a task you can say:\n\nclass MyTask(OctaviaTask):\n  def execute(listener, vip, *args, **kwargs):\n     ...\n\nThere is away to define that in the flow (see http://docs.openstack.org/developer/taskflow/inputs_and_outputs.html) but the system is smart enough to figure it out by itself pretty well...","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"5ccce18a54f76fb1865ba90d69157df840617823","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"},{"line_number":42,"context_line":"                for the listener on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_7eb03643","line":39,"in_reply_to":"3a961159_7b2688cf","updated":"2015-01-07 18:58:15.000000000","message":"I suppose thats correct that the controller still passes it in, so i guess thats not a problem. You can find FunctorTask by searching for it here:\nhttp://docs.openstack.org/developer/taskflow/examples.html This allows to easily refactor in the future but would require params passed to the driver and not installed to the flow in the controller.","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"fd1e660a72c58d5f27d8ebd7916f8c5418131138","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def getLogger(self):"},{"line_number":37,"context_line":"            #return the logger to use - this is a way to inject a custom logger for testing, etc"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_update_flow(self):"},{"line_number":40,"context_line":"            \"\"\""},{"line_number":41,"context_line":"                returns a task flow which updates the amphora with a new configuration"},{"line_number":42,"context_line":"                for the listener on the vip. The system will place both listener and vip"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_5b0d4c8e","line":39,"in_reply_to":"3a961159_88cdaf5f","updated":"2015-01-07 18:38:26.000000000","message":"I was hoping to use FunctorTask to wrap things to make this an easy transition in the future. With this set up i barely see the use for writing a driver. The controller now has to know which params the \u0027driver\u0027 needs instead of just running a flow and the logic for all drivers could just be put in a FlowCreator class or something. I was hoping to lightly couple this as much as possible.","commit_id":"5281a1b0a56189ca628cb551deeaeb2180da8ad5"}]}
