)]}'
{"etc/octavia.conf":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# configuration file."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[keystone_authtoken]"},{"line_number":24,"context_line":"auth_uri \u003d https://region-a.geo-1.identity.hpcloudsvc.com:35357/v3/"},{"line_number":25,"context_line":"admin_user \u003d xxx"},{"line_number":26,"context_line":"admin_password \u003d xx"},{"line_number":27,"context_line":"admin_project_id \u003d xx"}],"source_content_type":"text/plain","patch_set":20,"id":"1a930d6b_759178f0","line":24,"updated":"2015-01-23 23:22:43.000000000","message":"Should you specify this here?  Wouldn\u0027t this stay a stub until you actually put it in your \"/etc/octavia.conf\" directory?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[api_manager]"},{"line_number":45,"context_line":"amp_flavor_id \u003d 100"},{"line_number":46,"context_line":"amp_image_id \u003d bec3cab5-4722-40b9-a78a-3489218e22fe"},{"line_number":47,"context_line":"amp_key_list \u003d cloud"},{"line_number":48,"context_line":"amp_network_list \u003d a27e6dec-b3f1-4f11-823d-ca321253efec"},{"line_number":49,"context_line":"# amp_secgroup_list \u003d"}],"source_content_type":"text/plain","patch_set":20,"id":"1a930d6b_35b29094","line":46,"updated":"2015-01-23 23:22:43.000000000","message":"Same as above?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":45,"context_line":"amp_flavor_id \u003d 100"},{"line_number":46,"context_line":"amp_image_id \u003d bec3cab5-4722-40b9-a78a-3489218e22fe"},{"line_number":47,"context_line":"amp_key_list \u003d cloud"},{"line_number":48,"context_line":"amp_network_list \u003d a27e6dec-b3f1-4f11-823d-ca321253efec"},{"line_number":49,"context_line":"# amp_secgroup_list \u003d"},{"line_number":50,"context_line":"nova_os_region_name\u003dregion-a.geo-1"},{"line_number":51,"context_line":"#compute_driver"}],"source_content_type":"text/plain","patch_set":20,"id":"1a930d6b_b565a01f","line":48,"updated":"2015-01-23 23:22:43.000000000","message":"Same as above?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"}],"octavia/controller/api_server/api_server.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from octavia.common import constants"},{"line_number":23,"context_line":"from octavia.controller.flows import create_listener_flows"},{"line_number":24,"context_line":"from octavia.db import api as db_apis"},{"line_number":25,"context_line":"# from octavia.db import models"},{"line_number":26,"context_line":"from octavia.db import repositories"},{"line_number":27,"context_line":"from octavia import i18n"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_4443ef41","line":25,"updated":"2015-01-23 23:22:43.000000000","message":"nit: Probably just remove this if its not needed.","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":29,"context_line":"root \u003d logging.getLogger()"},{"line_number":30,"context_line":"root.setLevel(logging.DEBUG)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ch \u003d logging.StreamHandler(sys.stdout)"},{"line_number":33,"context_line":"ch.setLevel(logging.DEBUG)"},{"line_number":34,"context_line":"formatter \u003d logging.Formatter("},{"line_number":35,"context_line":"    \u0027%(asctime)s - %(name)s - %(levelname)s - %(message)s\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_e4d77b49","line":32,"updated":"2015-01-23 23:22:43.000000000","message":"In actual implementation, this won\u0027t likely be std.out.  Maybe leave this logging information out of the commit or at least pointing to some actual log file or something?  Arguably not a big deal, just a minuscule suggestion.","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"CONF \u003d cfg.CONF"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"LB_REPO \u003d repositories.LoadBalancerRepository()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class Flows(base_taskflow.BaseTaskFlowEngine):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_644aab27","line":44,"updated":"2015-01-23 23:22:43.000000000","message":"Doesn\u0027t this more appropriately belong in the init method, or is this acceptable as well?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    LOG.debug(\u0027Configuration:\u0027)"},{"line_number":83,"context_line":"    CONF.log_opt_values(LOG, logging.DEBUG)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # lb \u003d create_LB_in_DB()"},{"line_number":86,"context_line":"    # amp \u003d models.Amphora()"},{"line_number":87,"context_line":"    # amp.id\u003d\u0027123\u0027"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_c460bfa7","line":85,"updated":"2015-01-23 23:22:43.000000000","message":"Nit: Probably just remove these if they\u0027re not needed.","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"}],"octavia/controller/base_worker.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        self.create_listener_flows \u003d create_listener_flows.CreateListenerFlow()"},{"line_number":30,"context_line":"        self.driver \u003d importutils.import_class(SAMPLE_DRIVER)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.executor \u003d concurrent.futures.ThreadPoolExecutor("},{"line_number":33,"context_line":"            max_workers\u003d5)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_c407dfc8","line":30,"updated":"2015-01-23 23:22:43.000000000","message":"If SAMPLE_DRIVER isn\u0027t going to be used anywhere else, is there a reason for the variable?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"8db8e622319728377fb3a37256d4f21c8ca2596a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        self.create_listener_flows \u003d create_listener_flows.CreateListenerFlow()"},{"line_number":30,"context_line":"        self.driver \u003d importutils.import_class(SAMPLE_DRIVER)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.executor \u003d concurrent.futures.ThreadPoolExecutor("},{"line_number":33,"context_line":"            max_workers\u003d5)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_640b8b2a","line":30,"in_reply_to":"1a930d6b_c407dfc8","updated":"2015-01-23 23:32:05.000000000","message":"It was there as a placeholder for what would have came from a config, but this is moot now as this and related files will most likely be going away.","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"}],"octavia/controller/deploy_worker.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"bff5f6cffd841825c71cf37c3003007a11b85790","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_44976f48","line":1,"updated":"2015-01-23 23:22:43.000000000","message":"Did someone from Rackspace make this or should it be updated to HP?  Could also be updated to include both if multiple people worked on it?","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"8db8e622319728377fb3a37256d4f21c8ca2596a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2014 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a930d6b_44276fca","line":1,"in_reply_to":"1a930d6b_44976f48","updated":"2015-01-23 23:32:05.000000000","message":"I made this while tinkering, this and related files will probably go away.","commit_id":"ba106c524d7650752ae8a28253bc489d569ccc76"}]}