)]}'
{"specs/version0.5/api-manager.rst":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dc8c09c2a2276038b002470d2c76e0ef4ef0366b","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"API Manager"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/octavia/+spec/api-manager"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_ffd4b220","line":8,"updated":"2015-01-20 18:27:02.000000000","message":"I think we should rename this to Queue Consumer.","commit_id":"db27c694af10a9d8d5d32571b063ae7d47ff9823"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dc8c09c2a2276038b002470d2c76e0ef4ef0366b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Using the \u0027eventlet\u0027 executor will allow for message throttling and simplifies"},{"line_number":34,"context_line":"the need for the deploy workers to manage threads. The throttling rate can"},{"line_number":35,"context_line":"be configured using the \u0027rpc_thread_pool_size\u0027 option (see below for"},{"line_number":36,"context_line":"configuration)."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"An \u0027oslo_messaging\u0027 configuration section will need to be added to octavia.conf"},{"line_number":39,"context_line":"for Oslo messaging options. For the API Manager, the \u0027rpc_thread_pool_size\u0027"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_1f9c1e0e","line":36,"updated":"2015-01-20 18:27:02.000000000","message":"I think it should be outright states that using the eventlet executor has the benefit of the api manager not having to spawn threads at all, since every message received will be in its own thread already.  This means that the api manager doesnt spawn a deploy worker, rather is just starts the execution of the deploy code.","commit_id":"db27c694af10a9d8d5d32571b063ae7d47ff9823"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dc8c09c2a2276038b002470d2c76e0ef4ef0366b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"be configured using the \u0027rpc_thread_pool_size\u0027 option (see below for"},{"line_number":36,"context_line":"configuration)."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"An \u0027oslo_messaging\u0027 configuration section will need to be added to octavia.conf"},{"line_number":39,"context_line":"for Oslo messaging options. For the API Manager, the \u0027rpc_thread_pool_size\u0027"},{"line_number":40,"context_line":"config option will need to be added. This option will determine how many"},{"line_number":41,"context_line":"consumer threads will be able to read from the queue at any given time (per"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_7fc36239","line":38,"updated":"2015-01-20 18:27:02.000000000","message":"I wonder if at some point we shoudl think about having separate configs for each process.  Not a big deal right now though.\n\nAlso, there will be other options needed in the conf such as what the queue host is, etc.","commit_id":"db27c694af10a9d8d5d32571b063ae7d47ff9823"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dc8c09c2a2276038b002470d2c76e0ef4ef0366b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"consumer threads will be able to read from the queue at any given time (per"},{"line_number":42,"context_line":"consumer instance). For example, if \u0027rpc_thread_pool_size\u0027 is  set to 1 thread"},{"line_number":43,"context_line":"then only one deploy worker will be able to conduct work. When  that deploy"},{"line_number":44,"context_line":"worker completes its task the a new message can be consumed and a new deploy"},{"line_number":45,"context_line":"worker spawned."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_7ff1a295","line":44,"updated":"2015-01-20 18:27:02.000000000","message":"nit: s/the/then","commit_id":"db27c694af10a9d8d5d32571b063ae7d47ff9823"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dc8c09c2a2276038b002470d2c76e0ef4ef0366b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"then only one deploy worker will be able to conduct work. When  that deploy"},{"line_number":44,"context_line":"worker completes its task the a new message can be consumed and a new deploy"},{"line_number":45,"context_line":"worker spawned."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":"There are a variety of ways to consume from Oslo messaging. For example,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_9fa64e53","line":46,"updated":"2015-01-20 18:27:02.000000000","message":"Should probably list the functions/methods that will make up the contract between the sender and consumer.","commit_id":"db27c694af10a9d8d5d32571b063ae7d47ff9823"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fde0a18db1060b199f3ad6ff3c72928cb2937e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a930d6b_7472dee6","updated":"2015-01-20 21:42:30.000000000","message":"Shouldn\u0027t the file name be queue-consumer.rst now?","commit_id":"d7f6c2adb1a27b1a705bc0ee8bb484af6ce3ab61"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fde0a18db1060b199f3ad6ff3c72928cb2937e3e","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def update_health_monitor(self, context, health_monitor_id):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":"        "},{"line_number":87,"context_line":"    def delete_health_monitor(self, context, health_monitor_id):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a930d6b_f47deeb2","line":86,"updated":"2015-01-20 21:42:30.000000000","message":"nit: whitespace","commit_id":"d7f6c2adb1a27b1a705bc0ee8bb484af6ce3ab61"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fde0a18db1060b199f3ad6ff3c72928cb2937e3e","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def update_member(self, context, member_id):"},{"line_number":94,"context_line":"        pass"},{"line_number":95,"context_line":"        "},{"line_number":96,"context_line":"    def delete_member(self, context, member_id):"},{"line_number":97,"context_line":"        pass"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a930d6b_344f7694","line":95,"updated":"2015-01-20 21:42:30.000000000","message":"nit: whitespace","commit_id":"d7f6c2adb1a27b1a705bc0ee8bb484af6ce3ab61"}],"specs/version0.5/queue-consumer.rst":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"04a928f3069b635a27210d0cf67fa2ba438b8e61","unresolved":false,"context_lines":[{"line_number":35,"context_line":"the need for the deploy workers to manage threads. The benefit of using the"},{"line_number":36,"context_line":"\u0027eventlet\u0027 executor is that the Queue Consumer will not have to spawn threads"},{"line_number":37,"context_line":"at all, since every message received will be in its own thread already. This"},{"line_number":38,"context_line":"means that the Queue Consumer doesn\u0027t spawn a deploy worker, rather is just"},{"line_number":39,"context_line":"starts the execution of the deploy code."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"An \u0027oslo_messaging\u0027 configuration section will need to be added to octavia.conf"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a930d6b_db41da0c","line":38,"updated":"2015-01-21 19:31:57.000000000","message":"nit: \"rather is just\" should be \"rather it just\"","commit_id":"ed8a633701a71f2db59ae1f01d834350eefbe884"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"04a928f3069b635a27210d0cf67fa2ba438b8e61","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Performance Impact"},{"line_number":128,"context_line":"------------------"},{"line_number":129,"context_line":"The only performance related item is queue throttling. This is done by design"},{"line_number":130,"context_line":"so that that operators can safely throttle incoming messages dependent on their"},{"line_number":131,"context_line":"specific needs."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a930d6b_9b5e72e8","line":130,"updated":"2015-01-21 19:31:57.000000000","message":"nit: no need for either \"that,\" but definitely don\u0027t need two :D","commit_id":"ed8a633701a71f2db59ae1f01d834350eefbe884"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"da47611678911f4154a3030d39971a32b85301bd","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. code:: python"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def create_load_balancer(self, context, load_balancer_id):"},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def update_load_balancer(self, context, load_balancer_id):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a930d6b_27e72114","line":54,"updated":"2015-01-21 22:01:51.000000000","message":"Please explain what context is --","commit_id":"1e8ffead27b359b07733a98dc2f0c80b822cb44e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3b465a9a226d4fa32ee278d897c3e0abd556d30f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def create_load_balancer(self, context, load_balancer_id):"},{"line_number":61,"context_line":"        pass"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def update_load_balancer(self, context, load_balancer_id):"},{"line_number":64,"context_line":"        pass"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_load_balancer(self, context, load_balancer_id):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a930d6b_249ff6b5","line":63,"updated":"2015-01-22 19:39:58.000000000","message":"this needs to take another parameter, new_load_balancer","commit_id":"6ad8e94f7770b0c9254c4b285c7a0f5636bd1860"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3b465a9a226d4fa32ee278d897c3e0abd556d30f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def create_listener(self, context, listener_id):"},{"line_number":70,"context_line":"        pass"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update_listener(self, context, listener_id):"},{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def delete_listener(self, context, listener_id):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a930d6b_24861666","line":72,"updated":"2015-01-22 19:39:58.000000000","message":"this needs to take another parameter new_listener","commit_id":"6ad8e94f7770b0c9254c4b285c7a0f5636bd1860"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3b465a9a226d4fa32ee278d897c3e0abd556d30f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def create_pool(self, context, pool_id):"},{"line_number":79,"context_line":"        pass"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def update_pool(self, context, pool_id):"},{"line_number":82,"context_line":"        pass"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_pool(self, context, pool_id):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a930d6b_8496ea92","line":81,"updated":"2015-01-22 19:39:58.000000000","message":"new_pool","commit_id":"6ad8e94f7770b0c9254c4b285c7a0f5636bd1860"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3b465a9a226d4fa32ee278d897c3e0abd556d30f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def create_health_monitor(self, context, health_monitor_id):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def update_health_monitor(self, context, health_monitor_id):"},{"line_number":91,"context_line":"        pass"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def delete_health_monitor(self, context, health_monitor_id):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a930d6b_e48b2e66","line":90,"updated":"2015-01-22 19:39:58.000000000","message":"new_health_monitor","commit_id":"6ad8e94f7770b0c9254c4b285c7a0f5636bd1860"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"3b465a9a226d4fa32ee278d897c3e0abd556d30f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def create_member(self, context, member_id):"},{"line_number":97,"context_line":"        pass"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def update_member(self, context, member_id):"},{"line_number":100,"context_line":"        pass"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def delete_member(self, context, member_id):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a930d6b_04eafa0e","line":99,"updated":"2015-01-22 19:39:58.000000000","message":"new_member","commit_id":"6ad8e94f7770b0c9254c4b285c7a0f5636bd1860"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"833f93ceb51c667efc1b97348ab726ae10fa765e","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Data model impact"},{"line_number":123,"context_line":"-----------------"},{"line_number":124,"context_line":"None"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"REST API impact"},{"line_number":127,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a930d6b_94ba936c","line":124,"updated":"2015-01-22 22:36:40.000000000","message":"Please describe that we now move to a model where we have instead of the desired state the actual state.","commit_id":"ac4b2774270c1393871000aed93ea55256d7c965"}]}