)]}'
{".gitignore":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"c0cd6ce5cd97e842b130cb21a64db852ba8789ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"covhtml/"},{"line_number":8,"context_line":"dist/"},{"line_number":9,"context_line":"doc/build"},{"line_number":10,"context_line":".idea/*"},{"line_number":11,"context_line":"*.DS_Store"},{"line_number":12,"context_line":"*.pyc"},{"line_number":13,"context_line":"*.egg-info/"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"9aa53dc9_57da2be9","line":10,"updated":"2015-04-09 21:57:27.000000000","message":"If this gets merged soon its not a big deal, otherwise maybe add this in another review to move it along?","commit_id":"0969dcb7a8c05db5490c6b26b8ebe3997f67d9d0"}],"octavia/api/v1/handlers/queue/producer.py":[{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"26a69dc6595c665092725dd6505b539ed9a47986","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        self.transport \u003d messaging.get_transport(cfg.CONF)"},{"line_number":46,"context_line":"        self.target \u003d messaging.Target(topic\u003d\"TBD\", fanout\u003dFalse)"},{"line_number":47,"context_line":"        self.client \u003d messaging.RPCClient(self.transport, target\u003dself.target)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def create(self, data_model):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_cd72c948","line":46,"updated":"2015-01-23 05:11:10.000000000","message":"Is \"TBD\" here a reminder to come up with something else, or is this what is intended?","commit_id":"8923ff32f8bab32db2df8e211d6ff565cff1f785"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"26a69dc6595c665092725dd6505b539ed9a47986","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class LoadBalancerProducer(BaseProducer):"},{"line_number":79,"context_line":"    \"\"\"Sends Updates,Deletes and creates to the rpc end of the queue consume"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    \"\"\""},{"line_number":82,"context_line":"    def payload_class(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_0dbf71d1","line":79,"updated":"2015-01-23 05:11:10.000000000","message":"Nit: capitalization is inconsistent.  Updates and Deletes capitalized, but not creates.  They should all probably be lower case. RPC should be upper case. Also consume-\u003econsumer.","commit_id":"8923ff32f8bab32db2df8e211d6ff565cff1f785"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"26a69dc6595c665092725dd6505b539ed9a47986","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class ProducerHandler(abstract_handler.BaseHandler):"},{"line_number":117,"context_line":"    \"\"\"Base class for all QueueProducers. Messages are sent via the.\"\"\""},{"line_number":118,"context_line":"    load_balancer \u003d LoadBalancerProducer()"},{"line_number":119,"context_line":"    listener \u003d ListenerProducer()"},{"line_number":120,"context_line":"    pool \u003d PoolProducer()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_8d6e0195","line":117,"updated":"2015-01-23 05:11:10.000000000","message":"Looks like this sentence got truncated. Via the what?","commit_id":"8923ff32f8bab32db2df8e211d6ff565cff1f785"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c53111d61a9fccfad343d970ba1f5b0ccc83342e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import abc"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo.config import cfg"},{"line_number":30,"context_line":"from oslo import messaging"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"baa041b7_9c9bc1c9","line":29,"updated":"2015-04-02 07:07:58.000000000","message":"this should be oslo_config now, I think","commit_id":"5bb08d4b04ecebd7b553e22662378bc40939cbe4"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c53111d61a9fccfad343d970ba1f5b0ccc83342e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from octavia.api.v1.handlers import abstract_handler"},{"line_number":34,"context_line":"from octavia.common import constants"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":38,"context_line":"class BaseProducer(abstract_handler.BaseObjectHandler):"},{"line_number":39,"context_line":"    \"\"\"Base queue producer class.\"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"baa041b7_3caa75d5","line":36,"updated":"2015-04-02 07:07:58.000000000","message":"Add this line, and then import order won\u0027t matter:\n\ncfg.CONF.import_group(\u0027oslo_messaging\u0027, \u0027octavia.common.config\u0027)","commit_id":"5bb08d4b04ecebd7b553e22662378bc40939cbe4"}],"octavia/tests/unit/api/v1/handlers/queue/test_producer.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c53111d61a9fccfad343d970ba1f5b0ccc83342e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Had to import here since pep8 alpha ordering was demanding"},{"line_number":38,"context_line":"        # that the octavia.common.config be imported after octavia.api modules"},{"line_number":39,"context_line":"        # with producer being broken since config is loaded after producer"},{"line_number":40,"context_line":"        import octavia.api.v1.handlers.queue.producer"},{"line_number":41,"context_line":"        self.producer \u003d octavia.api.v1.handlers.queue.producer"},{"line_number":42,"context_line":"        super(TestProducer, self).setUp()"},{"line_number":43,"context_line":"        self.config \u003d fixture.Config()"}],"source_content_type":"text/x-python","patch_set":23,"id":"baa041b7_3c7395b3","line":40,"range":{"start_line":40,"start_character":30,"end_line":40,"end_character":38},"updated":"2015-04-02 07:07:58.000000000","message":"Oh, I wish I had realized this was why you were having import order issues earlier -- you shouldn\u0027t need to import octavia.common.config first. See my comment in  producer.py","commit_id":"5bb08d4b04ecebd7b553e22662378bc40939cbe4"}]}
