)]}'
{"bin/queue-consumer":[{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"326cf8a0a3f80c942f053c8210cae3a5cc346c9d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from octavia.common import service"},{"line_number":22,"context_line":"from octavia.controller.queue import consumer"},{"line_number":23,"context_line":"from octavia.openstack.common import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"eventlet.monkey_patch()"},{"line_number":26,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"baa041b7_ccb0858e","line":23,"updated":"2015-04-01 23:20:30.000000000","message":"needs to change to \"from oslo_log ...\".\n\nI did this in my local repo, and then it failed with \n\nubuntu@decima-devstack:/opt/stack/octavia$ bin/queue-consumer\nTraceback (most recent call last):\n  File \"bin/queue-consumer\", line 31, in \u003cmodule\u003e\n    service.prepare_service(sys.argv)\n  File \"/opt/stack/octavia/octavia/common/service.py\", line 27, in prepare_service\n    cfg.set_defaults(log.log_opts,\nAttributeError: \u0027module\u0027 object has no attribute \u0027log_opts\u0027","commit_id":"9d82392b0b32994f2893800c98196499412d23a7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"efecff03dd6c13ef27f2e9253ddd21d6cc86bf39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 Rackspace"},{"line_number":4,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3acd31a7_9e0f2fe1","line":1,"updated":"2015-04-30 15:48:42.000000000","message":"I think this needs to move to cmd directory.","commit_id":"d13306a793e3626bf1e7d2485266d1958e7cd1b2"}],"bin/queue-consumer.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e397187204efdae82e950c89fa050eba48d03621","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":31,"context_line":"    config.init(sys.argv[1:])"},{"line_number":32,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":33,"context_line":"    c \u003d consumer.Consumer()"},{"line_number":34,"context_line":"    c.listen()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_1088cc21","line":32,"updated":"2015-01-27 19:15:40.000000000","message":"i believe these two lines can be replaced with a call to octavia.common.service.prepare_service()\n\nYou\u0027ll have to make two changes to that method though so talk to me when you get to this.","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"67d7edbb1eea20c312eca9538b5f5ca36096f6d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 Rackspace"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_524ec597","line":1,"updated":"2015-02-06 21:12:29.000000000","message":"For a follow-up submission, please drop the .py extension on the binary.","commit_id":"0d44b7a13d932f1d646eb1cc488283b66ecee783"}],"etc/octavia.conf":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8eb93b4cd008b785ad198403b092bf81f56276fa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# the same host value."},{"line_number":12,"context_line":"# The default value is the hostname of the controller server machine."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# host \u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[database]"},{"line_number":17,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":7,"id":"fa81d914_43aae385","line":14,"updated":"2015-01-30 16:59:49.000000000","message":"I feel like this conf variable is way too generically named. \"host\" may be somewhat clear here next to all of these comments, but if you look at it ANYWHERE else, it\u0027s nonsensical. Could you make this something like \"controller_hostname\" (assuming I properly understand what this is supposed to be)?","commit_id":"29cbc8b47b9194a3105c17cd10039ce71a496097"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2d1fa5fb01b811b9d0eae153931d197a94704c2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Network to communicate with amphora"},{"line_number":47,"context_line":"# lb_network_name \u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[controller_worker]"},{"line_number":50,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":51,"context_line":"# amp_flavor_id \u003d"},{"line_number":52,"context_line":"# amp_image_id \u003d"}],"source_content_type":"text/plain","patch_set":10,"id":"da86d52c_8ca235ac","line":49,"updated":"2015-02-11 19:57:06.000000000","message":"I don\u0027t think controller_worker code should be in this patch set.  This code conflicts with https://review.openstack.org/#/c/151496/","commit_id":"af778508dc6f49c6fb5db06c94a910b59dd06050"},{"author":{"_account_id":10750,"name":"Jorge Miramontes","email":"jorge.miramontes@rackspace.com","username":"jorgem"},"change_message_id":"cbdfb5fe5c6acf27dd1e0cafddcbd3144d97f416","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Network to communicate with amphora"},{"line_number":47,"context_line":"# lb_network_name \u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[controller_worker]"},{"line_number":50,"context_line":"# Nova parameters to use when booting amphora"},{"line_number":51,"context_line":"# amp_flavor_id \u003d"},{"line_number":52,"context_line":"# amp_image_id \u003d"}],"source_content_type":"text/plain","patch_set":10,"id":"da86d52c_ac66194f","line":49,"in_reply_to":"da86d52c_8ca235ac","updated":"2015-02-11 20:04:30.000000000","message":"I didn\u0027t put this in here lol. I\u0027m dependent on your code.","commit_id":"af778508dc6f49c6fb5db06c94a910b59dd06050"}],"octavia/cmd/queueworker.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"f1c9a2c9dd12b2e2d5ca60ab4be34ee3f36fdf75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 Rackspace"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_b68fa722","line":1,"updated":"2015-04-30 21:22:51.000000000","message":"are we doing .py in this directory? Also why not bin","commit_id":"6ac94278c53f6b5088b19c52469f0a5eb2857b32"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f97582596c33dba8ca291942ac280493025110e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 Rackspace"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_fcf3c108","line":1,"in_reply_to":"3acd31a7_b68fa722","updated":"2015-04-30 21:47:24.000000000","message":"you\u0027re right we don\u0027t need this now that its .py","commit_id":"6ac94278c53f6b5088b19c52469f0a5eb2857b32"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e2d1fa5fb01b811b9d0eae153931d197a94704c2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027lb_network_name\u0027, help\u003d_(\u0027Name of amphora internal network\u0027)),"},{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"controller_worker_opts \u003d ["},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027amp_flavor_id\u0027,"},{"line_number":91,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027Nova instance flavor id for the Amphora\u0027)),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_4cc59d5a","line":89,"updated":"2015-02-11 19:57:06.000000000","message":"I don\u0027t think controller_worker code should be in this patch set.  This code conflicts with https://review.openstack.org/#/c/151496/","commit_id":"af778508dc6f49c6fb5db06c94a910b59dd06050"},{"author":{"_account_id":10750,"name":"Jorge Miramontes","email":"jorge.miramontes@rackspace.com","username":"jorgem"},"change_message_id":"cbdfb5fe5c6acf27dd1e0cafddcbd3144d97f416","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027lb_network_name\u0027, help\u003d_(\u0027Name of amphora internal network\u0027)),"},{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"controller_worker_opts \u003d ["},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027amp_flavor_id\u0027,"},{"line_number":91,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\u0027Nova instance flavor id for the Amphora\u0027)),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_ec0e518b","line":89,"in_reply_to":"da86d52c_4cc59d5a","updated":"2015-02-11 20:04:30.000000000","message":"I replied to this on your commit. I was fixing this because tests weren\u0027t passing. I talked to Brandon and he suggested that I let you fix it since it is relevant to your commit which makes sense to me now.","commit_id":"af778508dc6f49c6fb5db06c94a910b59dd06050"}],"octavia/controller/queue/consumer.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"3ff67c01219e91cf1683f701a92f390371d07a5a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.controller.queue import endpoint"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"from oslo import messaging"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_3ca87dda","line":15,"updated":"2015-01-26 23:10:17.000000000","message":"Wait, why is this not grouped with the other octavia imports, and not throwing an error?","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e397187204efdae82e950c89fa050eba48d03621","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from octavia.controller.queue import endpoint"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"from oslo import messaging"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_b0e38004","line":15,"in_reply_to":"1a930d6b_3ca87dda","updated":"2015-01-27 19:15:40.000000000","message":"yeah this should be i the last grouping","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"},{"author":{"_account_id":7398,"name":"Carlos Garza","email":"carlos.garza@rackspace.com","username":"crc32"},"change_message_id":"66c2035d78b12c0171285572a6e09c2b72c0344c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        exchange \u003d cfg.CONF.oslo_messaging.exchange"},{"line_number":30,"context_line":"        topic \u003d cfg.CONF.oslo_messaging.topic"},{"line_number":31,"context_line":"        transport \u003d messaging.get_transport(cfg.CONF)"},{"line_number":32,"context_line":"        target \u003d messaging.Target(exchange\u003dexchange, topic\u003dtopic,"},{"line_number":33,"context_line":"                                  server\u003d\u0027server\u0027, version\u003d\u00271.0\u0027)"},{"line_number":34,"context_line":"        ep \u003d endpoint.Endpoint(target)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_e67bbbbb","line":31,"updated":"2015-01-27 06:48:32.000000000","message":"exchange and topic are not being picked up in the [oslo_messaging] section as documented.","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e397187204efdae82e950c89fa050eba48d03621","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        topic \u003d cfg.CONF.oslo_messaging.topic"},{"line_number":31,"context_line":"        transport \u003d messaging.get_transport(cfg.CONF)"},{"line_number":32,"context_line":"        target \u003d messaging.Target(exchange\u003dexchange, topic\u003dtopic,"},{"line_number":33,"context_line":"                                  server\u003d\u0027server\u0027, version\u003d\u00271.0\u0027)"},{"line_number":34,"context_line":"        ep \u003d endpoint.Endpoint(target)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.server \u003d messaging.get_rpc_server(transport,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_70e2e804","line":33,"updated":"2015-01-27 19:15:40.000000000","message":"I have concerns that this is using the same target for both the endpoint and the server.  Whereas in the docs they have a different target instantiations for each.  A question should at least be asked in the oslo irc channel.","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"3ff67c01219e91cf1683f701a92f390371d07a5a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        topic \u003d cfg.CONF.oslo_messaging.topic"},{"line_number":31,"context_line":"        transport \u003d messaging.get_transport(cfg.CONF)"},{"line_number":32,"context_line":"        target \u003d messaging.Target(exchange\u003dexchange, topic\u003dtopic,"},{"line_number":33,"context_line":"                                  server\u003d\u0027server\u0027, version\u003d\u00271.0\u0027)"},{"line_number":34,"context_line":"        ep \u003d endpoint.Endpoint(target)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.server \u003d messaging.get_rpc_server(transport,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_dc077980","line":33,"updated":"2015-01-26 23:10:17.000000000","message":"what is this quoted \"server\" field?  Some config name or just a stub for now?","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"}],"octavia/controller/queue/endpoint.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e397187204efdae82e950c89fa050eba48d03621","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Endpoint(object):"},{"line_number":22,"context_line":"    def __init__(self, target):"},{"line_number":23,"context_line":"        Endpoint.target \u003d target"},{"line_number":24,"context_line":"        self.throw_exception \u003d False"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def create_load_balancer(self, context, load_balancer_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_59447b49","line":23,"updated":"2015-01-27 19:15:40.000000000","message":"self.target \u003d target should work","commit_id":"8a86a036a7a9f4f971b6e6126da9d33598ae2a97"}]}